From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 08BD742F90; Wed, 2 Aug 2023 14:36:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9628740DDB; Wed, 2 Aug 2023 14:36:08 +0200 (CEST) Received: from mgamail.intel.com (unknown [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id BD2C04021D for ; Wed, 2 Aug 2023 14:36:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690979767; x=1722515767; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=6xmqvpclFkmczEfPlvhMhZy4Gc9kBrnZWAlM5EEeNOQ=; b=kRJYsjkEPPqpXJywgDhVsIzdWpLFqPa8QDGldwWpLoagf/FfTABNzh3M pTPpZEtsRin61ZiclU6vLlhs4O9QMs11PqLzph9AnihF90k9h4TKqYQUN Y0n4jjhVIqe3M2To3HJev1DM5Bvjhg9/Ae0ml9WVo5c/sgsWzyL65nHkv fTjUUrb0HZtiWTISuFQ8PcwE4gZpnlmnXEKelhOrdniOhuatl8x4x69+b DkwyMlrWoW9f1oqgPWk3XhMkQIUaqnrhSB5ohmPYeT1LA+GHV85RvdlmK fFnnV1jNejFUpUUU5696klbKaJ7RinBh0dx6LCkipUDTT0kqZGl0wmJ6W A==; X-IronPort-AV: E=McAfee;i="6600,9927,10789"; a="433405029" X-IronPort-AV: E=Sophos;i="6.01,249,1684825200"; d="scan'208";a="433405029" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2023 05:36:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10789"; a="1059803893" X-IronPort-AV: E=Sophos;i="6.01,249,1684825200"; d="scan'208";a="1059803893" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga005.fm.intel.com with ESMTP; 02 Aug 2023 05:36:04 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 2 Aug 2023 05:36:04 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Wed, 2 Aug 2023 05:36:04 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.102) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Wed, 2 Aug 2023 05:36:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V3o7Cn0YjodnLhz1zpgG3ad6ag/d/hY0UPr0OdXTcJoYS3c3oKDY6B1R/Zqeo942c2AIFDV/xnxilgnU3jwJRVwkqClA2T0lOVxE2iDGHwLdb+yMtyDQfVJF9mmjADhUm8LAgpk0i1qWIZtQZJt6wNYGL6IVRM2PdxeLZZkpeUYkWZrT93Kupzo9h06hOIzSLGFurxZkkzIHk3uUOURj11SDTwckHz8i0vTy74NZvHvh2u5wiZL9S8cBwRfYbwhtb7fgoj+M0WahvI0a9wQlxMJjxoRDDHeJgTYqDRCj9SsFxydmMg6+5V9Nbc4ig5mvvTQjXGSycuYMT+xM/SfNow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iFd8IZ159WhyP1tZKUjEY6ds++akhJ6fW3iNjeYsxmQ=; b=Ww3C49IT+89aoqQfjZkpcE5rumfXwdP48Q0bKTZMkSe2LkTOAZH5cfRimAXbeAYlSqC7HGMg9x0hqr5h19YykS97LZXRyfER9eUdOr3EtjPwjhJi0lG3p9ss3T7m7Uj+3KgLZeFrhQZcoEIhYUnF0qOMvns6Hw4I59ymy+7hYyVoDmpsh0tnznr6R/xz/VaU33pYS6h6jaeZHPmUmN8fh2sYjUki7aOq4+FQB32rzQ7XE5C3YCE88M1duHB9Kwf1v/uTzP75fI9v0qFqTTDKhBrifQjAq1PF/5Qg16F/KifwoLx0WYf2ZQqBoRClngXYfOj/JZgCfJgGRq5ktsLPRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SN7PR11MB7068.namprd11.prod.outlook.com (2603:10b6:806:29b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Wed, 2 Aug 2023 12:36:02 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f%7]) with mapi id 15.20.6631.045; Wed, 2 Aug 2023 12:36:02 +0000 Date: Wed, 2 Aug 2023 13:35:56 +0100 From: Bruce Richardson To: CC: Morten =?iso-8859-1?Q?Br=F8rup?= , "Tyler Retzlaff" , David Christensen Subject: Re: [PATCH v5] build: update DPDK to use C11 standard Message-ID: References: <20230731103858.1491751-1-bruce.richardson@intel.com> <20230802123134.370199-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230802123134.370199-1-bruce.richardson@intel.com> X-ClientProxiedBy: DB7PR05CA0042.eurprd05.prod.outlook.com (2603:10a6:10:2e::19) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SN7PR11MB7068:EE_ X-MS-Office365-Filtering-Correlation-Id: 9f09b925-12f9-4d3e-6536-08db93550835 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: z6oju7m7TMYK5tz46eiYtfFJhuvCOogVWLTTVB/z5CeBNj1f2EJVIBV/t8l8JPTiGIh13qbsz5caw6/ckm6JXOq822ZxpyHbwJG7oiHJw/mD0/ByJ31xT40Tgvzdy2qci5GwctczjEWxZujQ2Se+ki8gkyf+D8MimIRHyh5GT/ncjAQuCgIZUbHRO1SgwRbWDIuH7fMBlysA8effwHqrzCjH06oGmYNHx0D1ffuYb4FBNqCpybC3EU1YtyN6oICg11ElYFpnxU4mb3kCMMeWleitM0rB31tBZEaGsEkxlr4SBPbmGtKDMriHl3JsQniMzXIoBnNe9OKgteL9SlUeGEepk9itQMPH5zz3R1B1pEYtqAXja15s+pd4rqmjJaLKYLlDsDQV9wSUEE6AdbT7aHAEeQSEwYY/9T/SKgI1k4L238VYo/CmrNN9zImRatS4XP9yIOKo8yiSUj8jX8//yZIaNROCqo9OduMdE5Xy9zR1HhXDVL027IDxxLSd8vVVOk05TH6sBkdkd6CzjvnsHEw3XXPdL+423Q7s4mFsx6rtRkiJ6wdIrHzbLulZNCJf X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(396003)(346002)(376002)(136003)(366004)(451199021)(5660300002)(82960400001)(54906003)(6486002)(6666004)(6512007)(478600001)(66946007)(66556008)(66476007)(316002)(38100700002)(4326008)(8676002)(8936002)(41300700001)(186003)(83380400001)(26005)(6916009)(6506007)(86362001)(15650500001)(2906002)(44832011); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?qoiRPY/6rso5M/icC5CC8+X4Wab4PHWSNMTH1eqzgVtTofRSNRl2GR51c/?= =?iso-8859-1?Q?6Gy4ICoMZ5SI2CHqDCj+b4tQk1RuCzRMfP4XNOueGgh4Bg4MFUynmD2AUZ?= =?iso-8859-1?Q?yX6HGPjzmUPbRC8wDnFX51lgg3kGcEcpgrCXRuA85ngZAktzyY1wS8FX6Z?= =?iso-8859-1?Q?i0MmJv9x1qPPJkE1+8AOqoFSlGdM9hnk/hI6Jxr/vsHkKN1UG4qcRvn7LE?= =?iso-8859-1?Q?lJkf3OxdEszMYdqI4kILEGwXBxWUR+riS0xjNBZQ0I8DHZAHqrA3jeTRk1?= =?iso-8859-1?Q?xSLNCoojKBS9D5cmgiLv+u1ckLwI1/SYqi/+5+M+BI5DrD3H0jX6glDIww?= =?iso-8859-1?Q?k3C5eXaGnoZHbgcUuXv4rh92bPh/t9FH/TXbJk8cESu7nJfiSZ5qpWC1qG?= =?iso-8859-1?Q?qtXJc3FqjxUHEOOr4YL6vjYnCID4EFC6/e5tT/ENiMXLM/jwvfw6m9GemO?= =?iso-8859-1?Q?BIBzfntGzE07CJlK5QfRy+GfVcAiv59Xrko9oGk+HjODECXQMWsYObkw47?= =?iso-8859-1?Q?uYyJ2/C8SZnBPNnFqnnjpXCPAubYZHOKwq3akvISxfVJBGK0sHwFGPGtX+?= =?iso-8859-1?Q?J5nw23NqAcZkRKqsEbyr1jb1BOJNBSFJ3w+5WF1wXW5XgnjsEj4DrOqCpS?= =?iso-8859-1?Q?DQSW3vk181Yz42jPFu+fjCTWZSJGhQTFeOnYYMn2SMFMXBpw9JSa8RonU1?= =?iso-8859-1?Q?VF3P7YH67x6gT/aZI3pjUtB2MzDYoiKNBuoCtaoiZkjOWowrqTJOJonFpT?= =?iso-8859-1?Q?GS0KMZCk45tU63fIAs1ySQExUXQDs7DLP56T4aaQTuKdbR4nG6wig5mofy?= =?iso-8859-1?Q?p6qfqL+FwQSy4dle4BMNxDtAfKNDbym0aEqUQoQ/owsvtaNjEje65WnCAB?= =?iso-8859-1?Q?rwjTRNw2l5EQmi2d6BLwHUQUKTT5DBXzTQhk/eXbmXVyCQPTxGdKCZqN6w?= =?iso-8859-1?Q?YIDXOsnyWew+eYK/wcFi9Kj4wCWFiI4J4mwwes8TSenkpic5jNAkGjbFdM?= =?iso-8859-1?Q?1PTxS4LjibMWHgKoEYo0El0ghq+O2emKWzM4ejL+XwBfLNCyIvOlEalBn9?= =?iso-8859-1?Q?nl7UsS6zooeugcAEsRNAtWOq1YJbVYzd8ly+NgyfnRiXg8ciVu6U96Q055?= =?iso-8859-1?Q?8Y//MnOz1lMBFgT+aX3THVRbitXxK1Yr4TwcGTvwb3UpDAB4wHHuVRKMHt?= =?iso-8859-1?Q?PBMKLxvvVgtkwk6+gWJpkklqUjkYkZwSzuUeHgh7/EMQIhruxfLD9T4WxX?= =?iso-8859-1?Q?AK2STUk3VZqTR0tKUbccybo/0JlKCk893vMOgpkRlkP17bAaD88+jowVb0?= =?iso-8859-1?Q?2z3PAttWegR/0oHPMxKA/r7aMgsxzCs7XcsN4n6ezE9I4LeHlrxM1PH/7m?= =?iso-8859-1?Q?0CA3+SV9qhNAiJK4nwyr6XFHms4GsxSVxgDbkLdtQKS7amqfJwPpmxbKg7?= =?iso-8859-1?Q?4EtfBsK2JxM4rrOEf0mq3PuGIXMAnCOrcHeNig4FCfSyY4YUPzsJLXaSuQ?= =?iso-8859-1?Q?CXgPWOTEbNFYUQQSni6NpfigHFXv2SiquNquylAxxcWCSyGh9G89goBowq?= =?iso-8859-1?Q?dFYLkA3Xg5RWT6cFcV4c8AH98z8JUq8/P0gYOX8f0fcrXcFCNOf2LJS8dn?= =?iso-8859-1?Q?EI9ATzldFf/ze4kSijnVilwY4zsSv2jQaHnSZZd0m+4+vVsZRi8pZ25Q?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9f09b925-12f9-4d3e-6536-08db93550835 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 12:36:02.4678 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: x0hKifvCfwUIlqVO371qGvn/pkGQPjb8XArmm2H5Ipx30Jhv4tXRzYJhQ6fJUHlTdH0atNUtJQHw4RB5DCWA9lFqftFIFQCaXO0kM5ssAc4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7068 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Aug 02, 2023 at 01:31:34PM +0100, Bruce Richardson wrote: > As previously announced, DPDK 23.11 will require a C11 supporting > compiler and will use the C11 standard in all builds. > > Forcing use of the C standard, rather than the standard with > GNU extensions, means that some posix definitions which are not in > the C standard are unavailable by default. We fix this by ensuring > the correct defines or cflags are passed to the components that > need them. > > Signed-off-by: Bruce Richardson > Acked-by: Morten Brørup > Acked-by: Tyler Retzlaff > --- > V5: > * Fix build issues with bool type in altivec code, due to bool type > being in C11. Use __bool for altivec-specific version instead. > Just a note on the altivec builds: from my testing on latest ubuntu with "powerpc64le-linux-gnu-gcc (Ubuntu 12.3.0-1ubuntu1~23.04)", there are quite a few warnings/errors building the current DPDK mainline. This patch doesn't fix any of those errors, but neither does it add any new ones, as far as I can see! However, we may need some more PPC fixes and updated CI coverage to catch these issues sooner in future. /Bruce