From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 171D343018; Wed, 9 Aug 2023 14:32:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A383340691; Wed, 9 Aug 2023 14:32:36 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 0E2BB400D6 for ; Wed, 9 Aug 2023 14:32:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691584355; x=1723120355; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=emQ98QCCRCV9KWqhv1AJ+pV26Rx+AlExv9KHjEwGPqI=; b=YyfS3Sg8T2Ss0YSgHT8ftwX6GrEKukswoepGQRZGb1NqzFks6tJa84qU axcbOE/ynlrBEVwAtUr4NpyxB/n8clEcs07grhZCu9PGzyhoBMTnehRKZ yVltfuOXxDrurRZl574Dob7VGXiImL2l+fj0EK4I/JL77Q/Udterg3YQL iNy5V5df+a4k1qDVhtKNuqPt4kU8KlZyfKtblkxuyQGVjkR04jIgRAX3p ut8BH0U7NIQicB/37fn0b9PbqsO/5bfvvbcAB0E7rq7sDQ0CfcIcb9UBF F/9HgJ5U3Vxv7Znc0mketOn3dUBZ+0MvDcjY06sSqFKOHN9xnCijbQyWB g==; X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="368564995" X-IronPort-AV: E=Sophos;i="6.01,159,1684825200"; d="scan'208";a="368564995" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2023 05:32:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="761360429" X-IronPort-AV: E=Sophos;i="6.01,159,1684825200"; d="scan'208";a="761360429" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga008.jf.intel.com with ESMTP; 09 Aug 2023 05:32:33 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 9 Aug 2023 05:32:33 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Wed, 9 Aug 2023 05:32:33 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.173) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Wed, 9 Aug 2023 05:32:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GWVQg+67TviNnQQ9VShZuxpNQTELoc8hxz4lmnskwJobxUFeoHrKz5iWsLqbEnHU1QY/ev/3lUYDrXYo+vgVTkIZaBW9tMHfnPdweHkZUwqdDIpq822ropXSJiABP30HTexrZPNcGEf4wSZIil/IkkZKq1bgXUGZocBC67Oepp96JX2eVh3eecaUwcKd3MSp0WXyX9RN9uS6FYe6ah3Rbbq0i67G1pIFEE8BqDoOBpBlg9mA/86sDE2Kw4j9kRE7oX9Lxvp65pcfNFEggrdZP3s48VTDgigUnGDM5acyoomlulgXWQoki1OMh/4HAwOo7YRvV8lKv9iUDUTc4khKSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0S2390EPEikwH6alMPOgoK2bqvQvfExxCVrvLFiwp/4=; b=IGKPEBFmvfWSg7BgJpQy1acJskseMWf6dWJ7qvSzKgyY2be/ekYeBqeot6C3qd8ckfdUzvecYhgPEm1wnrZD2ZKmtHoMn9yTxVF+7dcXDKBGGjn3Q4W4t4GDzPJDwT2DcX2qlnXmy0Eq4n9luU/n2XfGioGo3Mexzq7MVDzP6ME709sC+izd0TlLcL7ivybZKJaLd6kY4FS6h8honpAkRcduz01XaiJefeERYsop4hMwlY5H4aRzRUitdF3xl0oJdUuA84PnvCWQzMitT20XXGSUPox6K1GcBLSglXlffCiP56bivt6mQtzSUzlnWWCqX5yCdHMfNcj/EnNoKLtELw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CYXPR11MB8710.namprd11.prod.outlook.com (2603:10b6:930:da::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28; Wed, 9 Aug 2023 12:32:31 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f%7]) with mapi id 15.20.6652.028; Wed, 9 Aug 2023 12:32:31 +0000 Date: Wed, 9 Aug 2023 13:32:24 +0100 From: Bruce Richardson To: David Marchand CC: , Morten =?iso-8859-1?Q?Br=F8rup?= , Tyler Retzlaff Subject: Re: [PATCH v7 2/3] log: separate logging functions out of EAL Message-ID: References: <20220829151901.376754-1-bruce.richardson@intel.com> <20230731153902.2350026-1-bruce.richardson@intel.com> <20230731153902.2350026-3-bruce.richardson@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DUZPR01CA0344.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b8::9) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CYXPR11MB8710:EE_ X-MS-Office365-Filtering-Correlation-Id: a3d19932-f8e5-411b-cc12-08db98d4b36f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gfSzToeCh9H2JJ64hL/uY6uwl1c/bdNr3ckMSGuoZJgtKwAaFAUqGtNTGuJnks/J9z1pXH+4tjfERj6dZF2C63gJwMqBprPXDWfVm+fx5OfoFhonjS3qWc2CyJoA00R14sV30c/b7FoEk8tC8m/et55WzKrbqHgWwgD8D11jSw9y7lg3dJOobmP8QxhYr1iwcf6FXE0CJFEbaoc4t7IZOa3Ott9xqPxbTynjBEWb3I4XasmBHp+X1UffwMYq9ZxvXqOZ45UxaMreXUbbWVzH2Fe3LA7a0ac49xyqToDiBx1DTzSaVF3sNKzOkDSOrBE1XWOEs9o1yHUa8bArFs54GixS73WPnBSQkAJNODH2EORS+9lC6Leo3/CAjDqfdyI7otHt3c3GbUeGYQAcKY0DKEBH9h/5PdoJkvDBkcqU71yL6bT+hhnmanSpvVaeC7ZY83LDhd5bBb6ZemZcLMXk0wuN+Npe7KFObH4t3WxJL1kNZeHy7zVXC5/HgKFdmzFKkQS4pdjfo+KXi7mOxU26YjHkT6v9KnkWs8cBr5+EkVW9ccuFJKBPNHjiDW5IYNk5 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(376002)(39860400002)(396003)(366004)(136003)(346002)(186006)(1800799006)(451199021)(54906003)(6916009)(66556008)(66476007)(66946007)(6506007)(26005)(6666004)(478600001)(83380400001)(41300700001)(316002)(44832011)(4326008)(6512007)(6486002)(2906002)(4744005)(86362001)(82960400001)(8936002)(8676002)(5660300002)(38100700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7/1vtIplpnbuKy1dubyJJdYkvK/4aQETqpeU3TVNVSxsOZkdYTQpuNWxhNn5?= =?us-ascii?Q?fjT4lP/t0HgeRE+exc9c7s6Ulr+VrVvbvngs9VCcTkADzL4BcsabDVXw1aYs?= =?us-ascii?Q?Wfr0i99zrv0emNsxLLJgpXl/WgC078jpE17QDCk2zfCA+g01eXMW8wtTUMOh?= =?us-ascii?Q?PFDTp0qOJEvLgA9+OGXiWaPvkeHC9+QfjD2f9PTG7OhZ44jukinyA50T/vO1?= =?us-ascii?Q?83Hobd/hlokOTXXfsIqVDaeuv4aLs1sNKrkdzCdF61hiBOQqdhYI4ffZNiDu?= =?us-ascii?Q?3tRWXVAhKlbPmh+brDsBUAxn5RwZ76liA6+Ay7U3jUuv/s/p5rHtIvNUN46t?= =?us-ascii?Q?SFIUhgtVnW4p1lyKUvyMcwZENfzfJTfty+XMCxvXHLi0gLfytKj9qfOML9pX?= =?us-ascii?Q?TGxKuAfnKBFquqpX3nm+reDa/xoo0kaLwF9a1KZFi2rT3fBcLTzLI9WsGJZf?= =?us-ascii?Q?rytYmRjGVCtA6/Pj2MmLXdWiKEJZ2iQFKtTNSipci2cZJQ18yQabw7hZNlRe?= =?us-ascii?Q?sQbIQYCyTg1WqrUE7ilwzqSmsJhVK3VbkSpzc36ICs79Uf7Iv7u9+PuK/BbM?= =?us-ascii?Q?FPR34AE7CG5ho9zQ4h717UTa3eQuraJtzzADSyb9cK4pzfb1PKTVlZ2cB4Bk?= =?us-ascii?Q?5xvR4REWYd2sPhW5pC8N20WyP3HY8p5eXLfucHx+MP2b05zN3N0ZdRRh8KrV?= =?us-ascii?Q?1pes1ddKKJAVhpyBNrwxN1NKclowPI8SEdp0pzYP/4La8hkc3I7XPCCEoqXZ?= =?us-ascii?Q?Q4WGFKHiw1dRHSOAvvCd6T9tIyz11RcblTSghl5qXsycPTbQAOfsmOAa6763?= =?us-ascii?Q?nLlZwmuGA5toCfVmpmwh9gDjZW5DuXSjCk5Y5qK3axid4MezarCkot2tQl9i?= =?us-ascii?Q?HEWj2kvoSEvmaWaEmBwBAfLU5ypWL4PB72wL6kvsFEt5B8JbVZ4KnKe5BjkL?= =?us-ascii?Q?YAw/4teEskJumK+MKGOgW6sMs9LoPyc1JS9euLkELOo0BEVTrIXz3u1I9p9b?= =?us-ascii?Q?Sw7nl1AjvO6o/5l7uFoJnUgD+VlRguKWxKvm0VZWDF0oSJqAC4Kavs5mIJx8?= =?us-ascii?Q?8lN1QSv75sXpQEJo/B3rQg9OZsy2ZcUbjtD2IcPTPlsRlNaOm/68Mg2Yo+WB?= =?us-ascii?Q?Kv2w/z+MuXv+zWtFN9NIi/xzqOb2QxrawDsK2Dq0WH+HJ3IpEAVtiiQMIXt1?= =?us-ascii?Q?d2EyalleFQ5ysC4y8ZIgq+fq46MhiIxih9SsXRztZ93RXyFfQ3lhpjbgxCpw?= =?us-ascii?Q?MYLvConPiyZhPMGjG/D5VoV+klz4BDU6GqbguoAIoV907UXH32X0jcbQaVvA?= =?us-ascii?Q?961+EGD8aEOODmwD6f7w97zmJHwHDw+frgUf7qPHJLZQs3ZsWdD4XTX8ORwK?= =?us-ascii?Q?R9TZOuFxrs9OvjBQEmQJ9/pvNeCPCMnuSlbhP0+DaWIOOT4L/o1h0WyG03Gr?= =?us-ascii?Q?SQpmMQmx5YbUG1ckUr+lGWcZh4OPjRTZKdZLhDo/FL04m70WoDULyxo0TsCg?= =?us-ascii?Q?94WTlcmQkKIWrsebRBkyqBiimSGDCB9Jq4WVrvYphzTLegpijOvJSy6E/dd5?= =?us-ascii?Q?4OokrkFwNgRLxB2Hg52YUnBCt6zu6frEceJvhEa3I/ADbopugFliHbCZPjne?= =?us-ascii?Q?MA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: a3d19932-f8e5-411b-cc12-08db98d4b36f X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 12:32:31.5413 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: u4z92YcGqD6ovqPeMBOJT8RA0NjWZ71NYhftsnawJ9e6sQbqLBz5uJnUxuWSq8XOshUMmJ8CLCuKY8qQ906GZzEfANq2acEhfNgbVA4l94s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR11MB8710 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Aug 09, 2023 at 02:24:09PM +0200, David Marchand wrote: > Sorry, two additional comments after running more checks. > > lib/log files are not referenced in MAINTAINERS, can you add a new block? > Yep. > > diff --git a/lib/log/meson.build b/lib/log/meson.build > > new file mode 100644 > > index 0000000000..6baff83ee5 > > --- /dev/null > > +++ b/lib/log/meson.build > > @@ -0,0 +1,9 @@ > > +# SPDX-License-Identifier: BSD-3-Clause > > +# Copyright(c) 2022 Intel Corporation > > + > > +includes += global_inc > > +sources = files( > > + 'log.c', > > + 'log_' + exec_env + '.c' > > +) > > Missing a , (reported by check-meson.py). > > > +headers = files('rte_log.h') > Will review all feedback and spin a new revision. thanks, /Bruce