From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26E4B43082; Wed, 16 Aug 2023 17:06:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 84CBB4324F; Wed, 16 Aug 2023 17:06:01 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 8501E4003C; Wed, 16 Aug 2023 17:05:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692198359; x=1723734359; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=vdTucXd7nQEZFHJjAzEagiqXjyL1wDMA3CCoa/NBDcg=; b=daEwxrfsuWBnsKbFO9Xn4MhGZiaGP4dpg53D96QwMj4Ohqe039Ajf4P+ 3+Sv74ocfr7VsT/882uVYb/g4jyos0H6djbVeonn95NM0/eIAd7U6rzZ6 vs6wgnakaBxOrgP+gfs3Qa17hPAbTCEj6SVX83r5MY7Z2aepiqQ3wLMkg tOYJIqpwJtcE9kaqntzMpmuJjnGdWxrhgs5PDwAjpuoO2Lt66srwnajxT bzL/jmXZHrP2pPSs9KiUibyGeoWKodpnpzM5gaAdJaUTTztdm1NVjV2xK foCNj4UAticgyz1utsbrjxRx1+kmMTL3aO84XysXsfTPyeBXpqrLCi4yk g==; X-IronPort-AV: E=McAfee;i="6600,9927,10803"; a="438906387" X-IronPort-AV: E=Sophos;i="6.01,177,1684825200"; d="scan'208";a="438906387" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Aug 2023 08:05:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10803"; a="711139864" X-IronPort-AV: E=Sophos;i="6.01,177,1684825200"; d="scan'208";a="711139864" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga006.jf.intel.com with ESMTP; 16 Aug 2023 08:05:44 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 16 Aug 2023 08:05:43 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 16 Aug 2023 08:05:43 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Wed, 16 Aug 2023 08:05:43 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.109) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Wed, 16 Aug 2023 08:05:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=glvsa3rMkiAKv1/B5qWZ/LEAEEnBQEOzi5OTtP3kzypCxCMQjrDO7eQy1S9wz+XCecarIAajKc14y9UZ5vVUZCWK4Hq/KtTxkVW4D3LIfkqxyWZBYa+5Y05FsRbKbXcnSR6rK6qQqWpwTf6xSX5GKvHXRMTW9/GwFNe9LZJoAexLGR9HaZDgwgevWXpsjpREkYzpuBNmzoVktZrN//c1d2RwS5k3xKNSuM3wRSKxbcWIJ7Sv8geaM86KHIP92BHG/CFqZRKgETwvnJP8YP7/fOREpcQGJlEGgsFRwEWbUGnoWrXa2qz5P5wmelsgPY9k/Trp03HZRsMK/U7FO9n1WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j3VX+4OhhB6vwpa11VwVRxGGrsjcATqA113E5UctYmM=; b=eO2rBeT3h+ZcmwY/3hwHQ/Twy1n+kS55GQ74f7WHzT3xW0oAAai5aMB9+/MEkgafufNm7RWfIUEjZYu3+uesHssMzGR++oy5BwnGgB1giVTKx+VtARkfkkbTWCxr5QYhHvtkolNKIRHE9Auta77QOu+4zqkebHudoGpzCdFm5Z3W5i+qSieZzL9J06xk1izK8wjkdn1iOYjFdGgJaElHcMUPycgSU9bQvkpara7JWEBybY07nCs5Ym6G2ggPgrrKlwdcAncq3kCHgpfx7LEGRR/0VbINNZtHj/o483xlq4ntFZg5yh/7MbvyJ7l8FWKBVh9CLg8xBWRtSbdhE57G2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by LV8PR11MB8607.namprd11.prod.outlook.com (2603:10b6:408:1ec::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.30; Wed, 16 Aug 2023 15:05:41 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f%7]) with mapi id 15.20.6678.025; Wed, 16 Aug 2023 15:05:41 +0000 Date: Wed, 16 Aug 2023 16:05:34 +0100 From: Bruce Richardson <bruce.richardson@intel.com> To: David Marchand <david.marchand@redhat.com> CC: <dev@dpdk.org>, <ci@dpdk.org>, Morten =?iso-8859-1?Q?Br=F8rup?= <mb@smartsharesystems.com> Subject: Re: [PATCH v5 02/10] app/test: tag tests with the test type Message-ID: <ZNzlvlGuRoSVLFtm@bricha3-MOBL.ger.corp.intel.com> References: <20230721115125.55137-1-bruce.richardson@intel.com> <20230815151053.996469-1-bruce.richardson@intel.com> <20230815151053.996469-3-bruce.richardson@intel.com> <CAJFAV8zvas4W9vFjVQcohSfeX+8qtKn9iFKOgM5As5i5ngwRkA@mail.gmail.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <CAJFAV8zvas4W9vFjVQcohSfeX+8qtKn9iFKOgM5As5i5ngwRkA@mail.gmail.com> X-ClientProxiedBy: DUZPR01CA0245.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b5::25) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|LV8PR11MB8607:EE_ X-MS-Office365-Filtering-Correlation-Id: ebf13986-1348-46ef-51e1-08db9e6a41bc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2fDYBMo4hAahBFaOIIXhEPHmlKHaDNzkBgsciBUUf3VnL+N9cGrV+eNEtRLsurlvfgbVwU8vD4gbSxV8QKcXNledllV40l6CzC9qBukP96vemAD6QZRCXISV7+fHPfdlgRtSBXwqF6FJj8W7HJHUC9c5FuF/WaQyxBW8AEYwlXYGjMfaExrtMVGuHz6AyNJCQchSox1pQDMEMHcDycTSaZWzFZpb0eF5zf+o04Vjs3ti9kllHfxJqwBoLevAnIRuaYXTK/iYwOpd5qM9cqYumXycAQ1NEtzQkUHBJtiIKvpQ7N0xCuTO8bA4JwOM+ZFLwP9OdTyFy4hnIIpuu8hJXmQWCyT75XXtAPxWYEerRVkPpJ4wsN1brP0bhXgTLipKktiyqC/m0sQwGlVRWtnKftWENsPzmMIsIzYPf58H7sHSbXtgIyD4sRj2RP9vFNNUxJ36uKAxsHtYJrUd+zeAHTyQZpHLqK1FaKiQIok+d5dKQHHBSSqIEC1C0LWxj1ZajB0PasnuZgqoHbZ2XJxKeYT6raqviQtgiPdQDArhVKSpk+HB4pwQzI16J7AoGM2u X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(39860400002)(346002)(366004)(376002)(136003)(1800799009)(451199024)(186009)(316002)(6916009)(66946007)(66476007)(66556008)(41300700001)(5660300002)(44832011)(38100700002)(8676002)(4326008)(8936002)(82960400001)(2906002)(83380400001)(26005)(478600001)(86362001)(6512007)(53546011)(6506007)(6666004)(6486002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZW10WnZRaFJTWU4wL0VaVFkrZm1mSzc0UGJpc0ZjMWdreGt2TjdVY1NnYXRr?= =?utf-8?B?V1B6WFZReEdnQ01La2dvSERoNFhLYklwdlBaNlZpRE5tMUI3bTEvTVYzT2Uv?= =?utf-8?B?WkcyKzFTZmtqK2cxNFZsd1VzdnlDYzhVT2hxUitoelJnTUxPWVh3OWh0STQ5?= =?utf-8?B?b3EwYyswLzBFRzVQcWRRUWpFYWsxRHljcFVuR3ZIZS9zTk00YUtpdFZrMndt?= =?utf-8?B?b3l3cVRLKzVmeFdUREljVEZjY3lKdlZ2TVNGN2VtUDROKzNDOFJZTU9vSlVo?= =?utf-8?B?YUhuZXZjbGoydlRZUEk5S3FQOXh2T3lkcCtzVkV2VDIyazNQR1FEYzcvY212?= =?utf-8?B?NnhIbUIwdjNFamIrVUdVWXVMbWFiejQwbURmaVZ3Y2dXRGtOZXBMSXd3eXI1?= =?utf-8?B?RVNUWXhLWC9HalRkeFM0TEttYkNlZU5kR2ZsblZ5SFZ4WTJMWXVNZElmOERQ?= =?utf-8?B?ZEJEaFFPREF3TWN1azVSMWpkOEN3U1F5c0Uxa1JMZVFkQmUwYXBzSVlLVnpR?= =?utf-8?B?WDFhTDZxSmg2YjZpdXo2T2Qzd3NMQW9Ncnl5Z2FVWkRFMytHMDdNM2F3QU1m?= =?utf-8?B?TXFUNitmcW5GMVpwSVlMVjNNNGNMV09ZRFVpQkVZelBDWG1zcCtxWGZUdE13?= =?utf-8?B?MG5aSEptU3ZuU1l0VXJwUHFNemt5aHYrcTRmVVZudXNLODhHR0Y2V09pcUUz?= =?utf-8?B?OTU0YklaSlRKc0k5TldEQ0x2dEZETkxKN0FwQ0s1VDZUUHUvNHEwWWwyUW1h?= =?utf-8?B?bkFnTmc5ZmdCdERMNmN0NXBYN3ZWNkwzemdabG9aUjVVdVRyeUVWZ1IrSHN0?= =?utf-8?B?REt3blNpRnZsR3RCdFpKVHRwQnlkejJSb2dGbHhIYTE3SDhZN09LUTZUUC9X?= =?utf-8?B?RHdEYnlrd0dwRmp0TWNYK0Y1azE4UmQ0aEdEandXSFRBdk1qQUpoV0s2NnJm?= =?utf-8?B?UlIrNWpObXNJdmpIOXl3U1JxOGMvK0ZtTzg3NzBtaytNQ1o5Wi95d1NWTWF1?= =?utf-8?B?SnNjUndsWW4wUHgvVFJZanlkc1ZRK0tUS3UzRzlvQXNOc3plTHFOR2NRQzZJ?= =?utf-8?B?Umpxdy9oVE9tV01sbm83dGY3TDdQTFpaS0pNSm5uei9pdnJUcFdDMnZnM1Zt?= =?utf-8?B?R21BYjA5cnVYVEZtUEtYVDhKeHVkbG8zZVdXZlpMUk54T1FOUThKOFo4VEV3?= =?utf-8?B?aHU0ckZ1QitHdjdtSHZhOXRGQnZIdE03WVdZWjREU2psWEdSVHZTNWo5M1pS?= =?utf-8?B?d1hsbnRtVXN1OER4VHhPNTBSRGY0L3EwYUdaZ05mQU1wTDJPUFh1L2dyRnlZ?= =?utf-8?B?R2dHczRKV2ZpdTQ0SHRkNy92V0dOQmEwdEFXaHdBa05vNmU5SFdPeTRIc1Ex?= =?utf-8?B?dU5KaTFIUVFuRkMrbGRFT01JdkdMakM4eUV6RHR5anRPS1hkcWhPTG1wNWs3?= =?utf-8?B?b3gxU0duNWk1V0FGdUQ2SmRLMXUxaUNIalNVSVlIYVJsM0lXb2xjQ1lZUkF6?= =?utf-8?B?Z2lBTmRVeUZnc0Q5R1dXWldqS3NaSmRBUjlEazRMTFFCRis0NEozbEl5ZWMr?= =?utf-8?B?U0FDcE9OSFpnSFBNbWoxRUh6ZHF1RkgyUW1aMXlxQ3g0QnVZa1hMaTFtY1pC?= =?utf-8?B?c0FTRFp3MDZROTJUWnEySkFsek1ZcHhpTElxUlc3Q251KytCV084M1VETkpa?= =?utf-8?B?M0pSZ3RiazA2R0VsVlA0dE1laHlJRlpLZlFhMnVSSEY1Tk5KVUkvMmlqa01O?= =?utf-8?B?SjhxQmY2VEU2bkMrWHlNNUdQNzNzRkFlT3I4MjUrdGpRSGRrM1JhbGcwRE5k?= =?utf-8?B?Tmk4eGJ3cDh6blhkNkJBbjQ3aTNVSS9kazBvbStjYnpmTEVaN0E5WGhORmFP?= =?utf-8?B?RWJIZ3JxQVNRR0MwOUV0VXNyL2JzdXdlZ1hiUGt5UUtLUGdpQ1VaZVprWHU2?= =?utf-8?B?L0NtcXNuUCtvdDFwWlZIZS96RnNCWURpUzZIWjl4emxQaVdWRDNrblZhcGI1?= =?utf-8?B?T0wyckhrNzgydWR0WmhWWkJqaEFrbnZUenZ1V0hoYUNqTmlOWnlPWGdleFIy?= =?utf-8?B?b0RRZGx3bkxQSitHcDBsV3V5dmUrL0hreTFhL1UxdlVXTjRqU01oN1h1Z2hx?= =?utf-8?B?dzRtbTRIWnlmc0hjZ09ZZHhFYjZIL0hSbGZPZjhseXBERGs1bXA4N240RFpR?= =?utf-8?B?T2c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: ebf13986-1348-46ef-51e1-08db9e6a41bc X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2023 15:05:41.1910 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PjcY7xYCsOHaT5EgH6zUXgV3Q8JUHzNKMiFCT2hKmxxM/eg61qUa9yefaj6pM6bj4uMOT364yVAafjJAM8fJHFb0QGosOe4fUSXlcRIBnvw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8607 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Wed, Aug 16, 2023 at 04:56:23PM +0200, David Marchand wrote: > On Tue, Aug 15, 2023 at 5:23 PM Bruce Richardson > <bruce.richardson@intel.com> wrote: > > diff --git a/app/test/test_acl.c b/app/test/test_acl.c > > index 623f34682e..bf1466fe11 100644 > > --- a/app/test/test_acl.c > > +++ b/app/test/test_acl.c > > @@ -1749,4 +1749,4 @@ test_acl(void) > > > > #endif /* !RTE_EXEC_ENV_WINDOWS */ > > > > -REGISTER_TEST_COMMAND(acl_autotest, test_acl); > > +REGISTER_FAST_TEST(acl_autotest, True, True, test_acl); > > A bit surprising to read "True" and not "true" in some C code. > I see meson supports both forms. > Do you have a reason to go with "True"? > Maybe you prefer to keep it like this so it is not confused with the C > boolean keyword? > This info is pulled out by python script, so I believe it is capitalized so I can process them as boolean values there. However, looking at the script, it doesn't actually ever convert to boolean right now, so this may be a holdover from earlier versions. When we pass the values to meson, they are all forced to lowercase. /Bruce