From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 382EE430EE; Thu, 24 Aug 2023 11:00:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1F5D74282D; Thu, 24 Aug 2023 11:00:23 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 52D19410EE for ; Thu, 24 Aug 2023 11:00:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692867621; x=1724403621; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=80cqAKXXwk+wX/up0k7ltbvVrUO8fv7X8wpB+0S4yG0=; b=hNJQE1fsYC3bCG7+T4dd5XK5lMaHbmtyC7MENOsktoztDH6rWnx2f6Ty vfd1TYcKuTG2WWI5Ek8xuiwIu7KIpwvfCqTlWOnTr8LVyW3rrRNAt9euZ NykAsX/bLo4P6IpTeGcWUq4ES2S9qmUPn1o0eHt1dlPxoyK/E2Ri+xzeA +CHU1Sm0yi4g87rTbB4ABq8Y8gSosHpwrNq+/gvMaAa3CqFTUAU3ZDBdx bWsSkiHHJh8tqosLXfPUOyccQZIxIlbqagdSU/jyGGUAllOE9EJdbh+PV PQ6T/vANEW+KEzAw39WBQWgRUTlMvfQe0CBu/VHrS4iB4d0ckfyeZLgIJ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10811"; a="353927886" X-IronPort-AV: E=Sophos;i="6.01,195,1684825200"; d="scan'208";a="353927886" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Aug 2023 02:00:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10811"; a="1067748440" X-IronPort-AV: E=Sophos;i="6.01,195,1684825200"; d="scan'208";a="1067748440" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga005.fm.intel.com with ESMTP; 24 Aug 2023 02:00:19 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 24 Aug 2023 02:00:19 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Thu, 24 Aug 2023 02:00:19 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.40) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Thu, 24 Aug 2023 02:00:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BWPs7d+Vsn4jhkyawu1l1dGbn8wqGPB9gwEO948OrLCyN0diDwf5JLWZIIyJoL4HY63ZdUM2hdtef2ghbVEJDlG690vRRtjV8P10OH/BzY0uKl0kKgGdqmpgeIis3TghBF26SZX88LHU19YlOHVEB7Zt5ky8IjTIL7MC4m9bce6rrA+KmpM5IBb79SOs4EWcudc+64Mh2iqNzs8LCqgkIXSw+f5X4UOYdp+3jmYAsGOXFo80XpDgAojMbNeXKYo6X/qjrfM+RHvCqjZizG0feB8v4HpDn5yU2RAVi0ZBEEhtxru0hWcHuAlU2jObsWUSFbUCBb2UVzRwt3EAo+yZxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q/xsEW1GZnEFTaxcMRFoMHGfkh9WT/CvxDeZYVX5EbY=; b=b7YdWpDwNFlVvB2THrnnKqYprHemSnXjDBa2SVbCz3MZojRT8oLDJNnUKzShOqE3cmuSdHNMCevaLK1ohSzqwjnJAcC+GVL5P/y5mIHI9y1U6iYMOgWOPHIHd4NaDpNu37AUyP8E/80e5FvdW5498YUpqn7Iwmmhh6AZSnjHXEml4QNg1IMBQ+k+iNXlBAAineYsctG+hE1nxLB7QNi3kRXBWHd1KHqF8jd/PMmFBuMv7dyTrgZKPxvDN4IAwYXE9/mFAs9ya4phON5Pw36s9jCDnT7l55a0koFxF2/up7hCyz4nOB0vgeJAB6CQB+G73Nv4dtRGWBQ6LF2tauI+5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA3PR11MB7610.namprd11.prod.outlook.com (2603:10b6:806:31d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.24; Thu, 24 Aug 2023 09:00:17 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347%5]) with mapi id 15.20.6699.027; Thu, 24 Aug 2023 09:00:17 +0000 Date: Thu, 24 Aug 2023 10:00:10 +0100 From: Bruce Richardson To: David Marchand CC: , , Ruifeng Wang , David Christensen , Konstantin Ananyev Subject: Re: [PATCH] remove wrappers for GCC < 4.8 Message-ID: References: <20230824083034.806773-1-david.marchand@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230824083034.806773-1-david.marchand@redhat.com> X-ClientProxiedBy: DU2PR04CA0193.eurprd04.prod.outlook.com (2603:10a6:10:28d::18) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA3PR11MB7610:EE_ X-MS-Office365-Filtering-Correlation-Id: a51879bb-b4de-4c87-c83d-08dba480898a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DV5B9tDRUFLCPe685fNWOVBgJH/2K1RxipaaME/98sYniA+Pj0gSrfiQ34ANFOn8n0YxmcWfiv/RSSAvwfRVu5FnFx3ZHDaHe+qWH1gQ1o9Jz9rvNgjpfsPXS7ZyMTlD6JAS3uvguQeqGTAmwKx64S/GUASzCY91Wytd/dTU6NaN9WVw0LF1ZubMh74aApRQX6Af6Sb5x5QGCBP/gXVQzooDd+E8HoGiKSr4GJ/zV26RgW1ccrievLGzBA7J2HVBrRBuUKXypcY6K4l931qMDvJ/TL+Mk53K9LyPiOp8cfK/hen6XrNwn0AFZNYAcIdo3vcix/HM3EOZLb/zjwWufuCWe0Uz0rhY8tl+G/lCjwnk/UoMZTP0Y32ee1vlVNAtL8Qfv6Rn/MaEdOCCZa3RB8mQ6GPk+DvrKSHLZk/Si5ZiuxQH5NtOG/ib7WLE1zcAOFrN3JpctdQFCBTR7zJ1KXEC9NLvN7dALp6Ds7eqqeuw95c04CQAPFwZe9DZQBwQNO0UFSpUDnSe7lNB+iQfbHw64KWR66XAPyg/QZwcpe1o8SlVqkC6t1wFW7uFKOMF X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(376002)(136003)(346002)(39860400002)(366004)(186009)(1800799009)(451199024)(54906003)(66476007)(6916009)(316002)(66556008)(6512007)(82960400001)(8676002)(8936002)(66946007)(4326008)(41300700001)(478600001)(6666004)(38100700002)(6506007)(6486002)(83380400001)(4744005)(2906002)(5660300002)(86362001)(44832011)(26005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+SXgW/xUsxijpO0k53ZeVTK0xAxoVwuQkmO9bKK02ECLna9iqa8hJxGmpJH/?= =?us-ascii?Q?r6CJXAfpxO0f1oXKzbe+rzStkMcjeAfBwpfJUcwXQWuoCexfGxQzvhEm0Vai?= =?us-ascii?Q?qKxnjGJyejIk3aOo1XKDy7iLVPWWne+euUEE/0fAyGjmmqXdGyaG5TYs0bzq?= =?us-ascii?Q?mS60YO3KxEvoX6Eil07ZZot9+hyvBgdvrvaL8pTG1yIeiA8U5ZZWByv6CttQ?= =?us-ascii?Q?mDzPzpTWqSdQb8BOuAzW38IC2TX+GZNXZZSTfu0CHXuU77eW4bWXTvHNhfVR?= =?us-ascii?Q?0XOviza0fsz2JqQn5flkHiJVssUS7lGebyPMJX15S2E5wWcVEYatRWonGdnc?= =?us-ascii?Q?9KwK6LZEh0/kIjjUC+sAZIczjsNq/ZLdoITcDVJvC1V8kMoZnla8oZE75FBR?= =?us-ascii?Q?CHn/TUo3Zww0Rl8uQ08ZdZiSjsWDlVEQd9w1DH/nyUb+Y80LBDdEVuAXsmbU?= =?us-ascii?Q?z6CLnVGrdYHgaIQePVYri6eWwW9oRFcQxuJ39Gy1A5AXyMqza0Ys/y9mVZsK?= =?us-ascii?Q?BlaGdH8Ei8rn/wYV4gt8qj8gNT3kp6zb41RSN2r6dFqrMFEgVO5yDF5ev2F/?= =?us-ascii?Q?LsU4otI3iWmEA/s0FhN1+t7uHmksJuhHbnn6Yv+OxoPPf3dQw1MNNKw7n5+d?= =?us-ascii?Q?eaGa0h4aFK7xyKL1dfaYTMbod42qH2Rjrg75K5ebmfL8qH8L5jaDlQu2j8PS?= =?us-ascii?Q?xlWQAzeCJgoer4vVZEpTuRoEknHqq/PWQf7n1cuQKG388KA8C1IJasbaN37d?= =?us-ascii?Q?Mn68zrljpBunid+zYCjPY0P/WFO1Hx8LaGPO5S7pB5NCGuVMS13fF955V2og?= =?us-ascii?Q?rANIVTlJEQVRuzrEue/EDMBs0eO+qqR1xIgNCdh060EzDHCI4J9XDzs1TXC7?= =?us-ascii?Q?v4I+SqycCNaJIOc6UMH0bGqe+PVNTTU2jK5qYRt0LSlofJsdu7buopk8oo/O?= =?us-ascii?Q?6sEVstZUA93l73guXrD+9WroxWMkgcEwA/ghUFjtKWgXIXHFPkmxl9zFplu9?= =?us-ascii?Q?Mo/zwUioQNifVRWIcpKKwOOdT/bN1N7nHJbeplZT5x36cJEP3o6bqk6OdQml?= =?us-ascii?Q?EZZ7rppbNLHcDmGNKtCvf0u2BhXccZS3Vs1ypzGYu+8bxO90WfTSPMsy+oKN?= =?us-ascii?Q?Hfi5mXyzH/0i4g9YXLbzAQTf6kWtcoQAlklCnLL+0T+z257wB77YpzKhK1st?= =?us-ascii?Q?YSKoeF06Mg7FK9vX6Ks/UCvm9nAoxa/f72asLq/EbjSQxM2GxB/pdaNecASG?= =?us-ascii?Q?m8kkdCtJkSaecDHquzknY+2j8ziiU10acygmZarhVq6hqyG7ddTwGTzoFBQ3?= =?us-ascii?Q?+lWtCS4v/0XTCRL+dmwtlWjDloItb8Kz6QWbn+oxBw2LKqWXTy4tyKYZA7IF?= =?us-ascii?Q?vp5jUmOMknHwcrEwKIms9m1uhWhFR7ohXfOR3n4IApTSsRqDS6BB3gFfKM4X?= =?us-ascii?Q?ZaflEkllfwqGgZVRCh6Qo8+55pkW8lcu4Fxv5+19Ct2TKyVCcgoMTJQGJ9gJ?= =?us-ascii?Q?UjRgdbwKqAGDz6LatH0cPFcr89NHOKP55IcxtZbS0DUSAnyfMv9a4E43kKdP?= =?us-ascii?Q?xjaKmYkkYd2+DO2SQGCOcPcFDJWYVtCnSaWYBtc3rq55xsUAcoNY5rfA9rB4?= =?us-ascii?Q?8w=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: a51879bb-b4de-4c87-c83d-08dba480898a X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2023 09:00:17.4744 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7sl05B0UyKsSkH2pnFp6Sj7Vlj8iW7VLXtV4ZuXuP1UK3Rb0fd1jhk6cmjiKwCsmpjKu9pihBpzWQAdWaZJOkFIW57ce10DTPlJnlB17xsM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7610 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Aug 24, 2023 at 10:30:34AM +0200, David Marchand wrote: > As we made our move to C11, GCC requirements has been bumped. > Wrappers for old versions of GCC can be dropped. > > Signed-off-by: David Marchand > --- > lib/eal/arm/include/rte_byteorder.h | 19 ------------------- > lib/eal/arm/include/rte_vect.h | 12 ------------ > lib/eal/include/generic/rte_byteorder.h | 2 -- > lib/eal/include/rte_debug.h | 4 ---- > lib/eal/ppc/include/rte_byteorder.h | 9 --------- > lib/eal/x86/include/rte_byteorder.h | 8 -------- > lib/eal/x86/include/rte_vect.h | 9 +-------- > lib/log/rte_log.h | 4 ---- > 8 files changed, 1 insertion(+), 66 deletions(-) > I think there are checks for GCC_VERSION > 40306 (i.e. gcc 4.3) in rte_lru_x86.h that can be removed too. Otherwise, Acked-by: Bruce Richardson