From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91CFE424EC; Mon, 4 Sep 2023 09:54:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6FE30402AF; Mon, 4 Sep 2023 09:54:24 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 76462402AE; Mon, 4 Sep 2023 09:54:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693814062; x=1725350062; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=iCCR6yNSj7kqiq/oXaJRx51KbggzlU3tB/rvxLTteoY=; b=WHYwZPtFSDKqehU28LAB2cJo0WwV7YK6MHTL4hYjUiGRKXbjzb/tlVlg BYZXrMdrmaKs2YNbY1nKy49wdFVYFrXWG27fS6hAXZtUd+Z8iRSMUAt8T zpsdL/WB19Bzz0Dd56CiOOH/Q4yu9YE6uSAABV1cR5zoXC5K+bqUeTjqA 4/9Y3gFtO2NVpvco/hU2YcH1/UFqHeQBrbSnMLSOFqSj7qfnv3SmnOrZ3 AqP4Kp9jHQK6WimmOC9Fc933NO7R0mo0g/pvRIhP6UNpHThOgEYOqdACf /ZmuCD+WGhRyrirEnJ2/pNpDpJ7F2WCDTL5WggFR69093gAbAY+8jyhKT A==; X-IronPort-AV: E=McAfee;i="6600,9927,10822"; a="356859284" X-IronPort-AV: E=Sophos;i="6.02,225,1688454000"; d="scan'208";a="356859284" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2023 00:54:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10822"; a="743851681" X-IronPort-AV: E=Sophos;i="6.02,225,1688454000"; d="scan'208";a="743851681" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 04 Sep 2023 00:54:20 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 4 Sep 2023 00:54:20 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 4 Sep 2023 00:54:20 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 4 Sep 2023 00:54:20 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Mon, 4 Sep 2023 00:54:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XcNtoLj5QV7uygbxiI4VuDtJhm0CaXqme/vxQIe72VNfRSYwmAd/bvTzwtOmFErnlisT/VVcwcbcKD+z7oziZ1aQ8UuDV8Cm3J3z6Rgnd3VX3set2QaffnJ0pqvItn4fXGguMJpL/vo56eDT5kv69eUofBFYLJKhKWfHHYWiOTUWprfWhrGfEGBAe1P6Ls4D9RVLT3TuODuj5GkFO9iF1DRYN8Ym0cS4q2PoOFBLqGYSMORZvxvsAIXidzmya0QJNpOvN1lwMoK8URsDj3r9UwgmIiSc88ml1L1RIifFhHYBhx8ZfogmprB5suUKHxshW98XfLAw8WoPdP5KeEiErg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vsZ1GMbatoCEfuVImYlN3KKui3YjcC5vlTF07TaNoRw=; b=Fz3AnerBLI5Hrj+0YasCscNFJBDg4LGlk2SfSoXvbSrPi//VUvbS49nxANAousip48PpxSEq3INvJg6u169nGTflf294Gq0CIUt2mu4I7hHeNk+oImdUDDLvIGT1xGjokpBmo6e0hdsQSjQsSTIebPP8JCo8jR7+lbxLrZ+EnGGWj72tC8UaTi7y9sMvKp7dOrDdIBgP5MK4SNtRiNGd7BZEP7y/Ng0NLvMDVT9XcndmJ3Eyo019OclR57NWIVA8NOavrp2j77MDBOgDJGQC+NOjwcLJtE3cxggwJuEb9wHjUW18CRFhxDvXVLLPZYbN34cmv+tMzJpWO3WCiag/QQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from CY8PR11MB7290.namprd11.prod.outlook.com (2603:10b6:930:9a::6) by SJ0PR11MB5815.namprd11.prod.outlook.com (2603:10b6:a03:426::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.30; Mon, 4 Sep 2023 07:54:12 +0000 Received: from CY8PR11MB7290.namprd11.prod.outlook.com ([fe80::1bb0:424:8477:dbfb]) by CY8PR11MB7290.namprd11.prod.outlook.com ([fe80::1bb0:424:8477:dbfb%3]) with mapi id 15.20.6745.030; Mon, 4 Sep 2023 07:54:12 +0000 Date: Mon, 4 Sep 2023 08:54:05 +0100 From: Bruce Richardson To: "Zhang, Qi Z" CC: "dev@dpdk.org" , "Wu, Jingjing" , "stable@dpdk.org" Subject: Re: [PATCH v2 3/4] net/iavf: fix restart of Rx queue on reconfigure Message-ID: References: <20230830155919.592390-1-bruce.richardson@intel.com> <20230831123337.871496-1-bruce.richardson@intel.com> <20230831123337.871496-4-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DUZPR01CA0323.eurprd01.prod.exchangelabs.com (2603:10a6:10:4ba::24) To CY8PR11MB7290.namprd11.prod.outlook.com (2603:10b6:930:9a::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY8PR11MB7290:EE_|SJ0PR11MB5815:EE_ X-MS-Office365-Filtering-Correlation-Id: 5735ad91-0d68-42ba-1408-08dbad1c209a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uH6Pyk5A7XSTYWtVY3a5pOGxhyWVwCCITYUdODmOapc8NrnMErQOG3d81F8Aprgc446hGJFgMKUYycHKqBI5aMXpb2nbsBgQ4BkuaD0R6fEQYRtJlIbKbRs8bnG6OZPF5/C1JxKjUv6BwhmFM01qzUpwbJT5e+tKyIba3TFVhuEmz53L6iTRofJzIjv5l01Feutq8wCnJz8j+QXyHzwJ8z7/7tDWMfRjzs2dzKXqjDeMFCrEG/7P4Igfl+8mRZFe+ve+Jk8xF4F+V4NYFiX4dUNtMxVpXUHzTOzpEJZXcUIkmYXRWPDGPGQdPG1tsvNj0YMdmtUXfpTMfBUDDsm2zGNQRmtxh6z6Ahk4uRk4Bg38gjzZZoafWkE1/IMTurw9yQS+pSzVRmZiGmePLZBjcej4pwNzIVN01SU/fQjcP+P3Pi8zj1A4U241K/Psfv1al6x6AyFK1TLaQS810bW2k1b61BcMIFF728k4khWzLFyCgIHdrC/ytPYRC0MaSUez7s1fTAJOJiawvpp9FMhyiUITk4HSqOtJr5DWKQKSwD8bwmV/SVDIZtjdCs0X/SJC X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY8PR11MB7290.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(346002)(366004)(136003)(39860400002)(376002)(451199024)(1800799009)(186009)(53546011)(6512007)(6666004)(6486002)(6506007)(82960400001)(38100700002)(86362001)(2906002)(26005)(478600001)(83380400001)(66946007)(8936002)(8676002)(6862004)(450100002)(5660300002)(4326008)(44832011)(316002)(41300700001)(6636002)(54906003)(66556008)(66476007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U3BnVWdqZFNNRUQyOENuSW1rUnk0cWZwdjM5dUtUcmZLSC9rcitpNVFGaXdI?= =?utf-8?B?bVZuQ1FjUnFnUVRjb1g5bTlxejZRUTdCdzVFQ3dCbzFxaWZBYytZdHh3K2g3?= =?utf-8?B?SHFSdmJrelFaRDVvalFxdEQ0b3JvSXZ0UFRrOHdCb1pGdW9Iek8rRVNJeWJn?= =?utf-8?B?ZEVGcklMR3l1VVYwcllIbXhjRWlZSVRORWRqQWd1NWVDaU9iOFFHRTd0Y3VI?= =?utf-8?B?Z0RpNGNRMnFrSWNFaGZMaE5HNUxIQ2FXdzB3V0dGKzZrbTVzVHNZWEdoL3VN?= =?utf-8?B?VXFtY2pLbEZmcmlqWFJ0TGNEbGR1d3I3R2lwRmFXZXVaS05vM3pva0l5VnNi?= =?utf-8?B?dlkzdk10WUI0MEVlNnRLWU5qRE5MSVpwT1NTWEVxWnY1eStSQ2g4V3JSM1dr?= =?utf-8?B?aHFUTGcrOGJVdmdHTnREekpvRW03TzlTNWpKV1Fqd20ySG1rUC9valc1T3Vi?= =?utf-8?B?eVRnbTliVlpQa2IvNHVKcjNaL0tHYXJvdE9BZHcxYWNtK0dtc1VPbzc1czBY?= =?utf-8?B?Uk5kM0tRdTlkNlBvcitFSG4yM1NuS2JNNTAyTWQyeGhKT2p3MUc2RTNMeWFQ?= =?utf-8?B?ZHpmUVZFRmNIT0ExamhxVkNzeU5SWkoyT1FoNS9KdDVNRW9sUmRaUlU0T1U1?= =?utf-8?B?eXhrWUQ5L2tQTHBRb3AvL2lJbElrY0I1Zi9nRVlVa25KQm1wVm8zWVIwQ1Y3?= =?utf-8?B?c2E4VEJoK3RabUVUU25DMDc3UmNMT09EMkpVam5qNURJUGY2aStsY2xZREl3?= =?utf-8?B?V1J4am12a01IRWFvaGtnQUJ5Wkh1WUthdkZNZDlIdXphdkhUNWE3aUJ2eUZQ?= =?utf-8?B?blVrVytEVUpydDl5VHlrK3VpblBIaVhaUFhVSG9LMUZEYmNyWTJrS1lBTCt4?= =?utf-8?B?d1Z5b2VCbENZemJZRmlpWEEvaVRqTXpBTTBGSmFsNDl2U0tkclQrenVjbmVX?= =?utf-8?B?emRBekZuSEZ4MmNBWWlRNDJHVTRiS2JaTFRSc1JtK1QwM2dNTVdYSXR3QytV?= =?utf-8?B?a2R1WmY3Yk1oQUl0TWFIUjJmemdMNDJRa3VZbzFCYVBYYnpsR25UaW5Kay9R?= =?utf-8?B?SUJoMlo0YjBIMXA4WVF1UTJJVkt2aXNIUm5TQ0laMlVCS2tVb0FDdG1Udktv?= =?utf-8?B?WDZiWU13Nkk1UE1TZ0RXWjN4ODQwbVpPQVh6OXNtOWtFdFhQbGZpSVpjaWRl?= =?utf-8?B?WmEvTjVLSE04NmR4d094US9TQzhScTFtQk9jdjRTeHd4RW9mSUI3ZmRYcHFp?= =?utf-8?B?MTRSbGdSWXBDQ3ZPUXVnQTNpakswbFRVb3lXSXNSM2VJWTh5ODZyQTQ0NE9O?= =?utf-8?B?RzhoYzZ2Ky91RHB5NHdEMnhBUzNBZElVZFlmNnBNb1pHWDdCTGIxM1hWMzJT?= =?utf-8?B?UWI4SkUzMmQ2UE1LQ0UyZ3g0U3FxYjJGamtac3VJU2Y4MTNsR3VCa2pMVjZv?= =?utf-8?B?QXNJNFZEbzNHcU9zRmdXeFJFTFYxRG1BTVdwM0M2ZldkUEcrTkdWeDAvMEtu?= =?utf-8?B?WkJ5WUxRemJ3UTlIeURRRCtVRHpCVzM4YnlhM3NvR2xiVklDZW9CZDVicDQ1?= =?utf-8?B?Uk1vd0ZLMXF0aFdmTkF4RG1EUVlwVWczakdxbG1LQ2IxK3lHTk1YK1d2VWQ5?= =?utf-8?B?QnJUcDBsbjM5NEhWK1dseTA0VEZ3MytPSVlyMVM1MjFHQXhDRzlIdklkZnB0?= =?utf-8?B?V1J1ZkREOHdaQ0JLaXhUeU82a1lTODdieTJPV3N2UXN5TThLRjU1L2x2Vmdh?= =?utf-8?B?d0pmRnVsNkxxS3N1Sk1hVnpZcHBsK3dSZWFSaHBINEo1T3VCNDdYZGpQWTVG?= =?utf-8?B?Nm9yblRRM2dhT2hsN2VxQ21sRTdFb2tpdDNnQlNUZk9RTEhrWnprR2NmWVJV?= =?utf-8?B?Q1NkdFNQWWRhbUlOaWRvZVl5NjdmK2lTdVNwUXh1WFlkZzJTWVI3VVQyR1dy?= =?utf-8?B?WDNRa0xvYkNUbFdlczZXcWFDNGd1bkxFeGhxeTM0U1RxZ1lxUENFVCt0U2t5?= =?utf-8?B?TUN3a05MNFduT0xwRzVjR3JZN1dyNjJMNkNnWWZ5R1BlZFJUcUs5VGx5cHdp?= =?utf-8?B?UVFRcHA1R3ZLZ2JWSFRTdUtvekMvckg4RXAzTU9kYmVTMTlnekN4QlNGM2lL?= =?utf-8?B?b3JXNXBiTDZTT1plV0J0QWNaN3FqY0ZtWTdqNFhlZnJiZkYwcXJtbTNPSUQ0?= =?utf-8?B?Znc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5735ad91-0d68-42ba-1408-08dbad1c209a X-MS-Exchange-CrossTenant-AuthSource: CY8PR11MB7290.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Sep 2023 07:54:12.3288 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JEKsH/pBkDJqWCLkKrQT3eZx0j8iyYDZUhskpz/0sYkPXdpv1o4uAMChKd2q/TzE3VXtsvkzc3IWHLeUuOMSHiorQgOqnF/QL8x+Wf+S6IM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5815 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Sep 04, 2023 at 02:30:32AM +0100, Zhang, Qi Z wrote: > > > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Monday, September 4, 2023 9:15 AM > > To: Bruce Richardson ; dev@dpdk.org > > Cc: Richardson, Bruce ; Wu, Jingjing > > ; stable@dpdk.org > > Subject: RE: [PATCH v2 3/4] net/iavf: fix restart of Rx queue on reconfigure > > > > > > > > > -----Original Message----- > > > From: Bruce Richardson > > > Sent: Thursday, August 31, 2023 8:34 PM > > > To: dev@dpdk.org > > > Cc: Richardson, Bruce ; Wu, Jingjing > > > ; stable@dpdk.org > > > Subject: [PATCH v2 3/4] net/iavf: fix restart of Rx queue on > > > reconfigure > > > > > > After reconfiguring an RX queue the mbuf_initializer value was not > > > being correctly set. Fix this by calling the appropriate function if > > > vector processing is enabled. This mirrors the behaviour by the i40e driver. > > > > > > Fixes: 319c421f3890 ("net/avf: enable SSE Rx Tx") > > > Cc: jingjing.wu@intel.com > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Bruce Richardson > > > --- > > > drivers/net/iavf/iavf_rxtx.c | 7 +++++++ > > > 1 file changed, 7 insertions(+) > > > > > > diff --git a/drivers/net/iavf/iavf_rxtx.c > > > b/drivers/net/iavf/iavf_rxtx.c index > > > f7df4665d1..797cdda4b2 100644 > > > --- a/drivers/net/iavf/iavf_rxtx.c > > > +++ b/drivers/net/iavf/iavf_rxtx.c > > > @@ -755,6 +755,13 @@ iavf_dev_rx_queue_setup(struct rte_eth_dev *dev, > > > uint16_t queue_idx, > > > if (check_rx_vec_allow(rxq) == false) > > > ad->rx_vec_allowed = false; > > > > > > +#if defined RTE_ARCH_X86 || defined RTE_ARCH_ARM > > > + /* check vector conflict */ > > > + if (ad->rx_vec_allowed && iavf_rxq_vec_setup(rxq)) { > > > + PMD_DRV_LOG(ERR, "Failed vector rx setup."); > > > + return -EINVAL; > > > + } > > > +#endif > > > > Bruce: > > > > May I know more details about how to reproduce this issue? > > As the iavf PMD does not support > > RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP (i40e does) > > OK, not sure if the patch 4/4 answered my question 😊 > > should I squash patch 3, 4 into one? , for my understanding patch 3 doesn't appear to be a bug fix unless we announce RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP. > You may have a point. I was experimenting with queue reconfiguration which is where I hit this issue. However, even without queue reconfig support, the device still needs to support queue-stop followed by queue-start, I think, and there may still be an issue there - I'll have to check. /Bruce