From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65FD6424EF; Mon, 4 Sep 2023 12:21:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5A2CF402BC; Mon, 4 Sep 2023 12:21:15 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 42239400EF; Mon, 4 Sep 2023 12:21:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693822872; x=1725358872; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=WDlSpIcm4dOKSwpcIQ7GUPRQtggVfWMo87iK8DIqsBA=; b=EXvfXyZBXHnbzR9zbFvrimhijNG7hzDBP/j1kk3e/X037Iw0tn+6XudH yRPAuyT3TD4wkcYJaPDI/34ujew7qf+DRYV5vYWibw2qBG02vqL5of2W7 a81w9mq0FudSVMzfbKohsiGYwmt8ztGThVMcQE7LcPci+UgIMAtAmmlS7 +7U6DbWvSdXlnKWjfEE5vymVne66aLu/fOyb4k9NIc9QbS9Xqj8WYD0Vh 4kk/cj6b+LDiet2vFLUlL53tRUMeIjFoWz1+PKNuoYSR0k9y/1qmzT+v2 fWf6dAZqa9mluNTVtzVUHKfAd8CHcrsAFPdO4IhxmUPhHAP8jDEbKojG1 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10822"; a="442964594" X-IronPort-AV: E=Sophos;i="6.02,226,1688454000"; d="scan'208";a="442964594" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2023 03:21:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10822"; a="914465199" X-IronPort-AV: E=Sophos;i="6.02,226,1688454000"; d="scan'208";a="914465199" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 04 Sep 2023 03:21:11 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 4 Sep 2023 03:21:10 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 4 Sep 2023 03:21:10 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 4 Sep 2023 03:21:10 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.170) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Mon, 4 Sep 2023 03:21:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K6kWlN97sbZ5t7uQ1YcHBHns4W0HuZF1wgDrB+ytpU42m318AMeUXME6udV4IMM7IOO9n9JZHIiYpjKYHPAHF7JocRvbDTVkdSslMSTeeBi7tT7ofZVYqLsnkMMhzp0cYfcajhVxqyv4YStMA5NuRGqwcNAjAL62unWlvHbXY4FFM9WVQckl0eeWF8KBum+ywIyAGusMFs+Dp62Ag2/xw0THUQhjemjJzmtUsm9uWoYKSliMNV7siV1wszGJ/CtfwKbHGjkLEfDoHq0DKRvpoVjIbBkkdMp0oasvvFMiK2fZJoiRf9K0hPNn6FNjRfvkV4d/86/4RRSo7AqxXLiRsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kyJjyf9tJI4rhMRmHtOWv5DUXZy6E0p1mqpHzQEbOSk=; b=M8863NO+jn2HSKLDaIPh0OaYdzcwZB7wkC3hHn59Ok9OI6axalBGzVx7h+Jg0FL8kxmWPYhfdqFmyWYEigX4CKCkNsA+buoezRlh6Y+7fap6SfV3ExSNlHPhsZ/8PknjZclyQB1m2h42M6ETrgWZN4HeGScV0CyHc8KfHBXfyk4mcBq//Fw1K3lIyYflUtwDUnoudEx4bPA0dI+mCgWCVIc4YZ0IzVmCtVneVXawaO7OjUGWKuRWKbTbVsQ57ekS5B45CiZTTZ157IPcOhlSp6gmVoIVBkfs8ut4o+xRzgS8Aew61mMdf9M8g9kJoGLbZq9IXSnKl3dyZV2zflYa0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CH3PR11MB7868.namprd11.prod.outlook.com (2603:10b6:610:12e::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.30; Mon, 4 Sep 2023 10:21:08 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347%5]) with mapi id 15.20.6745.030; Mon, 4 Sep 2023 10:21:08 +0000 Date: Mon, 4 Sep 2023 11:20:59 +0100 From: Bruce Richardson To: Ferruh Yigit CC: Konstantin Ananyev , Stephen Hemminger , "Varghese, Vipin" , "thomas@monjalon.net" , "dev@dpdk.org" , "techboard@dpdk.org" , Morten =?iso-8859-1?Q?Br=F8rup?= Subject: Re: [PATCH] usertools: suggest use of hwloc for new cpu Message-ID: References: <20230812005720.997-1-vipin.varghese@amd.com> <20230812080025.7626a94d@hermes.local> <20230813085201.719e7a73@hermes.local> <40e74786-5854-37c2-7f52-1e5d43996b5d@amd.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <40e74786-5854-37c2-7f52-1e5d43996b5d@amd.com> X-ClientProxiedBy: DU2PR04CA0212.eurprd04.prod.outlook.com (2603:10a6:10:2b1::7) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CH3PR11MB7868:EE_ X-MS-Office365-Filtering-Correlation-Id: e0682f5b-5405-4257-f131-08dbad30a760 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WECF/HztAmgmgxlKzfp7Xc42BxEFCcTunucRGKy3Jm4VWQbvK7ex4Zzf3gnP8seybOX7faREFoPHJs9IksXbMyvErCdTCzahN1mRvOTSqa7mjZj6+UhRj5+SyuyDtUFLejDQbDUsNfi3sLDzWIdoMLfl/HAIekcbOZu93m6UEvEO7H7ax0GKyAqmm0DWIM8np87Kb9Eg7LEfL7OruKQtK54pvHkOqa5zBmRqNfdKhB2qiQWO9SljBgTA5dlzrbKZq21lYbm87uclOFrzm6vSb6bt2juhn29gTngOorDnUIhkOwTUgTLXWzTUlP7w6CVGokEFng9X1znaF/D2frEwtJbaUr/vGZwmkfPBR4A/2XqV/xNAGMjlV+GEoYzA+hGP21/P2Kgb62mTAfeiAG6eFKwBzClbGEc+tXseZ2Ol/FaPMLnSjFnKoFEWr+lD7UdcsTqZ5S4ybnNiuEyLPw4LgOYv/HVvaL7+RpoZMPAS0c+rpP4XCiPYdOWNwu9loMk1BJ5l+cBL0VXZu/wauVS0eJhKrwlDnI85pS2sd4k0xBw36wpc1OfyBc3R0YAyI6zrHsMilzDUmADRbFEr4ghCgxr5VmOUkOLaG3zz989L80k= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(366004)(136003)(396003)(39860400002)(376002)(1800799009)(451199024)(186009)(8676002)(44832011)(5660300002)(66556008)(6916009)(316002)(66946007)(54906003)(2906002)(66476007)(8936002)(4326008)(66899024)(41300700001)(53546011)(6486002)(6506007)(26005)(6512007)(38100700002)(6666004)(478600001)(82960400001)(83380400001)(86362001)(67856001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sXCGJBpdP4pEjnNKb4At/c7wPY83kCk5z1IxCbDVH51vVFAZnDxkkR+eM7Yh?= =?us-ascii?Q?j8dlta0uxfxLMd4EIWYagEeHpEfgdfNeEo+QbjaDynO2ugycsBbNVW4bvuzK?= =?us-ascii?Q?CYYpQQbbwe7n73vRBM5LL0lXn6nK4nrbn/X6Pzv4GpTbO2BwoRy1kMJlye3W?= =?us-ascii?Q?z9Mnbk3Rho1N7XXz1TjRD8FWPxPEhMyt62IJkR4vO671aBjgITeEN4pJ1pzZ?= =?us-ascii?Q?eZcVl55KmYmca/PmAyLvdOA3nsTy6wAoLUXYB10+cVDFnCrEa5o/6Zf2Uwyz?= =?us-ascii?Q?wmrnmYip5gDAyL9N+rXT1jD7vBO1kz+XXSBIaZsd+0OyQXzD+Gr9jgmW5MmR?= =?us-ascii?Q?knmbDibr7f6KDhjvRpGBJZNqBBw571k0fw3vUJUohdLZ9qfgnIY07llkk94N?= =?us-ascii?Q?q+Qe7FyS4B/q7xSRXebe35FzwxfHiCO9lV1nhUPWC5/VcyYB79FCRCIzpk2L?= =?us-ascii?Q?ucnpsdVHfu94EOXEjen5sFt5jZIeKULsOLYE6Tsb2WfGiqj8d+mayW1iqpkH?= =?us-ascii?Q?ZUOZyjBaVRLXbld/IafX5CoEh8r5WHkk171lVVCxF2TtHT+yW2ltvc8NXxOi?= =?us-ascii?Q?tZJKd6pEvWdFiu0evx3vfPoLDTdY4rkgcdTmHQjxZTniP1drqE5HjyX7bk4+?= =?us-ascii?Q?LiZ5BUR2KDGZ0sp1uP+MEMj+Fibh+ps3rofDKTK5tsePY9w7LJczsMzXi7A7?= =?us-ascii?Q?mzS27lAS8l/BwMCbSXTDbBXuNCisrrKn43zTi39dmyeDSX4SmKCEMDM7Re7h?= =?us-ascii?Q?2HdbBGWa0cUXA0QwqaA7GFuulK2XyWY0/YMywJeE3w2fXMRho+ne6k7KsGUI?= =?us-ascii?Q?r29nxGaIKpiJHj7DJYdEpfKrwcEl1LI+jlrK1Ss8mySJuo+ypUM/km1f73xE?= =?us-ascii?Q?NP2xN2Y1aZo3ANKun3U7AQlyK2AranymIsD+Vn8g2hTUapCCskE2w+AXp0RA?= =?us-ascii?Q?nCxnke/ikGTsbIyOQB5oI7q6jAjDEft7bzsCMGRzzaQiafMUcarGO06I8wCf?= =?us-ascii?Q?7vHPb92RRr7VqLzw3/Qi3GFIkIOmU593Xl0wRLUua/XwyNpz7q29sahIYFAL?= =?us-ascii?Q?tSR4gDvyzvLA0rPonwWWXczUYE8vB0JywOV9KxtaEtPV9EqcPJKTgQb4MooE?= =?us-ascii?Q?zeqHj6qBsfRNKb54l/Zlqhn9KV1hU6O3ZZZFef38vtNBei8p8RkhGygQTREX?= =?us-ascii?Q?FtKooiCXI4JpINr3fnZ/+oxlMLq0InGLgHe9zI3ykpqVEM6U/zxV7WvtgFYl?= =?us-ascii?Q?F9kouzbATNYPfXGJI+7VmOA/NWu6NNNhJ61PR22pYacT5xs3UxtJKSUDs1sH?= =?us-ascii?Q?n+rx6ZW0ym4JuJhE5j7eiWAo+LzyC1j6LKGseLfts+N5Q0VzOL/nw8+M0zmj?= =?us-ascii?Q?vJ6vjbtrP4VWitXCXq8h7kO+vJ4rfFm7gXzcVye5xUJ9tL1Bk9sNmB7obNYN?= =?us-ascii?Q?p/Rv25roRpzw3slJ2jCIziDCv57Xu03AusZRRHIgZ1aYk49WiRNNW7jzzUuA?= =?us-ascii?Q?AKFJO8gzqT1PcoM3MzKDlLUYCEg8CtWCHWOVBb1apsTWfu6CUFXNPb4YoYjm?= =?us-ascii?Q?1K+2AsRVWPWglteidJd3/1+84NGNJqw8ViQuLpmMt21AD7F5D/sb+45Iif51?= =?us-ascii?Q?yw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: e0682f5b-5405-4257-f131-08dbad30a760 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Sep 2023 10:21:08.3373 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g5h5S+r6ymwwsKrQ1VZchcvDqC2QidAiDBWiQdPPebv22coOx9pgQO2GRg5X2rWBsDinnX3yzsAYN0MMzaMyUEKxUxd8FU9+65TwAy38J4c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7868 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Sep 04, 2023 at 11:11:20AM +0100, Ferruh Yigit wrote: > On 8/14/2023 10:25 AM, Konstantin Ananyev wrote: > > > >> On Sun, Aug 13, 2023 at 08:52:01AM -0700, Stephen Hemminger wrote: > >>> On Sun, 13 Aug 2023 02:12:03 +0000 > >>> "Varghese, Vipin" wrote: > >>> > >>>>> > >>>>> On Sat, 12 Aug 2023 06:27:20 +0530 > >>>>> Vipin Varghese wrote: > >>>>> > >>>>>> Most modern processor now supports numa by partitioning NUMA based on > >>>>>> CPU-IO & Last Level Cache within the same socket. > >>>>>> As per the discussion in mailing list, suggesting the make use of > >>>>>> hw-loc for such scenarios. > >>>>>> > >>>>>> Signed-off-by: Vipin Varghese > >>>>> > >>>>> NAK, no scripting hwloc, it is ugly and creates a dependency that is not listed > >>>>> in DPDK packaging. > >>>> > >>>> There is no calls to hwloc within in thescript. Hence not clear what does ` NAK, no scripting hwloc it is ugly and creates a > >> dependency that is not listed in DPDK packaging.`. > >>>> > >>>> Requesting to cross check why NAK is shared for `print` as suggestion. Hence, I have disagree to this. > >>> > >>> Sorry, I misinterpreted what the print's were doing. > >>> Better off not to list exact flags, the lstopo may change and user may want different > >>> format anyway. > >>> > >>> How about something like this? > >>> > >>> > >>> doc/guides/rel_notes/deprecation.rst | 5 +++++ > >>> usertools/cpu_layout.py | 5 +++++ > >>> 2 files changed, 10 insertions(+) > >>> > >>> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > >>> index 317875c5054b..25a116900dfb 100644 > >>> --- a/doc/guides/rel_notes/deprecation.rst > >>> +++ b/doc/guides/rel_notes/deprecation.rst > >>> @@ -185,3 +185,8 @@ Deprecation Notices > >>> will be deprecated and subsequently removed in DPDK 24.11 release. > >>> Before this, the new port library API (functions rte_swx_port_*) > >>> will gradually transition from experimental to stable status. > >>> + > >>> +* cpulayout: The CPU layout script is unable to deal with all the possible > >>> + complexities of modern CPU topology. Other existing tools offer more > >>> + features and do a better job with keeping up with innovations. > >>> + Therefore it will be deprecated and removed in a future release. > >> > >> Does the script really do that bad a job? While I can understand us looking > >> to recommend alternatives, I actually find the script in it's current form > >> really handy - much more so than working out the exact flags for lstopo > >> etc. Since it's not a large maintenance burden, I'd request we keep it > >> around - while still recommending lstopo to users. > > > > +1 > > I do use it on regular basis. > > It would be a pity if it will be gone. > > > > I also use it time to time and find it useful. > > But it is not accurate/correct for some AMD platforms (for various NPS > (Nodes per Socket) values). > So either it needs to be updated/improved or replaced. > > Vipin sent a patch [1] to update it but it is question how much of this > logic belongs to DPDK, or should we rely on external tools dedicated for > this purpose. > I'd like to suggest that we take a slightly ambiguous position on this script. Specifically: I think we should "recommend" but not "rely on" external tools for this. Specifically, I think that recommending use of hwloc is the best thing to do as it's better maintained and packaged for windows. However, for quick use in many situations, cpu_layout does the job as well or better in terms of simplicity of use and output. /Bruce