From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: <dev@dpdk.org>, <ferruh.yigit@amd.com>, <thomas@monjalon.net>,
<konstantin.v.ananyev@yandex.ru>, <ruifeng.wang@arm.com>,
<zhoumin@loongson.cn>, <drc@linux.vnet.ibm.com>,
<kda@semihalf.com>, <roretzla@linux.microsoft.com>
Subject: Re: [PATCH 1/2] eal: introduce x86 processor identification
Date: Fri, 22 Sep 2023 11:38:38 +0100 [thread overview]
Message-ID: <ZQ1urgJWU7Rs4614@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20230922093722.2057688-2-david.marchand@redhat.com>
On Fri, Sep 22, 2023 at 11:37:20AM +0200, David Marchand wrote:
> In some really specific cases, it may be needed to get a detailed
> information on the processor running a DPDK application for drivers to
> achieve better performance, or for matters that concern only them.
>
> Those information are highly arch-specific and require a specific API.
>
> Introduce a set of functions to get brand, family and model of a x86
> processor.
> Those functions do not make sense on other arches and a
> driver must first check rte_cpu_is_x86() before anything else.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Couple of thoughts, having had a few minutes to process this.
* Rather than rte_cpu_is_x86() API, we could go a general API called
rte_cpu_arch() which returns either a string, or an enum value. Within
that, rather than #ifdefs, the actual return value could just be a define
placed by meson in the rte_build_config.h file. The list of families
according to meson are [1] - we'd just need to merge the 32 and 64-bit
variants into one in the meson file.
* Similarly rather than having is_intel or is_amd functions, we could
generalize to a "manufacturer" API, which could be applicable for other
architectures too.
/Bruce
[1] https://mesonbuild.com/Reference-tables.html#cpu-families
next prev parent reply other threads:[~2023-09-22 10:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 9:37 [PATCH 0/2] Introduce x86 specific identification API David Marchand
2023-09-22 9:37 ` [PATCH 1/2] eal: introduce x86 processor identification David Marchand
2023-09-22 9:46 ` Bruce Richardson
2023-09-25 9:42 ` David Marchand
2023-09-22 10:38 ` Bruce Richardson [this message]
2023-09-22 10:55 ` Bruce Richardson
2023-09-25 9:46 ` David Marchand
2023-09-25 10:16 ` Bruce Richardson
2023-09-25 10:52 ` Morten Brørup
2023-09-22 9:37 ` [PATCH 2/2] common/mlx5: use EAL " David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQ1urgJWU7Rs4614@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=ferruh.yigit@amd.com \
--cc=kda@semihalf.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=roretzla@linux.microsoft.com \
--cc=ruifeng.wang@arm.com \
--cc=thomas@monjalon.net \
--cc=zhoumin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).