From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0AE642612; Fri, 22 Sep 2023 12:40:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 479C940265; Fri, 22 Sep 2023 12:40:09 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 8D4EF40150 for ; Fri, 22 Sep 2023 12:40:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695379207; x=1726915207; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=EaX3yPXJeMbTVhuvMVlNgELkmy50SYPqzcpjPZhwfG8=; b=VEs+FSaJ6bPn7M15PsbrIEtaEb9mZII4WYb2aY8f9Fr+G9IcEXI5LmiA /SEZXju2OGsBfXkgs4VqouLx2jZTPOdiP0BfIaq+PUecrScUY4yIgR7Sj gUUcawp3q1oHtCSdfZNG7ht+h20ykUdI+hwitqeHkDGIMQKC2BCBj0KQB uKAm8Q1UO9b0gG02vyyPtVbgEPVHdtp0ms7kA7V2r8RKHho3yB7PMVSQA XdBJdJuVW1oMt9bkec/wPZJlrResRjBMPb1m/fbatTmDpmFQt8pR18deJ j5dqjna8ZHJ8R2GjKd4SYs2hpc/7ict9l+NOCHOzM+s7FGN0I2RT6lANp g==; X-IronPort-AV: E=McAfee;i="6600,9927,10840"; a="384631671" X-IronPort-AV: E=Sophos;i="6.03,167,1694761200"; d="scan'208";a="384631671" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2023 03:38:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10840"; a="994493858" X-IronPort-AV: E=Sophos;i="6.03,167,1694761200"; d="scan'208";a="994493858" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Sep 2023 03:38:50 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Fri, 22 Sep 2023 03:38:49 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Fri, 22 Sep 2023 03:38:49 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Fri, 22 Sep 2023 03:38:49 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.103) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Fri, 22 Sep 2023 03:38:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hKWoSiYPycbrwqwbgIUgUZRjMLo7FGZtH5EpKLqCV7DE8lv6TKO9lryNsjwN20S/QOKxR2L1CvClbJxzcn3jgWknLdD9oF+onZRASAynQAye4xUDRg/AURY69eK6mh2rjG9+oKAC1KMNQU19iKejtgmY7Sv4dE+ixTKc922YYtziEOn5tCRiCDPAnsFUPhaNznZWRTIjfcPyj7Uy6oYzgCwY8cVBRQIp3BtSJknoEamEU0LMrPCDg0JENosgiVtU755ucpNQ7tCjjMbBLqIqevRVmPVMkrbIhQU2WUAjAIrEkHy7m24J86pyL3gwswNN7dV7MqqIKWTdFVfYhjJMMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xyx9MsHZgfTdpfvTr4MVXsZmJncgYvpUS7EknJkeCCI=; b=kW0STUaK8DXnDoAXQSl00JvaB+suVRxa7mNt4AQasERoZHX9LsSwC+EU4+aKOoW1HJAflMZYfFD/wySwbQ2nHRgDbHbTIazjLGJxPl9iXTUjE23PZhx2m0jpOiPe9Qi0UBnkBPEsDT6DKUFJCR2WmQXDCAZXjOlFqmIva6Dmpr/Yp1BvNBQ9VjkRfsRjjlNExMJgRfndOJF11C3FJpzcQBZwwBvSKV48b1FziVA2baryBb1M37ZBrTkHphOJQ0ZuTdxV22EhP2XjKh9pnNZXzAiKZPOzQRbGSUTKrC0Y3oMxuV0af0yNdZxCKqG24jcfCVYi4ayIuQspHCRSXWQ5WA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA3PR11MB8117.namprd11.prod.outlook.com (2603:10b6:806:2f0::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.34; Fri, 22 Sep 2023 10:38:47 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347%5]) with mapi id 15.20.6768.029; Fri, 22 Sep 2023 10:38:47 +0000 Date: Fri, 22 Sep 2023 11:38:38 +0100 From: Bruce Richardson To: David Marchand CC: , , , , , , , , Subject: Re: [PATCH 1/2] eal: introduce x86 processor identification Message-ID: References: <20230922093722.2057688-1-david.marchand@redhat.com> <20230922093722.2057688-2-david.marchand@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230922093722.2057688-2-david.marchand@redhat.com> X-ClientProxiedBy: DB3PR08CA0015.eurprd08.prod.outlook.com (2603:10a6:8::28) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA3PR11MB8117:EE_ X-MS-Office365-Filtering-Correlation-Id: 928e25da-3951-43ab-27db-08dbbb5819c9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MgYEzJKdljriFfdRxWroj6h5juB/B5xehCZmlKfubuxcjc+8nWy8ltra+A3v0GfQ/9ZeyuhYSOQ464olBn2yZ5Jh40puYedSjjjhAGoIFj0LhX3thSiBWuHrIoln64dcO1jIUEPoHwutFr3jY6P6cqq8n+6dHo/fqhWz3iCEjuuqa9xOzZAZzbd438A6VWZnSjPl4WFdKCtmhDL7HT5A9U4FunjshLukEWbJPftuzUHip8Dq3hieLKQgH7ZSHFVGuLsyBSGR4S89WoD1wKlaRAZBMADjls8EeS0YHjwxp1tGnO50qsm017cfmf9UHQO7ggc6tPtkeLefTp284TXRCpTcge4lCAWMeIn5ItnPpvB95Db/9wUjyBbveLKB8oPtK2D1QgvxolNFB05/ViQFYcDh2p14hhATwApfq0vThdet/UABSOh41i6gNIHZqiHdnP2gTZhPzYKGFQGB9U0tCTL3V5xH1NB1p2LO3qtAFB5DT+7vMs51Yg1zPa19p1H1TrVbiP1NvrKEKgAdyiu4X+DAG2yPGZXNyhtFLmndsIg= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(396003)(366004)(136003)(39860400002)(376002)(451199024)(186009)(1800799009)(6512007)(316002)(8936002)(4326008)(8676002)(6916009)(41300700001)(2906002)(44832011)(5660300002)(7416002)(66946007)(66556008)(66476007)(966005)(478600001)(38100700002)(6666004)(6486002)(6506007)(26005)(82960400001)(86362001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yNi6e6voEGKvTEYp5tDZjVTJKtmP0W3c55lLjZyd/ztNk4n22Owaw1l5LVNz?= =?us-ascii?Q?YDpK9xFZKXQ2An9mAi73+yRTfwTxYRuv1/KjeAYm+22Dd0d1Rx77r5jtaBnm?= =?us-ascii?Q?zuv6Shqd36l9c8khhZplA/znS6ncWjunJeMUZ2u3wI3GqtVhBYZ7w/Ii2dF7?= =?us-ascii?Q?htBBqoju8NQxdoKEU0iBPEfBhBaWA8kqPY8bTRCh2dCZ7ZhugImMmdH1nV2q?= =?us-ascii?Q?nuaXcn70pIJBw4RvVKKWFJe1ljnWEI6wNS6DWixqp48FZqkZ6Wve1jYpV8T6?= =?us-ascii?Q?q5VCr/IZev2knxPFzx7Ren3uu9U4sf0zs160YSEh/GcGuAUxKq47j/NWYb9O?= =?us-ascii?Q?g6mUb+zsf9d4GpdmRNqzjulK7Spt6AhM0EVnilAE7WRIpd3YPD9o4tZCtI5R?= =?us-ascii?Q?5ALsi5jm/LJcELP6ggyp1Wtp6FsWiKsXmm2eenJqtbOfYu4+KvpQH1wS7cUy?= =?us-ascii?Q?kvpKn/lHYHbVhB6pC++tj48Msgcjgdt24bTZD3m5feGT7fn/ZDSd6if83ybi?= =?us-ascii?Q?BttQzDKj4ScvcnFZE7Aus5tQrz/f6UZ2qsASovYc+G6Zy8Xnr505F9NDTLmV?= =?us-ascii?Q?MqWarqcbMkfFWBKBJY2MFRkjcrMukRmAFT4HTod02LYvLPyCdAPRNq45/Ayt?= =?us-ascii?Q?1E1lUbaT4prjvP+RJTiXx7gnVKxUJw2nJ1IAOaoI3dnUqyH21gxB/yIDZcln?= =?us-ascii?Q?jF1bixkFQ2532medsiYZ2uSrHhRQ47HqOykkjnfZtRpJMgcGrcETIQwIZlqI?= =?us-ascii?Q?1qQKvz1a6e+pUwzm9XsqKP8SUVTUu+5f2LT4vQpum4LtVySLnpLeRaoJzts2?= =?us-ascii?Q?I4u/hBPO1n+fzOm4QPulQUuPs5/pKH/ugxytafayNepgZADLvFsc7W3aNpXf?= =?us-ascii?Q?vvoJbqAM8r2gnYlnhcvrpTF5481pkfNfjsIGqw4vNKJlkqV6xYrUJ7BJdCjs?= =?us-ascii?Q?5sp/l9FJaatthwKakWIiPv/a2DgLHNCOJ7nEXDYj6DsaozaSi6zRjONq7Tsk?= =?us-ascii?Q?YZHPjxs0bAayITm6D4CNSBNK/Za+l4E9t4xLV3clqdrJ0U9r5cNfTD90CROY?= =?us-ascii?Q?mNS8qZsTXQaiEB5edneITmVn92sen0H+VEmBh2GJQ8WW5U7oGGR6wrQq0UFZ?= =?us-ascii?Q?uFrh+jahvKPobgM6vQHyvyUBJ6JE+QMQxHB/VrAvsRWSRp4amSDEyM5YIRv1?= =?us-ascii?Q?DGPuQAGh5p7VlVTWww3dt7pQ6TGkv9/Swf3IYqhd5nzoSQ9tJGKiRXuo+Mfv?= =?us-ascii?Q?6X6fbA5iSHx8F/lfJSJyECzLI2rFh+hJEhYMbclQdyLUQfEsg7EyU1p2ZhSC?= =?us-ascii?Q?lzy7HExjTUxOrfMSFFUexWo16yuoDIGGA9zaKrznB1LROLN3vD0CgLLtR+Q9?= =?us-ascii?Q?o5L7IYx5bp/Yl1oI/E7IdsBgJQlv6KCJR/F3XaetLyvgyKYyrrmrc1XtNQsE?= =?us-ascii?Q?Xt/YTqSUcPNYc/RXRYthz8TCbzAMUnlQ6D6wtZSJwzhtxAKZQ/6RVyvJXKp7?= =?us-ascii?Q?F2XXLspqOSRvelQYHMCDGb1OvJxi4QnfM0zhAkUEDMM4F47aazF0EclmXemJ?= =?us-ascii?Q?Gijxj1QPif1DzFFJVpx6ffNYgq4VYn6+/ZPpnBDulPLc09Y8J3VwjiK6Yi3N?= =?us-ascii?Q?Hw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 928e25da-3951-43ab-27db-08dbbb5819c9 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2023 10:38:46.9364 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: n/jz0xGQAR2mRsmO/71K3J23NBKgWI/0Vz9/RYbNwKwo9IznVLN2dQh5Wr5CPLqwZTPhoO3Sqsr3f1mONXAkNLHMpWacnaf/BUVa2WWWXNY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB8117 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Sep 22, 2023 at 11:37:20AM +0200, David Marchand wrote: > In some really specific cases, it may be needed to get a detailed > information on the processor running a DPDK application for drivers to > achieve better performance, or for matters that concern only them. > > Those information are highly arch-specific and require a specific API. > > Introduce a set of functions to get brand, family and model of a x86 > processor. > Those functions do not make sense on other arches and a > driver must first check rte_cpu_is_x86() before anything else. > > Signed-off-by: David Marchand > --- Couple of thoughts, having had a few minutes to process this. * Rather than rte_cpu_is_x86() API, we could go a general API called rte_cpu_arch() which returns either a string, or an enum value. Within that, rather than #ifdefs, the actual return value could just be a define placed by meson in the rte_build_config.h file. The list of families according to meson are [1] - we'd just need to merge the 32 and 64-bit variants into one in the meson file. * Similarly rather than having is_intel or is_amd functions, we could generalize to a "manufacturer" API, which could be applicable for other architectures too. /Bruce [1] https://mesonbuild.com/Reference-tables.html#cpu-families