From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 25251425FC; Tue, 19 Sep 2023 10:12:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B699C4028B; Tue, 19 Sep 2023 10:12:26 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 3B6404027E for ; Tue, 19 Sep 2023 10:12:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695111144; x=1726647144; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=J0MOAiRhvJGCu0t15xFBr/iaVSygIPxywO8+5bTKZZg=; b=k4N79NyuPlbh7AK69aOy3OtR9dnUAJ3bQPe/O3+RRNmn40aZv/0kIXxv /GpCYPfdC2P9SXZOP1I5VLoke/E0+OeF2bZqEvPR/X7qG63cgN2M1M+CV E7c3X/fit9zQfXXDpnEFwf3jVPhL0OmgzRVUfR5Ow+SZfO2BNInj9WQWb 7zPgxznx77um9mXsuhDJAYbIxKJumUahGMOdmfshTVywon6dQGkWkZ9zo v3I+oA9Zop6FTHI5BRoywM9MnUadDJy0hPMCZ13TvdLls1AUzVPRDueuE pFzqkUEeVBbw+pLmpaHa5S1Iu+Zw9qm7qlQKJfJAH3uz63RpYC43KI9e9 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10837"; a="446356403" X-IronPort-AV: E=Sophos;i="6.02,159,1688454000"; d="scan'208";a="446356403" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2023 01:12:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10837"; a="722775257" X-IronPort-AV: E=Sophos;i="6.02,159,1688454000"; d="scan'208";a="722775257" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga006.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 19 Sep 2023 01:12:22 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 19 Sep 2023 01:12:22 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 19 Sep 2023 01:12:22 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Tue, 19 Sep 2023 01:12:22 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Tue, 19 Sep 2023 01:12:21 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UijXk83IXtWDtKYdrP1Ntf3MeuJhBp1U/3ShfmTY7zBjBHxe/pIKeccTAOqsbSLpyy+ROgCmSqx5pqv2EdWY2IKx/xbk36I1ZHBjLpdOl9ysAxr2URxAnP5ORPqwooYgyf5iTzR1oy8iu8Wn38YWXmPw3sNS8EpT9weFSfZvaKiNosPW3g+yQvP+fHEUEl5IL2NVipEszDBD0qLmCdJwhhgMjhbvL9rwG+UxhdqDdiM92nT54btNJUc3bXw32qhbFiobNs+WLJrAaJ8jOgGXQljfUlhFB+QUEdNHJSit8WVumU4fkfb9Jfd902QajY9et5gMoVqkyjJdr0pHL/McQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U3+qpveQ3hcdmxRAlASMCo10aJfXhoO+a0rrX9lLyTs=; b=TkfYaGMh/ppB/gcGg4XHBiHnWmE4OjqUGqfulcbUiobhIMDVOVuDEIUVwP4ncKql1qmA7WjdoDOuHPwJh4+ZoBkoAri/wGvoEPceVe29ky6Pl0bN7q+vKdAe2LCS1kVz7hCVaK66fusXCp2Z/JONCV55LuD6pTo7FPHVdM6R3Xh8E+XlZIJfwKzVwXmR7UdPqXEpzLlxTsFUOkqX2WYNGW8sLCabATarXwieyIq2OX+JncpnyIlfNxFZAPtLVggST2eIashPGPNG4SbohbfdMEcTRQ/ShmQDOdz6CaT1zM1cSnjw1bWrM7PROON+o6RC3cZuDxIKMixEqlhyQRqhIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CY5PR11MB6413.namprd11.prod.outlook.com (2603:10b6:930:37::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.28; Tue, 19 Sep 2023 08:12:20 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347%5]) with mapi id 15.20.6768.029; Tue, 19 Sep 2023 08:12:20 +0000 Date: Tue, 19 Sep 2023 09:12:13 +0100 From: Bruce Richardson To: Ric Li CC: Subject: Re: [PATCH 1/2] build: fix list_dir_globs failure in MSYS2 Message-ID: References: Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DUZPR01CA0084.eurprd01.prod.exchangelabs.com (2603:10a6:10:46a::11) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CY5PR11MB6413:EE_ X-MS-Office365-Filtering-Correlation-Id: 566d4a8d-a6ed-4926-7182-08dbb8e824dd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cj9R4uayg1ZzFj2t2jOLqhd9NKw3qCPOpsASI+fWYoWrGgLcATm0g+hgnb93SJxRdaV/MB9024fghDOIusEeRHYssYafwZRgEsPtdTMsvhVcb4LrFfgGPikLjNnJ9bLBmMPXVrcFQTtE/fSfGYMG5l+H5unRqKWRsSViXmP9/u2wdOgKkBSXlf1PoHk+iYohg4pXZh01gLzVhxfbnP1u/FS8L+DuU8ormDBzTolrMGLF8BX3mxAlnBZ1/uWYyscs3fRo8X/803O0FyY5AE57R/7kUdbm3V6PAq17u7i5rgdSLeE33iwDYiEcf2nFQx6qj2qLlI/ZI8JqQ1CJYX8xVLk7hdAJ0eKSVi4Fgh9tYjsW2TV4CrVUFrERirpFm1K6MBTocoMgFT+I0tctDJJ9UP1gZQza7ukRyDIQsjnXefw28HT8hKSHhpTGicAau46PQVTDnSWyqdoQSWwhaFY4ylow6bXJoK2JARfifBwipznn4To3qVBH/MEV5qO7sDhswnF+iPKVn3/6dr7lu7PwxPZWOmGSxcjnZcCTXH9bubweJaUCS6zzaFCAh5fetSSJ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(396003)(376002)(39860400002)(136003)(366004)(451199024)(1800799009)(186009)(6486002)(6506007)(6666004)(6512007)(45080400002)(83380400001)(26005)(2906002)(44832011)(66476007)(66556008)(66946007)(316002)(6916009)(8676002)(5660300002)(8936002)(41300700001)(4326008)(82960400001)(38100700002)(86362001)(478600001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hzZqXq0XFUwSsLf9RVtjv0rTMhomc/vWjkhtpXCbuFbNbrT+HZxIUg846mj+?= =?us-ascii?Q?IuiSX3W9LivXNgbmaFIF5IYBpE6lClJnEvFBSKlfOD2YxsnfwatHKSsuhkHg?= =?us-ascii?Q?TL0wRf31OK4TOtohaiSCc+xnWZ2nvAOyzWClGhhLwfSI6X0PGt3pMMaNJYiP?= =?us-ascii?Q?2KfH6V22S+mTfQcAqpqIHgcg3CjRMigHNt0q66slo+IKinmxMPtxzOu/YEGP?= =?us-ascii?Q?NhC1q5ZL0vsIVFdVcqc0tPiOsTv1l0tbypX0thiFabn3mMynMNtZbe2tRO7h?= =?us-ascii?Q?55MxifElHO12koqJVaSdHgBjBgxv86BxqUnB9enAzemm+hhfbY4G/QIaR8Wr?= =?us-ascii?Q?r6+Z5NREikFJeGsBRYTUBZrDmianYgQQU+dDMkLlfuoqWhRGpYLzTouK/75j?= =?us-ascii?Q?IaZH7TJiQqRWhh2U+qm/2hj88STs1VDclKrfFS8UswKrnkgsxtitZcr6dJb3?= =?us-ascii?Q?FOd55/9uCr4LOOzo1XBIm4Gxj0Y7s+8B584KiEt81UyIrq00Sq5rRyk1tYwc?= =?us-ascii?Q?nkrz7BeEIs3aDSNs6BhiiJqqDyp8eLAjY69+OChzYR8GhLfApu3REpDiEjkS?= =?us-ascii?Q?Zs2Sf+e6Vgek9DF3emhJTtRXregldW9qcbW2fN0uTZYr+yNepOlbDVAhu03Q?= =?us-ascii?Q?9K4ycc4UjKE09FQue368bmzp0/YGULBHJT9+yHeVqfuEcCmGcBcodFji4YMW?= =?us-ascii?Q?OAXo3elDQyHRLBkLy1QGSdzosqgptzXwkHxGFnB4gKR8GOfiCSYfFNLf5xXR?= =?us-ascii?Q?7HM9vnMaJi8WRboz5+AvmWPjStkfH0WuGv4lZKSQ0HMlNLWlZfzLzfBDvBeZ?= =?us-ascii?Q?yTrUNs6TmCCKpbpdMN9E22DdTs4ZACc2vKhdqGei9eKWHIgEnNjQ4GMn65er?= =?us-ascii?Q?t1pqzdr1ih0/pS6IzbDHdG+4IMAuv0Rz7R8GjPzBDKk+DDnLMzN8yIl9MaPz?= =?us-ascii?Q?WYWL9jEQv3VIY41+XcaaQ4ISpapK3rP/05OLEpXelmIe3ZfMMC7+aRSjL3sL?= =?us-ascii?Q?QDx++ZmCyBXKgIEUQo66sncKvZGYOk6V4CpQNm09pK/GhY72auuQC67NyTyA?= =?us-ascii?Q?dB7ZyO/YTIB/1JdHdzvs0r8eQSF9d+LO/G0Pycqehk50G/A54UJptMWgLM87?= =?us-ascii?Q?MSI8WYIAuBxjKZvlO4r5icvSjx3eOAmhyY0Wr//v7Nmyv0W233JVNCBuvU1X?= =?us-ascii?Q?qnsCq/j03vdwxrQ0empmHTPnlcci5S3TALx2K71zSdAUrlzgaMzSdyjq9Eu0?= =?us-ascii?Q?VigdZNWucvwk05L90UbklWbCECOj7kecS/PQQw3jDnisRlZE7+OZdGRT9BqF?= =?us-ascii?Q?AwiyR25ab0B41LoJAvp9k8qdGLK+kyQMhEbBhB6nUANhDAqAduKLEPHfGY2O?= =?us-ascii?Q?ngOwOWn6QNvmdYYYzMPGNssVvqK7TA9StMQJ02jNk99VD59qV5F4ZVQ2j+3t?= =?us-ascii?Q?zXhFtXfoUNWHiq5/3x15us2+FyDJkP9l4hmkVAAJm/PQL3SJapxK6qDhQMO3?= =?us-ascii?Q?InsXwyKRTk24c85gAgnHhiGtCxBtvFmyGBmEtgG9vbLSEbIJvnJWtY2VTvqa?= =?us-ascii?Q?L3oISuWWs8IH0elcqYkm/3re4jdzT6Pfl9u4ysTLwJtrpGHL6ojQmxT5KmWm?= =?us-ascii?Q?DQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 566d4a8d-a6ed-4926-7182-08dbb8e824dd X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2023 08:12:19.6007 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cBNsK/pCURSGPLfdzDa5+4bYDb7MbY6oqgAVHjORU798EABG3FJ8P3j3Z+Vnp7HeOmSyCAoo6R2b3KRVp47EieVwylcKHDybNgjqIL1BLj0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6413 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, Sep 16, 2023 at 09:15:19PM +0800, Ric Li wrote: > When running 'meson build' in MSYS2, > "list-dir-globs.py * failed with status 1". > > Signed-off-by: Ric Li > --- > app/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/app/meson.build b/app/meson.build > index e4bf5c531c..73e5138301 100644 > --- a/app/meson.build > +++ b/app/meson.build > @@ -11,7 +11,7 @@ disable_apps = run_command(list_dir_globs, disable_apps, check: true).stdout().s > enable_apps = ',' + get_option('enable_apps') > enable_apps = run_command(list_dir_globs, enable_apps, check: true).stdout().split() > if enable_apps.length() == 0 > - enable_apps = run_command(list_dir_globs, '*', check: true).stdout().split() > + enable_apps = run_command(list_dir_globs, '*/', check: true).stdout().split() > endif > Do we know more about why this particular failure is happening with MSYS2? Can you try running the script manually to see what the specific python error is, and if we can make the script more robust generally? In terms of the fix, I actually think we should not be using a glob here at all. Since we already have the list of apps present in the file, I think that we should move the app list to the top of the file and then change the code to be: if enable_apps.length() == 0 enable_apps = apps endif This sidesteps any issues with globbing, and also makes the code a bit faster as we don't have to shell-out to a python script. /Bruce