From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A1426425FF; Thu, 21 Sep 2023 12:44:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 056DF40E2D; Thu, 21 Sep 2023 12:44:13 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 0BA6040DC9; Thu, 21 Sep 2023 12:44:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695293051; x=1726829051; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=PLztFmswfGegSduNwuDF4eTU5rp/izRsf00t4YQuM0I=; b=hoXcIc7JCWfjuZCG9m1Su3OUf9RgPY4a9c/5WiRVm8Yl9gB/DjmnqHIO CIE3Wi+vzYSf7cSBVIJaAeItExilKcs4TBG2gB34DXRHz3C3d+X14hATH dXlZ6mVEXM1GDieMoNjfDIi4zEVJKpAYzXg7aCp864SNx2jxurML6zqQn KgDebqVctNLmIxBowPfNMEuLBh5PRRfex9+baXSDw2xuVSadENFA12qXW i8mJGmREXpybYGb/9JSbzJoMqPCi7N8sV9oDi/ImBhvMIk7Z/p6A7dY/I S12sg+RjvRlXW+UZjYZ/0Vy0QkWgL7w6s8oH+EPkHqw2RnLBezvITu9gJ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10839"; a="379370320" X-IronPort-AV: E=Sophos;i="6.03,165,1694761200"; d="scan'208";a="379370320" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2023 03:44:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10839"; a="696686770" X-IronPort-AV: E=Sophos;i="6.03,165,1694761200"; d="scan'208";a="696686770" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 21 Sep 2023 03:44:09 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Thu, 21 Sep 2023 03:44:08 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Thu, 21 Sep 2023 03:44:08 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Thu, 21 Sep 2023 03:44:08 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Thu, 21 Sep 2023 03:44:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TSS4UJeIhT0PWt9KuXeeH4NAzeLpscZT7gsHYmihdACMEJwPLvK5Md3mEL6LpJi8tQD/EDKys5j4mWxmzt17ourtGpJI0MPxAyvsikFMfjWAjQ8Azv8/Loxc8VdX7p03ITxXztm1nCBJ445PSGtkY1cD0ZxeykZ3F0pc6floKQXemZycORJAZu8OGOeyuwaJMfxvu1+Ddwf7JUzprF2hgNiOJB/KicqXe+1sH5e501GjTCCcGPLrOPNBh0XLHOwlK4nQMBM/E8JMXVgQfphcXo6ABXx173jz7jsr6hEB+bs3CSGN75WyvrQ/7JwUcwDA2MtfKaWV97lp7QJSisobzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9VNtmOUZy/APG7ZiuliZrEKMt1VbfeOLo5AQ6CnSE3E=; b=FNWvlrx+wb5vEXNavZ7q/ISkGUO1DHs6+Q1/44ZAnZw3/Vv8jGV4ORHEjdh0mIrwcHJ2clgqOcGmsZg+tWQDjRCsA864PXQeH+8Xo2SCnYi35/EMkVqekKI36Ec4JcDx0ZDOdho9cxcdoHMl0mmyXMzzDJ3OPa62FNmGR4zUcQ6n5JmaZX4XxCoCEcrAGR7mHPiBcWJ5v9U/YJlwxQYDWtDv3cHtrOQ0kGxxa2jMzoFKhDEmj7QsRb1Tedgday7Ltngie40aMnrr0myriUb5HFqlJQyn3VhKZqiIzI/temETUndirgL+g18ijOt1oPhGmvhiqwHsO+1p9X3eh2AnGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by BN0PR11MB5710.namprd11.prod.outlook.com (2603:10b6:408:14a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.20; Thu, 21 Sep 2023 10:44:01 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347%5]) with mapi id 15.20.6768.029; Thu, 21 Sep 2023 10:44:01 +0000 Date: Thu, 21 Sep 2023 11:43:52 +0100 From: Bruce Richardson To: Shibin Koikkara Reeny CC: , , , , Subject: Re: [PATCH] net/af_xdp: pass cflags to appropriate build components Message-ID: References: <20230921102923.65738-1-shibin.koikkara.reeny@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230921102923.65738-1-shibin.koikkara.reeny@intel.com> X-ClientProxiedBy: DU2PR04CA0156.eurprd04.prod.outlook.com (2603:10a6:10:2b0::11) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|BN0PR11MB5710:EE_ X-MS-Office365-Filtering-Correlation-Id: c6dd98dc-1e98-457a-bd90-08dbba8faae6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: n9IpyhyBvw6ozhIGSKAXZnVowpe+nW39QNc9SvGF51vawr771HjMtZcgLHIvHc2moNU2DYbTzO0GcZUE3S3bGZcpV07BWuMq5zjT6lZvsttG6EbS17qmLXzSD2LEb+ME+oK8oIWU26iNdK7fKD1xcY70GpH0CrINRRcJJ++XwSLSX70FzKEjFoavU+gzK+UIztPRDWUmsPl1MEcAJvo+Pew89nSomg2z500GG7W9I6Wdi0mTXH1YF1PApNP5BjvkXZ9nyq3s5jQuc82IkXzxf4OcaCqb4WUC/0My382s1sI9BxPFyzHoSlzNYgsU82ytAD683btgvriGFPXER4VeGQiR5zyiH3/w8jKTE5D3I7UFgPHLAsGzgaHC+vl7gobn43/ViYE2eQhcBCVDGob/WnBtkTJ29Ay9uEInBxvXDBLfLz8ob4+MI7RW9+8DYSW3x8A2y9p8opuAA5nEqXHQoBZQ59c89GWV/LJFi7f5gLNXh5EHBgbo0FaHKlQLKK+UXZZKXHDwmBRKStaNMyVOybzlEiNNhbKk+8hHzKWB8XsGL0byxrKGPtO96n2jKZEZ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(396003)(136003)(39860400002)(346002)(366004)(451199024)(186009)(1800799009)(2906002)(44832011)(5660300002)(26005)(316002)(66476007)(41300700001)(66556008)(66946007)(6636002)(478600001)(8936002)(8676002)(6862004)(4326008)(450100002)(6506007)(6666004)(6486002)(6512007)(38100700002)(82960400001)(86362001)(83380400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?g7Dr8N9ohhzlmaMK7L/MnaGMwMidOMgRmFiuE+yiZCz4SFs24wDywOxyfhO/?= =?us-ascii?Q?xgTJrdv7QY+tFTnfON8u899oz4a7q30Q9Ql+rVTl6ARApca+Sny9h+C7PwWr?= =?us-ascii?Q?8uvSVLaY0Dchf+Ai3kLdg/DxKIbmVALfJ6EPxnikfYfOcIZx2MzKINKHtDdu?= =?us-ascii?Q?NuxkDENDomS2SVbwmx5CpHZfAYZHsCzH3FS65KPeiAew/PeC4XavbjABHGUQ?= =?us-ascii?Q?/6nw1d5sll3vElInLv9Unr8HbNid33lnmH4UJJUIY6qlILHG74BbXgKuyVkB?= =?us-ascii?Q?6jxK9pXFeBwk+x3nF7flHKED8uNyKLUDywVoP2Omq4/qFovN9jK6YwfDH/6l?= =?us-ascii?Q?sIkAAzztx5t8MX2GDuKFyYhyjSjFCwyKNPYzgHSmf2CK2PkH7+M7mg/Cjzst?= =?us-ascii?Q?cfnpQyEP7ilekpF1+D4vWck6+MGZTXImw6X4C/ROS0QuZCBFA/PgKf9NXogg?= =?us-ascii?Q?VeNyqhW33oCq9lVFkzPH76R/7hliDbhIORJnWTAekgmvQ6qpVAUJwL9B89xP?= =?us-ascii?Q?igon8MokrN4d++1H2FsQC+LW4u+TRCq3gFVSKmjj5ILCCP2TD4+97ozQmJ+I?= =?us-ascii?Q?gp9bHgFKgr48k/dVjW4F9Wb/HZeiiA0+rIlFQPbPrhMpniT47J3T5ubOahuU?= =?us-ascii?Q?U+WoSkhGwCQhppzXYX55Zm/xP3Zc4cr0g4UUioz4sfHnvxoz1bKxJz03mhme?= =?us-ascii?Q?CAhn2lRYsRM3KtGJ6JpikKO1BN5SNwW4h7DAq1AJoEZyz9JdvB5DsbA61+qz?= =?us-ascii?Q?uZ73sxnTWP0xualozv/UjLp5UHjY9tQsecCl7Clmq7tiYNbR+stIZZS3YdZz?= =?us-ascii?Q?3mw2ur4lnC4AcF9aPihwMZXan7O/KGXcZLweTZ4DTsbl0FiOoHFSl2r98Jpw?= =?us-ascii?Q?XfzqIXz0JNwM1SgOlbiwCmVZINCEF1IqOyCeKPWAO6KWVmi5BqIm1JbDPMOL?= =?us-ascii?Q?Dw6psEf9LRDQJJcuB1slUU9ZN6GzsovlG7dzQTqvW54oDNcDyQ/hAqVceMhU?= =?us-ascii?Q?9JKNTNYVfBPBRI7VLqQ+l7CFFxNCP9GrMHO0KSHw6pQbUQvfyPPwidhGs0Z0?= =?us-ascii?Q?Qx64P9aBj3TgSAaMRquy3/JkbAFETwQBQUIGTB7N+SEXVtbP1SroVz2MrWlm?= =?us-ascii?Q?oY8jX42/0Hwju25QR74OK41kEGpxhzrFM5ZHCcsvej9FlHW99gCR9KvC7TMX?= =?us-ascii?Q?xo3/qzki/quOKk3e+4Z/6ZMd1FhvC9emHCBdxN9yHD3xa5z5hN8fRObT6c1D?= =?us-ascii?Q?v3fulT3U8FGCNNZx1BdI1d+Dl+nEsbVj+2nlf2T7AAEE2GkcGl9yApF0j4jV?= =?us-ascii?Q?l6okIoQMzsxcSZpTaf5RjE1A4KfBLP/7UjcJ2XlWOJ4vHs6leH4qeWSxsSTx?= =?us-ascii?Q?hnwAUbStjm/j3+1vZivgUHKP3z3eLLGrVppt2a+cNLcYU22KLAG5Bu1m7PUB?= =?us-ascii?Q?flc0Nk5b28pjdj+3vAgxpMxEExoT2Duw/haMAUetWwoYdZOLwpIPk8CeykQN?= =?us-ascii?Q?xlSXwjELVoKEAhGkD2WcFNGn9R7QA5LVyh9e3/cc9dnwOri+eSG3/d2ZkNBV?= =?us-ascii?Q?dGj0Qx2pKcwI6iBURWmSf928G98SVQ7f31TH4ZIyO2Js4fH6sGGm/KB3tbPY?= =?us-ascii?Q?yg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: c6dd98dc-1e98-457a-bd90-08dbba8faae6 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2023 10:44:01.5668 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vygSg/AFwFIQB8dBL6T2tmaQbw4rCE7hLWBLFOevyP1+Yl+ckToxF4mzY02TKFiRtq6eFECoZ8yJ135yeC6PfGQ2cw56hGL0Gyg0Sg/QUMM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR11MB5710 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Sep 21, 2023 at 10:29:23AM +0000, Shibin Koikkara Reeny wrote: > Commit 33d66940e9ba ("build: use C11 standard") enforces > the C11 standard so some changes need to be made to the > af_xdp driver meson build to ensure that the appropriate > cflags are passed when checking if certain functions are > available in the libbpf/libxdp libraries. > > Fixes: 33d66940e9ba ("build: use C11 standard") Not sure if that is the correct offending commit, or just the commit that exposes the already-present issue. I'd add the following also to the commit log: Fixes: e024c7e838fc ("net/af_xdp: avoid version-based check for shared UMEM") That fixline would imply a possible backport though, but no issue has been seen on versions of DPDK not using C11, so I think we skip backporting this for now. Putting stable@dpdk.org on CC in case the LTS maintainers have additional input. For the code fix itself: Acked-by: Bruce Richardson > > Signed-off-by: Shibin Koikkara Reeny > --- > drivers/net/af_xdp/meson.build | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/af_xdp/meson.build b/drivers/net/af_xdp/meson.build > index 9a8dbb4d49..3319acca65 100644 > --- a/drivers/net/af_xdp/meson.build > +++ b/drivers/net/af_xdp/meson.build > @@ -56,17 +56,17 @@ if build > ''' > > if cc.has_function('xsk_socket__create_shared', prefix : xsk_check_prefix, > - dependencies : ext_deps) > + dependencies : ext_deps, args: cflags) > cflags += ['-DRTE_NET_AF_XDP_SHARED_UMEM'] > endif > if cc.has_function('bpf_object__next_program', > prefix : '#include ', > - dependencies : bpf_dep) > + dependencies : bpf_dep, args: cflags) > cflags += ['-DRTE_NET_AF_XDP_LIBBPF_OBJ_OPEN'] > endif > if cc.has_function('bpf_xdp_attach', > prefix : '#include ', > - dependencies : bpf_dep) > + dependencies : bpf_dep, args: cflags) > cflags += ['-DRTE_NET_AF_XDP_LIBBPF_XDP_ATTACH'] > endif > endif > -- > 2.25.1 >