From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 633524262C; Mon, 25 Sep 2023 12:16:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 082A2402BF; Mon, 25 Sep 2023 12:16:31 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id AEAC2402B7 for ; Mon, 25 Sep 2023 12:16:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695636989; x=1727172989; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=TgIIGzhc8jcJsckRF+EGyVIfOYA/3uElw/Lk8ZXjW7I=; b=eH5JzM2u0s//RnZnMjy91UrMSsqVVjtWDrS2u7fvcYGAgWYeBxgW8KXD 9NyRuw7Q4pf5WOeyr2Bb0fH1QpSYbFjS6UAnlYwQMtlFTTe3GaopiZEgd n8YdVBRJEEmUtO0qGHyHQeyMKTOkIR/OvF/nLjP0g83kv8A237twMgN65 /pb5nvazJdkcgcT4t3qRZMGvXvM3X6UwhLb52RNEvlufWqKh/7P01ossM BBRJL2veKL3msoixSEUAejAlGUlxbbbwGvCWcLriEP2yha5c+c5idFHqg XlRqRCdgpYE2GBfh7dBwJ99CO6RD/NuRKMl4Z2eaOnsrHcgrBEDsqFMBm g==; X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="412146517" X-IronPort-AV: E=Sophos;i="6.03,174,1694761200"; d="scan'208";a="412146517" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2023 03:16:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="751628188" X-IronPort-AV: E=Sophos;i="6.03,174,1694761200"; d="scan'208";a="751628188" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 25 Sep 2023 03:16:26 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Mon, 25 Sep 2023 03:16:26 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Mon, 25 Sep 2023 03:16:26 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Mon, 25 Sep 2023 03:16:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iBvv7ljXwe6fLQ3PJxKi5jZIGeiyl7CiKkg7qU0525Ir98K29S4zMtA3QmBVKmwDF0Gi1eX5fDPTihwawcNZmgVMQZ/ngwoyaFjqUQc18oUAFFvEtahhYX/ndkiAg+FcGg7t6Y9KdgK1LGN0DSZ/x6VgkXl8GV18khsCfCmCifvmYNs1aDexugKND4N1Mr83IPjojw4xeNVf2sYhJ6aJcFSQlFHWbtrlPwVNGEKPpAbjC6m85/0LRkr5bx8wE2XxknZiEwo6ON3HyW3NVzABvUWv3xCEkG3kavvAajx9pybr6yFelMBTMs6wznCh1TTGMkU46QmDuHOncFw1qBvQQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rtTk3xDeCwR7kZdC42ia+qEu+3bV4p5O6CZK4DBeGsE=; b=DQ9u+zh9okiBrrjfp3fZrfoERqMQIwxbP974ZkR5LsNcuMQg6/TvjX+2nVBlWM3zOu5amZflfJ305dixPA3cYeNe9dKHOSzJmLPF4LebNE681wP4RS1KfxR7DvJsU9MrEQ07ckEj5KmyLisBC2AIAP+04svlpsYeevqUvEA0H8ndw8BXPmmfdnjR5ziUflIr6YdYdNaLzKYyefPR+kGjFxRZ2H5ujPZ+TOqUy278+KcKOSrYeMFGQFbMd7VkRzpeihsvyzuQwbrPPbENSAuR9WusZaL4OKUEPYWzHxd3+ByRCuxopHv8BGM7h/W2alrvfyXibmOqgkND6ZXdaPTfSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA1PR11MB7038.namprd11.prod.outlook.com (2603:10b6:806:2b3::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.28; Mon, 25 Sep 2023 10:16:19 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347%5]) with mapi id 15.20.6768.029; Mon, 25 Sep 2023 10:16:19 +0000 Date: Mon, 25 Sep 2023 11:16:11 +0100 From: Bruce Richardson To: David Marchand CC: , , , , , , , , Subject: Re: [PATCH 1/2] eal: introduce x86 processor identification Message-ID: References: <20230922093722.2057688-1-david.marchand@redhat.com> <20230922093722.2057688-2-david.marchand@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DB7PR03CA0107.eurprd03.prod.outlook.com (2603:10a6:10:72::48) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA1PR11MB7038:EE_ X-MS-Office365-Filtering-Correlation-Id: 87c410ed-beb0-4397-d4ff-08dbbdb075cb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mso6OJtCupwWD2olPdsaj6DduSReKCxlKc9SqkoAKyiH21HUX1Ga0vs+d4wQxNrAGNBtl2rosemAtkQ1fJPfHL1SNnGDHBGyFTVkyrSpxpvUrEFJbfTjEdSEUQDv1WMPvoMUMdPnfbMc+ZHGqZXmdJUd1CGixRv3sCypytYiGuSNRWSInp9oTiXFLr4cHL2SmLWg9iit5av7jO6SKp94x79tvYlVF8KsdXOYlc+nOt9fDyU7/7lgt3Jmk89aBlJG9WIIYA0UEA/msAhr93dFbXkbz0UJQ4a8GlpqWAXGfoOSSfa5Uj12sUGSfxZXMnbxUsQu4VAVHpUOz4/By32dTO7c7nBUvfGj01ajT7TQhntOj2XU1WjXH60Mi7mMzrCWMGRJBR2By1zyVjkiXZ+tPpCGaqeJjmiHeOKfOZFuWCM4zA1zGhNLwRYWRt8ZKOBdmR2p28XhCNdR/OCujEwfLt52dRO9L7MILa6SO7zrv26+14lhTD0dYN8cY+QOfKJLs8d08nuPpzeiYkAKHskL6YRDXkf2LGdenzdqEKNVdTFBOoG3c6XsO2NIiIkOlR/a X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(346002)(136003)(39860400002)(366004)(396003)(230922051799003)(451199024)(1800799009)(186009)(8936002)(4326008)(8676002)(26005)(44832011)(2906002)(478600001)(66476007)(316002)(7416002)(41300700001)(6916009)(66556008)(66946007)(5660300002)(6486002)(6666004)(6506007)(53546011)(6512007)(38100700002)(86362001)(82960400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2hUY2xpNEhIb3ZKZVNjbTR4dXFVOVJ2QWtQSWZheHpac05GeFErMmRSZnZ5?= =?utf-8?B?Z0p4bHdaUFU1ZUVFMldyWlhNNk1zMTlqZG45OWp3T3BUQkRoVEJ3WXZEZzI3?= =?utf-8?B?d0RFc1hlVzArRzUxK3JyaWwwR216OGlRenFqc1RYalRGamROZ1JkSGt1d3I5?= =?utf-8?B?RWdadW9TaXloSHowUDZaaGpWUktRSkV2azVQWlQrMTlEd0JxYzVHN0d6NEsr?= =?utf-8?B?Y3BsYUR0RVRTWUVrdnI4cUxSTDBVcXJ3OTYxYjQ0YUozZlg3aWtpQlNybnMz?= =?utf-8?B?WkxqT2thRTViMUhoaDRVTGkrSmxaNXZPWEhOcDRvbytsV3p5cjV2UXVCL2sz?= =?utf-8?B?K3FDZTN3S2M1WGdmUVN4U0d4ZDlqbCttYmVXNXVFajRxVnYwaUR1cjlzTS8r?= =?utf-8?B?YTkvZGpvcDgxRTZTbklienlNMzA5KzJ0SkZsQ3ozeEtrMUFySUNVWm5ycC9E?= =?utf-8?B?TVM2cEt0Z1NObjlDMTNtbEpldlN3b1hWeEN4WW00QkpnZDd3Z2h5c2Vlbm40?= =?utf-8?B?WnZLQ2JmekozKyswSitPWVV3cFNDcTRCcnVTdWJKK1poSnUyMGFRZnp0Mytr?= =?utf-8?B?MVptSW5Bd3V3ZWRtSUx1R3FCRnVSMWF4Vng0OTJFRDZPVTJuNEhpeHMxbjMx?= =?utf-8?B?dWx4MG9aSzdZRURFRUQwU0ptMjRQd1ZIaFl3WTFibTNQWGVSM3Y2RklNZ0tG?= =?utf-8?B?cU5iNG1XREhQcElOekkzNEJSNDNlN2FuRC9hM2lSNnFnZmlWQUYyYTIwNGJV?= =?utf-8?B?WVNFdWh0cHRnZUkzR1JZZFNJMk1ISlhxblk5UmJRazcyMTFhbVQ2L3VzcFQw?= =?utf-8?B?OWYwcDM2aXdjWlZmVlFWUzIvSVZhM29NTDFWSHNqMmY2aGZnMWY1Y1ViN1My?= =?utf-8?B?cGo2L3QzUDFkNXhFNmV6aTZkZFZLdTdzT2M4QjN4SnZzd1o4R1g2Q3cxRGh5?= =?utf-8?B?WEF3YWl2VWNsZDFSeTVRSWIrWk84cERPNmRXYWE3TmRvaU5vbFRLUDZjMUFj?= =?utf-8?B?emlsZHlVdXJsNTVud2haNmxjaFhqU3VSY3ZPQW11eGhSNm53VTVpYW1FVVFK?= =?utf-8?B?RmJFeURKUURWSThZTTY4VW9GcG5qN052VHZEV09DenJoM0JGUnp4U25malhS?= =?utf-8?B?cjhpcFAvaUZUeDVsMkJzTWFuczFjUVE4S3NKVndoSVVjRTRqUDRDdWdnMEZ6?= =?utf-8?B?cmRSVjljZHlsSzRhYzN5U25XZ2s4TFUyYml3N0VBcUtIdkJqQTU5NWUwTHVp?= =?utf-8?B?VENKVmROU2VoNld3cnlNbFJVRWxGbmExQWJtR29aRTFmTUNtc1lrWjJGNlMr?= =?utf-8?B?WDJIcURzdGxVV1NpaGc2YUdhWllCc1UxdlJmRXBmZW9MVkdhNUFSUEx3ZDV6?= =?utf-8?B?S3E2NVRkdkNtUEhDTkh4UFl3bDB1RitiaExrbXB4NFJ0ZlFSSHQ0Mm5JOUVB?= =?utf-8?B?SHB2YVFUd1ZzR0hMWDg4YTc1a1JHNkI0RGtOZENaMnRKcUJ6MFFJbnNYTHg0?= =?utf-8?B?Q1RhUTVEVTF1UThvWEhnQU0rdGNiTStMYVNsa0drVDI1VlZwalBzNUpoVWlE?= =?utf-8?B?dmdFQjF0MzhSSzFSdEVCWDNONURrYXVDNndDZVZucW9LUkQ2ZlR0RXByU0VC?= =?utf-8?B?L081bndIaW05L0lIUXg2anB6a2xobE5adXIyR1NGdVpjQkpXOEFXaTF0Qk5E?= =?utf-8?B?TlV1cGRXMmtuQnRMT0czckR4OWdPOGVsQjNYUnNzUytQNWFHQW4zcVovSmt0?= =?utf-8?B?WTFHYTJIMXlGZ3djUXQ3bmE5RmR3QTAyWUN0Zkx3R1FIbXhBTFpYU3UzVDlU?= =?utf-8?B?RThxbmpyK3k2Ym5pbWVHRk1JTzg4ZXB3SHJyaDJ6ckg5U0FNNHZCN2M5VFUr?= =?utf-8?B?dG1SSXZrR2VQaHovVzhZNVMyN1c0T1RuWm5TVDhDanVyb0R4aU5HNmRMT0tk?= =?utf-8?B?eUNMVVhyN0hhN3JCc29wa2grUnNqS0NiMTg3SmlHVHZkL2F2WkRGTktqSFZm?= =?utf-8?B?NE5NNy9mOXNnY0pXcllodXN6dXcyMXMrQnk1NEFjdlF0THcwV0xvNFNlbzFn?= =?utf-8?B?TmxyTkxnREc1cUUvWmNaaHMrYnRpb2tqWU1IZ2ZXN3V0bmdYNFJhdG1BZWk2?= =?utf-8?B?ZDZXYk5qVHR0RjhWcWZwd2toUUM2NFNTdUNhdndLQjEreUlJVFhkRHhrZmJ6?= =?utf-8?B?T1E9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 87c410ed-beb0-4397-d4ff-08dbbdb075cb X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2023 10:16:19.3222 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /68b7Hns3xh3U497YG4n3ElHDcOT5HPhaENZjjjJRFKCxmjwTJa8L/yD9o9I44DeYvpdQ5YhWFtVoPLlk4tP9DeukX3if5PmL6kob+mYkMo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB7038 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Sep 25, 2023 at 11:46:00AM +0200, David Marchand wrote: > On Fri, Sep 22, 2023 at 12:40 PM Bruce Richardson > wrote: > > > > On Fri, Sep 22, 2023 at 11:37:20AM +0200, David Marchand wrote: > > > In some really specific cases, it may be needed to get a detailed > > > information on the processor running a DPDK application for drivers to > > > achieve better performance, or for matters that concern only them. > > > > > > Those information are highly arch-specific and require a specific API. > > > > > > Introduce a set of functions to get brand, family and model of a x86 > > > processor. > > > Those functions do not make sense on other arches and a > > > driver must first check rte_cpu_is_x86() before anything else. > > > > > > Signed-off-by: David Marchand > > > --- > > > > Couple of thoughts, having had a few minutes to process this. > > > > * Rather than rte_cpu_is_x86() API, we could go a general API called > > rte_cpu_arch() which returns either a string, or an enum value. Within > > that, rather than #ifdefs, the actual return value could just be a define > > placed by meson in the rte_build_config.h file. The list of families > > according to meson are [1] - we'd just need to merge the 32 and 64-bit > > variants into one in the meson file. > > Your proposal (in next mail) lgtm. > > > > > > * Similarly rather than having is_intel or is_amd functions, we could > > generalize to a "manufacturer" API, which could be applicable for other > > architectures too. > > Like a rte_cpu_x86_manufacturer() ? which returns an enum too I suppose. > I was actually thinking a more general "rte_cpu_manufacturer()" which returns string, and therefore could be implemented by all architectures. Could default to NULL or string "unknown" if not implemented. /Bruce