From: Bruce Richardson <bruce.richardson@intel.com>
To: Shiyang He <shiyangx.he@intel.com>
Cc: <dev@dpdk.org>, <yidingx.zhou@intel.com>,
Liang-Min Larry Wang <liang-min.wang@intel.com>,
Simei Su <simei.su@intel.com>, Wenjun Wu <wenjun1.wu@intel.com>,
Yuying Zhang <Yuying.Zhang@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
Qiming Yang <qiming.yang@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>
Subject: Re: [PATCH v3] net/iavf: add devargs to enable vf auto-reset
Date: Tue, 26 Sep 2023 08:48:36 +0100 [thread overview]
Message-ID: <ZRKM1LE/8cldlDC3@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20230915130249.425790-1-shiyangx.he@intel.com>
On Fri, Sep 15, 2023 at 01:02:49PM +0000, Shiyang He wrote:
> Originally, the iavf PMD does not perform special actions when it
> receives a PF-to-VF reset event, resulting in vf being offline and
> unavailable.
>
> This patch enables vf auto-reset by setting 'watchdog_period' devargs
> to true. The iavf PMD will perform an automatic reset to bring the vf
> back online when it receives a PF-to-VF event.
>
> v2: handling reset by event handler
> v3: change reset process
>
> Signed-off-by: Shiyang He <shiyangx.he@intel.com>
> Signed-off-by: Liang-Min Larry Wang <liang-min.wang@intel.com>
> ---
> doc/guides/nics/intel_vf.rst | 3 +
> doc/guides/rel_notes/release_23_11.rst | 3 +
> drivers/net/iavf/iavf.h | 7 +++
> drivers/net/iavf/iavf_ethdev.c | 86 +++++++++++++++++++++++---
> drivers/net/iavf/iavf_rxtx.c | 52 ++++++++++------
> drivers/net/iavf/iavf_vchnl.c | 11 +++-
> 6 files changed, 135 insertions(+), 27 deletions(-)
>
> diff --git a/doc/guides/nics/intel_vf.rst b/doc/guides/nics/intel_vf.rst
> index d365dbc185..c0acd2a7f5 100644
> --- a/doc/guides/nics/intel_vf.rst
> +++ b/doc/guides/nics/intel_vf.rst
> @@ -101,6 +101,9 @@ For more detail on SR-IOV, please refer to the following documents:
> Set ``devargs`` parameter ``watchdog_period`` to adjust the watchdog period in microseconds, or set it to 0 to disable the watchdog,
> for example, ``-a 18:01.0,watchdog_period=5000`` or ``-a 18:01.0,watchdog_period=0``.
>
> + Enable vf auto-reset by setting the ``devargs`` parameter like ``-a 18:01.0,enable_auto_reset=1`` when IAVF is backed
> + by an Intel® E810 device or an Intel® 700 Series Ethernet device.
> +
Why do we need a devargs for this? If the VF is unavailable - as you
mention in the commit log above - should this behaviour not always be the
case without the user having to ask?
/Bruce
next prev parent reply other threads:[~2023-09-26 7:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 9:48 [PATCH] " Shiyang He
2023-08-11 9:40 ` [PATCH v2] " Shiyang He
2023-09-15 13:02 ` [PATCH v3] " Shiyang He
2023-09-26 7:48 ` Bruce Richardson [this message]
2023-09-26 12:15 ` Zhang, Qi Z
2023-09-26 14:05 ` Bruce Richardson
2023-09-26 23:41 ` Zhang, Qi Z
2023-09-27 6:39 ` David Marchand
2023-09-26 11:31 ` [PATCH v4] " Shiyang He
2023-09-26 4:51 ` Zhang, Qi Z
2023-09-26 12:29 ` [PATCH v5] " Shiyang He
2023-09-26 12:31 ` Shiyang He
2023-09-26 12:38 ` Shiyang He
2023-09-26 5:33 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRKM1LE/8cldlDC3@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=Yuying.Zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=liang-min.wang@intel.com \
--cc=qiming.yang@intel.com \
--cc=shiyangx.he@intel.com \
--cc=simei.su@intel.com \
--cc=wenjun1.wu@intel.com \
--cc=yidingx.zhou@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).