From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A102142644; Tue, 26 Sep 2023 16:06:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 29339402AA; Tue, 26 Sep 2023 16:06:01 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id EF4AB4027D for ; Tue, 26 Sep 2023 16:05:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695737160; x=1727273160; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=+VNGu1eejTF2w8oKUPDPsfHw+lsJ1h9awgu8i8fattg=; b=fVwotxmFrPXpfq8SC68ht02nwG0McucIBp8DLINoDOARZaQzSJldbRcv L1DowmS45mSWKeB27tccIwH6iswIOSpKhGYYpDafhGcxgc79Xj/MAEJwx UmMgVRIQt8aNBpsqb4oyPDPsrprne4POOXDp6r/p0njtOcXtCfwID61gE 4bKYUigi0xej7brdwtMi2kQVUMtZYSQNgFz9zDGpFqt7YhvxRxAIniFqH wHvNa/Gu3WVDA/dbrplA98LufVPq6h50mcCkMf6lKpoPEFl3hEX9eA+BE L3M+9cVPczorfiW1VIvQcZ+ZU4JharmjpQN3WBg8joG2Q04TpvPz7cn8R A==; X-IronPort-AV: E=McAfee;i="6600,9927,10845"; a="448067423" X-IronPort-AV: E=Sophos;i="6.03,178,1694761200"; d="scan'208";a="448067423" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2023 07:05:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10845"; a="748823896" X-IronPort-AV: E=Sophos;i="6.03,178,1694761200"; d="scan'208";a="748823896" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 26 Sep 2023 07:05:58 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 26 Sep 2023 07:05:58 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 26 Sep 2023 07:05:57 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Tue, 26 Sep 2023 07:05:57 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.171) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Tue, 26 Sep 2023 07:05:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lH/EMAO9b4PsEYStU+tHJgcRlg21T1z17E8XulzPUcvGBLgtvvHDLrsB/Zxu+t4QmbUPc4QoDP2fg9kLmMq2FQxSHW+X7HMjV9x459FDCtDoFwTiFeitVlY5UYoTBUHdWxRYjKIe1KIYaTAJ88AI6FSnCfyK3wH+dsXclczV5gtnhUkzMTWrkxWiFg99Ynl/1jUjijRONAcx+9hZFgYhdMS79BnXwt0N0l8iqmIn+SxHeOwPZ/BE9n5BvWbj8Hm7srSNgEhiwab0FVwuEaeyAoSsI7fr0n0J0RMlwD/jvdyW/96j3INbGUBVjyNg3GyRbLjMWZhipqBDQY9/FJLQiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+ZwqTn789L8aNL1syE2BZLYinvBcHFKdRB1zEheJCqY=; b=ffXpcQkrmbxQASYgFX5JSKoGdVSb7vk2v1NC31MLAnW/rbLu8wmkZTCUFp8jjJBYgqRe+a7camrDlCJ/ERJVm1eWhc25XVz6acRJ7o8YeI1iNdtgK3YNhqK42adiPnWzufIU/4KiWKEd7rFu2r1koyeQelm0y1zAL6zx/9yt0tiEWsHByd7CVJ7Y1nYmsPKLy07H87y7TTI0W0EMbYHwj5KFbn5XniCMTWsoYJVhlQfzKm0b8n5bt0pk5BJv5NtW+XQqzbpq+BfBm9gkcqH7mQZLoB0jC0gKlUYzac562fTPl3PuFIAHA6vKcWSSxnYzSrDw0PlUWMBiEsB/B1LFug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CY5PR11MB6092.namprd11.prod.outlook.com (2603:10b6:930:2c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.20; Tue, 26 Sep 2023 14:05:55 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::43d1:af60:464:347%5]) with mapi id 15.20.6768.029; Tue, 26 Sep 2023 14:05:55 +0000 Date: Tue, 26 Sep 2023 15:05:47 +0100 From: Bruce Richardson To: "Zhang, Qi Z" CC: "He, ShiyangX" , "dev@dpdk.org" , "Zhou, YidingX" , "Wang, Liang-min" , "Su, Simei" , "Wu, Wenjun1" , "Zhang, Yuying" , "Xing, Beilei" , "Yang, Qiming" , "Wu, Jingjing" Subject: Re: [PATCH v3] net/iavf: add devargs to enable vf auto-reset Message-ID: References: <20230811094043.200995-1-shiyangx.he@intel.com> <20230915130249.425790-1-shiyangx.he@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DU6P191CA0012.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:540::12) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CY5PR11MB6092:EE_ X-MS-Office365-Filtering-Correlation-Id: b729d0a5-a02a-406b-79f6-08dbbe99b381 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: htENuvl1fvjaOAT/zkP3q4KAjed/bN7XVtwZtrjNkWoNIu/KmFq3ubAkWc5aLFcrwRn3k+x2M9zxJEIhTnJnp3UYe69Ca0RtzJftBRjW/nZZRw1KY4cd4zFMF8v9uWBcCel7UxbpSuMMW3oGqHBzJ8hz2Q2cn6bnRo7ilPHjGEtpf0Lz370Wsb64SoJIRwX1CXZo/PqwcSKvaJAL8avydbZ0E4uhXVxIcD7jPVup/6y7dKNnieL2qcqXZMWFeUWVJwQJXYmFyXg1xr/rxRkegjt0W0QJmIiiUgppbXXOd0x9xLusy1kbja2NxTAdH3txU2PyT0X/txMcWLXr9Vq/upgbSzmpvmcr0A0IBm2WrQwJ5rywXNlMx2uFTGXG/sIpTiR3EtFXj5bPNUU9D9Jrqwcjs1HVu/7+MyfiOJF2KW9OWiFySMBp2opc2yzjZBn8hecr6kO9m6pkEIpO7i9ccyY0TBvI7lhJrBaITBCNE6j8h8KTzq1Rb5btNCIpWY3QlPvloTDK2iQbsYJesxEqBtuC4nZIYgsAx+03JNbKnhH9/rzJ+UsHYUolCe8LpZFN X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(376002)(346002)(396003)(366004)(39860400002)(230922051799003)(451199024)(1800799009)(186009)(2906002)(44832011)(5660300002)(26005)(66476007)(478600001)(316002)(54906003)(6636002)(66556008)(66946007)(41300700001)(8936002)(6862004)(4326008)(8676002)(6666004)(6486002)(6506007)(53546011)(6512007)(66899024)(82960400001)(86362001)(83380400001)(38100700002)(107886003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oEPlvltO0i4Lk4ukS2ZDSKElUpDzX/1octJobJWLPxCTS9T+z7LBjDCWnk9Y?= =?us-ascii?Q?oo2qVUnyiTe23j/4dBtlVi8BmvvWZrqkLVhsMh62TZchqHWDUQvG1ZOAr74o?= =?us-ascii?Q?YExlRXERTA1rTu5aGiFG+i/Q82e0sOsywkA3ImoqRgCfsQztF0mY31HIzFpR?= =?us-ascii?Q?OJbBklRmo4Wr9Cyfrzit2Qr+2NT2jDW8sUS3g777kiyk4hIUElxsiGajXKxY?= =?us-ascii?Q?aEfCiLUF64a8uiG5FhhOerSeoFRdHp/or0fKl3tp8RXMlcdWeFRGzgvYpy/8?= =?us-ascii?Q?lLgeGuHlsIIsK2k7h1txSGZPWAUu9m/K1w4YMf6iDTgNLc4YcJSpBwy6TvhR?= =?us-ascii?Q?GkHeuqMszrnP00Dp4FC8yljnwi4ai7DIl0TgOtwklX/4b2sOgS8y7o4qyF1B?= =?us-ascii?Q?i0I5ZfzMkI+uP8L5ylzqmcnJoYQ+sGSFX3gN1N8Kue+tlh9nXDGIbJhbApf1?= =?us-ascii?Q?Hi+CG3ZttrAHssw9mutMtvQwjQsnzDNY5A4WrTn0tWN4erz8Keuk0NF5dwIZ?= =?us-ascii?Q?tz7ZcHbdNUm1tAx1wlX7YkMyMXi/UQbKUFA8xa+DiUbxc6eiiPDKw0Zrdyl7?= =?us-ascii?Q?YV2xeCePr/lwmQ1BeCzVrTsO+3/kwxYXAofQm3oOc/RfDIhZU6oQWtGorHZX?= =?us-ascii?Q?WNHZM+3P1nRb29/s/9IDkmA5NHfVPdGkNbabPeZkxmPfJxA95SrMzkizEzrT?= =?us-ascii?Q?Eb0c4JSnZQq2HXeT70o6czsa/9V0jMhH6wgW71pcEA1PMFzugXdOnn68Vo1H?= =?us-ascii?Q?uVSTpszp2GGk6Pl/iKSYo/blqsd1hjvFJfyXL+8bmyJhSmyfkRfiMxkKOMM3?= =?us-ascii?Q?w0cjL+DW8IF8JJwCt0yJ+IC9Op601Xs4gw7HalqcpuYPQ8yH6v0dmYee580E?= =?us-ascii?Q?cZDq+YWA9mCvBPgSjmYH8XRsgS2Qg0mll9eMZMH1hOrJeAE2a5BPtcMOcFQL?= =?us-ascii?Q?h0xbqpT0eK2sC3FCpMR+U95EL6HKBycvIyGQ1xAXxDmxjMGgsNOS9fdXuXve?= =?us-ascii?Q?GMP/ibJPYzXaxbs7J2W3+c6nLgXGdov7csfpsGconEwaPv3VSbfXleem57uZ?= =?us-ascii?Q?s8OHUBLaHlx6C7z37bD4NO9tIfb/ecwAaDzNb5BWpIMAEi/LcoM78gIlDu1p?= =?us-ascii?Q?LcS6mlI7rmfN1g2zYyeLaHBdon0lw/bTyLF1Ipnqa+ewc+WiHELjyTIrDuz4?= =?us-ascii?Q?JOCTwJyRrHqSEXLGsSU7gN406OIm8F/l3lLCVvTix2Z/oXknrWpI1deDFez6?= =?us-ascii?Q?cyiZV6E2Yef8LMOGUy/CRfzMHQzicUJAw6yAqPVh957vRKCOQFJMoNp/7gmA?= =?us-ascii?Q?2sib88vQS0YgFsHzJJKFCJqYJExYzzYmNke9plDWesb95pQMaPupIgDhgBGb?= =?us-ascii?Q?BABeNQarMqLIx14EmZdBFOP2ENdSZ/qGER9YCbPwPwaPnv6Ap6x+i7AD2Y/j?= =?us-ascii?Q?rd3C0+W/zdwt2ambzYszSu3QqCb3qv9a/SImT0MgZie2cbmzDIgk4swSOdOX?= =?us-ascii?Q?u/MUmXuYyovaMQN5/4ohPkITjLa+pS9S3scJDiolWyfAbS7Y1GeY8S9hvvHk?= =?us-ascii?Q?sE+6Wly2/UdKOC5Kac0n3jIqFW7ml30PsvN9KeLck4mfR76oVs4kSG8UHSiy?= =?us-ascii?Q?kg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: b729d0a5-a02a-406b-79f6-08dbbe99b381 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2023 14:05:55.7238 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qn9sx2GzsZ9Nae7hgfA9M1yd6grWK/1SYQP+C9DmC6US3qUP4vl4N3UzW/riQedi51jkBX3ghtBuoscqGW7f3YAKxsYgU52wVjluN9N05sg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6092 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Sep 26, 2023 at 01:15:28PM +0100, Zhang, Qi Z wrote: > > > > -----Original Message----- > > From: Bruce Richardson > > Sent: Tuesday, September 26, 2023 3:49 PM > > To: He, ShiyangX > > Cc: dev@dpdk.org; Zhou, YidingX ; Wang, Liang- > > min ; Su, Simei ; Wu, > > Wenjun1 ; Zhang, Yuying > > ; Xing, Beilei ; Yang, > > Qiming ; Wu, Jingjing > > Subject: Re: [PATCH v3] net/iavf: add devargs to enable vf auto-reset > > > > On Fri, Sep 15, 2023 at 01:02:49PM +0000, Shiyang He wrote: > > > Originally, the iavf PMD does not perform special actions when it > > > receives a PF-to-VF reset event, resulting in vf being offline and > > > unavailable. > > > > > > This patch enables vf auto-reset by setting 'watchdog_period' devargs > > > to true. The iavf PMD will perform an automatic reset to bring the vf > > > back online when it receives a PF-to-VF event. > > > > > > v2: handling reset by event handler > > > v3: change reset process > > > > > > Signed-off-by: Shiyang He > > > Signed-off-by: Liang-Min Larry Wang > > > --- > > > doc/guides/nics/intel_vf.rst | 3 + > > > doc/guides/rel_notes/release_23_11.rst | 3 + > > > drivers/net/iavf/iavf.h | 7 +++ > > > drivers/net/iavf/iavf_ethdev.c | 86 +++++++++++++++++++++++--- > > > drivers/net/iavf/iavf_rxtx.c | 52 ++++++++++------ > > > drivers/net/iavf/iavf_vchnl.c | 11 +++- > > > 6 files changed, 135 insertions(+), 27 deletions(-) > > > > > > diff --git a/doc/guides/nics/intel_vf.rst > > > b/doc/guides/nics/intel_vf.rst index d365dbc185..c0acd2a7f5 100644 > > > --- a/doc/guides/nics/intel_vf.rst > > > +++ b/doc/guides/nics/intel_vf.rst > > > @@ -101,6 +101,9 @@ For more detail on SR-IOV, please refer to the > > following documents: > > > Set ``devargs`` parameter ``watchdog_period`` to adjust the watchdog > > period in microseconds, or set it to 0 to disable the watchdog, > > > for example, ``-a 18:01.0,watchdog_period=5000`` or ``-a > > 18:01.0,watchdog_period=0``. > > > > > > + Enable vf auto-reset by setting the ``devargs`` parameter like ``-a > > 18:01.0,enable_auto_reset=1`` when IAVF is backed > > > + by an Intel(r) E810 device or an Intel(r) 700 Series Ethernet device. > > > + > > > > Why do we need a devargs for this? If the VF is unavailable - as you mention > > in the commit log above - should this behaviour not always be the case > > without the user having to ask? > > Ideally it does not need, but with below considerations: > > 1. Not break existing scenario, which still assume some application will call dev_reset /dev_configure/ queue_setup / ... after receive RTE_ETH_EVENT_INTR_RESET event to recover the VF manually, the devargs make sure application be aware of this new feature and will not call rte_eth_dev_reset which will fail now. > > 2. intent to ensure a smoother transition, in case some corner case issues evaded our validation, keeping this devargs provides us with the flexibility to remove it once we determine that the implementation is stable enough. > Thanks for the clear explanation. One small suggestion: in the commit log, at the end of the first paragraph change "resulting in the VF being offline and unavailable" to "... offline and unavailable until the application resets the device on receipt of the RTE_ETH_EVENT_INTR_RESET event". Similarly at the end of the second paragraph you could add "This change removes the need for the application to handle the reset event, as it is transparently handled inside the driver". Regards, /Bruce