From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DBC804265E; Thu, 28 Sep 2023 11:32:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C337E40693; Thu, 28 Sep 2023 11:32:55 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 46BE740273 for ; Thu, 28 Sep 2023 11:32:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695893574; x=1727429574; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=xNJXH1TC75zeVvh8UTM1IXJzqrEVPcmSSSNUDWCSki0=; b=cR0dTIOTH6oyP9HQU0bscLvfS4F6ROfBnvCVF6tSzIxbqg3tlCTr3G8+ 77fculnJoLugZ1CGphGoeMlwMyhErqvcBjxbYQz0rbGJ+pt+1xCYVznAk KGG3WG1a0fo7iLVwQtauv6YAUbb4nbp/44JKvEpy0TSk0ydKC4ccVkL1h PCv8IhXbdn4BRhjP/2UgDalyOUXOiAiwjVy0r34zCsE5dC1Rx2wAC3R5A iG9uJsLxpvdm+li4uXxQKAiKL7FNTMPbRRR5m2ZvQcXWDQEJeMwLTIJku kjsJcwsklqWbsYVX1+Emk6LWVkjyVnpcaL4zjNH5m+lTek3K8mujxJVt2 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10846"; a="372379570" X-IronPort-AV: E=Sophos;i="6.03,183,1694761200"; d="scan'208";a="372379570" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2023 02:32:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10846"; a="923141340" X-IronPort-AV: E=Sophos;i="6.03,183,1694761200"; d="scan'208";a="923141340" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 28 Sep 2023 02:32:53 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Thu, 28 Sep 2023 02:32:53 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Thu, 28 Sep 2023 02:32:52 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Thu, 28 Sep 2023 02:32:52 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Thu, 28 Sep 2023 02:32:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oLCq/pzQfYSyIRO+avOq995fevHJwxid2WCw54WHwhyq3F2dNzjtdgwdZRS0dX91qZMqQ6mO7WmYgDgYTzRuX0j3ydr5r8SQcepTuwisGMZMTtp7LlPdJ6dZjzOj3ngTAaun8pbMyqxe+zo19y4z2MEFjI1tSMDTYekELKU42RGZ7yjol6JpRX2BZ4kEnUdd3zv5x6IYJV9RbcYfxVr/CCPnMvNYMKBOoXfspUXpEQHM3PrTq4EgpSwM1bdsXzGtrvv3alp3qfdHCyHdoIybOVrSm9dGEH6OxC6ejz/sQakRsSHCnjXm5uVq5M4YKoMKRalMZAT687GXjUlsfPLPoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=syor4rrCnwzpZAY6ZR00snFDefWHqZdXRA1V368WLy8=; b=gStfwjok6Uj8qirSaRusbFYmcOzwDtIU+1gA+UPC6PacibAYL9dNe7Rq4uLujvzgYkdut/ZLX9CXXGaQ2gu6uhLnxoC9qeT5QZ33M3EaNOiM6PT728DifrWJML3R1AXwZ/eycwy9TxClcKNIDyckD7jIZFldB5Qv+Uav6iLY8eAR88lJUetORX1my5c1mxuOel1OzaXukBDBkTHQ1iZ2lTRY+MXoEXPIgVxjSIht1QzmjIVWF73yjw4GWmKShtS4WCZ2mL8CgWsW2K7HNt43l65oz9CQJHOpoJvjaXazIAezTtpqyRaxNQDeweG43ntHXaW77USGwI6Q0QulLVF2hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH7PR11MB6724.namprd11.prod.outlook.com (2603:10b6:510:1b4::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.27; Thu, 28 Sep 2023 09:32:50 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::aa85:ead1:baa8:c652]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::aa85:ead1:baa8:c652%2]) with mapi id 15.20.6838.024; Thu, 28 Sep 2023 09:32:50 +0000 Date: Thu, 28 Sep 2023 10:32:43 +0100 From: Bruce Richardson To: Shibin Koikkara Reeny CC: , , , Subject: Re: [PATCH v3] net/af_xdp: fix missing UMEM feature Message-ID: References: <20230922093103.58541-1-shibin.koikkara.reeny@intel.com> <20230928092553.339452-1-shibin.koikkara.reeny@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230928092553.339452-1-shibin.koikkara.reeny@intel.com> X-ClientProxiedBy: DUZPR01CA0083.eurprd01.prod.exchangelabs.com (2603:10a6:10:46a::19) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH7PR11MB6724:EE_ X-MS-Office365-Filtering-Correlation-Id: ef1ab084-d83f-49d5-c1b3-08dbc005e201 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: laNL9f/FGbafgaJMV75u0vdbMXIlD0/8WWekZV6RKq+M1/i2IPm7ghdnP2hCZSyOKZ0yfNMaFFLXiqs4qNZwXFaTPeRwManpF63jccoyKLNb83f9PXG8xsC6DwxnFaE9Nna2/ifx+/v3eswNfru7/VeX1vfhjA7plwCs7QXUuQjWYMjxKLNRy+s1CU/AKzrNyKtUCug6Z7Vy8HFQk+kHU7uIeylVJOOWKE5Mjc2nPwnYBeLYQRRUIah3zGvTg/PNePxy3V+uTZgO8l8M9s8gM0fvzGrr+xIKMRAEtCqXhmjcxHATG0wE9rmKsnFKLqLRd2Fv1rW0VPqoWLQGqxo3+pI1OTKBlGjVGuESVU8iQHxs2SdwQeJ6DIT2Cc77pLpEywoTn3/yPenpKjqWxfPK5iqQvRGaPulamDnef8N1d2A0fzvf3U2zNqXHxZxD+XHhAHIQBIdfH3jqMenxEgVFKOd//2lxF7X7vRIx0P4iuE0fE/k3rOQNGxIYGHX5dgLT/npUL6VmY39Twud/9D0Zi11nej3f8cUC15FIGrQr9uw= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(346002)(136003)(376002)(366004)(396003)(230922051799003)(451199024)(64100799003)(186009)(1800799009)(6486002)(83380400001)(8936002)(38100700002)(8676002)(26005)(478600001)(5660300002)(86362001)(4326008)(2906002)(6666004)(66946007)(6862004)(966005)(6636002)(316002)(66476007)(41300700001)(66556008)(44832011)(6512007)(82960400001)(6506007)(107886003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?th+TmH8wtHsTiGtUkWcG7acb0hXo5tSD7qhYc7h38XAjYylHYgroMJKR5wD8?= =?us-ascii?Q?Q/JL41gNZJc1VYYW3gNUc16yGMBuP4n5QFSBZ7Ic55Cvj82Qm8LhupeqtfcN?= =?us-ascii?Q?zyG61bRqqkO0vCioSWwb0OWYf7XiDdqTCyao5L/3qJ/01Wn95DeLGf+UMfhg?= =?us-ascii?Q?FlOPmBi6Wnr9GlraL6FEbDbK8D30SZjXp0PnQxKExtoWpMxeOC0RPT9ufeCO?= =?us-ascii?Q?ssy8ko2p1bPcto4sLWJ3prtGsk6dQ7CxgGQwQphYQwis7pipPshd/O4F03hU?= =?us-ascii?Q?2wNgrEc6E/clTdWdBrKENUD8y5XpVlf5Sb7b1kD6DRnwQk8JAbM/jlRt99h+?= =?us-ascii?Q?pw9+I6T4WnTzuf/SM08usdDn0SFFyay9hxL0EO8vipc91hr6+NXbjYQUs19o?= =?us-ascii?Q?q9rdsLa2Qf/DKTLsepYaiCKQyZZa/2bxF1YrLCPgAspclmtNZiBvLCXz3zhh?= =?us-ascii?Q?cRCi2YBiRn8THSg6HFdQv/NNGIb4SdXFbXs2LJ2SJrcbo3/iBNR9qaqon4QM?= =?us-ascii?Q?CtlwS29nug6NFhhtorCnCk2nuSqNlepMIt3KEr8x+cuf4MLDCCcLlgjjTjM9?= =?us-ascii?Q?M8jTVgmvxpUf9Qz3EjoqpQ5M/PublBdcIU5LhNcR5Y8wi7CPxdApldFwr0B/?= =?us-ascii?Q?QH/4PQB6UwD7ayH4HoaQrGGHqHzKcIhSf5J0PHKnWPT5bS/HNSSAKKG35xd+?= =?us-ascii?Q?EMDBPgKSMFp4RZ7PDHkFtEyWvbeF1OiZHsDVNy9+RnmQegrlutnrQpmftARd?= =?us-ascii?Q?CfVL4hgHUu3Fu6J+XZZKHC8wbKZvHNEmZJpOB+SZvdtu6zYOp2EMrdr0Pbee?= =?us-ascii?Q?HArDwOIuOtIasW+2eF2+ZgRn3Oc+xmOe9DRibaDJk+H4nl6CKjlLcDtfMLef?= =?us-ascii?Q?rwcK/IaxY2UIiqedmfTmlmsHb1EcUYJLae6gikG+YtM8hh4deod4tv+3Uqjx?= =?us-ascii?Q?uB58wgACxZiD/e+Omn0mhQWl98tzK5h8R7oRRUtCKDoh9+IlBFEceYjXUFAV?= =?us-ascii?Q?HCS0gELQwu+7EqO54hMHbGxIt8NWoewuLpKIdv+XT8HM+3DFDruw82e1CxXl?= =?us-ascii?Q?MmHQc0VT3FbhQWFe410rOz8cJotfCAnxfmDvCJBF36A92nWjUQEhFld1fjQc?= =?us-ascii?Q?HcblIwZdwDUdOBomNzsWKLkaZHIIgJQi/UlMxGfTEO9gGuGyVFXUxdiV0BJ8?= =?us-ascii?Q?doaY1ozqFARqpM3lNKGKuBx7ovYJtjvgAaUslFWQ/XXLLKu578Kb7s60k1dd?= =?us-ascii?Q?+RO15/zzuypu3twVksH0O+53J+FHlxpP4lkRL1XrJxjc5SSmNVPK0ql+kjwo?= =?us-ascii?Q?wlrYaZspQ/lunwXkDggkgQbcxgv/yMzra2g1meT9qILO62UIgv8zIqv1b0wo?= =?us-ascii?Q?NNNVNy7VoSaDk8qU2cjnwK5xBnTjYf+eb+OTHrnpmPAvisJXi2/vLX5XUtib?= =?us-ascii?Q?QsAK6LwA+w+FNYBXMGHAQ6QTo4zRN9jHpm67ZKi8sLscF766+B196XGbemv7?= =?us-ascii?Q?8KssoQJQ8T9qTwEh1K0Pkm25Gv7OirCu+4dmlflQgb/+LuxQ0f+/7hh54eWn?= =?us-ascii?Q?yHb6ICcQdKqG0/vE3EM4crnrzyxOzp1pDABelO+azNCQExemm7YddGe//cQ6?= =?us-ascii?Q?wA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: ef1ab084-d83f-49d5-c1b3-08dbc005e201 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2023 09:32:50.4558 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hXNcFXbjBN0nhFaKOoDwijVFu9XBL1AdiKjQYMSbbvCpT75QrqeEtDqS6AgIgQq23VuPX9yTFl4BY9zkRSTSWIp63XG4C/6FD49BpPL2wAg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6724 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Sep 28, 2023 at 09:25:53AM +0000, Shibin Koikkara Reeny wrote: > Shared UMEM feature is missing in the af_xdp driver build > after the commit 33d66940e9ba ("build: use C11 standard"). > > Runtime Error log while using Shared UMEM feature: > rte_pmd_af_xdp_probe(): Initializing pmd_af_xdp for net_af_xdp0 > init_internals(): Shared UMEM feature not available. Check kernel > and libbpf version > rte_pmd_af_xdp_probe(): Failed to init internals > vdev_probe(): failed to initialize net_af_xdp0 device > EAL: Bus (vdev) probe failed. > > Reason for the missing UMEM feature is because the C11 standard > doesn't include the GNU compiler extensions typeof and asm, used > by the libbpf and libxdp header files. > > Meson error log: > In file included from > dpdk/build/meson-private/tmpf74nkhqd/testfile.c:5: > /usr/local/include/bpf/xsk.h: In function 'xsk_prod_nb_free': > /usr/local/include/bpf/xsk.h:165:26: error: expected ';' before '___p1' > 165 | r->cached_cons = libbpf_smp_load_acquire(r->consumer); > | ^~~~~~~~~~~~~~~~~~~~~~~ > /usr/local/include/bpf/xsk.h:165:26: error: 'asm' undeclared (first use > in this function) > ... > /usr/local/include/bpf/xsk.h:199:9: error: unknown type name 'typeof' > 199 | libbpf_smp_store_release(prod->producer, *prod->producer > + nb); > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > Fix is to provide alternative keywords by using Option Controlling C > Dialect [1]. > Minor nit, this patch provides the alternative keywords using macros rather than any C dialect options. > Fixes: 33d66940e9ba ("build: use C11 standard") > > [1] https://gcc.gnu.org/onlinedocs/gcc/C-Dialect-Options.html > > v3: Used alternative keywords fix. > v2: Added original commit causing the issue. > Signed-off-by: Shibin Koikkara Reeny > --- Acked-by: Bruce Richardson