From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B15342671; Fri, 29 Sep 2023 11:26:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 08CB3402B1; Fri, 29 Sep 2023 11:26:25 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 49DEE40287; Fri, 29 Sep 2023 11:26:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695979583; x=1727515583; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=LFW5L66lthQ6x5VJToDGOqD52MpOeVaymOtIgPRmwCI=; b=ZQHEUeqPn2zeQi2CwKeIKYPRmr22MW8dqwD1kFYQwx31PqPhiWrcmnJ2 KVrmh4qhcY2CLMOQUQZfuZbJhMI8rDreG1N/tz6LkeM+/H7JwibchCKve /slfqLWWW1CwW18ut4qtISyrCndKuEXAcNidwAikZJDApvTxqtU+sfvs7 jsFLrHoU7LFQhS7Q8wAXR4tKgU7l+zb+9zHePR0E9qV/sKzfW1OfavKHQ jJ20WsZ7CbdqOFY2zpTZ714k4w6CM1pjXidj8wwxgoMejdLWtFRubs6d2 DGstOQEs3G+QY5F/HbpMZPj3/nvQJNFCFh5Mpll0AgS6eOcEdM6qmjnZN Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10847"; a="446422686" X-IronPort-AV: E=Sophos;i="6.03,186,1694761200"; d="scan'208";a="446422686" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2023 02:26:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10847"; a="840225891" X-IronPort-AV: E=Sophos;i="6.03,186,1694761200"; d="scan'208";a="840225891" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by FMSMGA003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 29 Sep 2023 02:26:21 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Fri, 29 Sep 2023 02:26:21 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Fri, 29 Sep 2023 02:26:21 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.175) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Fri, 29 Sep 2023 02:26:21 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VuGK8phbP8+avq2D6SzC67cK9cdOr3zRM1urdE2XfsrRibJM6FWl1K6fEOU/3Qm4T5LCKQ/0HPM502wTQWIC0QJ9HXNSsdxc+bCo44ObMO3k25baIei5AsThmZ7P25Mmff7fIjESuxeDriM2mFHrLyxsmLalDMruHO8ewuuqccsxRECTtJo6TdCpgwPFiQm6P7A9wXtO3vEhZmaTlEl8cHOYhppHmbOXmW2EEMsdBnYA2KhsFjnZxS2xQxMsPz0jD+WY65fFRWA+u2UTEZdlSKMKRgHO6Z0DG6CHxB44W7+dtvnMvU6oiZzNLBW/ULFxUSXCJOIw0dOEqOtVS8sdYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C30WcSTal78Ni1h9PLEryV1267+XicQCwJcPV4OMaa4=; b=oc1lJx0yAadcGf0ppv52RPAMSiqYoP+w3pHkaRagQVemRHn1Y26fAaj7IH3WenKoN2dmu+GgWxaOha0Pv/PdR7paJ3lg0+8u42tGrSYSgx/Gr9rpASGAJVdXmw8T2Ux9PUGqvRX2DtTYN8bmwvmOsBtDEIMLY6mVwAYIky1KOAVEyYL7wUTYT0DbEO/flGsl3gsBVqp4Xaa3uy+IptK5qnWIdg8nf/sXVcvTBRgVs6u8OJwV5Z/LLhCd9TpjmxejoYalKfYKTZclZF2r6Z+ZqjIQcPu9NaGUAFugmjlf0uvEYCaid2XrzR8QPEm5f3plTaWEsFQrxGcT9F2BeSVT8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DM4PR11MB5422.namprd11.prod.outlook.com (2603:10b6:5:399::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.28; Fri, 29 Sep 2023 09:26:19 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::aa85:ead1:baa8:c652]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::aa85:ead1:baa8:c652%2]) with mapi id 15.20.6838.024; Fri, 29 Sep 2023 09:26:18 +0000 Date: Fri, 29 Sep 2023 10:26:11 +0100 From: Bruce Richardson To: David Marchand CC: Morten =?iso-8859-1?Q?Br=F8rup?= , "Thomas Monjalon" , Tyler Retzlaff , , , Honnappa Nagarahalli , Ruifeng Wang , Jerin Jacob , Sunil Kumar Kori , Mattias =?iso-8859-1?Q?R=F6nnblom?= , Joyce Kong , "David Christensen" , Konstantin Ananyev , David Hunt Subject: Re: [PATCH v6 1/6] eal: provide rte stdatomics optional atomics API Message-ID: References: <1691717521-1025-1-git-send-email-roretzla@linux.microsoft.com> <1692738045-32363-1-git-send-email-roretzla@linux.microsoft.com> <1692738045-32363-2-git-send-email-roretzla@linux.microsoft.com> <5908573.LM0AJKV5NW@thomas> <98CBD80474FA8B44BF855DF32C47DC35D87C1F@smartserver.smartshare.dk> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DUZP191CA0047.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:4f8::14) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DM4PR11MB5422:EE_ X-MS-Office365-Filtering-Correlation-Id: 58b28c3b-a17a-4d59-f389-08dbc0ce2302 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5Hu+iu1EQVo6Cl1M1V3wVbGBj23x7bkHHl5l1ZOBoluqAaiSzyDfU6ldkDp+h93FKHwMmAgd6NagquK8/EcZ5LSH3Kmd50ELe7I/o6UmunDpt99g4h/+3+p+IixFww7pMAUqDAW9/nneU17GpY/I1RwIIVgaAcclcvII7ekxLaVtEXTMepajbpjZLwPK46HWncK5T9Xbv/i2OcN4Q99FogOmdpmY5NZPEfXqJHBKfp+Gw55MjJVXiEux23R+GEpiYEVWUJQ7ogAO0xtlIjELdk9Aa8jfyqQFxiS+equXGkkaUgrbGYvxBuaESr7UaZV5YunrYNH34zi0EZAhF8FVCZtzrtGft9Ak/YBCWMQbbQ3khCJMLwq7/mj1n9T++D3B9ei1DhbIRKY5ifb9HO9XqJVIhg2drxfL2LbFuMQOUagKb8YyUTqFvx7Thn6tZkfA0JUl4XSU1TjMPU7/NB1/yEMUR4uGuGrdpaV/8wEV5QQsVLgEqNr8+PTMhJg0KqR1vqS47ucC6w+u2Mh6QLpPBOXdtjm4JXS/i+dkpU5XDl4/e3LZ7yJ2M4/x5VQDE/gP X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(366004)(136003)(376002)(396003)(39860400002)(230922051799003)(186009)(64100799003)(1800799009)(451199024)(2906002)(7416002)(4326008)(5660300002)(41300700001)(44832011)(8936002)(66946007)(6486002)(6916009)(478600001)(6512007)(6506007)(6666004)(8676002)(26005)(53546011)(107886003)(316002)(66574015)(54906003)(83380400001)(66556008)(82960400001)(66476007)(38100700002)(86362001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SGExcWdWeEkzSEJMZ1ROSUxMd1gvdnprZk4vVjZxSWV1cmZmY00xcElWamRn?= =?utf-8?B?aUxSQzBseHlxbWpvbENxRU1jWEd0QXUyekJpVWVUNXhaQnJ0Nys1dCtUL3hZ?= =?utf-8?B?MmJ3anUzTXNoSFFGU3RKWnZtVGlpcHI4NTJPT0lDZjdnOTNRUHIxTmtVUmVn?= =?utf-8?B?UzBWWTNGdjN4dG9nVlY5cEdycU5xb3NXWFVLSUNwa1ZFTUUrTzJNdHBibndY?= =?utf-8?B?aC9EV0ZLZU10WUtGb1JLQzdlRW5YS0Q3TGljYWY3Q3l3M3pzUUhCU0N6T0Z1?= =?utf-8?B?WGlLWTE2aDBiUWxoamVTaXZCbUlXYWtNdFRwdllvZEhabGJnOC90OHRidWpR?= =?utf-8?B?RVVHNFpxbTl3RUR1OVhScEJGcHllYUpmM1JETmUwYmpjbGJEUnl4QnJxTm9Y?= =?utf-8?B?NGVKdGxrbktsaERneG1lNCtHenNQU1RxeXNhWUs3OEtiOHMweGNNRDYxenB1?= =?utf-8?B?VklEM3lucFlLRkU2YkZpY1p6VUFZZncwTUFxQW5nTTVkd3lELzkra1B4RGQ5?= =?utf-8?B?Um8rSmU3Zk1kL0V1SHVRMDducFYwcXVFTXdJNWl4T3pwNC9SZVRFSzFVWUZL?= =?utf-8?B?ZTFaSkRzM1djNXV0R2p6WFZTb29KMVFpK2ZqSm1EaVMyb21zbjRjZmFrQ0t3?= =?utf-8?B?QUtwTDE3MWhMb2c5WERJL0FHK3FuSElaVXRScjZ2SVYySE00TWpQVHpqMHJC?= =?utf-8?B?cXBoenFLb1Z2em9WSW9BTzJMbDRZbDFScDN2WXU1blFiUmgrdS9QWUhUMjBp?= =?utf-8?B?VEEwQ2l6ckE3N05MaGNPelNzbXBEa25qeCtNZXczU2VFeVdoWlBUUFM1MllU?= =?utf-8?B?dzZtektMNGI4OWdBSXRxTGE3ZEJYZ3orUmZhazVhd3ZqODUvVTBHWXRuM2li?= =?utf-8?B?OVk1S2FwYzlvdWVCclY1ZFVDTkRINnNkaHV6RXFab0pkVTFDU290UlMrd0pR?= =?utf-8?B?Y2RIc3BLR1JJL2toRDdrTWUzemdPR0lFakNVWUZUbnlDeTdjOEl3Y1JUbjZh?= =?utf-8?B?Z3U3VGQ4Snd1d05Vc2gzQ2xLMEQraW1MU2YyQW5OTGpYVTFTcHFla2pFWVB6?= =?utf-8?B?S3lucS84UVZNbzc4YkUvSG9STmNRR3BUVDdPMUNqUUxHbFRlOEUwZ2hYZTRG?= =?utf-8?B?UUhQTEtTUTFHZE5VcXhpVUJuMUlpNjdUdGN1YlRNamNSZ3ZwQjY2NjBhYVVX?= =?utf-8?B?Rng4bGMvMEV5bHhKNE85aXVqZWFZdS9vMnA4c2JWWmpBMUJwd0JjdzV6T2Uv?= =?utf-8?B?RFRNaWI0WkdlWEVTbEdadis0V1ovMFUrV2ljckJZOTRYVVRvUFNPUFlSOVJY?= =?utf-8?B?WW9UaGdhMndQMWUxcWw1Z0JRYjM0cllWUDFPWVUyS290VjUvMW5jVFdseUZ4?= =?utf-8?B?RE9vdCtieGk0RmF5NU55cFc3US9yTnVMMHJ4WUJmT1NzSnloVkxVc2E0Z3RS?= =?utf-8?B?N0owQTVkMGxZSnlTSjh4Y01kL2JIenJSdlJkNFNFSlV1MFlJRk9uSzMrQ0hR?= =?utf-8?B?MTFRK3NyK29mQ3A0ZmlvWUpuUkRCTEZmZFM5RlFpZTM1YkhvZlg1eXMyM3JC?= =?utf-8?B?eC82YUdYOGtDQWFUOXR2OWp2NGY4TkhWdEw3eDZuUFhQSGdpMzF2NU5sSUgy?= =?utf-8?B?UEpraTdtUGpZd3Jmeit1bHkxOW9DaUplRllPdjBZQTlVdGxBam5SMFdjTjRt?= =?utf-8?B?YVFDMkF6L01Kd1oxSGZSNDJOWjlSMUVJY3JLb0JETjlOcEZtOW1PbWZpME1y?= =?utf-8?B?WHN2cGg1MS93T05VVVBnbTQ2Yk1MS0ZlYll6V2l1WW1GcE9YYWtjSWVFV2po?= =?utf-8?B?SFJNWFhTK25aVGU0aFpPSWxEVlRaL3FyZzYvNjN2R244U1ZXRWl2elNkaUJ5?= =?utf-8?B?bXJCRUdmYkprNXZEWFkyc25GYUM1emlXWEdPdjIxVlVabG5lTy90TFBNNEph?= =?utf-8?B?a3RBUlRhakc5VTNsK3U0ZjBMc1d4WnNkSEUzRXdEME5TK3NGQlp3RjNnYWFa?= =?utf-8?B?R2s2a2tRcXgwdXdxRkYyYXZkc1lDcEFkQzM1SGtiV1lXRHZ2NzRxVWNtY2gy?= =?utf-8?B?WEpwakFTVFJoNEtZOU5PYlpEYnNiSHp1TjgwUTN0UTVSbmRmVmNlODByMVAz?= =?utf-8?B?cnlkY21neklpUmE5WWE4OXNHQ0ZISWEycGxMSy9WTmhuNUM0SG5ndlBHa2E4?= =?utf-8?B?Y2c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 58b28c3b-a17a-4d59-f389-08dbc0ce2302 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2023 09:26:18.8462 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: P0Uu3HHKlKcwo5xVxvwMK6iqJLykAHvNyIrhOQdgNmmzDzYhkuaT4M8fo5vzN9eUTbD6lsjl/hD1ROyQvjDoonGxQngs5UF/qqlmux79BOY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5422 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Sep 29, 2023 at 11:02:38AM +0200, David Marchand wrote: > On Fri, Sep 29, 2023 at 10:54 AM Morten Brørup wrote: > > In my opinion, our move to C11 thus makes RTE_BUILD_BUG_ON obsolete. > > That's my thought too. > > > > > We should mark RTE_BUILD_BUG_ON as deprecated, and disallow RTE_BUILD_BUG_ON in new code. Perhaps checkpatches could catch this? > > For a clear deprecation of a part of DPDK API, I don't see a need to > add something in checkpatch. > Putting a RTE_DEPRECATED in RTE_BUILD_BUG_ON directly triggers a build > warning (caught by CI since we run with Werror). > Would it not be sufficient to just make it an alias for the C11 static assertions? It's not like its a lot of code to maintain, and if app users have it in their code I'm not sure we get massive benefit from forcing them to edit their code. I'd rather see it kept as a one-line macro purely from a backward compatibility viewpoint. We can replace internal usages, though - which can be checked by checkpatch. /Bruce