From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91975426A2; Mon, 2 Oct 2023 15:24:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1B79F40294; Mon, 2 Oct 2023 15:24:28 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 2D3854003C for ; Mon, 2 Oct 2023 15:24:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696253066; x=1727789066; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=0JfKqncBPJrNgTUSRK0cwc44kVkTtUhegfa4TBhe364=; b=UR+exUB3fqkyC7iR/TloQlJdJoKUncrzh3A4rRHSEg891Lp/nFCDztu1 q0lHznycXXaExYvCihzdN4x7wfn8aNOl46prawFaPgA+bVjBRyT1wgV5u EPeF5Pq3mmawsYyiEKJyaHf5uhBRUlELG9rkxubhSIKqt6fldwZs/C4HJ Ktc1lXc11NdKFpT0kFEyAnqr6G09/SJAH9ytXto9mkrOr0A3HbG7Rv5po HvOoYhmKU97oZdphwMsCgIf14SPRhD+8K3Fx5lRRRWl8gttNa55O7Ljf8 pStEAms6ndilyMSaxBEo1FJ3Jv8hNx1c0H5oFZr9Dctdz8WhCPLRqg4ts A==; X-IronPort-AV: E=McAfee;i="6600,9927,10851"; a="446791935" X-IronPort-AV: E=Sophos;i="6.03,194,1694761200"; d="scan'208";a="446791935" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2023 06:24:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10851"; a="727259863" X-IronPort-AV: E=Sophos;i="6.03,194,1694761200"; d="scan'208";a="727259863" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga006.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 02 Oct 2023 06:24:05 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Mon, 2 Oct 2023 06:24:04 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Mon, 2 Oct 2023 06:24:04 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Mon, 2 Oct 2023 06:24:04 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.49) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Mon, 2 Oct 2023 06:24:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l9NcBSq1CjDwYVFfPdSJYvv78obfkzNOLL3U1IA/SHX/h0M4bPAw/DWeAMhEPDpfoyYQWRqf7desl3NNqiRwZ7dxEnTcb6g01bTHIG9Pad3pHsL8NkZBNcEpEA/5UtBNlu/7OiZFWEqR9y/HsAKT/PSMt9nE1HJVOEwL2/xXh6HJWyjUfIyR1eT+u31x8ed9OtLCV2IE9+jRCY3FEphekcFuVjh8Kb0v7y9NGcAj5ZIKCWjPXo0M+DKPI8gmu/4Li6onfaiG0eq3OLc9+hiVYblapWI3HfHhDp6ak/vXS7DT9DJvGNPcZKDMYVnNLb/0FarBmwU77kL4kvQLfcinAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4UlhmRKxF33wvSwfS1RD1A/v558Eh//XpYOBxvBXrYo=; b=R++nC7oYwPtUuF15y7zaHO8uPhXsNiHa8LfVRoeWqiqblvYyO6CpcgRpSqiMW/wxbZ1jW4ObQveDmkPj7a59VvDyj8cDTdgSdRw4iKQPOyyTVuWMqLBi1fTQ1TySXF3D+lDckPAyTiN9Xwj3+cbENRPgf/Ldcjon9dEnE0QLEkF0HOBbr33Tk30AJkadllf2eH8wzDRtOfFM+u+HVKIx3AmOuF5EwKpt2ADWxVCCNNh7kBLbgr9g9sW9B8e7HIqvD2IBerNsc5dBm43NQvCoycf7t09wggB70fMMuDHF1o4dQWUn0e9tvKoF+bl3lpRThLoBX0SvEPNP0u8G/I5kIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from CY8PR11MB7290.namprd11.prod.outlook.com (2603:10b6:930:9a::6) by BN9PR11MB5289.namprd11.prod.outlook.com (2603:10b6:408:136::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.30; Mon, 2 Oct 2023 13:24:02 +0000 Received: from CY8PR11MB7290.namprd11.prod.outlook.com ([fe80::1049:683e:132f:e690]) by CY8PR11MB7290.namprd11.prod.outlook.com ([fe80::1049:683e:132f:e690%7]) with mapi id 15.20.6838.028; Mon, 2 Oct 2023 13:24:01 +0000 Date: Mon, 2 Oct 2023 14:23:56 +0100 From: Bruce Richardson To: Ferruh Yigit CC: Shibin Koikkara Reeny , , , , Subject: Re: [PATCH v4] net/af_xdp: fix missing UMEM feature Message-ID: References: <20230928092553.339452-1-shibin.koikkara.reeny@intel.com> <20231002124852.76374-1-shibin.koikkara.reeny@intel.com> <24c4c344-1c71-4d13-9fc7-8f4eb7601f44@amd.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <24c4c344-1c71-4d13-9fc7-8f4eb7601f44@amd.com> X-ClientProxiedBy: DB8PR09CA0010.eurprd09.prod.outlook.com (2603:10a6:10:a0::23) To CY8PR11MB7290.namprd11.prod.outlook.com (2603:10b6:930:9a::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY8PR11MB7290:EE_|BN9PR11MB5289:EE_ X-MS-Office365-Filtering-Correlation-Id: b46b02fe-9e41-42bb-f76b-08dbc34ad7b6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QwlLWc0HnD/4DLG6VpxYk20s1gIqZg8wdB56eo8pXxLOydRZrhqQBjdadyN5vD0N52nYMxGY3ygNPWO51PuE+2e84O1qlrKuHPZ4XiQHUoHa0W+qj0RflYaeKyZbnXmj3es2PX0AOkoW/MXvFCLCtvZpxL04f+epKkkG17biczZ/7L1ue4Zqfj0wgEa0UEPCRnf8IxJKwGp0wBN58otPmfihcmYch8lyt4NXSdmw4hatVhamtFCXAcdVQto3HWUEZ5W0UbM+GS/z4uHCUvMKmNi0wRnp4TTPLQB1BNA20Kf3HJ8lI7dD8je7tN2u2T1wMdYnvMB9rN5IJHci1xAxsLgMM4caJ7Ub71Q3Pcw6EmJ/h8vB9Vvik/LF7O2VHjy2ApwDf2THes7cDxH5+4Giucm58nLiTznv3DZv3dZfy8Hqx9mGFWnv0GnLeWIvoZBb1iEZHRx4z/oMR6KSWx0IIBb+nRzZYFs2mfCaoMaIjcWQih4oOqEm9GYob2mynbXvPhOXQHbyhLOHUXnYQrf1B3YCGArjOm1WEH+RlMcwpmKOczfadCRX6roCp1LfVU7NI+js3FFZmr0Py1TbLpHab/w7P0l+hCppjH9FwPNTVPcIz7rtRDflTabS7Q4L6818iePT630CKJxwwQJWkarmVw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY8PR11MB7290.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(366004)(39860400002)(396003)(346002)(376002)(230922051799003)(1800799009)(186009)(64100799003)(451199024)(6512007)(6666004)(6506007)(53546011)(83380400001)(38100700002)(82960400001)(86362001)(26005)(107886003)(316002)(66556008)(66476007)(66946007)(6916009)(41300700001)(2906002)(44832011)(4326008)(5660300002)(8936002)(8676002)(6486002)(966005)(478600001)(67856001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tG5EHsJNJnE+fM14Al2xWHjZB89VNcrz0zB2xeD/gyqoQJdh2HpVFfFZa0gQ?= =?us-ascii?Q?2Ca2auL/DIGv85z1iFet+e5FZpuGitIhckf3V1PCvhAwdOba4hBh3mMM8W8D?= =?us-ascii?Q?Fa1ligbRc9Pmc4qtgNNVABMbt8UCyjJPZG1LTs4mHAMHDwI8MwmxzDf4AGuK?= =?us-ascii?Q?xb83PQirOwVww0RSgB23kkQcIn+MlYXGZ50/cvXkfeM3dA9ZT3POkekZ3dn7?= =?us-ascii?Q?E//8jnTz1y1AxgIEKD1vETAFz9QGPa1f6rhJ5bOuJ0oS+q7NBOezSvlD1cfW?= =?us-ascii?Q?yxcFTLlX5BOzqKH6281gxmRoAxZbEaUYEoa31ZbLXQpJH6YCgvjCDHqdlanK?= =?us-ascii?Q?hCNLzBeCp8NK1XZ3VE+rVDbIbFzH9VzzCWxnUFjZi0FzriH5SYHB9GIG93OM?= =?us-ascii?Q?K0fCaujiImq70Tflhg2u5Ancd/VvKs15QBFgMVoQ4M9O+fbPsEDA++diekj2?= =?us-ascii?Q?VRtVrmUx0Hc2pKinN9+ur3gAjvvGnaJU1F8FTlgX2xw9svi+WC0j0ZMTPu//?= =?us-ascii?Q?HyWBsRke/OKewwFZNkvbotxPSub2qEGDXosZw3f/6TU6wadbgbjHhF6goV5x?= =?us-ascii?Q?v4fRXdJT+wk8Ep0wmCAbgy4aQsmd0Hd3A9mSaW/0KMMn6HaUUbHEwaWS/GRf?= =?us-ascii?Q?y1BIMiyy3Z54QZrDDAo/+qnZAtsx+zaXkMNw5f8//bSqf7pwvEB+PRFUH8AU?= =?us-ascii?Q?ERwweqBDDDEJIVryeU9nDtof9Vz+ssNe7NA6iluxTHEuhEoikgNrM6kqa4vH?= =?us-ascii?Q?HZmstTyG+/rnuJFaDUS8iDsT2jBiL32YbAdEHqfL8is8T3AYt0aXel+aMpwz?= =?us-ascii?Q?qBQNGKTeCp/FlMox9QBjNjz+le/Uv7/AlTxeH9VH4gd6KcXvVe0n8a5tJXmS?= =?us-ascii?Q?Gm/vNiwvU2CLFXyJxClzIAPek/8kMfm0QZ6Hbj9wVIJrAzGJb7mr9kOKe4F8?= =?us-ascii?Q?hcrc2mIsKDOFTZsJfCLDhL+FDsxXp77CUUPkLKul/Vy6WF92dZOVi1GUvzY7?= =?us-ascii?Q?dDrJ3uAtEB+flbWWbZ4XP+jjKbMknAAUQS2k8V341RQcB0/ZqIxe+I0PteFl?= =?us-ascii?Q?ggmWwktVI9e84W1P3ZJWmKoP7Kya7wiJKRpPnmAGSM1cXoajoF7TDs8RQXIA?= =?us-ascii?Q?P0dOGp5gieCKkb9L34xKWwT6Gbnz51u6KrWERqtesv8p6hrHf+zTwZWbzaqu?= =?us-ascii?Q?cNGg73eZAxeviV6O/e7+6Zb9rPtE8tgB56/vVIlmXG3/dh5JIFg5fSjxNNDh?= =?us-ascii?Q?e0BivceRs6ZxZbc9JQdZWytifayMgVCbxX8B1wUMQkzo0jhX1lhdWqwOvMzS?= =?us-ascii?Q?O0bGriQJpasU4Zq5jeMUA8p5xvN6irTCcO5rrS6Zay4KBX24z8MzzkS9nwk3?= =?us-ascii?Q?Q6VuPp9A30j1grOV/5AhM55hk1O0G588+H9UthsU7OtUz43VaqZbLYHUuDLf?= =?us-ascii?Q?xZnddGLtzgjiR7GuvVtPZLca5Y5UN+GyHUDnW6CkpaHRSaqxQ2h2yptK/EoZ?= =?us-ascii?Q?m7YNFC4l5LoNTz47vBTskaExS01+Arp/fQ7V7KjkijKjxO07zZKzRtTgTfky?= =?us-ascii?Q?vSutW7zHYhKkuHvwf2SvJqtVvSitBeTso0vrP+IW9YgjX1ANwMlFQVXCqzAF?= =?us-ascii?Q?DA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: b46b02fe-9e41-42bb-f76b-08dbc34ad7b6 X-MS-Exchange-CrossTenant-AuthSource: CY8PR11MB7290.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2023 13:24:01.9300 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qOJcqXxthhX+imMwrOw9RU7HIU16m5jOmh8Z03n7qHHsVOXgpG617TxeE9UvaXD7eqRwfxQc5BnzRErEluoMf/0Rg8jjPQTrzh3aL+jX8/Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5289 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Oct 02, 2023 at 02:15:51PM +0100, Ferruh Yigit wrote: > On 10/2/2023 2:01 PM, Bruce Richardson wrote: > > On Mon, Oct 02, 2023 at 12:48:52PM +0000, Shibin Koikkara Reeny wrote: > >> Shared UMEM feature is missing in the af_xdp driver build > >> after the commit 33d66940e9ba ("build: use C11 standard"). > >> > >> Runtime Error log while using Shared UMEM feature: > >> rte_pmd_af_xdp_probe(): Initializing pmd_af_xdp for net_af_xdp0 > >> init_internals(): Shared UMEM feature not available. Check kernel > >> and libbpf version > >> rte_pmd_af_xdp_probe(): Failed to init internals > >> vdev_probe(): failed to initialize net_af_xdp0 device > >> EAL: Bus (vdev) probe failed. > >> > >> Reason for the missing UMEM feature is because the C11 standard > >> doesn't include the GNU compiler extensions typeof and asm, used > >> by the libbpf and libxdp header files. > >> > >> Meson error log: > >> In file included from > >> dpdk/build/meson-private/tmpf74nkhqd/testfile.c:5: > >> /usr/local/include/bpf/xsk.h: In function 'xsk_prod_nb_free': > >> /usr/local/include/bpf/xsk.h:165:26: error: expected ';' before '___p1' > >> 165 | r->cached_cons = libbpf_smp_load_acquire(r->consumer); > >> | ^~~~~~~~~~~~~~~~~~~~~~~ > >> /usr/local/include/bpf/xsk.h:165:26: error: 'asm' undeclared (first use > >> in this function) > >> ... > >> /usr/local/include/bpf/xsk.h:199:9: error: unknown type name 'typeof' > >> 199 | libbpf_smp_store_release(prod->producer, *prod->producer > >> + nb); > >> | ^~~~~~~~~~~~~~~~~~~~~~~~ > >> > >> Fix is to provide alternative keywords by using macros [1]. > >> > >> Fixes: 33d66940e9ba ("build: use C11 standard") > >> > >> [1] https://gcc.gnu.org/onlinedocs/gcc/C-Dialect-Options.html > >> > >> v4: Updated the commit message. > >> v3: Used alternative keywords fix. > >> v2: Added original commit causing the issue. > >> > >> Signed-off-by: Shibin Koikkara Reeny > > > > Reviewed-by: Bruce Richardson > > > > I already merged the v3, and updated the commit log while merging, > can you please check the next-net [1] if the commit log is good as it is? > > [1] > https://git.dpdk.org/next/dpdk-next-net/commit/?id=a499de2602df505e0313ae468817863b29f2311e > LGTM anyway.