From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E75D4318A; Tue, 17 Oct 2023 14:28:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 348ED40273; Tue, 17 Oct 2023 14:28:15 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mails.dpdk.org (Postfix) with ESMTP id 0DEBA40270 for ; Tue, 17 Oct 2023 14:28:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697545693; x=1729081693; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=VE0O56EbwAiOWYEjyiqk7fko0EcGMiMqSVzGG0p5VS8=; b=Qgrv7arGD4jPcbZqZC855wdOPyT/1ic5I8tHICCknju4ZL3s0nHKYfWD 0XRLRjKbUokJiDCGw1+eaQ6zDNjdtFkTAkv3LR0TCQUjVItF/WjEA27xS tS4tAUXYtEnVSlQ0JFq0kZyJGMQ90SaPvdpxxETbnkr03lxIM0mWIDEro xipQsVDEiItTRYNAy3Ju4v8UonB4JaeRTTs+XQmkxrcSgGRdoqmcxM1I8 KqfU0vAdxhwoxcocGwxwXjvqj/mTSN2//RkDc+g2LjMTd9VpT+OG9dcgA PRvhPt6RP1JPWheIk0jujyPKAfyHu/la9SirW5e+hdL1ic1JvDcb04jQT w==; X-IronPort-AV: E=McAfee;i="6600,9927,10865"; a="7327882" X-IronPort-AV: E=Sophos;i="6.03,232,1694761200"; d="scan'208";a="7327882" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2023 05:28:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10865"; a="821964023" X-IronPort-AV: E=Sophos;i="6.03,232,1694761200"; d="scan'208";a="821964023" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 17 Oct 2023 05:28:11 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 17 Oct 2023 05:28:11 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 17 Oct 2023 05:28:10 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Tue, 17 Oct 2023 05:28:10 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Tue, 17 Oct 2023 05:28:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LtGsquD+pvgLMHV5JoegzYEZhQHwe9Wcl8bibkti4qchUTR3IOtlphLxAn7862DlTDkoKCPPl6bd7c+dlkC8Db34K+niGMwc7ha0vSruLfR7WbIU+AW6sSRP2Db+yxZo1Cbe+KGkdmYb5tJhAcDiw8gfLa+vQBUr1mbjRIvD5L337S+5oPIR4pWTZP2aET2RSmjvOl2Rs+bMLukyiJvF4oeL3xPrE+3EDmIsFn53MulZLaGiTBpRySgVqlk6f8i8uMwUSIdVZpqTh+h89MJo0aCL1Kaj893Mmkoc7T7jODjB7nis5bknixc+6lq5eeUtIPeEk5YrOs3Au+un080bQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ICL+pjWHn7qWLBlnF3D2j3xA1QLMcAErEjKO1J3qKow=; b=U26yvNFNtUEQiiqzOyCU6yyokt8NiiACPD9///6Jo/YckR/XVlEctJ7BBen8LCNB8jSQZkUFJ4MRz20UFU1gCWCEVEcQrH3wynXCdG9WR4RktkTafk/l6YN31X/JTPKlGwmzxHQCcbPRkat6zkvQ9bFi4+maUSEM25g5RXyr7TodDGZvD7DYbvkn0EdVn0TkFHlj5a5hWGlYJ+W52E4UaGqxL8yphyIU7w/maDp3aaf6jQCnBTUPGNOdUDx1/NWFcyzL7P8GYl8mnJ8Gve430ErW4aLzINnyjLt6OM3FH1lc4tVXVUixt4NiZPan0qm/ztfgIH/1LdxTwWpKT9lt/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CY5PR11MB6114.namprd11.prod.outlook.com (2603:10b6:930:2d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.36; Tue, 17 Oct 2023 12:28:09 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::68fb:c3f4:75e7:5fb5]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::68fb:c3f4:75e7:5fb5%4]) with mapi id 15.20.6886.034; Tue, 17 Oct 2023 12:28:09 +0000 Date: Tue, 17 Oct 2023 13:28:05 +0100 From: Bruce Richardson To: Aaron Conole CC: , , , "Michael Santana" Subject: Re: [PATCH v4 3/7] ci: allow use of DPDK tools when building examples Message-ID: References: <20230802170052.955323-1-bruce.richardson@intel.com> <20231016140612.664853-1-bruce.richardson@intel.com> <20231016140612.664853-4-bruce.richardson@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DB8PR03CA0035.eurprd03.prod.outlook.com (2603:10a6:10:be::48) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CY5PR11MB6114:EE_ X-MS-Office365-Filtering-Correlation-Id: 2e1e8772-c9d9-41d2-d410-08dbcf0c85a8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5hQ4lilXwBke4s8FYQmJoedQCUDWBNufg9Ec9O998gl9Pz+OkDQKPKBS/m5pR+9e7yr1nfXhiyHkz7bkuCLmsw/C/HCSoyb7tBnA3o59GMcUWUJdRIqRNQCAFCN79UT0laNaIl2j1vAoD+X6WUmKtWJo7fiWp+edjb20sXtVkZmT8fdziRSKMaRrMrJUjUQW0lcv1AXK6s53UCoVIGQZqEtxRXFPQqEzruBqz3MwWMFmiswWqIv8MLKKoHCUPuCgZJnPPrEgrICMr7Fk9b5mpJ8MswmgrrxuASILOaft+GzT1nWTCQcZHU1yihPIvITT+xGH1LIW7CN+XBgJHrdXUOYC+WHhuYzKjVo4ec3tenTFuvXUy6N6LKY8HJxpV0/pIAodnMjvF2GtLqyuyytaiDc1ovhU4LawhuKlSaEZGhf9UUrXqbD+DdoxqRqRfi/CTIaKc5qoPMPsOl6fFmKx5L9fgqV3ce8Hy3MRrywk8oD4V1MYbTFm1grjTphPSiXhZNjmvfBCkJ3I6dYlcbTogsGPRvqx63zWTsQr5tspPh9ZwNmXGe1UfK+oIXbzv5z/ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(396003)(366004)(376002)(136003)(346002)(230922051799003)(1800799009)(64100799003)(451199024)(186009)(6916009)(66946007)(478600001)(66476007)(66556008)(6486002)(6666004)(26005)(316002)(41300700001)(82960400001)(6512007)(6506007)(4326008)(8676002)(8936002)(2906002)(44832011)(5660300002)(86362001)(83380400001)(38100700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zJEg0jzjC5SbGyolqu3WX/XITFvRFNjG0nYWrXtC4cITaU5mTxFtNo+J3u4x?= =?us-ascii?Q?UKqUmSjyAChm2wxHj5I5SngDHyr5/maDeHCAQ/LsrjeuKh5BdrGKXwQ0b63H?= =?us-ascii?Q?/jmBY0Jb6BubJ1e4NJbbZbleU+pGik/M9Io+beeMTI1ktl5mdl+Zi7ebNb6Y?= =?us-ascii?Q?eSnbI9secildP1gRRNf/vI3tm6Paqs1TKRFHQekRZiz+5Z9wkcw9PgJY+8Sn?= =?us-ascii?Q?zUXEMxy5fIWVOck6G9QjEDkJFGw/sHZCC7sWN+LEw5SzSOq5nWcwzqCpWbSA?= =?us-ascii?Q?0oPlIjYw6E1z6GJbOwfNniL2FcHDZFzQeqmQQfztYKJElDqhCiXTMTh9GwLj?= =?us-ascii?Q?gJ123QTK1IJW/IeR8h1p2MMZuMaRlFoqT+nm3kcXy8MkvE3dA2vTirKmJxh1?= =?us-ascii?Q?XXxAXIiJWmLAFiiaUQdeVGvcPhft/kaI+nGpuc/5b7KT0d9OqRITkPXq3gx6?= =?us-ascii?Q?A2zhK+L4l3EFJk5Nfl/yKTeDH9BQ3RyiM8b9blR0HoD4UyTjGKC26vWo3ZQI?= =?us-ascii?Q?NRoW47FepyDj77K1VKkewcV947vzUo+qTAHLL+ivYoOP6cKJ8TQB7GUwynRU?= =?us-ascii?Q?1/sS4hb8Z+bt8rklHdc+IdYDu9VsR66omHREeRi1XQCDOrolds4AjMBFffUX?= =?us-ascii?Q?i5uB39Zycpu09bidTW5hqW/5FACjwi8VbldSqjatDeSCCso9TAkzIbPtLTpB?= =?us-ascii?Q?3sYkDtU6cdU0SlgvXpXg56qoZEmp11YOgXKKrnmHovbRrZvFq7zXzKYyPYN8?= =?us-ascii?Q?K16o5wOVj8QUqbnXmHyhZ/skV7LBTVpF5q96qKRZf9f4ujgjJ/4q7Uh8NwiY?= =?us-ascii?Q?M7wk5GaaWIXo/uXdP1d5rc6e4SBdVwUNCp+hpJV6j07/l2Mjx4LqI7a8nT8T?= =?us-ascii?Q?vAxpTV9TmkxiBwo6/u4vTQGuDNqhKWzo9/SgL+f7U3TTabVlyfIToZVAQQJp?= =?us-ascii?Q?/aFIboxRWbpqOIKAnbrx0aQ9JCmVuATlj7RgHOKyo0+dsWxSHs/KDRKcvqH6?= =?us-ascii?Q?tgAtj9dHsAUafCUXht5vjzQ9wIMqG0QKxiuxVThPHmHiBdZpChMuXhRJWTz3?= =?us-ascii?Q?WAW8wtn9xX2vo3mQw26fz5rhx0Ypie9ChfmCCmTm137C9sPg6x28gtLvCydD?= =?us-ascii?Q?XuZ92wgSKMo+q/ynoV+bV2IJwO2LNReC/lYkIfUBXI+NVjurov4oCCC1t1vz?= =?us-ascii?Q?XexJqjLvyZRQqdbpkIT+80QMGW/6BIsYIUkdLPqAGSbgrd8ExYMDmUvYM315?= =?us-ascii?Q?x64fzN07iylMJUxyAPJRLQr38qAcgZtECD5ifqu4xDJ0Xv5SZYdNRj0sv+r1?= =?us-ascii?Q?pvRKlquUq84cNAR85/WtAjbExL3S6B+Xddbg3Np3FH6LUWlBIs+TTi0chD7J?= =?us-ascii?Q?RgwGRdckQMyeCYzcNf3AsUwsOitwLEsujgR8Vrygo2qMNjstqarSaP9v1sFV?= =?us-ascii?Q?z+ifVjRvw1k/09v5RViJbj1UdPUe+okejN/5OP9nj3srfKJTXbEIWP25G353?= =?us-ascii?Q?Sub/r5OomFwjMppjrffddZse0r/TC9hRDwaiME5khnu4yPH/vDGgbF1s98Oo?= =?us-ascii?Q?y8u36pqkvVJJAI8NXICXF9W0moMLCsDLPHC4sECbfggDxPM9cX+i514K6QlY?= =?us-ascii?Q?kw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2e1e8772-c9d9-41d2-d410-08dbcf0c85a8 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 12:28:09.4184 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4l321J0bxCo8IcW09AOAcP4uQcfxRm6Gun5SgiEyA8eW+UZUoq4WsuCfb2TmoRuzGSaO8tr7ifoW+3TtfyZLhbZtVYvHnfswSKay8TIx6H0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6114 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 17, 2023 at 08:24:36AM -0400, Aaron Conole wrote: > Bruce Richardson writes: > > > To allow use of the DPDK python scripts (installed in $(prefix)/bin) > > from within the makefiles of our examples, we need to export the PATH > > variable with the location of our installed scripts from within our CI > > scripts. This matches what is already done for other paths e.g. the > > PKG_CONFIG_PATH variable. > > > > Signed-off-by: Bruce Richardson > > --- > > I guess this should work, but it's a bit strange that we need to key off > something like dpdk-devbind.py. Not a complaint, just an observation. > Yes, I also find it a bit strange, but I decided to just copy the style used for the other paths which also key off a "known-good" file. As you say, it also works though, which is nice :-) > Maybe a future change would be to update the meson.build to set the > exec_prefix variable - but I guess for now that might be a much bigger > change. But it means we could get the path after setting the pkgconfig > path and then just run something like: > > pkg-config libdpdk --variable=exec_prefix > > and wouldn't need to search for the python utility. > > As I wrote - it's a more involved change, and I don't think it should > hold up this patch. Just something to consider for the future (maybe > Michael or I could look at it) Thanks for the input. /Bruce