From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22F8B431E0; Mon, 23 Oct 2023 11:26:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D5741402EA; Mon, 23 Oct 2023 11:26:21 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 6237340270; Mon, 23 Oct 2023 11:26:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698053180; x=1729589180; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=uDMGuj32nIwttvvLm+0AayS4e0LRTNFlPg9+rWtP21c=; b=Vf7yc21J0IpFoAY4x8GneL3G0ZSMhHHRTD9qsWrjLpIVje14AsfeZG15 Z20OJ9N13NP4mbCFZyJw/q7op4Lyv5Mr2KxC226GBOpIbYMjvaQXK5byX bOTQpk42TrsMLkkOS6H0EB7hp2uvxh0vTjtfSR6fMf3RAAMVRHY0A4f5Q VhG7YPkMw+64VPgIUMhxAmibyrj59XhZLhGaOH2nHLKttXEFgLC7WxvC+ 8yDeqq0w7IVAKQkTurlJELCpppQOKfL9YIQmEHIELAhQTtzggI/q7LRV5 8W+7Nh84KQbfm+dqJbS/JpfN+RjuTx6PzuLToRhL+kB3G7XNdzHRI0cRF A==; X-IronPort-AV: E=McAfee;i="6600,9927,10871"; a="371870760" X-IronPort-AV: E=Sophos;i="6.03,244,1694761200"; d="scan'208";a="371870760" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2023 02:26:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,244,1694761200"; d="scan'208";a="5745437" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 23 Oct 2023 02:25:03 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Mon, 23 Oct 2023 02:26:18 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Mon, 23 Oct 2023 02:26:17 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Mon, 23 Oct 2023 02:26:17 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Mon, 23 Oct 2023 02:26:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Cc/TtoeyvUIRexHEQr3uVUia0OU6DBcjPVoF7G+L9/uToPNIq8619fRkxmtm7fOfHK0Q90i+J3qkCYHdCOZ8Grobs2IP8hmxbC+Wby8Sv16ORiytcutG95ySN5GFQGrqGp78iQ/ouhgXJepgtMT2SivWZYjYeByKroLENypFu5PMnXhhzSmt0tYSlCCpm9BPh9qp0GL//2iSVioDMpfaH1vTELnl/kmpsODO/d7UED50xO1+WOdxqO6u8CkSONEx/fqWoBCIWsal5Lpziy0Flim12v8yuoRWftGrPEvLIoYWajZIRdbRgHky4e4B1wrIG/gG8c9FfpKRWr/pHCWOFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bm67fAPNyYlUbAO4wTLj1MUBmIbMP0cUhGSScNDNLRs=; b=c7qBr8k/582QseqGgUMnvnT3PiEtcrIfIm5K4mwcxYNgCKSPs+dRiqKsrz5m61YbRpaZKRcbrjJU/JfQLhLTp3/jx6Q07iGaX7w9aum1GHOvW+DstPZ/aJluiFkb44qvx39JiLit82hng6I/mYxIzmMIEifLXv8A/AorbOo73phTw12WIzMHgsN0MO8VAh/+oyZTNXjR/dcnFVOyuaRS6YPt3E6qZihO6RESbs8o/f43tR5htFLGincZ9NBveDjZ2msDyZUadIhtRUQ6s8IIBusOFLj4QXRuzUPRZ2TTLjyj/LGT9PCccbAYSzlKwRH209DxO9B0DrGf3nnugjLvCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SN7PR11MB6704.namprd11.prod.outlook.com (2603:10b6:806:267::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.31; Mon, 23 Oct 2023 09:26:09 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::68fb:c3f4:75e7:5fb5]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::68fb:c3f4:75e7:5fb5%4]) with mapi id 15.20.6907.025; Mon, 23 Oct 2023 09:26:08 +0000 Date: Mon, 23 Oct 2023 10:26:03 +0100 From: Bruce Richardson To: Srikanth Yalavarthi CC: Aaron Conole , Igor Russkikh , David Marchand , , , , Subject: Re: [PATCH 1/1] build: update link args and includes for libarchive Message-ID: References: <20231020170135.18319-1-syalavarthi@marvell.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20231020170135.18319-1-syalavarthi@marvell.com> X-ClientProxiedBy: DU2PR04CA0187.eurprd04.prod.outlook.com (2603:10a6:10:28d::12) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SN7PR11MB6704:EE_ X-MS-Office365-Filtering-Correlation-Id: 73932d1b-7f61-49c1-197c-08dbd3aa16c5 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bZOL+tGdyBt6qvuCZMBG9usiFWJAVY8lGX8b3DyebbmlqRyFMS1YhaP2DRZ8gf9FXr8DAxiTx6Ux+jfGdXnLZJUifsbpixJIib9emG71RAGU5/2rccy+nCfCEoDg6GOcdPFiOm/fwb/jZilKyYizxF0Ei3OBPYloPv2zY418ZZZE284TTTdNF0et0+14df6Esbvwmj8+g84Wk5xqcnQqAuQUvYxtCGjuTLWICPAQiF6aZR9K0CKaDLOf0Z9owtFSLmhdlFpQqZkmaOpJeRUomaTkw04kwOds52FzqTT9zMN84EPClm8CLYRG2XI1vpeZl2fMvU+eAWFiSGhQVs30HVkoeime66f0PTuTIi5GbBxhCHNX/ZA1lyVZ2q3qkVL/t0W91PYyG4rDUb6rHFIY7TJCF4et42j4cEudso1AmgNxUY2GFgH0ICm6US4q6b06enNo93NWx2yEargnu/SUhbzhUvuThstFChkFwgPyIUQGJHgFyxmt24gVrkgTLlNMVn9QcsiMyzAqGy1r1hZtFM6a9bjKH3K7pmz2rgBiQWsyKS1u76uzaSIoWnO6CZfj X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(366004)(136003)(376002)(39860400002)(396003)(230922051799003)(451199024)(64100799003)(1800799009)(186009)(2906002)(6916009)(316002)(66476007)(66946007)(66556008)(54906003)(38100700002)(82960400001)(478600001)(6506007)(6666004)(6512007)(6486002)(83380400001)(44832011)(41300700001)(86362001)(5660300002)(4326008)(15650500001)(8936002)(8676002)(26005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2ZBJXZHN0H3UP6wNvQQdS8epmeolQ1vxDZvC3kb0mP0Thuy6dMZ7pz1U4nbt?= =?us-ascii?Q?S4S271lRov2yVsN4BCMhsd9eUJ2R+UUcsBJpVgsHQpaejd5YBJSGgSWaBKI6?= =?us-ascii?Q?90YjQPdk5eiwZBdcslzM2zYtFXu2wW9j5alKoeJ1XWXIovOimSS7dqP/4JMK?= =?us-ascii?Q?UAeMigPSE7OFFgvY7ulzxOq1NAhfmNbDUnImtGHMSIyWADTzcSAjNDaMO+3z?= =?us-ascii?Q?0X+7f88Hr6GAVd+hbWCAFg/5Eo4ebFVyAe3+89VvtEaZWbwM/R4SPjdkG+Ax?= =?us-ascii?Q?xVjH7RDb23AM+/ocSEIFbovHRhN8Wfg6m+y43AOv7ENfP2HMcP8Gnx/U6nLk?= =?us-ascii?Q?oyIKUwyNnvrOLj/rNZ1KHyIQx3Z+L1/pIaxrL57BYuMXhye/P3SgVZ8RdmAn?= =?us-ascii?Q?kj+uFuIR3hy3hWYzSMhZzq7VElb0b8U2BnGvB+qTyHmg56HRUEOqa8pBwZN5?= =?us-ascii?Q?CD/dCNhWstD0jklhzQdKwiewUorP5znUO8yfxI1poanWC82KwE94nBqplj6V?= =?us-ascii?Q?WgXjs9tzXVATKRX3wd/WTncqezsswEb42MMzCvthff9dhUElFR8QJqE5IDEL?= =?us-ascii?Q?3Ya8Sa1tSYNY0y85Qw8CUa8lcwMITNkCgxsVx91PKu7yuI1PAKsynq2CvZQ/?= =?us-ascii?Q?6Zp02mcAj4pr2cr+8hKNnqdYkmN7bQcYFz7SQEsCBotqDEbNvWhiFUafzUC0?= =?us-ascii?Q?icCCRbRlrt9120umGHMR4KlmxVRZ9uVMjnEK5iG4SnuRz4d2qjUfIqGPtayg?= =?us-ascii?Q?HZerkARpKPnT3/uHoHJTlBQMdtU4oPgIOnyzKyGhXQSNSI9iYiu3RC8jVJbQ?= =?us-ascii?Q?Fdub1OWzMbVXu5kkTIXiMvCrMB8d9cttY4Sq13XFjuVQU3b3Y4Cfv+gLG7NN?= =?us-ascii?Q?5L83ansIb2KtUP53dh5gZIK/D1sqpcWoAh0oD7UrKT+M3SfVP4ZtLH1c+rx8?= =?us-ascii?Q?VcCgbaTLOtHKGeOq0sAXQxEgXzfOiMfxY7xunZuHfhtRLitl9pyt+KLrmCyP?= =?us-ascii?Q?0qggRETT99xvu//l5sQ8egrzCaTuaAUOPcuqk+AIe4qRyAdh42y0TiJ/oxit?= =?us-ascii?Q?n6/zJrP+a+XIQPlcNtDq3gsEMzloinJaYDkeIr6C2BNBINBMjkbdeS5XtKx4?= =?us-ascii?Q?FIUfLM30zJ/wEWPi8E+LOMh01d6zygrrh/6MbKwLYpmIaNW/HSi7otI4pwbO?= =?us-ascii?Q?S9UKBI1URlakbjdENG2aycnQ78WC/QwFWBglUrhCIbgGiXT2LY7oUDsgfzyy?= =?us-ascii?Q?sIvM99iTszrl0Y9tcmJj+bONTuAB7ZsthnmZed/ajz2h1gnym3onxS7c/NdA?= =?us-ascii?Q?f3m0xpGSrs4XWdL64uJ1PWQmBWCsAbB4K9Inr6cCiMzqu9FbPzdZ8Ph3oAJE?= =?us-ascii?Q?jskdRsS8bSDBekJMDoZxrmrKYp1lKo2fWMR9AU3fKVekCvqYpQQvsxYwnrwz?= =?us-ascii?Q?GvBVd8MvRdeLN2pIxVuldKHt3c9CwUCFerFTgN7wqVbhLfcA1GSg69OJweaG?= =?us-ascii?Q?FI+ofXfCBD+DBrwTfTViqB7AflE23N692LWddjP8pbcVLzfM/0KDdsuiSApf?= =?us-ascii?Q?7+yennlELx19/rd3j1Jjvt2J6rtddQg77Z3AQWi4RngEig7x3L1/pqUeyiUC?= =?us-ascii?Q?cg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 73932d1b-7f61-49c1-197c-08dbd3aa16c5 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2023 09:26:08.5427 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jhGtayGg+pNR8tg5flmnUMJDTjHrBkyJXqlANZm0PkWpyBDLD/PXZcO8oB5oiU81yih0514d3NSASQnac4/6Zd8LoYGzu9d4igJ8JpVPLZE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6704 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Oct 20, 2023 at 10:01:35AM -0700, Srikanth Yalavarthi wrote: > In order to avoid linking with all libraries listed as > Libs.private in libarchive.pc, libarchive is not added > to ext_deps during meson setup. > > Since libarchive is not added to ext_deps, cross-compilation > or native compilation with libarchive installed in non-standard > location fails with errors related to "cannot find -larchive" > or "archive.h: No such file or directory". In order to fix the > build failures, user is required to define the 'c_args' and > 'c_link_args' with '-I' and '-L'. > > This patch updates meson build files to add libarchive's > includedir and libdir to compiler flags and would not require > setting c_args and c_link_args externally. > > Fixes: 40edb9c0d36b ("eal: handle compressed firmware") > Cc: stable@dpdk.org > > Signed-off-by: Srikanth Yalavarthi > --- Checking back through the mail archives I'm still a little unclear as to what breaks when we try using libarchive as any other package with a pkg-config file? I would have thought the best solution was just to add libarchive as an external dependency, found using pkg-config, to EAL. When we add it as a dependency, rather than using c/ldflags, we should get all this path fixup for free? Can you clarify what breaks when we add libarchive as a libeal dependency only? /Bruce