From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DAF174326D; Thu, 2 Nov 2023 11:24:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C5F5440282; Thu, 2 Nov 2023 11:24:12 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mails.dpdk.org (Postfix) with ESMTP id 0242A40262; Thu, 2 Nov 2023 11:24:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698920651; x=1730456651; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=idEPDlhEJ86wSFGymLsur+nCXrzPuK83mutLrFahKJY=; b=SSZAq4bIWqPcfpuVItlIRRb+dXOBVswk+dHQV7GYHw3sMKwNKmXADTLD ck/HQlI0jFvgAelkmlscv6P2jRls0hAPEXH5qKefGQZp0vY4X366wt4pr EDuz0g3mCfbw0L7hMPoeOBSiPr6Yn52R588gDIRRHA7htHHNQwqNzOWYw ENDMji9GweAxCcbLoqjqAtYjPwX7m4QE+l7XqUsNLHCEyc3BZS+ppcvxv L7t5ViKEloYtWtsfAUQfF7ipt9YC1DQCEtKTrcymbqgLMQShPAZdjG14i QPfg08ze5MdxfILbK9uAT7hZZdtQX8e2m3bJQIF0W/yfuYe5tBAMjb5mS A==; X-IronPort-AV: E=McAfee;i="6600,9927,10881"; a="7320982" X-IronPort-AV: E=Sophos;i="6.03,271,1694761200"; d="scan'208";a="7320982" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2023 03:24:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10881"; a="904971183" X-IronPort-AV: E=Sophos;i="6.03,271,1694761200"; d="scan'208";a="904971183" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 02 Nov 2023 03:24:09 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 2 Nov 2023 03:24:08 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Thu, 2 Nov 2023 03:24:08 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.41) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Thu, 2 Nov 2023 03:24:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hDX4f0wkglGOjxxDnGkIxmMxnxI4/DK05VMGpnyC0gXiL2VGN38YttYAWPqRHGAg/H2W55eMmDMw4iVisAnQmroDwtDC0uDPc/rb16Dtpr8OeHfI4ls4tLcCq2qCyrJhj3jG2AMI8pm2bzbrH2+CElplchamzJzIW2+vrWyPlLrd/J9e13JNkSlj7lyY8E8S6SX1bMrWaxh3rE0LkNh6QuG5bKwSzYl3u6OVb2Kv4N3ZzImtuC2iDkJEk7qyAAFqYIfKFfZfpZ864P3HX64TnV8q3tGisS8HtUHl5a08NnbZTH1sKQv7EUuTSYuIUvVJlFsqTKgP0khJ3NdZKiSu4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/bmq4l2GGXR0j3/dUzNcbwZ8v/NI8CP5auz2LDm88MQ=; b=bqRak3Tkh+GqyyWuAeFU53u/V+jTKSCJ1QQrUkH0+ljSGl9a8xtAmifc3ax3cXloop0oScPXLub7+gKC/PcNzGUThHev1CTZuZo3/+6sn/jh067Lju0aNJc9HSlVvfN8o84N4WtZVWHts3a+zwHA8aQ2VT6RXrYp4QfiIXFySaREIo0ftY/kj0wERBRRr+gJiUPB6QRwx6eOA6OfoGFoFGVfveF1e4Mw0P72gFfGCu5xLxnWf+HlzEtNU0et2qhX+ITAFbREiEdrbTGqPljuXKoqMRnHQhamdQTWjNmm4Y82OCN+Fb4MQdcs03ENEzIMoUy7YrQLiD+xPB9gFpsKxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CY5PR11MB6439.namprd11.prod.outlook.com (2603:10b6:930:34::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.21; Thu, 2 Nov 2023 10:24:01 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d70b:11a0:d28f:ec44]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d70b:11a0:d28f:ec44%6]) with mapi id 15.20.6954.019; Thu, 2 Nov 2023 10:24:01 +0000 Date: Thu, 2 Nov 2023 10:23:54 +0000 From: Bruce Richardson <bruce.richardson@intel.com> To: "Sevincer, Abdullah" <abdullah.sevincer@intel.com> CC: Jerin Jacob <jerinjacobk@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>, "jerinj@marvell.com" <jerinj@marvell.com>, "Chen, Mike Ximing" <mike.ximing.chen@intel.com>, "stable@dpdk.org" <stable@dpdk.org>, "Marchand, David" <david.marchand@redhat.com>, Thomas Monjalon <thomas@monjalon.net>, "Xia, Chenbo" <chenbo.xia@intel.com>, "nipun.gupta@amd.com" <nipun.gupta@amd.com> Subject: Re: [PATCH v3] event/dlb2: fix disable PASID for kernel 6.2 Message-ID: <ZUN4uqRUDkEBIO5P@bricha3-MOBL.ger.corp.intel.com> References: <20230607210050.107944-1-abdullah.sevincer@intel.com> <20231030211244.2516043-1-abdullah.sevincer@intel.com> <CALBAE1P5OmQ90+RsnqVUYjo7SVE6CpPG168aP67NgmFPHhRuNw@mail.gmail.com> <BYAPR11MB315806B04257956B084B1F83E9A0A@BYAPR11MB3158.namprd11.prod.outlook.com> <CALBAE1O43SvXCuNyFU-T46gtE-J_5s4zfvaFC3+_di3eL7V81Q@mail.gmail.com> <ZUE2GxxyZgZuN66O@bricha3-MOBL.ger.corp.intel.com> <CALBAE1Npi0Pr7LD3ZAaJ5J1h0F=pzE1OJbNAoH_tsN_Qq594Jw@mail.gmail.com> <ZUFnJqux75Sqf1SD@bricha3-MOBL.ger.corp.intel.com> <CALBAE1Mm+q9K8ftJKPpSST5danLF7m_XPFOdn89Re06B-PAQjw@mail.gmail.com> <BYAPR11MB31589E16B2385CCD38F3818CE9A7A@BYAPR11MB3158.namprd11.prod.outlook.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <BYAPR11MB31589E16B2385CCD38F3818CE9A7A@BYAPR11MB3158.namprd11.prod.outlook.com> X-ClientProxiedBy: DUZPR01CA0180.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b3::14) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CY5PR11MB6439:EE_ X-MS-Office365-Filtering-Correlation-Id: be0aefec-0077-47a6-046c-08dbdb8dd49c X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VgLhJlnWQG5rStHFsf2bzVqqQWCGQ4PNvU5rKCQuLBFdom6iKal9kVaKAeYFF1yuSK0eQnoDNFiTuoHLKLY91DL2f8NUTfT74OoqmkV2sYQ8pTfg17SphAllwvijJAfbX30h91LBY1aCpbV1wbuSNzfBnIUHLkrhIK62Y2sZ5Y/DvPJFNrsru0zhuyzF8htg2EW3LXW4nPQWbzZ+almRvqn/Z9p7BflzuVTvVmnMgve2jjMULVsZvTovScFXnPaTix0EwTwKdrOK9pfMnfwre3o9dVkkBd3/g+zLMVwidtwwBppJhOdCwi4Fh3yTjouCwKI50Yz/0uFTRhGkuMdxVmLNY0k1FxUgErhVReFdCzh+y8aubk/1qzHAv8whMX+4q3Mewjkumuc6VnBtdpfUxWywDN1asPJDU8LFEStAtQh5ZlZP0vjWVD4rGheZPq+zje8qyMnNFzLT+lAjHz/9FHQX0hlTiMroh0m08/BmyyngsA4kM2u2RmvB9ogFIcXPhxfO2aB0Zugm/XEB13xoUpeG9sPj1SQtuckWjarwGjQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(366004)(39860400002)(376002)(396003)(136003)(230922051799003)(186009)(1800799009)(451199024)(64100799003)(82960400001)(66946007)(316002)(6636002)(54906003)(66556008)(66476007)(26005)(6506007)(478600001)(6666004)(6512007)(6486002)(5660300002)(86362001)(38100700002)(44832011)(2906002)(41300700001)(4326008)(6862004)(8676002)(8936002)(83380400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?J+M4eq88grPJ+IJKZl4I2nf4xpB2xyCsZFAc/PU4QQo7Hgm5AdF+7wAB7nvI?= =?us-ascii?Q?r1hJSKKqKPwHXTsIYwUvb39OEXtxHWALMxyLHIdhF2aazWHqHnEP2ZXmHoT9?= =?us-ascii?Q?GCnr8NR5ciy/p5+VR2K4LBCPnE7bQxNPfukrQLkKucUl13Q1LaThf9bVxOWT?= =?us-ascii?Q?On2e6utsbf5XoWqg6J8D0WRXClZ3QfE6PP+JxV7uOGYnPSg6JuftMXNX2c2y?= =?us-ascii?Q?ci3U+5T1Ngnt3ir2APaUzmHCNj7rLHRz8qjGag1b+dGLPWssZF03qkWYb/ir?= =?us-ascii?Q?3NmbXJ1bEHNchtkoQJ23G76kzolsl86WVEw53eiBoyryr/Q/bojhRL5whnwF?= =?us-ascii?Q?FUE0BaiUPq4qCHvdFbeYvNZHy11NMlx0gj04NUSLc5iHWPtECjIw4DRXw9EU?= =?us-ascii?Q?on628YbK+otLjLz/kDLe2YN7IhdR/hFRx7Dui0n/XuJ2wbWBm0eJ5kIW23gQ?= =?us-ascii?Q?f1rFl6R3xds8+6oicbCSPWB3DSw1I0A8Q8SYYt1JnCrblR9P2hJQWBzpVJ+6?= =?us-ascii?Q?we1CmO1zrvrKyoM9oZ2t38xTO57lgdgu5wIA8f4s1i8TrjLN2vcqP7Ci44li?= =?us-ascii?Q?mWR2sBdCYs9JipLTiRzmxBLtpXvZ3Q3EiktyL0pnrHxbOyrmk4ehpZ8jlxdK?= =?us-ascii?Q?UxG5MMJpusX4V2RULiLWdloRWwZxkNPWpJa+Wttwri6txcp3MBDTp9T2kPUQ?= =?us-ascii?Q?yFeiY1WyUdngRrruIeIL0jXx5w0OMG4iLpm0dRDYFV943+A5sLBBvEO6G4Ik?= =?us-ascii?Q?Dz7KfuWuMe1kjGogHQ6vbolS0+akLKryl6gMET7FNjD2oD5zLmnhuH8qVNIY?= =?us-ascii?Q?zFDcokSMglf1u7B6hcx0WnoF+V8w4ALZ3QT51VlTW85OqQJ0X+tAO6ZwXKS7?= =?us-ascii?Q?vs5vByw1Z74lzFAYKZ9lRQ9sXIiSxDmXdeOmOMOfqMBUYH4nV+n/p+MFbXIm?= =?us-ascii?Q?chYeHRm+OFlhnnjCb+NmyoTkMy3ZHXhKaFFI0QeG8SgzQloCHZtmzY1r7C+W?= =?us-ascii?Q?l7GXuNVXCeDU+nzeZpwlXlheNWicZ5Oyi9H/bkEnqs5k7enMypTA5/r9tdB8?= =?us-ascii?Q?82iHwue3u/Ys6/pGW+kbkIUvAWZu2cdTAxYPPBLQBQ7WjliO1cPuUMsWbaCm?= =?us-ascii?Q?M1ArtjEkx8MBLlQC/rF51PeGjRqnpL16xG4GsOESVDVUQJH7ge+0DQOBMC6u?= =?us-ascii?Q?oekoZ9uv7bd8pgijWonFMc1g4CZPLAiTBVjFSIKxDUJ4kfxi/cVjOr4yWjUU?= =?us-ascii?Q?ToIFm8iksTjf1B0xNqEV51DuFysCR60FlikzHE0s/9c+VtxY0y3Mg/4q0W33?= =?us-ascii?Q?JghHIyxx/lUXwX2RPpM+VL+uXt78S78vdl6xBO8GS/aOe25kDc5HnPFc0x2t?= =?us-ascii?Q?0Hv97tpxxytF+vlAxYk6MqfawjBykF2F3qA77dxA3iwcmBD8l+oEQqiYiwYJ?= =?us-ascii?Q?fsEF1HlgwKeQV6nmdUYc5Nvsu9v6apXIqaeCNqRZntHaVk8FdkpIKLwVf3xO?= =?us-ascii?Q?Inw8GZ+YUnyYE7+fgHS4VXpILsiFBpATJ99wLN7OjBz2xNuFQfVmKqu8lGPz?= =?us-ascii?Q?50CF5T7SSwIgaFdl6PF3/pp9OuqDRP11/xkerMZXlVxPUCXQydHZrsPWxiwn?= =?us-ascii?Q?VA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: be0aefec-0077-47a6-046c-08dbdb8dd49c X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2023 10:24:01.2296 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rnTHSzCy9iGNN6jWgtVCzMeCkGg0wRixO5OmUuYu7CMIP3VleseDronvehK4tfGhBaP5SsIHUDNREgKMXSZdpVgOAmSXi8Ogd9Rxn93XvGA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6439 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Wed, Nov 01, 2023 at 07:05:54PM +0000, Sevincer, Abdullah wrote: > > >++ PCIe maintainers. > > >+I will leave this up to @David Marchand / @Thomas as this patch has common code changes and needs to come via main tree. > > >+Also in this case, The comment was given very early(Back in June 7) for the same. > >+https://patches.dpdk.org/project/dpdk/patch/20230607210050.107944-1-abdullah.sevincer@intel.com/ > > Thanks Jerrin and Bruce for the comments. > I will wait for opinion of PCI maintainers. Thinking on this more, any API for enable/disable pasid would be internal-only, so therefore would not be subject to ABI/API change rules AFAIK. This gives us more freedom to change it as more discovery capabilities become available. Therefore, an initial version of the function can take the offset as parameter, and we can update it without API/ABI concerns later. I was previously worried about trying to get the API correct first time, but for internal functions, we don't need to. WDYT, Jerin, Abdullah. /Bruce