From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED6C543382; Wed, 22 Nov 2023 17:17:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8D1EF4028C; Wed, 22 Nov 2023 17:17:47 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id ACB3640265 for ; Wed, 22 Nov 2023 17:17:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700669865; x=1732205865; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=60aTfwG5sP/w9P2GVSVQvPuAbQ2qugR0igaJQxv52hs=; b=KlKz6D6eYq0NbEEbc51SrHlbVzaQo1WC+hWLyFEBmDzK6OyOSyIpRkP6 5xm9Az6Jfw1BE+paju/mc26PF1eJkXM4SbODebc+WkcZoax3xm+oQcP/S lqgoojuIYuplGbKJCXfY8MFzvJ3sBe6HVlT/C7+KsnfoaOgyX/8dRr1o2 KA7BLfVTWjxJLN/7PGmVmItG7yOU23kHLE2i6hMXAyaNKNXkzZhU3bG2T HtOZ8EQw51s1rUU00SbkscSeus6YViR3+Pulk/W3XJ1AM1XkXZJaCCn/h 7jYiYX65XuxZ3MnqkZujad+ujekRIUQB4Q9tBU+P3PV/4JTIIuD86HuaW Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="456407112" X-IronPort-AV: E=Sophos;i="6.04,219,1695711600"; d="scan'208";a="456407112" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2023 08:17:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="857796931" X-IronPort-AV: E=Sophos;i="6.04,219,1695711600"; d="scan'208";a="857796931" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by FMSMGA003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Nov 2023 08:17:32 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 22 Nov 2023 08:17:32 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Wed, 22 Nov 2023 08:17:32 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Wed, 22 Nov 2023 08:17:32 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ODVCVQT7Y4k7PyekufhLzetOixNK4xPPYIlYyKWS30bm8bicwPgE6bnp37RcC89Rewp+/ecEp8Aqj9HEcG2D54FJBczQ2BEiGqBSrByrvWbNA0USFAv9aVEpIBozLBNfhsuMj9VH7KDy43FEW10xsQ9i3KT/dk4cigOiUiITO+EEXlTuby/Ekx+153Sj1zfn87sL45TuYU3ZN6d73ETOjVo1bdfrA3OncYGPdt1g8pJf1yfDuvnTHPD/I+i9vETEv1sMox2BDGtPIootJ0xBnKCniMKBSwJXR73DqzXX9a9EoMTQ2OC7/xPfrQeSUktnR7EfwtLDm2mSbzYPaM9rdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kAS/j9EPoyVFmVBmGCaOVi6Vcidv9EKklE8NTiI6CZI=; b=DGlrxirUtf7XGsmgk86GlH4i0GA/wUd861/FRcQt0vzNbETuGfHjgbHsuVfzEHTXNlFR/ByblJB//ypoPJsvARaZs7bkHTfdFbMnRtgFzObuz6zw3w7lp2ZxA/hABjGOdzOlF1iJHgLzC+7otLqnAR+r9HOP3VxjwgRDpvPdsbn/5cYANYHyWeZwQRNspv8+0fSbWi7912Gbk6t4R7YbBJDCpTtg6atH/OGb279BHtIjDeN5ZgpHGN3PHQshs0EFUg0/cvlx7cfWNp9q63QNvXbio20XRYzYTYv8Dz9ebM8TnviGHywLJVNh2n1O5xXrg4wE3uqeFFZBKH0vXS9yJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CY8PR11MB7873.namprd11.prod.outlook.com (2603:10b6:930:79::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.28; Wed, 22 Nov 2023 16:17:22 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49%7]) with mapi id 15.20.7002.028; Wed, 22 Nov 2023 16:17:22 +0000 Date: Wed, 22 Nov 2023 16:17:15 +0000 From: Bruce Richardson To: David Marchand CC: , dev , Thomas Monjalon , Luca Boccassi , Stanislaw Kardach Subject: Re: [PATCH] build: riscv is not a valid -march value Message-ID: References: <20231121164903.3982163-1-christian.ehrhardt@canonical.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DUZPR01CA0139.eurprd01.prod.exchangelabs.com (2603:10a6:10:4bd::14) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CY8PR11MB7873:EE_ X-MS-Office365-Filtering-Correlation-Id: c94ca969-7ab4-4e16-60e2-08dbeb7681ad X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SGvnvmSpOo+kVOYkfjKlOoL+PJoUGusP0pcN0BTIcEegEnFmQ1MJsqn3P2zpNSTCUcmxZX9yMTSCUkbaJYcKMEP1QiGqZtWJnccWZEHIUNlETDGoR2xvEj1KDIzbSTRZmgPssbhoc8HwfmmhrNvwc8AHvf3ninC/EDdNB21nw52XawTYkHK/dx1suJKXLjksOnRLxhQLkfJ+BgTWrMV2brAIF9uTdtHrtllLxZpM6lspPwCtyQj4QQqepB5dOteEf8CEW6nesZFBZNQXmmlMS2Qd/Rdd2SJPW3MXEySD3XiAhfyyls76gKzevDX8HswQcTacWPZ1MG8fAYUP8TT/zL229AhCzPc1L0KwY6C9mnrKkPhvKg6leh+7wNqxEU348Xu3KWGBR1+LqIoZo57pcFn+VUbIHUNcT7PhJurHXrEj8NPDj66fAX5nZlTOlVwRKIZ0XsOIJI/VgOnmwqwcvnNn7vsFUPous/PMpNarjigjrxjyF1u8fe5Z3wm8kuAm1g9JB9biz5766DuNjo5iOLwOi+Rplv0iQd22YFG/lS+eOxbP/6faehB0zxFuKp8j X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(136003)(396003)(376002)(39860400002)(366004)(230922051799003)(1800799012)(186009)(64100799003)(451199024)(6916009)(66946007)(66556008)(316002)(66476007)(26005)(54906003)(82960400001)(4326008)(8676002)(8936002)(38100700002)(41300700001)(5660300002)(86362001)(44832011)(2906002)(83380400001)(53546011)(6506007)(6486002)(478600001)(6512007)(6666004); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YWhqSFZJaXllbXZ4ZWVxWHM3YTh2ais5K05tRTFZRjUvVVdoYnFLRWtvU2tj?= =?utf-8?B?UGNGd2tBd2ZCZVRINDhZR2hsWHk5OXhqTkJQa1VSWW14UFJTaGNBeWpIamZP?= =?utf-8?B?SVlEL1QzTXFSUTBldnBQeVNIMkxUR2x1K0NvWnlJNjJsMCsxRkZqZGtNaUps?= =?utf-8?B?ZE9vMTFxa1RPZ3hzZDV6dFE1ZzhvY2k1amMxekJPRjJ0K21SNURoZzJ6S0Fp?= =?utf-8?B?dkN6Rm9aZWlMQUFVU29Eb0lDeVU5cFp5RGV2bzQ4bzI3a2UxQjM5TXlySk5i?= =?utf-8?B?eWV0WVhhS21ndjZWalpnRndEazlmMXlFdG5IcG9xTjAzTGdkSGNpSk5qOEU3?= =?utf-8?B?WTdncFBhZzNINTBROHIyb3NPOFAyQ3FuRkMzRE9BWStnU0ptaXZZT2t6SGpB?= =?utf-8?B?UDJwWlhoNmhYcUM5TGNFTFJCNkVlWTlUOTB4QlFhOHc2dXBYT1h6bUNvait4?= =?utf-8?B?M3BWYXdXYWV5MEFoNGFpcCtZVGN5SnVjVlNsUElaZVY3SUlzV3RmY3FQeHVP?= =?utf-8?B?cDVjdFJOL0FjYnlkVVcySEhUYVoxdDZEckdwMnExM1Q2dFRQWEtKTU1hNkFx?= =?utf-8?B?Q0puVFpYWmdJRW9tVk5LKy9sWWl3VkVYNFVpL0xKbHNqK3h3ako5RDlRVFdV?= =?utf-8?B?eGJPUVEyVHNpS2dxTGVvQzUzRklFVTlFMHMxSThJT2hyRHFUNDdseWQ3THF6?= =?utf-8?B?dTFJMWxvcnZ5S0pTdDZCNkxxMC9hTW5XbnZQaUpXZGtWZm1ybVZIa0ozUDZL?= =?utf-8?B?MFErZW8vZFJwNFlOOTNLT0ZYSUZpNDliRTh1QTBpS24rZ0xXZnN5eWJXWlhV?= =?utf-8?B?c1BqL2NSWjl6eWVuTUJMRFVzWmhaN1pYcmJHL2krbWZVa3pTQ1ZWUURZTlhu?= =?utf-8?B?R1hHTkNIWXcxVmZLYnZOYTQ2M1htL2U3ZTYyL0FhYXMxNFgzTjVVSWRDRGRn?= =?utf-8?B?SWZDYko3aUE0T0RwZitES0ZIZDVHeWk3Qm85bm9LdFExN2lRZnY4Q0syT1Fu?= =?utf-8?B?WHNuU2JmVkdMVWdxNjdlQzNzbFpDSitFbjFmSDM3OFk0cWtoN2E4YWpkbjlO?= =?utf-8?B?NGsxdVlSM1RqM2xXWWErU3JHYzQxMkFMcWFPR0pZQUppN29ZV1VjNEx0SUNI?= =?utf-8?B?R0RUTmpvS01LaDF5NVhtcVAranlvODhEMmt0RVFUc3hnQ1gzT0FmTE1yRTZN?= =?utf-8?B?cnBzUXRxTy9vMDMzc2ZQTDNZRmtVUnd2WXVzV21zRTM2RStJa1pjRG5XT2hR?= =?utf-8?B?akxVNVlMWEpIOFk2b2hvSFVSdEYyL0ptVDFyRExtTUpaSU5RWHFLdkJ5SERQ?= =?utf-8?B?VkhPaDVkZEd6djhRZzNiWDdySHdGbzJVVU1aVXRnZDg5a0dzaE4wTFZnRGkv?= =?utf-8?B?TzA5ZlNWQkpTMXB6a0FMNG5OcDhDRW1lV2JSR2NmR3MwaEdDSktuMXRDZjJ5?= =?utf-8?B?eUxhaHBXWk0waFl0UWxNQ0RVemxUdEw5TWN3UE8rcDkzVWErUkZ6dWpTQi8v?= =?utf-8?B?dDAwNHlRVzA4ZU0rekt1KzhJNEVLbzVzdk9GeWRhVTR2ZHhXQmhLbVMxbUNu?= =?utf-8?B?bi9IQTk5RENlWkRqeDA2cmVGR0YxMjR3K3V6TDh2OVRDQ1ZrcWtMTFB6bEJC?= =?utf-8?B?VHZ4UEJ2dEV5aGZGS0NYb3BHaTNkZFpweGtQYlVZSm1ZVXdoODhJSzNJYnU5?= =?utf-8?B?TlRCdTlXendjK1pLQTRCNnVONXc1dTA3eThJQlkvdGEzNHQ0RWNURFVDS3N1?= =?utf-8?B?WjJ1WHRDbHd4VTVybld2N0t1cHYrQTA1RWM5Q0JoRU1sSXhVaU4rY3BSRjZp?= =?utf-8?B?SkNZWjhwSUhKY0xhdUZ0WXN6WFpGMloxZjNRdW9PUXJ4N1FoRmFpTTViSVZj?= =?utf-8?B?a1NtZDFvWDJTMHVpaldNcXY0THBTbVFicTYrdEhQcnh2TGx4MldkSHpzbnhI?= =?utf-8?B?OHpHdDNSZjF1dWdxcHFrZ2VJaE5lNzJuMitOUXAwdU9lTU5iaEkvazBHS0tV?= =?utf-8?B?bnUwTEVXV014VEVrR1hkUlZKNDVwSlNTQ09tMEZjaFV1WGd3Yk0zUVpybmpn?= =?utf-8?B?QldlM3QzOXBQTXlpcGo5WHU5ZjdRQllTSjJWaktsTUcwd3hvR3VMK2p4N0hQ?= =?utf-8?B?bFRRdy9RVnBSYnhXejFRWFRFZnc2N0YzZnp4eGxQVVBaa0IwbTkrQ2ZKQWY5?= =?utf-8?B?RWc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: c94ca969-7ab4-4e16-60e2-08dbeb7681ad X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2023 16:17:21.9945 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Tnksbl9RW8MFUGH5Y5UxV7eFRgLxQFcdVjLfC4IPTQ+lOQnMLGv+frIh/t+gHLmHtJhypZSY4g5PfQZYFzUM/RfRV651989Wb1QQVAlmAFc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7873 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Nov 22, 2023 at 05:02:56PM +0100, David Marchand wrote: > On Tue, Nov 21, 2023 at 5:49 PM wrote: > > > > From: Christian Ehrhardt > > > > If building riscv natively with -Dplatform=generic config/meson.build > > will select cpu_instruction_set=riscv. > > > > That was fine because config/riscv/meson.build did override it to valid > > values later, but since b7676fcccab4 ("config: verify machine arch > > flag") it will break the build as it tries to test -march=riscv which > > is not a value value. > > > > The generic setting used in most cases is rv64gc, set this here > > as well. > > > > Fixes: b7676fcccab4 ("config: verify machine arch flag") > > Fixes: f22e705ebf12 ("eal/riscv: support RISC-V architecture") > > > > Signed-off-by: Christian Ehrhardt > > --- > > config/meson.build | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/config/meson.build b/config/meson.build > > index d732154731..a9ccd56deb 100644 > > --- a/config/meson.build > > +++ b/config/meson.build > > @@ -152,7 +152,7 @@ if cpu_instruction_set == 'generic' > > elif host_machine.cpu_family().startswith('ppc') > > cpu_instruction_set = 'power8' > > elif host_machine.cpu_family().startswith('riscv') > > - cpu_instruction_set = 'riscv' > > + cpu_instruction_set = 'rv64gc' > > Copying more people. > > This fix is probably the best, so close to the release. > Agreed > > However, I think a more complete fix would be to set this here to generic. > And do the march validation in config/riscv/meson.build in a similar > fashion to ARM. > > Or maybe the validation added in b7676fcccab4 ("config: verify machine > arch flag") should be moved after subdir(arch_subdir). > Bruce, opinion? > Probably the first of these two is best, to do the march validation in the riscv-specific file. However, I've no strong opinions either way. /Bruce > > -- > David Marchand >