From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5553B43382; Wed, 22 Nov 2023 17:49:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4644C410F2; Wed, 22 Nov 2023 17:49:04 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by mails.dpdk.org (Postfix) with ESMTP id 4E3E1410ED for ; Wed, 22 Nov 2023 17:49:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700671743; x=1732207743; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=3Vd2wtrPC4pUnXi9kmQ1PvscqGZcnPrcsh/HvJSdL9s=; b=EF0J8wLZQVeX4g/zDVcf0jC7i2YdAyVQJ21DLcX3hUWE9IWBzQcBwg/g ABfCZqJpNkj3OMcady3qCSLHnIeWMg+FFSeoc63RGzOA6XrBib1JrdKgW O6fRqAkzXocTLOQOscf7tE8dozlluR2AbwdKbys5+xuccp2T2s/QkAUfc 4lXuvpzJRVlhXyLJXH2owBrmEwyEuV/o2kkNth1MzyE5lntmYKMtQD5G7 r6m9eld4lefYLldNyEX3JrQ59Y57K2cc4DSs0zU2WCxfWXAcpVIDlTNYA jY9mQcsrJ5RbsSDmM98eKYBAY6b4tyOAQFiis6BQzqL8oWMCZjxGxIH8+ A==; X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="5232345" X-IronPort-AV: E=Sophos;i="6.04,219,1695711600"; d="scan'208";a="5232345" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2023 08:48:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="1098498135" X-IronPort-AV: E=Sophos;i="6.04,219,1695711600"; d="scan'208";a="1098498135" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Nov 2023 08:48:58 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 22 Nov 2023 08:48:58 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Wed, 22 Nov 2023 08:48:58 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Wed, 22 Nov 2023 08:48:58 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n+s+Dd5HYCx3qwKvuOrRjGNxVCjSxBhn0cSfis7/d2HND+JcbKu4Y3UXrFnxfmgVgt5icIgf3BHDcA2mPMSC/MZvIGj71B8z1lV4Y8VVKqRs+JHQ7+Xzvz/nL66RmuAYXKFJOMKz+RHOEpSCUwM1WL09joKTOGilxgAhBOiSN5ZY2YjNm9mL8nx2J1VkYtxcvsq1vZDqG+zJibdKca68kau8q3SwcMbEglb4QV6Mvt4+ZfupWgm+cL4D8Y8hcXLjgxhmZ8cT63OEu77ksAYzgKJoBU4FZJCJk6LqgP4e2idd3k4njJen5mr+/PTIf4lYp09oTmUpCGOga1ha4C0CZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EvA8HH11gw3sM7QbG4hB7sUh1kWVNKhEE8iu03VrCZk=; b=LADecV1JawfpEh7niXaWerhLlNjiXhp8wmBIHnRDI5XPXsyWTTLBgF0hD9/7Byfi4M9yNiNTimVZaScS3rzRlOrY8SZGyFWvH+MSemzJSxgIiGc3fK1647XC8h5XH/Pp1EtH7I+Q2yc6g3jiE0X7vSIVFcpqfGNIe83F1KSEK4a8r3cw9ZqTSCvRSJ0/9m0VWARQcLS1UFRgjFlb5lMNiBcqwJ0sY0NwOJVhHE5aUdNKv/3EIJSH4N90QMB1soZmNWZ8DpB9WwBRammXK4GmxahX3rfezhEkDp0aj1htYuNVaqv5c/zRxfubkhwzqMZmfv72MiYIDhR4hZxdDDPpTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MW3PR11MB4697.namprd11.prod.outlook.com (2603:10b6:303:2c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.18; Wed, 22 Nov 2023 16:48:56 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49%7]) with mapi id 15.20.7002.028; Wed, 22 Nov 2023 16:48:56 +0000 Date: Wed, 22 Nov 2023 16:48:50 +0000 From: Bruce Richardson To: Srikanth Yalavarthi CC: Prince Takkar , , , , Subject: Re: [PATCH 1/1] ml/cnxk: fix name of TVM model with single layer Message-ID: References: <20231122163640.615-1-syalavarthi@marvell.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20231122163640.615-1-syalavarthi@marvell.com> X-ClientProxiedBy: DU7PR01CA0042.eurprd01.prod.exchangelabs.com (2603:10a6:10:50e::26) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MW3PR11MB4697:EE_ X-MS-Office365-Filtering-Correlation-Id: bca6c389-8a70-4530-1f9a-08dbeb7aeaf1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: k1KlqhH0VVYLLF9oFFePnOh5zlXWIsSEOnlX7imFGtIqp9mzPFS8jWetRRby/3fR6oTYTAk6FKTYR/qmsJCZUCsvjq8heRwiT0mMMo+Q0ck+A34aIaUEXDjzgeyerNQrRk1vmy1LRqJYhtIrKziUe0PDb21QtJSla9OlJnbtsgptBglo1iQnEP/SjsYuGmUpkcYZi+46wP2H8542EuadjsCJsH2X58kSGwfdrwLsUI3idk5z+wXhmT34XLe78rncANGjjrbt4D5KxrUX6UZiJ3etBWHDiQ5lKu5ng5KR0FUe4S5F64bV40OKVrvx/iUdeYc0dUhOiq9Ao8OpTu2LlNDtbr4KPpXYW42qekM05s0eJq/jv77d2g3wfOn+fPLIHqzIwHnq59oBmAKi8G686Vz/MWdHZmESS1TjPLHh4780ixOFnCSiO/JwUNDsIUs1gTPaHAepVLLheAasBfJVCY2QyC1x1cBR6rWNMVpHR+8VrBklY5om6Lmbv/mG8FBPBuRnOXSlUI9/yfVtJLZQ62PkJj8/Rab4IzwH44VrRO3R5rX1uMXMPB3og85B+Qcn X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(396003)(39860400002)(136003)(346002)(376002)(230922051799003)(1800799012)(186009)(64100799003)(451199024)(6506007)(83380400001)(38100700002)(26005)(82960400001)(6512007)(66946007)(6486002)(6666004)(478600001)(316002)(6916009)(66556008)(66476007)(86362001)(44832011)(5660300002)(2906002)(4326008)(8936002)(8676002)(41300700001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8TdgcWQqmS8H5p/luJN/BCBmB84IZSnOH0k68KitZD4ym0WNU4tSxk37m5gn?= =?us-ascii?Q?0+NowDJ7AouEjNR7LlJllzgi2PqGtIV8TUSpgrvxCdxqz+NBLRFgB4VyVDgF?= =?us-ascii?Q?P4vfhYwqYgPbEmjeVNTlEONuc6ceQJSLn3a3stvau1omWHNcbKZmNi8Rme+z?= =?us-ascii?Q?sl0uCzl3KJ5Ro/yZ8Ia7OWp6GBw1mSuCl82swCeGxKpVBXy4ubK/l4zcvUEp?= =?us-ascii?Q?HOyMhX5UHsHGEyp7DY72CJ0hWJlD52UjF59+Fgyx6mYZzjxgpx0uJufUCvGz?= =?us-ascii?Q?1wF3sl6XOCEAx2BTPSb/X75pVu2RYUNeE94kW4NoCY+ydp9D6sQG9klcGEhz?= =?us-ascii?Q?ttT3jizF+5ZCwZgPDHfJDaLuIb6P/oUVVuHoo6v1mO8X7SXg4ElPpdJb7E5z?= =?us-ascii?Q?wGAVU7GWkNEvJcJY6c788r/bXxyv6r3JaeZeuk08YjyN/ELZeBkQvuAM8BW3?= =?us-ascii?Q?b4cTAyAQ53bm96xYEPe330Iv7hiAVCBGA8wXhsROZNI2j2gtArHpfC8I2kiI?= =?us-ascii?Q?lgoOnDyazyYIeoGbkQq+WZE4x9TKLlRddVNu0iFIQpCwqEhMvYSoic4x8N+F?= =?us-ascii?Q?SEyW0k4sIrv27fMaWleOdHjDeXQ0kmELfnTbcyMe31G4sus4a0fi+OXHQT2B?= =?us-ascii?Q?5e+eKkHf+fPV3pgaWiTX/MFJJBCc0MdJ6Ng2gyTdaDNzRf5nXt7qsby1Qhuy?= =?us-ascii?Q?U4XW67EMn+9nV9c9SPQOeurgiCtAwAjVS3xPCvknExmOf3K7kpDRh5kN9OAo?= =?us-ascii?Q?U8J2SQv7kmOWezTp8cfeHvlH3jHPVGjwdtncUHTtcw032g2VwIG4/AsTgLgd?= =?us-ascii?Q?5oj7iqGBHl7J09Kv6OFkfas3bpESoi+axahT5Sb9UjmGGNSlFJ3Rbt5CsW6V?= =?us-ascii?Q?bOLJ/UbV4Gi66w8jUhIif5mCoyaGmT/NZbxB6PbkJKNogUSTafoKL9s5MFys?= =?us-ascii?Q?peP0QSrurSW+0Ac3Uhi81WEYDS949ZVyMh28tPVSW5Z7oXi8n0EgvERLmpAH?= =?us-ascii?Q?xyZo/VdKyQWK1rWaOaXPiLoMfgKoyWBly676aTB4smH/mnRIZ9r3Rh62JNV3?= =?us-ascii?Q?rXm75AqCZ/CAFVeePkF0Unkvfa9dpYbLkUwrwfN7FnzsXylGTVsYGtNzBewW?= =?us-ascii?Q?DzRn3+MfzOz5jfszwcbhXyAgDmR49fnwvOYxpdtRNoSVgfGpmGedciGv8Zvk?= =?us-ascii?Q?0caaYEQ5KCVvpP7jFeCKrvYwdYSD0Q7XpwJDuZRa+AxovtIeuXZnt8rMxfel?= =?us-ascii?Q?pafT6trFX+dS8irwAqQx/HIh3Em/T8NdYtDVPrPTH5xIFgM4tiLBHClVsPzh?= =?us-ascii?Q?wqYNMjuQBMlk2Zu6zkQ7zTYrGGf2hXIoQsVSG7BShi9E30nwKoHikjHe9C/O?= =?us-ascii?Q?rsXzLHl8RYfNkGZ0utMrnLo9zxqwq93poGaapBhkhTL9GFdqiHG/C4SE0Ejz?= =?us-ascii?Q?boVQ70b/wq1OoPkrPClc/L/FewsOwbBKgeAF8Wbq75F59UzEHubuVokfWAYt?= =?us-ascii?Q?MoGqDeUkEQS8gCvLYqhrgP4kTCKyEk/JdOvRUvjwtzy32BrJ8PL1NbjoFm5a?= =?us-ascii?Q?L55brI1u8UvAJu0XS3BCnNnUAdv7ijurF45LTSFW972i2FLwoPcnuCPcSkZX?= =?us-ascii?Q?AQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: bca6c389-8a70-4530-1f9a-08dbeb7aeaf1 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2023 16:48:56.4372 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tw5GCYNsTjoPwpu7rO7JcDxBA/8e0xAJlgUf3PAW+8QA2C1I2AcOKTDkb9sNcdr+8NnOxw/1xUXd5LKTbDbTguzntOGdpcm0P4P2j1u+OJc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4697 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Nov 22, 2023 at 08:36:40AM -0800, Srikanth Yalavarthi wrote: > Name field of TVM model with single MRVL layer is > currently set to empty string. Update the name with > the field from metadata. > > Fixes: 5cea2c67edfc ("ml/cnxk: update internal TVM model info structure") > > Signed-off-by: Srikanth Yalavarthi > --- > drivers/ml/cnxk/mvtvm_ml_model.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/ml/cnxk/mvtvm_ml_model.c b/drivers/ml/cnxk/mvtvm_ml_model.c > index 3e06ea658bb..102d30e5f4f 100644 > --- a/drivers/ml/cnxk/mvtvm_ml_model.c > +++ b/drivers/ml/cnxk/mvtvm_ml_model.c > @@ -352,6 +352,10 @@ mvtvm_ml_model_info_set(struct cnxk_ml_dev *cnxk_mldev, struct cnxk_ml_model *mo > tvm_mrvl_model: > cn10k_ml_model_info_set(cnxk_mldev, model, &model->mvtvm.info, > &model->layer[0].glow.metadata); > + > + metadata = &model->mvtvm.metadata; > + rte_memcpy(info->name, metadata->model.name, TVMDP_NAME_STRLEN); > + Minor nit, but you probably don't need a high-performance copy here, so I'd recommend using regular memcpy rather than rte_memcpy. /Bruce