From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DD11F4339E; Wed, 22 Nov 2023 17:50:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C89F4410F2; Wed, 22 Nov 2023 17:50:44 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mails.dpdk.org (Postfix) with ESMTP id 6A16F410ED for ; Wed, 22 Nov 2023 17:50:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700671843; x=1732207843; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=/fPKXbTVW4oZCpWXI9TRhTxiReiA5roSO454qeNvIus=; b=mxXVupyq/ucmeXyj2r2K9hCrOJEnHJJlvmWRLsgZDGFfWckU+J41BfGC q8dz7wk5lqcF3W8YjLs7wX2vTdsnpOl0t3rnXaU/FOTJ5DbwuygQThS3r 2+iWNS9tAVj4MBvlM836HziJkq24aTS+uA8XMPpVG5Ij1KV1M+LXuTgbw 69SR+ZQBVsj+x3jMKgGDd0pXoQp5KNkFNicuhit3BjwfyzvurE9V1T5l7 uErfzJv3to8BTh4r1A+uGoTxVnH0Q+YahC/wlfqkIL3eNufbFAaY4jF8E BjruQhWHSJxz/5ueg1j/iUFQIrwR+J5aDTVAPE3Dz8SlxASbmE+UVnlvx w==; X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="13637275" X-IronPort-AV: E=Sophos;i="6.04,219,1695711600"; d="scan'208";a="13637275" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2023 08:50:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,219,1695711600"; d="scan'208";a="14998008" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Nov 2023 08:50:40 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 22 Nov 2023 08:50:38 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 22 Nov 2023 08:50:38 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Wed, 22 Nov 2023 08:50:38 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Wed, 22 Nov 2023 08:50:37 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bcp+Wf6DeMvfLB6r3XIUIGkZDahn6hMo1oBkJTKQwu7Zmi9mWsOnDsVRn76+0OE6bo19O7tIdW7gz6ta3i64ohZTgQy9Gidh1Y4H8hV+DwsFu7K7tgUm82htY+GnSw1wG9CRWinpg7E2af7OiWCoZfgzGxn8I2WxXrvbW/3Pm3ebfSLNT7JhwQIriPG80TtbTAN3nzKbZ8I/zQZtmin/fDd0Fw+HaIr9D38w99hirTbzykZ7Ys5/SqA9IKgJcSZ7wlP6NFwJLqvWO1OVVal8YulpFDax9v/RuxLXLlhbVa0GNKpLp2yeRZlqHV0LUp5H/ObYbOLVdG8/RcaEYIi49w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b9hHFooXB+kCR6pY7czTR1U5uDhEp1sZwOtL31xlQQY=; b=Ass0j4/pT0xQrptxKYS0fmRxtAA3azrNJOaO9Nw82pZFf12Azgk/yfCAr+YOtnhR/330o15PR6gw22L4izetFIGaYDEs5l19wnpEIXWZsvRU0U/bq4yR9idVvt3CRYHVK0f3q5jO8cWUKmQPr7wWXuh0HLUoHFbGCVMOzgpkzyHGDOo0h0rLnXSLHynrOfgFC4xdv5V6i7sL+xpbBoXYNRMcS3yi0P39sdAkV+bsD2dD6+jD5od3kLXh0C0+1cOGWCx2hF1Dxg33wXUSrKd3z+4uGWY+M29pSvwTKZSSU67JuyKg1YuOOks8Nbc0FKmlfmliWlW23QKX5JbKqZO+nw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DS0PR11MB8162.namprd11.prod.outlook.com (2603:10b6:8:166::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.19; Wed, 22 Nov 2023 16:50:35 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49%7]) with mapi id 15.20.7002.028; Wed, 22 Nov 2023 16:50:35 +0000 Date: Wed, 22 Nov 2023 16:50:30 +0000 From: Bruce Richardson To: Srikanth Yalavarthi CC: Prince Takkar , , , , Subject: Re: [PATCH 1/1] ml/cnxk: fix name of TVM model with single layer Message-ID: References: <20231122163640.615-1-syalavarthi@marvell.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DB8P191CA0009.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::19) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DS0PR11MB8162:EE_ X-MS-Office365-Filtering-Correlation-Id: 4540ee6a-6feb-4961-edb9-08dbeb7b2618 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 171CJW7A4tcazb3oAt3sQFuH0JZebtgvs9vpVsVBqxqjdzA/p5BlNwO9AMx3iNawPbH6mGsRSynCwMXm7UQANtUmshxUGqzE9gJ+TgC1WoG2XuT8KYuGx1EaenWe7B9KlJfSZFufjkUX8dg5nB/3F19yEbObkHQ6XIlVGrPmaba/zWG/Pr3lcgS6wr1yVb9tF8sdKO2tJhvaNW4DXnjVZjvINM09Cx2i2BonVZm1kJILMOgzsbkqYy1VsQVlOv1vtmjjheTQHmZh3E3ZSz1Dw1fcLUn2oZXByfU5OIeu8oVWt80kwxSijHDC7NBit4fXzafok9L7gcJgtwwMwBaWQTX0S954IF1R8NwgX/PdDUdFsUaRkjOwUgCMwZrrjgpP/+zVMUg9P5FktONXthLEgSOOIpotubqbLIfqmD1UuO4wJek+Qp1Pdx5N3e54T4FJ/pbu8GRFCfkQ6bjB/HZeU7Ey8qJbAaak/GBQ79Y4dn3YUL11hZwp2D7zC8iXIVCWoMd+iy/gmuptSujrB7VeiMo/orjnsHmNWNmQzmwDClMACgbZfvHNiD+YidVGG4oD X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(346002)(396003)(376002)(366004)(39860400002)(230922051799003)(1800799012)(64100799003)(186009)(451199024)(66556008)(66476007)(66946007)(38100700002)(82960400001)(86362001)(6512007)(26005)(6506007)(83380400001)(6666004)(6486002)(2906002)(316002)(6916009)(478600001)(5660300002)(44832011)(8676002)(41300700001)(8936002)(4326008); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SERUAHP7KSMzitcve2WYPGj7rbHUFUea6fFU3dYa2LmoC5CwC52E6PpuIaCw?= =?us-ascii?Q?tD1JUvvaGrQh/eY1hNKa17o3Br41Fq8/YocSkVCKCFfQ6Rz52MKBxrdG4TRu?= =?us-ascii?Q?CDhTMrfVTM7Xm/OE8JzQiJP+jjo2F9kWbw3F3+264a2EiCCjLo29pMaR7uiM?= =?us-ascii?Q?t4BxmKlnTF1srm9V3nz5bPJypGc5sFHjcf2ovW8iw9RdvDQaK5vkDVLxUtBR?= =?us-ascii?Q?jS+w3SqT6Y0ImrNXlXVhNNt4ZDYCgOYEhOG2vtKgXc0Mnc5wc7pngFyZ58bs?= =?us-ascii?Q?Y1+hHOkSC71N2yb5CKIWViNY2+EDo8EZaUhIeFwMv1geQXZ7hUPer7gA1hNO?= =?us-ascii?Q?7eTYvidISFwbJqdeSsM9qLjPXxGIyU5HSNu5kakc3KYVId78mYaR4hmXj9nt?= =?us-ascii?Q?h9HKnBq5teAyZSBkoJ5yCypSBF06+Vgg1H1XSxQVUr9W+u4G3MPSgMTBPGX3?= =?us-ascii?Q?BlpdqcImdzpknQ/dlF71czSp8sHWJ/plBVLRYzwM/03hscz5iwxMUwts6Wun?= =?us-ascii?Q?0L8otnw2K4NmdwWA5N2maN4mbaiJaEjngE80bSHWKJK+ykTkS3Y+KLLSsUKU?= =?us-ascii?Q?xlcPUKodyMYa/xZBpYoGF2/LLj4JXCTa3Bpmn67vLiQT1kJWedes9e3bEQT8?= =?us-ascii?Q?peC3wx/7Oc76bCgDpNGNRyS2NWjnFJAzBjnXCE/51WrjldJH2N5mdeMxdRSr?= =?us-ascii?Q?gXN+p9jyEmdpYXx3ECBbVc3BO0aNaHXfe3aiA9UBYAJLc2rY6QFmpMJZId/A?= =?us-ascii?Q?8dh81ABHG6hJ5mkxv6r7vXhN+KbeWhAu0eVzUDcmj7ct1xlC41LPRWRVS8Q5?= =?us-ascii?Q?/40EqXOTCnC/YDlGopaCveZmN6f2bvn/IeibsSB6cY3RA0a6fOU9vBQSepGQ?= =?us-ascii?Q?C4WfXDUnW12a1iI0aLiSjumVK/D3VeujGqR5REI2S3BClsq0peF9Lba7AJZw?= =?us-ascii?Q?J+2aQOSoSO9papuBZKWobU14qIZJF7WnyEds0hkMqsEkCyucXPhp/60xHrJq?= =?us-ascii?Q?r2/BWDznAaQ7MSZgvWHRZ2Jqm9Xt0e3393wK7cKnU+lFxePREvZPBbxmMK9I?= =?us-ascii?Q?w+kXqe5gdsBNciPf2TpGmMAKKfl8NqTBboo4/Lil8y2lq94czrKuYsP15FZv?= =?us-ascii?Q?rGpgfUMlLV4m8Bjjp1796kJypYwoGh3Z+rYsLOT91VLgIkMjUCfue5JwKsvz?= =?us-ascii?Q?MQytzP1+GuqxUeroWTQvg5D3dHhP+dKnqciYC5Lm4ktiIOfVQXw0358EiQvp?= =?us-ascii?Q?mx0L1+DnzEFMSd0cwwm+MWYas4jr6k8jGm3V+UWkawKSS3jr2/eC/D0cTfaW?= =?us-ascii?Q?Il2mdJfDKkkN4SwpGisHYdKlxLpRkey0f9ecnDkem1lJLjcTte+Wt8DNhfT8?= =?us-ascii?Q?Z4h6a5b/X1CzjXS2AQ3wAMW4/YyBvs4Thzbm0tT0PkYzPdHEciRXxCPRjm1G?= =?us-ascii?Q?nzT3FcIlwL3N4baTcb5+ke8XTmvTYTVhY/mwDVO09F+f/cUno4hlvY6JckbS?= =?us-ascii?Q?dkcGr7ejd1s/dMeq7uqJvYCYESCsKfwZAG2OU7VNOQbypAXkkHrwMg6SwMOt?= =?us-ascii?Q?OLMQQ4vEutwaJrugJtdHePmNMz2IrGzmZe5XeDzmFyiePq3N2EQqE6STOrf6?= =?us-ascii?Q?Vg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4540ee6a-6feb-4961-edb9-08dbeb7b2618 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2023 16:50:35.7889 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1KTagrYiaOl+gVLuW4N0bCciJCbYkNJAfDhJFPM3F/UJqUiU51URposP0ADm0m+T0710Zh4pIX4hIlx6ioP2P9s1XGQOKEnYCHluNBj2YGc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8162 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Nov 22, 2023 at 04:48:50PM +0000, Bruce Richardson wrote: > On Wed, Nov 22, 2023 at 08:36:40AM -0800, Srikanth Yalavarthi wrote: > > Name field of TVM model with single MRVL layer is > > currently set to empty string. Update the name with > > the field from metadata. > > > > Fixes: 5cea2c67edfc ("ml/cnxk: update internal TVM model info structure") > > > > Signed-off-by: Srikanth Yalavarthi > > --- > > drivers/ml/cnxk/mvtvm_ml_model.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/ml/cnxk/mvtvm_ml_model.c b/drivers/ml/cnxk/mvtvm_ml_model.c > > index 3e06ea658bb..102d30e5f4f 100644 > > --- a/drivers/ml/cnxk/mvtvm_ml_model.c > > +++ b/drivers/ml/cnxk/mvtvm_ml_model.c > > @@ -352,6 +352,10 @@ mvtvm_ml_model_info_set(struct cnxk_ml_dev *cnxk_mldev, struct cnxk_ml_model *mo > > tvm_mrvl_model: > > cn10k_ml_model_info_set(cnxk_mldev, model, &model->mvtvm.info, > > &model->layer[0].glow.metadata); > > + > > + metadata = &model->mvtvm.metadata; > > + rte_memcpy(info->name, metadata->model.name, TVMDP_NAME_STRLEN); > > + > > Minor nit, but you probably don't need a high-performance copy here, so I'd > recommend using regular memcpy rather than rte_memcpy. > Actually, if this is a name value, would a strcpy function, e.g. strlcpy, not be more appropriate?