From: Bruce Richardson <bruce.richardson@intel.com>
To: "Mattias Rönnblom" <hofors@lysator.liu.se>
Cc: dev@dpdk.org, "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
Subject: Re: [PATCH 24.03 5/8] event/dsw: add schedule-type capability flags
Date: Tue, 21 Nov 2023 09:47:53 +0000 [thread overview]
Message-ID: <ZVx8yawG5tlYnS6A@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <ZVx8BQOcxUjn6fUx@bricha3-MOBL.ger.corp.intel.com>
On Tue, Nov 21, 2023 at 09:44:37AM +0000, Bruce Richardson wrote:
> On Tue, Nov 21, 2023 at 10:32:07AM +0100, Mattias Rönnblom wrote:
> > On 2023-11-21 10:30, Mattias Rönnblom wrote:
> > > On 2023-11-20 18:26, Bruce Richardson wrote:
> > > > Document explicitly the scheduling types supported by this driver, both
> > > > via info_get() function, and via table in the documentation.
> > > >
> > > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > > > ---
> > > > doc/guides/eventdevs/features/dsw.ini | 1 +
> > > > drivers/event/dsw/dsw_evdev.c | 1 +
> > > > 2 files changed, 2 insertions(+)
> > > >
> > > > diff --git a/doc/guides/eventdevs/features/dsw.ini
> > > > b/doc/guides/eventdevs/features/dsw.ini
> > > > index c8bc6b3f1d..941d257e3d 100644
> > > > --- a/doc/guides/eventdevs/features/dsw.ini
> > > > +++ b/doc/guides/eventdevs/features/dsw.ini
> > > > @@ -4,6 +4,7 @@
> > > > ; Refer to default.ini for the full list of available PMD features.
> > > > ;
> > > > [Scheduling Features]
> > > > +atomic_scheduling = Y
> > > > distributed_sched = Y
> > > > burst_mode = Y
> > > > nonseq_mode = Y
> > > > diff --git a/drivers/event/dsw/dsw_evdev.c
> > > > b/drivers/event/dsw/dsw_evdev.c
> > > > index 1209e73a9d..a68ca1fe30 100644
> > > > --- a/drivers/event/dsw/dsw_evdev.c
> > > > +++ b/drivers/event/dsw/dsw_evdev.c
> > > > @@ -220,6 +220,7 @@ dsw_info_get(struct rte_eventdev *dev __rte_unused,
> > > > .max_num_events = DSW_MAX_EVENTS,
> > > > .max_profiles_per_port = 1,
> > > > .event_dev_cap = RTE_EVENT_DEV_CAP_BURST_MODE|
> > > > + RTE_EVENT_DEV_CAP_ATOMIC |
> > > > RTE_EVENT_DEV_CAP_DISTRIBUTED_SCHED|
> > > > RTE_EVENT_DEV_CAP_NONSEQ_MODE|
> > > > RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT|
> > > > --
> > > > 2.39.2
> > > >
> > >
> > > Acked-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> >
> > Eh, hold on. PARALLEL is also supported.
> >
>
> Sorry, missed that. Will add in V2.
>
> > Do we need a capability for single link as well?
>
> I was wondering about that myself. For this v1 I decided against it
> because any ordered or atomic queue can be single link by just binding it
> to a single port. The actual single link flag is jut a hint allow the
> driver to be more efficient about resourcing.
> However, if you think it's worthwhile calling out explicitly I can
> certainly add it.
If we have such a flag, we should look to have eventdev "emulate"
single-link via ordered or atomic queues for drivers that don't directly
support it. I'm concerned that the number of different capability options
makes it difficult to write truly portable apps.
/Bruce
next prev parent reply other threads:[~2023-11-21 9:48 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 17:25 [PATCH 24.03 0/8] document scheduling types for eventdev drivers Bruce Richardson
2023-11-20 17:25 ` [PATCH 24.03 1/8] eventdev: add capability flags for supported sched types Bruce Richardson
2023-11-20 17:48 ` Jerin Jacob
2023-11-20 17:52 ` Bruce Richardson
2023-11-21 9:30 ` Mattias Rönnblom
2023-11-21 9:46 ` Bruce Richardson
2023-11-21 11:12 ` Bruce Richardson
2023-11-21 17:08 ` Pathak, Pravin
2023-11-20 17:26 ` [PATCH 24.03 2/8] event/cnxk: add schedule-type capability flags Bruce Richardson
2023-11-20 17:26 ` [PATCH 24.03 3/8] event/dlb2: " Bruce Richardson
2023-11-20 22:45 ` Sevincer, Abdullah
2023-11-20 17:26 ` [PATCH 24.03 4/8] event/dpaa*: " Bruce Richardson
2023-11-21 10:51 ` Hemant Agrawal
2023-11-20 17:26 ` [PATCH 24.03 5/8] event/dsw: " Bruce Richardson
2023-11-21 9:30 ` Mattias Rönnblom
2023-11-21 9:32 ` Mattias Rönnblom
2023-11-21 9:44 ` Bruce Richardson
2023-11-21 9:47 ` Bruce Richardson [this message]
2023-11-20 17:26 ` [PATCH 24.03 6/8] event/octeontx: " Bruce Richardson
2023-11-20 17:26 ` [PATCH 24.03 7/8] event/opdl: " Bruce Richardson
2023-11-20 17:26 ` [PATCH 24.03 8/8] event/sw: " Bruce Richardson
2023-11-21 11:54 ` [PATCH 24.03 v2 0/9] document scheduling types for eventdev drivers Bruce Richardson
2023-11-21 11:54 ` [PATCH 24.03 v2 1/9] eventdev: add capability flags for supported sched types Bruce Richardson
2023-11-23 3:59 ` Jerin Jacob
2023-11-21 11:54 ` [PATCH 24.03 v2 2/9] eventdev: increase flexibility of all-types flag Bruce Richardson
2023-11-23 4:07 ` Jerin Jacob
2023-12-12 11:28 ` Bruce Richardson
2023-12-12 12:47 ` Jerin Jacob
2023-11-21 11:54 ` [PATCH 24.03 v2 3/9] event/cnxk: add schedule-type capability flags Bruce Richardson
2023-11-21 11:54 ` [PATCH 24.03 v2 4/9] event/dlb2: " Bruce Richardson
2023-11-21 11:54 ` [PATCH 24.03 v2 5/9] event/dpaa*: " Bruce Richardson
2023-11-21 11:54 ` [PATCH 24.03 v2 6/9] event/dsw: " Bruce Richardson
2023-11-21 11:54 ` [PATCH 24.03 v2 7/9] event/octeontx: " Bruce Richardson
2023-11-21 11:54 ` [PATCH 24.03 v2 8/9] event/opdl: " Bruce Richardson
2023-11-23 4:10 ` Jerin Jacob
2023-11-23 9:19 ` Bruce Richardson
2023-11-23 9:38 ` Jerin Jacob
2023-11-21 11:54 ` [PATCH 24.03 v2 9/9] event/sw: " Bruce Richardson
2023-12-12 11:32 ` [PATCH v3 0/9] document scheduling types for eventdev drivers Bruce Richardson
2023-12-12 11:32 ` [PATCH v3 1/9] eventdev: add capability flags for supported sched types Bruce Richardson
2023-12-12 11:32 ` [PATCH v3 2/9] eventdev: clarify all-types flag documentation Bruce Richardson
2023-12-13 12:50 ` Jerin Jacob
2023-12-13 13:20 ` Mattias Rönnblom
2023-12-12 11:32 ` [PATCH v3 3/9] event/cnxk: add schedule-type capability flags Bruce Richardson
2023-12-12 11:32 ` [PATCH v3 4/9] event/dlb2: " Bruce Richardson
2023-12-12 11:32 ` [PATCH v3 5/9] event/dpaa*: " Bruce Richardson
2023-12-12 11:32 ` [PATCH v3 6/9] event/dsw: " Bruce Richardson
2023-12-12 11:32 ` [PATCH v3 7/9] event/octeontx: " Bruce Richardson
2023-12-12 11:32 ` [PATCH v3 8/9] event/opdl: " Bruce Richardson
2023-12-12 11:32 ` [PATCH v3 9/9] event/sw: " Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVx8yawG5tlYnS6A@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=hofors@lysator.liu.se \
--cc=mattias.ronnblom@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).