From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1C7C43698; Thu, 7 Dec 2023 11:29:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CE31542DB2; Thu, 7 Dec 2023 11:29:43 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by mails.dpdk.org (Postfix) with ESMTP id 2E83440295 for ; Thu, 7 Dec 2023 11:29:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701944983; x=1733480983; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=tdVjJ04eahUmFTpYh3yhshdWeB1oKP+//8g+dJjHqAU=; b=ebXO3+5d6VhduGqJEJS7Aj8+OmTtK1wkO2P+EWbKUdpd4+bQGMbb6U/N FejrL+gGNXcKCpEDYD89xyVr8btHTJKfl8/lFnPxO++RmYOmXk88BzEBT sVRSDIQeVf2R8HS9u5AxcBfxm0bm2k1Ct9z7Fjq9O0YN46qxFvFbaKvfW Bcg21JCtQOAcfGfo8x3o4PPrqQtZRdjf1TURNbGnlUbeFWnGoDAQOlbRJ Awxmwa/mlI0jfsjjMMMmivIZbu0ImWq6MuD0/syLW7i/S9dFrbDQfVww9 x9FD8ie/K1+W9HoXnx19lr9Re+Awo9G1JX9Bo9N5yfALtUGX7eJq6fxKX w==; X-IronPort-AV: E=McAfee;i="6600,9927,10916"; a="1091631" X-IronPort-AV: E=Sophos;i="6.04,256,1695711600"; d="scan'208";a="1091631" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Dec 2023 02:29:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10916"; a="1018898999" X-IronPort-AV: E=Sophos;i="6.04,256,1695711600"; d="scan'208";a="1018898999" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 07 Dec 2023 02:29:33 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 7 Dec 2023 02:29:33 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 7 Dec 2023 02:29:33 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 7 Dec 2023 02:29:33 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 7 Dec 2023 02:29:32 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fhyE+h40oFE/rmMcnIBqdtQkJ0OFkDLNCwfD/s1+nz00rIXTtWCKXXSSoMcx7GmsGaqHdjsQIteZxidPg6Xzw45oFzX626TazGQUSSnP+gctDT7ls7F5OvowWeU74LxyVhPGY5UPlnuTpKAjpLkv24R38DQ6GrVJ2Mj3qBK3x1A5dZv0qSPHLOxHugjPF6q4BEN0ZKK7WvKzlWhKxCzajChFa16QLLlqtWzpAVL/qHcGkPI2zmbg03OSWKtWyhZv6q4n7Q2lG+9xDfoexe6iQdQJlBNPnUejFrfzpEYfrkjO5ouBzhSSfB2EZXyga5nOUzis8yK1wkhEY2v2/44MrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cow8o8YYmMMnlrezi144al6YdzpWl47LEkCVNw/48AI=; b=bn0JG1CV0iWZI8ER3ZnDDskCXsOArdnasfWyxWDfdEhN7M2pXXqhWiGX2nY2m6bWoqFkj0bL2GzQjwfqbtCfgSM0Cz7I7sY7F8iYrSIqQNumA3CfLxuomVlLazVomdP5SaUlRSCOo7RAATiXtU1j9oJ8HPpachLqlSwgleF4HDH4thiUFfZSup9Fjh5bkk6Ik9215c4p6/qgc73B98WuxfdCp04cqynVEo0+OG5wkkiAuiCskEjdlEmJzp3CHmG1amYEIekdcFsppJC1mZMX/WsrHlSO1bEuO4ENkkjnqhlhOtIsqGpJ4s41ZdaT6jKfj4U2vpS7jNsVIsu3xOKLjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MW4PR11MB6910.namprd11.prod.outlook.com (2603:10b6:303:225::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.27; Thu, 7 Dec 2023 10:29:31 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49%7]) with mapi id 15.20.7046.034; Thu, 7 Dec 2023 10:29:31 +0000 Date: Thu, 7 Dec 2023 10:29:26 +0000 From: Bruce Richardson To: CC: Rakesh Kudurumalla , Subject: Re: [PATCH] app/graph: generate cmdline boilerplate Message-ID: References: <20231207071205.3008880-1-skori@marvell.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20231207071205.3008880-1-skori@marvell.com> X-ClientProxiedBy: DUZPR01CA0082.eurprd01.prod.exchangelabs.com (2603:10a6:10:46a::10) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MW4PR11MB6910:EE_ X-MS-Office365-Filtering-Correlation-Id: 9cf4199a-a4b5-46fa-6980-08dbf70f6562 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SkCUdLZ+Ok+o1VYmIRuFLqvbUd8dFi2nl+YV+rBjLf0jIyxAxZn0+XTQ7yPFZIi9TiMwpm5oKl7JkFO01fmpoGiONml8cId7ciOx0BJGIXRKjvJIzN+r2WaI3rHjIOsz/Dd9LDMKXwPp4ZNml7nPjLVLV0bnxvf1clMF1sK1tkZOacYkiqpao6W1cBU66lXbHz/9gCSNX/pcLLMcXfMB3tyzH3OkDeeH5Sbop2ktlI7uIRaD2G3d2K4tg6/g6V9MT5sCAtgxq4jDT2CF4QRjUX72AdWuEojJ55A9listMn7XMulJ+W/DCyOvAELIA7jl02t+SdBDLhfbef7juto/ZzlN58WhtqB71C1eaPwMKaojX1eZ6H+lUFTPign6NEGbHYYi5LwcfH9/9daV4+g8cacH5ZBnDuEK8e2gk/udJ9r0jIpG1T/Zx4bWMLWB3MjMxTZzfYKCUcJ/IjJqlsO7nXqnkGZnbD/U81Ocvg0dWh19cY3MM9TuKG8jtlymXhv6EX/ty/+l+5AW3Cs5/qQdtSXPXIZJ6n6BFFkSwOxFxPom/qNfS/4TU0kQKyjiuKsk X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(376002)(39860400002)(136003)(366004)(396003)(230922051799003)(186009)(451199024)(1800799012)(64100799003)(41300700001)(5660300002)(44832011)(86362001)(2906002)(6512007)(6506007)(26005)(83380400001)(6666004)(82960400001)(6486002)(478600001)(8936002)(8676002)(4326008)(316002)(6916009)(66946007)(66476007)(66556008)(38100700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bboXRyrMP58dnEbJ+31G922FJPevDGQ30NThkufiXcD81/hr+8OzpPNPadXD?= =?us-ascii?Q?3SPlnCMcPeRHEtCCxw2ZkcXat9HwDCQDuxx8UxU9AzDrcKTSPHElK8/tcP33?= =?us-ascii?Q?ejwd5DnMOgZIUVpReuCYLIlKL7djCbphce4bOvIdlsuILeEn12yrJzBGi2SQ?= =?us-ascii?Q?Pp/1lLIY8omV/kbYqeBdzcZBL9ksV3Mdkof3orsXeBHsd3QOybmtcOxweYFA?= =?us-ascii?Q?ekZ7Rc981ahVgTTT2ll3dGgLlErr7mvYvAEAUB2ZVhFOQqCAQqiF0obI4uQB?= =?us-ascii?Q?wBDrbviI5Suw6Fje1S0xy85p/psDAVSEp6/wp/EU7ZjWMUUzudLlCS3OPvXV?= =?us-ascii?Q?7eE2vB+SH2oGrrEnSkVUSY3836vgquLhN0LjMaMdajnN9jkqIIyqOAskNMAn?= =?us-ascii?Q?Jjx4D/E2Rlz558+QXmZ7li+oJFmArAOHsjHvDYjql+AsNzqpw4Sk5HyxqTEB?= =?us-ascii?Q?65bOEM77017QPvNfZdZ+kHCF4CPTgdJXlrlpa4o1CdqLM4raMOxN57VwQHQs?= =?us-ascii?Q?K0ph1whuppGyyU3eb57QRbvFPYCjU50rUuR2GwE/Pv4rTalyJTnb5ZbhTEnl?= =?us-ascii?Q?hBqGoZIsJRZBtFcD8ZN3RA2tZQwXR72Xa9kjY2UunISyqsgrXH1Yhx1ugLcy?= =?us-ascii?Q?2Lm17DfjMesgF9bv8fHL6m0XECbIoyJgynY6rJ0t0G5A4r9lhGcm7LCXRfuR?= =?us-ascii?Q?RXOLQ74bRkZI79fZcDwxVoqlDgLkutTU9geTTBw2xmhTW4AfXUGvM8OI/t/K?= =?us-ascii?Q?dR74V9DYeXuScetyK+ommjjIv8yENY5EMDuLgOlKHPuX+MlwjNN8C4jD2Vq1?= =?us-ascii?Q?rjinBEdUd5kLocxHLCpcvo/aDUsJhShNwz0DAUDAa9V/hsE/BBYq8bgW72eJ?= =?us-ascii?Q?hM13MVpZz7K2ZAw9F7KIHDTXmZAPjuhggIHNPcEl72Ztw+UlLNWLBZ1vKTcz?= =?us-ascii?Q?8d9hZW62D1acVpNmBgqbidDTQ9GkvAai5eznE2Xj1wW+Gvg3z76DUxCsa5c7?= =?us-ascii?Q?vedogE2F7RhQR1XXoT3qiDkmQMKJ1YikaX0UbCX9v3urfp49jUPIM3QKxU/G?= =?us-ascii?Q?GscwPCHYydI+OgNNtv9yKrgid4fBOLBiA4YJq5Di0B74r8zhEeM4tjW9qqNS?= =?us-ascii?Q?PcFtjdjPlX9JRsbCMWtmeueTQ7t6q7qZLAZtDgMw0T72S0MLHmD62+ry1Cg9?= =?us-ascii?Q?NkCbAAi7GCbMqFE4fh+ZHlUlG77KEeChhjWDtn32FUmjVLQoy2Q2rmkoNOGN?= =?us-ascii?Q?3XysFWLVNHUhfXa0kPmSfGHW2RMIBsIWVDuaNfzSRxIpamF83cmE3FCeSQt/?= =?us-ascii?Q?JVcksujLkCul4cqvZlGmdK14jF/MxUQrqctl8YAz9u6APBsn4Kpi5oDsfOfV?= =?us-ascii?Q?j0t4KFM/T1eybrkXHy3PtRR2ZQCmzThlz/Ap9gMI9ETdhq+LEoJzHQ8bPhFT?= =?us-ascii?Q?dCRPG43dxz3gsH1kTnsc6a7skMq3hw4pkeMw9qMDkRUkNS58vRBLWHPoD/68?= =?us-ascii?Q?h10GZbTTvLR/GOiZxyroJ58cLCAIRN3OmBcsvirvOYbz1mT9HCuXlzgCwCd+?= =?us-ascii?Q?DqgQBDAhvZOlYEQLISIC1riL9s90vOozkiHF6avkaAghTDXnzrOo02yVlU0n?= =?us-ascii?Q?+g=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9cf4199a-a4b5-46fa-6980-08dbf70f6562 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2023 10:29:30.6533 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: d2c+hdyTYHVk52p4vvVfkv+ffzQV8WkED7ylfvZkbqIxsv0DaHZ0UvV4q9Yx7PVE71jVVFMBuQ/MOJ12Q4/aXmf+UgDfu0v0gfI/K7Y0Gtc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6910 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Dec 07, 2023 at 12:42:05PM +0530, skori@marvell.com wrote: > From: Sunil Kumar Kori > > Use the dpdk-cmdline-gen script to autogenerate all the boilerplate > structs and defines for the commandline part of the application. > > Depends-on: series-30459 ("enhancements for dpdk-cmdline-gen script") > > Signed-off-by: Sunil Kumar Kori > --- > app/graph/cli.c | 27 --- > app/graph/commands.list | 32 ++++ > app/graph/ethdev.c | 288 +++++------------------------- > app/graph/ethdev.h | 9 - > app/graph/ethdev_priv.h | 63 ------- > app/graph/ethdev_rx.c | 67 +------ > app/graph/ethdev_rx.h | 2 - > app/graph/ethdev_rx_priv.h | 16 -- > app/graph/examples/l3fwd.cli | 12 +- > app/graph/examples/l3fwd_pcap.cli | 12 +- > app/graph/graph.c | 131 ++------------ > app/graph/graph.h | 5 - > app/graph/graph_priv.h | 35 ---- > app/graph/ip4_route.c | 86 ++------- > app/graph/ip6_route.c | 88 ++------- > app/graph/mempool.c | 68 +------ > app/graph/mempool.h | 3 - > app/graph/mempool_priv.h | 18 -- > app/graph/meson.build | 8 + > app/graph/module_api.h | 1 + > app/graph/neigh.c | 103 ++--------- > app/graph/neigh.h | 4 - > app/graph/neigh_priv.h | 21 --- > app/graph/route.h | 5 - > app/graph/route_priv.h | 34 ---- > 25 files changed, 164 insertions(+), 974 deletions(-) > create mode 100644 app/graph/commands.list > I really like the diff-stats of this patch! More than 800 lines fewer in our codebase. Acked-by: Bruce Richardson