From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 84DA443874; Tue, 9 Jan 2024 16:35:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 14B144021F; Tue, 9 Jan 2024 16:35:47 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mails.dpdk.org (Postfix) with ESMTP id 0E91B4013F for ; Tue, 9 Jan 2024 16:35:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704814546; x=1736350546; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=nhwJylcWfl9wLIIFG8END0BAK6QeYIdOf9OXNEENG9w=; b=FPywxMiRWpJRXlYAr1zGZ20Pk4ySsQJxGNnpUxVRgCVtmUD66gSuYPQr lToWZtOU77GjkIpkA20cA3EoUASbCpVU/YR+SXiU7r51dk5+V6tPmyiOl ZA9XKmWbW+HicMcciDvQlvEIzY0XEbQXByGsBwVTBXDlGY1gFvdeiyU5G 3mRGOvKOuu7efwblY8xmoYTO3OXTxceH5NqaUR1Hj6rgd6KWXj0pko1cV lKwbWqeKr2KqT/j/xfvZ3n9qUMS28VnJRxc9+zhJsQ7AqwJUrJxkfoyL+ I8Fn77bnrZv35qD/M/0WnQns5sefzDnycjqN+OoDmjJHQF2LNbMA+OkIk A==; X-IronPort-AV: E=McAfee;i="6600,9927,10947"; a="19735538" X-IronPort-AV: E=Sophos;i="6.04,183,1695711600"; d="scan'208";a="19735538" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jan 2024 07:35:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10947"; a="872274428" X-IronPort-AV: E=Sophos;i="6.04,183,1695711600"; d="scan'208";a="872274428" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by FMSMGA003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 09 Jan 2024 07:35:45 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 9 Jan 2024 07:35:44 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 9 Jan 2024 07:35:44 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 9 Jan 2024 07:35:44 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eXCLjgApQxG49rbYTPPIwaOpxfEnnCz3QxP3V42ryOTpNRxBAnhoqoj/qDn/lWELWge9MWqz/rPhh8Qy7ItVj2EDDuF9gJtbjQ9ONUF/2LnDm/vqI8qaynpZM83+y6hRWz1qKWXW2cgzMfKApDgc2aUFYhDm8v+jXsM6dQJXiH7dVWDzvkeKAjPyVorqkvwXB2FD+g524PNqTjXdFpOORCquNeE9KwBqSBwyJoPEFyz27zg0pSeUS3iQlSQYezR9raB7axGV47bkozdUy2fD57IXLzDpxQQZXe2uX+F9WOfgbMmOmK4O58r6wnhRyCO/Zt+t3MaRrtfU3ESxJ/fvWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YkQ2wUr0vD9dzr7Vh4JUlrgofkPa3P/eMK3629sKGg0=; b=b8Sadi4VUadrw4FOxfdoceaSofYFvnIurrtfZiZQJ4CutFX6AP/GUIl2TKuPA8DmXMGyO8N9GF063uXR9U9hw01ITiBl2TyXclyrA6WHhP+L13bMLy0wCVfP4FJ00i8UYu79vkC9JObi3TRP4ZFZJS9RlO5zXthnob3yl5JsLlRT+mLHGMJoaXkP7tX9wxiN47iIkQHQnCkAA14FXJD3gXvrcUktiXUYv5ryhIb33I+/G9A3Qm+PSqb85VgzYh/W5UKq960kZ0YtfyvNbR8CUaoObCsH73n/9iYDRHReK37SPqTRXYCFEcHdXchIceNWbhHxzjIBIZhNK6cOGIIrug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CH3PR11MB7274.namprd11.prod.outlook.com (2603:10b6:610:140::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.23; Tue, 9 Jan 2024 15:35:42 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49%7]) with mapi id 15.20.7159.020; Tue, 9 Jan 2024 15:35:42 +0000 Date: Tue, 9 Jan 2024 15:35:37 +0000 From: Bruce Richardson To: Lewis Donzis CC: dev Subject: Re: vmxnet3 no longer functional on DPDK 21.11 Message-ID: References: <2134779104.413217.1638218715124.JavaMail.zimbra@donzis.com> <1796133353.5470017.1654262374494.JavaMail.zimbra@donzis.com> <12922153.12944.1704552603431.JavaMail.zimbra@donzis.com> <1182416671.1246287.1704808007894.JavaMail.zimbra@donzis.com> <519672326.1276848.1704813707871.JavaMail.zimbra@donzis.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <519672326.1276848.1704813707871.JavaMail.zimbra@donzis.com> X-ClientProxiedBy: DUZPR01CA0166.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b3::9) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CH3PR11MB7274:EE_ X-MS-Office365-Filtering-Correlation-Id: f3804639-bebd-463a-f891-08dc1128a3ac X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SzvGgnvqYmuFQhkgviARoz4xp/ArKoUj7uLuCD0bxim8zev0fO/q7IF6zbjVvuUCX8No/SvS1tH9d+d8y5y9Z6v5+jiQ5f4foCn+6adJFnzKsqZpsfH5CYdEb0PHKvXK8sItiu2q1NGxy9K6EbjKvPEFVCZe6+tL1j3aRkhwbt+G5FGe2IDJWb4yVBuwNpOAyCLmUe/hVpLuSra58zzpKfzoXvIQYj3/Nnvy27h3uCIYp721pwvqg8b1ZiI3wc57JDw4t/u55CVASosZqbegwB6QpT4OOm8I7mqb8XlvETGXqyIFsYkAvJWZMLtny3UTbgauPmLaS+26DBHJ/l7y0aqa+xveGF3rNXnWUDLLPxIGThq/GDmwwUcPSYJSzpllZzEleP5S+SQHmZ7vxvg0V5nBsAIF0m4AeGVLaPoMjpoP/1uRGb8nSfjNUBeroO/ZUW4OIScTwm7/bGHo+oXotWZtUbXdwBm5Ppcdr3O9Hhmhn2s3kK7DI4g9jmmPtji776183TfzvkRbO0xs6SL5boqFSzTTP5EMVifPzlfsh4VUvaX8IO7lq/iiOMCQx5+kXrGtUcSL0Qyj1rGKj+o7LSy8x73zBnVMY08H0FWlg9Hvc4wQtJgLxv8k1deuEdQ4 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(346002)(396003)(136003)(39860400002)(366004)(230173577357003)(230273577357003)(230922051799003)(186009)(64100799003)(1800799012)(451199024)(83380400001)(478600001)(82960400001)(6486002)(8936002)(44832011)(8676002)(4326008)(86362001)(6916009)(66556008)(66476007)(66946007)(316002)(26005)(38100700002)(6512007)(6506007)(53546011)(6666004)(2906002)(5660300002)(41300700001)(66899024); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iRQjOCpvwWSLslcEPwkkuO/umXYYAn7LShMgCYl37SoKCtEFlqr8nc4JdqeK?= =?us-ascii?Q?h7QwTY84ESS49D+HO9Qi1EevJVKg06yKRzaM2tTb0PntAF+4A4SjkIe86OC3?= =?us-ascii?Q?dDoJe19LMTL+y1ytzk0fBPThVeK9hkaggWENxoyKvZ3sY2wfDI94pXnoceWk?= =?us-ascii?Q?LvqgOVeLUNM2fJojLjLFy/o86xJM2qFVK2DCV8T03xRao5za0uUoFnliOmZK?= =?us-ascii?Q?ORdukrZyTqtHF4tXyouYd6VNw1qxc0fNJHmdq39aKyVAGL578XDwr7yCZaEd?= =?us-ascii?Q?t9bqc2DTy23EB2Tls+unyuhVEAkuckHeZP/73N+i6/+U457RA4WggxMVoVYG?= =?us-ascii?Q?9oig7+VG4Xg+qRVX21IqZHVKu/tFsJdWQK1GihM5nPVk8gzozyzXiakONRap?= =?us-ascii?Q?QEP0B99TXI4AZmEuwGhbPsdhl9qrL7CqNFQrd5pZ+5gadBU1tkQm2BFjPLeD?= =?us-ascii?Q?8WMQgIiV9OqQ8ZuEBNZ0RUKMDTXt8nAD/dLYKQENbU6qbcwhf9pNKYYUYVCS?= =?us-ascii?Q?CagjnxJPUY7Al9La4jtp4Wv2SMUzpiW+aI7KgrH8XC8BFaZoGhS+n+tmN+Tz?= =?us-ascii?Q?BUxVuR22vimYCm3atwXxBVSupwf/keX6pI/GHQDR+zCLlLpI+OCBW1T0sR54?= =?us-ascii?Q?4Gl0mlyK26JUtYrnv12LrtfleA8dahPx4Dd0IP9SyNPjZ/uQqhlh95Pc4aui?= =?us-ascii?Q?ZqCYqnS8jsjix9NVORSYOTlx7CxOuvpArL1NcsquK2x+NfMCObp2BlU6+K1M?= =?us-ascii?Q?Gz8amHmdeDp8WFaNwIP2x9P2Gnk25Y3AFlne7+y9cPsZfJIwZRv9hoKaocxy?= =?us-ascii?Q?6lUlcIIaUz3o6U3Lb10EyZqGmdKQcyqHlCbWLXoEnvmpaWHKP6RXduazlf0g?= =?us-ascii?Q?TN6UewuUCiKmgZ38ba5UGs+gyjkr0Ae+I38PCoUA0BSeCkdfUvilCIYgsj/J?= =?us-ascii?Q?XVUhbinP4luLCezYaqA4iEItiIfQm7eXzQM0/VnZb3Z5V7spWPY8qUsbIrnM?= =?us-ascii?Q?PB/4inW5fJ0ZsfWfLnEcl/360rol/FsiNawvjiLvg524wG2DuT/rnU51ixIe?= =?us-ascii?Q?koQA93OBuwox+N8iBUV9KCW/hDSFP+qsFNmhJoW4CfZHQDqcc+nlax5rAenI?= =?us-ascii?Q?1ImY/Jxq384BjdC2OdfZ53S6Fec5aVSLtIkkN703tzpDxylvdjmSzxb5ttHj?= =?us-ascii?Q?Qnh+ZLmHzAsqMwkfBsYHMGBB0WZDdYvSUSfyL7JY8nIRObEfS1XsIqKXbX0K?= =?us-ascii?Q?8I50DLohumgFyCDx0gsQFeME/IHsFXCHAKaCnAv8VEdS9hQrwiKEKLR5UOU6?= =?us-ascii?Q?AaUbi6N6O0oNHCTumtMbCjBtQl98V5NU5HTcDOzyDxjiU6RqysYlKlZ2fHve?= =?us-ascii?Q?2Wspxu/K/XOkKpqnN5V8nYKkzPP2XT+yc16yI+35xOfTp1RB7lrxQiHdKrK8?= =?us-ascii?Q?oYrdTMooFZZzuePXarj3DP7Nt82VjJm2zxPG728zc30wdFJrYyuYu6jh0B0z?= =?us-ascii?Q?wiZx1OmshFyF6BJCzFDmq3QHoshLFiEgFLCxr1KB0YK+bhFshkGfHHLgcCKr?= =?us-ascii?Q?CT/4C4w26lm4edwAVN/PgDiY0ggOWG3vGx4Ub59x7zh/0Igfs/793k6ukMgR?= =?us-ascii?Q?rg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: f3804639-bebd-463a-f891-08dc1128a3ac X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2024 15:35:42.3532 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: w14lyD6QWgYTJzgO0rYZKAxeITuTCAUj0HP8KCrve1MetE5fD8hkgKhCW1762721iL4U0jsea30az4PBLwretkaLSUWAF4A+0HJuCIqY9kc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7274 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jan 09, 2024 at 09:21:47AM -0600, Lewis Donzis wrote: > > > ----- On Jan 9, 2024, at 8:28 AM, Bruce Richardson bruce.richardson@intel.com wrote: > > > On Tue, Jan 09, 2024 at 07:46:47AM -0600, Lewis Donzis wrote: > >> Hi, Bruce. > >> > >> I'm even less familiar with it, but we do quite a lot of testing using VMs, so > >> it's been quite handy. > >> > >> Your patch seems very reasonable, however it also produces a warning: > >> > >> ../drivers/net/vmxnet3/vmxnet3_ethdev.c:264:1: warning: unused function > >> 'vmxnet3_enable_all_intrs' [-Wunused-function] > >> > >> Adding an #ifndef around vmxnet3_enable_all_intrs() eliminates that warning. > > > > Right, I should have compile-tested on FreeBSD myself, before sending the > > suggestion. Patch has now been submitted. Please test and ack if the fix > > works for your use-cases, thanks. > > I compiled it and ran it just now and it appears to work just fine. Thanks very much for submitting. > > > In general, yes we try and avoid interrupts on the data-path or fast-path > > and use polling. However, for some use-cases where traffic levels are low, > > interrupts may make sense to save power for fast-path. Even if not, > > interrupts are useful for things like error conditions or for monitoring > > link-status changes (LSC). Unfortunately, we don't have any interrupt > > support on BSD, so fixes like this are necessary. > > That makes sense. Makes me wonder why there's no interrupt support on BSD, i.e., maybe it's better to fix that than to have to fix "avoiding it" in the drivers? Sadly, interrupt support was never implemented for BSD, which is why it is missing. If someone has the time and interest to do up the patches to add it, it would be a welcome addition to DPDK. > > I kind of feel like we're a bit orphaned in the FreeBSD world. I don't know how many others are using BSD, but it seems like we're in a relatively less-supported environment. > Linux is the dominant environment for DPDK, which does mean it gets most of the attention. However, we do want to keep supporting BSD, so please continue to flag issues to the community as you encounter them. Smaller bugs we can certainly endeavour to fix, but adding things like interrupt support probably requires someone to explicitly step up and dedicate time to implementing it properly. Regards, /Bruce