From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D30C43863; Mon, 8 Jan 2024 11:45:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9DCC040263; Mon, 8 Jan 2024 11:45:55 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mails.dpdk.org (Postfix) with ESMTP id B1A4A40261 for ; Mon, 8 Jan 2024 11:45:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704710754; x=1736246754; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=RvHWSvMPeunmBzwfDEpb4vWZvl8GGhy9mcjdZ56ae0o=; b=XP8RVeI5pqoDjkPRViaMlh9UsxIPRU++ygQydBxPFUueQrflbKLaluSN T7YoV/muerxGVq7K/AyZT+YtNnOGkL3SHZdoO1UmCS02J8ssZ4JrzUGOp sg8md0s4yo5CxwxDO4b2lQ1ZMQTXPj/rySeWY77C0u759eS0mvb1dyMd/ XzSxqPX2z6DpfL/KWfc5gn9rmdoY+q9fbzax1DgZfs+dqrZWfoiSUq6Xb peK26KBfOwWzNJ/CeFJGYMdUpQA2WReFRchM+/8umbfZ8kQD3fb6LdB2U ixQAduYtjD5/g3RU3H2DZ23XRxFaYm4PxCq5Smg6LhFh/C3CjNoSwjjlh A==; X-IronPort-AV: E=McAfee;i="6600,9927,10946"; a="4603479" X-IronPort-AV: E=Sophos;i="6.04,340,1695711600"; d="scan'208";a="4603479" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2024 02:45:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10946"; a="757588749" X-IronPort-AV: E=Sophos;i="6.04,340,1695711600"; d="scan'208";a="757588749" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga006.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 08 Jan 2024 02:45:52 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 8 Jan 2024 02:45:52 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 8 Jan 2024 02:45:51 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 8 Jan 2024 02:45:51 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.40) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 8 Jan 2024 02:45:51 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K/GCjun1p7CRHiQ5Z8G4q4odbJ0TLbmJ2zQJGdisE1g6tplle0BGoPe+dEFltSqLzcEyxxBn6DwhILQGqgBaPrV4Rp85qOICY4iHzM2MkxO3vKofVy1IvBtHY0XdRCgtz/vg/ZG8yDBsI10x0WyEvisDGKXoa5xV2CUySv8OsUGOO7fMyCV6IevV12EnATtSVEopwJ83stzc7iZbQ5eWDOv4l9/QVKvXerar4132RIr5vbK/vRFPjWsYLCOAWgm89eyPTz3/mOXrQsioBB8v/mrQMIFFKdT9Fz8IaSMYM1V0kCwOS+4DA0CHeWJHtVjDpkqoe1yXPEYTct68KKvdZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5nRiGZGe45t3jNEOuQIP0P/geXzq5YwBx0X+4dpYfXA=; b=MmhDh8fQpVAXC1YBW3KoLU2NfWtiE+wv2qJX/cmJbMhadMW2w0HX1VYrGG4v59WAfgdhA539/vgzpQ8A4CER5asrwJiO6RMKLoBBGd0qrJOyRHZvMw9HjUm+vqT8YbHmo6BPJ08cns6ghFqHqbJfJN5JZLomMq5xXICuAim+0uEUYXKZV+bXfGb571eG62vkOF2x8VBHztokC8+2dwOA9DjCgkgkAhAtIU6Hd80WD47uZZgFnKlJZwCxM0+1mL/82SiXh3dG4uLKQjYGE0rI8wmhryi1tIKS23xcqQWvjI3PiuvaeshpMQCCbLkF6I7fMKsV3ajj0Xm4QuHD2XpGWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MN2PR11MB4744.namprd11.prod.outlook.com (2603:10b6:208:263::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.21; Mon, 8 Jan 2024 10:45:49 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49%7]) with mapi id 15.20.7159.020; Mon, 8 Jan 2024 10:45:49 +0000 Date: Mon, 8 Jan 2024 10:45:44 +0000 From: Bruce Richardson To: Tyler Retzlaff CC: , Kai Ji , Pablo de Lara Subject: Re: [PATCH v2 0/3] remove __typeof__ from expansion of per lcore macros Message-ID: References: <1703006864-27378-1-git-send-email-roretzla@linux.microsoft.com> <1704239102-31044-1-git-send-email-roretzla@linux.microsoft.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1704239102-31044-1-git-send-email-roretzla@linux.microsoft.com> X-ClientProxiedBy: DU6P191CA0018.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:540::6) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MN2PR11MB4744:EE_ X-MS-Office365-Filtering-Correlation-Id: 4d7b31b3-5a6e-4420-9f52-08dc1036fa5c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fB5h83p9r8bJagqA3nfNUptLMj4sYksVnXw32Tf1SAqEFdFsHeV9S1jfbhC5EtjwPgLNat9LMhXY3kphYZWtpDzaZoIiDVQHh/cup+NbtABG2BGa/YFJIuYErtnG5WiSHLOK2b6JbfwYPvQ3929QXtsfS070OzpxenPg1LffbDPPub023qPDljEyHg3YoDAij73+Yd84iWvpKH7IGutT8DSnwdn1/tX7Ac6WTsT0mxfAVTB3TEH8/ky8KP1+WSxFBNAp57uPsI7WFmPtoJZcyWX8uOZkPvxiDzVeC9kgJvjDnOERcj4ooyhiSG1JRQPU4w1C8D7zlCYgOz5xCH0mUJO4GoSxg1iIarEKxC0o2/TBCyvWgUX6XhFmfhoRRMucaaWiQvtC5CRmxnJ6dcaechTEiz57bjz/VZtgKsoJ5NOCp4bj8cNzSEYFP87Duvrti2X94Pl5ijvvrVseATdS6rSDbjJJrrseuRq5EZZexw4iYVHlOmM7Pgu92b3awEwZacow3fssbtqL80URmo4q4KpAYytUpiWP7N2kIlChc9D95nB1Pw5a+RCjBKNs9cNR X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(136003)(366004)(346002)(396003)(39860400002)(230922051799003)(1800799012)(186009)(64100799003)(451199024)(26005)(478600001)(6486002)(6506007)(6512007)(6666004)(83380400001)(107886003)(5660300002)(4744005)(2906002)(41300700001)(66476007)(66556008)(54906003)(316002)(8676002)(8936002)(44832011)(4326008)(66946007)(6916009)(38100700002)(86362001)(82960400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Lp2IB1Q0r9jG1Svn6rmogdF/apHSNpM4m9cxLhuCu1YVRyGImEe9kZ+7FWLr?= =?us-ascii?Q?5FW5DRme50jkm8lfRfV+iToWtqW9wBcxmAYdOX4XuEtNufPsKvhOPmb7wbZM?= =?us-ascii?Q?ydG4TGtShoXHllYyvSqPWldr7edt97D3LsnsH85tzum/+F+vpI+0BWKylrdu?= =?us-ascii?Q?KhZJ4MwT4ZQq3ivi5nX5zgkCTZuFa/zhod5EEQZ95IPgPs9I6HC8PbVGSj7u?= =?us-ascii?Q?VUuRiHYEsR1uOaGNSa2EAoZq9Ln3ER5vGPsI5KrdleRU614qvsTEZ/LYfkis?= =?us-ascii?Q?vKvOVt82YK7JNnOY9s5UXiKvTt67UBiu99DPGDbE+PiMYp1zf6P1hm2eGp7j?= =?us-ascii?Q?tIjxTLNa4DUmhqtasn29PhPRDXuRkTidlQbxGrU44LmN21zhfc2LcQFwbrMt?= =?us-ascii?Q?IVdQLioQEH5wh2k543Sm0FVW4EVQnrwHVeurB5iBmN5b/ZsJnLypceshqpxA?= =?us-ascii?Q?z65w7xv2yupGAu/xnFYZ7WUjDuUD63WdoNDM0V9kemBMTgs0PYgVJ2dPt1Lv?= =?us-ascii?Q?pAmHjIx5G7I0AXKkOPPXJAiEhyYxikCorrIC4dgTDoBs4q1zLrG60VacQ9Ew?= =?us-ascii?Q?RWhGIThS/QDMzXPycizg3ppaGasTxjHYsya5f3imvDgVCI7PWkqApKCresVd?= =?us-ascii?Q?QbsioWplLPWtdk1bMLqQULesRJqYG1fKNQROFfjldYirhAwlnC1Sqn5qEGgZ?= =?us-ascii?Q?EMVoNLC6alFLui/9D7ahKLi1xL+3vfnZe5U0VUqezrF1FDiLsITo2LRgXZua?= =?us-ascii?Q?pg2+gILtrglWDAA5fEqoTvuKUTMpQHEroHZvZR5kfktaSV8uruEIjfo1lGtL?= =?us-ascii?Q?THaFbH3vGG/NcYpfsOYyBGqOhypfwig4wG2U5oqDH/oBUbjYoyKYNrByZ0d6?= =?us-ascii?Q?oqjr2NX0iBC7OFvXr4eJ3+vO7OxyFQy00/KIyhhb7znuo0QMy120Nl/8si7R?= =?us-ascii?Q?UQ6DA3ezUNOk2cfZpk9cV1UiC6tM8p0pCrReyTMgvAzld0icgMOMg2nj7azO?= =?us-ascii?Q?nwMx7tvel3vTYXH3EiXcjVn989dvBtShx56TL0DSrLubzzFNRyoRGl04xTeK?= =?us-ascii?Q?VgPW9xLMC1B4CdNQ44KtHrHuPYveIV1wbXxT1p3LkGiYgZxEDJBtOJdT6N62?= =?us-ascii?Q?TKETM+9ZIbI2Ss/1EsOleRVTSStXHrnnrIcJtP06mCLAKXbR9K4FkNyT9bkP?= =?us-ascii?Q?OobD+gLG5qfWKpuqswUAszJEI7LAYJSv6dl7VUyOvUhiuHtkVMYzbOOJHsZy?= =?us-ascii?Q?ZZ8tvDEFkJgldGXcFvC9ujm3Kfd2/RIvhidj4DKYAeFGktVWG7uZUzkDBVPR?= =?us-ascii?Q?o1sq5G6tZBH62SndCad4yWTXKKB2puEyEkeM2TvM7AbU5ajgZvUhaqN18H0C?= =?us-ascii?Q?wYS4byfxLNcXZZBpyCrl/OMq23AWaRwWbVOItVeCAvGQ6ZWT9kDMznpbRbY9?= =?us-ascii?Q?Fp64pkMpRNYCdRdxPU1xrTsB5uMtM5cklnSeiVw8d1EaVW+xuCQOL8nwtADG?= =?us-ascii?Q?/16Ddq0Lm7E/AHuJHyBE44cu2cuhGjlGv3OtkjmFxUkIgWmP3cUUzUIiEbYj?= =?us-ascii?Q?byO3jdqhxLh8fhdk9K+jHwR+Bfp1Rs7wImNMhwE8qIPtXJFogci2u+NjVUTf?= =?us-ascii?Q?OQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4d7b31b3-5a6e-4420-9f52-08dc1036fa5c X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2024 10:45:49.5498 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /DStdGQJj1rnm/F/tZ8vucFzjA3RDn8D6r4i14RtKOoieHtdY4TB/Yus9tzrdFTQiGxghScqD00FlmO8xaB/+7+E63Op7yTdtfAinWHBjqM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4744 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jan 02, 2024 at 03:44:59PM -0800, Tyler Retzlaff wrote: > The design of the macros requires a type to be provided to the macro. > > By expanding the type parameter inside of typeof it also inadvertently > allows an expression to be used which appears not to have been intended > after evaluating the parameter name and existing macro use. > > Technically this is an API break but only for applications that were > using these macros outside of the original design intent. > > v2: > * add additional patch to adjust usage for crypto/ipsec_mb > Series-acked-by: Bruce Richardson