DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: "Varghese, Vipin" <Vipin.Varghese@amd.com>
Cc: "Stephen Hemminger" <stephen@networkplumber.org>,
	"Morten Brørup" <mb@smartsharesystems.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"techboard@dpdk.org" <techboard@dpdk.org>
Subject: Re: [RFC PATCH] build: reduce use of AVX compiler flags
Date: Wed, 9 Apr 2025 12:31:12 +0100	[thread overview]
Message-ID: <Z_ZagNDgzV-yl5dy@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <PH7PR12MB859614316DC742F0C8A12B3082B42@PH7PR12MB8596.namprd12.prod.outlook.com>

On Wed, Apr 09, 2025 at 09:53:47AM +0000, Varghese, Vipin wrote:
> [Public]
> 
> Snipped
> 
> > > > > When doing a build for a target that already has the instruction
> > > > > sets for AVX2/AVX512 enabled, skip emitting the AVX compiler
> > > > > flags, or the
> > > > > skylake-avx512 '-march' flags, as they are unnecessary. Instead,
> > > > > when the default flags produce the desired output, just use them
> > > > unmodified.
> > > > >
> > > > > Depends-on: series-34915 ("remove component-specific logic for AVX
> > > > builds")
> > > > >
> > > > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> Hi Bruce,
> 
> From AMD end we have tested with gcc 12, and 13.
> We tried cross checking with and without patch for libraries such as `librte_net_ice and librte_net_i40e`.
> 
> We did not find much changes in the assembly code generated.
> I hope this is expected? Can you please share any pointers?\
> 
Yes, it's expected. This is a simplification/consolidation, not an attempt
to optimize in any way.

/Bruce

  reply	other threads:[~2025-04-09 11:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-25 17:22 Bruce Richardson
2025-03-26 16:21 ` Bruce Richardson
2025-03-26 18:06   ` Morten Brørup
2025-03-26 19:20     ` Stephen Hemminger
2025-03-27  7:55       ` DPDK compilers and RHEL 7 support Morten Brørup
2025-03-27 11:11         ` Kevin Traynor
2025-04-09  9:53       ` [RFC PATCH] build: reduce use of AVX compiler flags Varghese, Vipin
2025-04-09 11:31         ` Bruce Richardson [this message]
2025-04-10  3:49           ` Varghese, Vipin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z_ZagNDgzV-yl5dy@bricha3-mobl1.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=Vipin.Varghese@amd.com \
    --cc=dev@dpdk.org \
    --cc=mb@smartsharesystems.com \
    --cc=stephen@networkplumber.org \
    --cc=techboard@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).