Re: [PATCH v1] net/idpf: avoid truncation of constant value

[Bruce Richardson <bruce.richardson@intel.com>]

On Wed, Apr 09, 2025 at 12:54:40PM +0000, Praveen Shetty wrote:
> Truncation of constant value compiler warning was reported in clang/msvc
> compiler for the VIRTCHNL2_CAP_OEM bit setting.This is due to 64 bit number
> is initialized in a 32 bit enum.VIRTCHNL2_CAP_OEM capability is not used in
> the present dpdk code,so removing this bit setting from the dpdk to avoid
> the truncation.

Please just watch spacing after punctuation in commit message. Will fix on
apply as necessary, no need for new revision to fix it.

> 
> Signed-off-by: Praveen Shetty <praveen.shetty@intel.com>
> ---
>  drivers/net/intel/idpf/base/virtchnl2.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/intel/idpf/base/virtchnl2.h b/drivers/net/intel/idpf/base/virtchnl2.h
> index 3285a2b674..cf010c0504 100644
> --- a/drivers/net/intel/idpf/base/virtchnl2.h
> +++ b/drivers/net/intel/idpf/base/virtchnl2.h
> @@ -265,8 +265,6 @@ enum virtchnl2_cap_other {
>  	 * if a reserved bit is set in a standard completion's tag.
>  	 */
>  	VIRTCHNL2_CAP_MISS_COMPL_TAG		= BIT_ULL(20),
> -	/* This must be the last capability */
> -	VIRTCHNL2_CAP_OEM			= BIT_ULL(63),
>  };
>  

Although technically perhaps not as good as [1], this avoids significant
divergence from the shared base code, while still fixing the core issue.

Acked-by: Bruce Richardson <bruce.richardson@intel.com>


[1] https://patches.dpdk.org/project/dpdk/patch/1734537913-1159-1-git-send-email-andremue@linux.microsoft.com/