DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>, Kai Ji <kai.ji@intel.com>,
	Markus Theil <markus.theil@tu-ilmenau.de>
Subject: Re: [PATCH 1/2] build: fix reasons conflict
Date: Wed, 31 Jan 2024 18:02:49 +0000	[thread overview]
Message-ID: <ZbqLSXx_rmZGNQ6a@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20240131174552.2601531-1-david.marchand@redhat.com>

On Wed, Jan 31, 2024 at 06:45:51PM +0100, David Marchand wrote:
> The "_disable_reason" variables are subject to naming conflicts.
> 
> This has been caught while looking at mingw builds where the graph
> application was skipped with an <unknown_reason> (which is caused by a
> missing reason variable set in app/graph/meson.build) and the graph
> library was skipped with the same <unknown_reason> too, even though
> this library meson does set a proper reason variable.
> 
> Example in GHA:
> 
> =================
> Content Skipped
> =================
> 
> apps:
> 	dumpcap:	not supported on Windows
> 	graph:	<unknown reason>
> 	pdump:	not supported on Windows
> ...
> 
> libs:
> 	acl:	not supported on Windows
> 	bbdev:	not supported on Windows
> ...
> 	graph:	<unknown reason>
> 	node:	not supported on Windows
> 
> Prefix all those variables with the type of component.
> 
> Fixes: ecf75180171b ("build: list selected applications")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

  parent reply	other threads:[~2024-01-31 18:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-31 17:45 David Marchand
2024-01-31 17:45 ` [PATCH 2/2] app/graph: fix build reason David Marchand
2024-01-31 20:38   ` Tyler Retzlaff
2024-02-01  2:31   ` fengchengwen
2024-02-01  9:24   ` David Marchand
2024-01-31 18:02 ` Bruce Richardson [this message]
2024-01-31 20:36   ` [PATCH 1/2] build: fix reasons conflict Tyler Retzlaff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZbqLSXx_rmZGNQ6a@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=kai.ji@intel.com \
    --cc=markus.theil@tu-ilmenau.de \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).