From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 434C943A40; Thu, 1 Feb 2024 18:03:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1361342DFF; Thu, 1 Feb 2024 18:03:29 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by mails.dpdk.org (Postfix) with ESMTP id 7EA2D402A9 for ; Thu, 1 Feb 2024 18:03:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706807007; x=1738343007; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=8CY4ewCY9lPCSkOyrFsAJ9VKsoe2+Y4hloeEks41O6s=; b=OycGDTunsAVuYqL/6J5fYp1k8svhv+BpY12yxDFovHJ1Wcil5nZTE5vG whXHU4ntmQxC5LU7xSZ+4JV9XkYhIa+tKaLN87duefxmIO5y/RTz+pMIz c+WGqP6fuoW+iEsOztuyvG2gmdREXIdvDWD4UgCCuWWqf1OrOvKKcWEF8 PwiJFnDux93YGs7Ue3A5wjHoSXNtiw0iFQKG36YfGxBTzht1j4IMykdHD zXOH9VGgHFXTELkNo2dZFkSp0vNPZb/zFkqVjo1xs9euKnpB8pvFCBT2C wzWzGaQSQggSaxA7e/6xyu1/RuoHTrEfPAQV9XYFNmOSnd3zfuvSrhSdG A==; X-IronPort-AV: E=McAfee;i="6600,9927,10969"; a="121886" X-IronPort-AV: E=Sophos;i="6.05,234,1701158400"; d="scan'208";a="121886" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2024 09:03:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,234,1701158400"; d="scan'208";a="139482" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 01 Feb 2024 09:03:07 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 1 Feb 2024 09:03:06 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 1 Feb 2024 09:03:06 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 1 Feb 2024 09:02:52 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HAsOzyFeX876WKY7Tt2ABZ1Sh3Z9P/P7QxK4TttedRBZCMoyqZoZT/evdFvNC9FZYXfV3y4glu03T6zawrY+yyjnFvoUW7Q968agydJygoyYNFCutjNp7CqxEJmGwHf6TVwXQbMd8z1GeUoaOdMb92h2NglynzbI+7Hwatmddq62dEx5/2HnPVUnUMPOD2Op/mQUTNKKbFkfw3N+/o/1lc5M/QO/6PCkmuCLQ6VdH7kNCH/Q1U5uR9R94gml6yDz7OD0grXdIh5yLdRr9lhZneAz8MmtQKai0n81yFUOodZJpFYawsUGZp6nUwn/UTUvdN1U77ujgddeYESpa0++LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b5gVWxAYUkGpp3aoGNoCuW6k/nvecXnJRYHypCAR9ds=; b=NxUAsJikBfCveezj6LOJE9D0u2aLQXe98q5dlOG3nUL/U3iSkKSAeRwHhRi+P9Abnl74uW11ovoKHcV/bJWlfK7NaIiaCyESQ77MU6CPQfoFmrSFSFk42FiJYdfc5Ay0ga260H0yRNIVfWSav84OrfhTJHEHWyUDBZkNDtamnyFcpVblxH1MhzC/xgvso0CO+UzLt4md0x23csK9UcvbjQ+m26abJitm9+ul4DIWdnTIxyY60yp9ih3+VNy9bW6ardhzsVdmrASFhLcTSOdJBqhbAUiZMNNI92oUaG/CPB1pQ89KF+fl0pX/MmQurXj8+YktypfowxDM1ngiSoR9qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA2PR11MB5004.namprd11.prod.outlook.com (2603:10b6:806:112::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.29; Thu, 1 Feb 2024 17:02:50 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::df88:b743:97f8:516c]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::df88:b743:97f8:516c%5]) with mapi id 15.20.7249.017; Thu, 1 Feb 2024 17:02:50 +0000 Date: Thu, 1 Feb 2024 17:02:44 +0000 From: Bruce Richardson To: Mattias =?iso-8859-1?Q?R=F6nnblom?= , CC: , , , , , , , Subject: Re: [PATCH v2 11/11] eventdev: RFC clarify docs on event object fields Message-ID: References: <20240118134557.73172-1-bruce.richardson@intel.com> <20240119174346.108905-1-bruce.richardson@intel.com> <20240119174346.108905-12-bruce.richardson@intel.com> <211a59b9-095d-418e-be82-b49f4e5d1d00@lysator.liu.se> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <211a59b9-095d-418e-be82-b49f4e5d1d00@lysator.liu.se> X-ClientProxiedBy: DB3PR06CA0020.eurprd06.prod.outlook.com (2603:10a6:8:1::33) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA2PR11MB5004:EE_ X-MS-Office365-Filtering-Correlation-Id: c51b106e-2345-4e78-9d34-08dc23479f22 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2q2nzD1IW1q7czSox29uqtRVadZvBhCnA9RQlU1cPp4QEEHo+doh/I0/NFPCnBlULrP2p0Qyp7d3BQlmYV+FBRTTDhlwnZA5LsMADk/ktkvEAuRxsuu8GJX4pIHwXiYUSWK/o14faaISM9EifmnC87YusxQ8XKEHGo2mJMH7l8MjntXDZyidvYevW0MFpt2m8QdN5wP4YlzToDbZ6K7BuJdflqqgO+wLa7ilv0bLZ3E7fje7SW4n8RHbvSVB+eoN8ATiLwR1rICQ7QoJ74mMmTNgoXdEQ2Cds4yviGVOFnyP6J3Kw1KZ8N8BtdTOgQmpbJGiA668X+OWf6mXOMYf6Ogyyb2zsjNs7eZ5azlUqassLrdwU/158eyrx4scG07l2avlytqKxhdUo5LKeOlgSmTXCfB3llqyf6CqZR7W5aVZYojaKwQALXNsfoQggR6R+VanINZaWCtQHSkZMJOlCeU1jKXeKdgrawPhDFZpzG8RQ3JIgp2dbu1qS3TGH9qX2YD00CJ4vVQTxrcS+H9MRNOqO7yfuxCDNJ4NEw4EcDwLCvOKN+ZrM/i9z97V+dpX X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(366004)(39860400002)(396003)(346002)(136003)(230922051799003)(1800799012)(451199024)(64100799003)(186009)(83380400001)(6512007)(107886003)(26005)(38100700002)(44832011)(8676002)(8936002)(4326008)(2906002)(478600001)(6486002)(6506007)(53546011)(6666004)(5660300002)(66476007)(66946007)(296002)(316002)(66556008)(82960400001)(41300700001)(86362001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?vtHahTwxpufcWRZ1cPxqoP1p0Ydjt2u2cEtd6qRSTXxrL+ONB0yyvlTBam?= =?iso-8859-1?Q?Dmy+q+y0Phu5wWE4IvU+5J4oKJnxhCY23gYYaWnrQtVPp26BfmRt/J4/Kd?= =?iso-8859-1?Q?EVQ3nvn8S8r3iCItEpwpZSHN3fYxFRgzL9ctcdtT/Pwv7+dpS7w1Cfc6DQ?= =?iso-8859-1?Q?ggPPmXgjfHfVFw9WfnXyHA5lXkXWKTUs/IqmQx2P0oHLNJhD0mGPkDVQy3?= =?iso-8859-1?Q?K1W/LShgNiv2TBzJu/nhNfNIIrlIc9bvKxsOa4LMVIpGtQkGM3iaLcu7PO?= =?iso-8859-1?Q?Hx6KGpKcYYefh9GUrc7/y5Tbzg1lARZvIjbhDda4dr2Yx0xol4kPVlie6x?= =?iso-8859-1?Q?jjwM+Qna5hewL2WFXvqIc4Dfe2ysxvSN9N16Lp/wAvcNVBj6E/Lh9uX6EV?= =?iso-8859-1?Q?GnYW/8mgD9xd1FkVj3NYlOMzJxbFMoSE/hyPpmYmU7EflVZQo6YkNa0rUo?= =?iso-8859-1?Q?rugaDW8ERR5k0a2moNlBomaDeFOqKsCf72zDyMEbWudZK6SWuldfArRJee?= =?iso-8859-1?Q?zo0BtV+RcGbOFC29RvxU508vMIM5YkjqtctpQeu8iatmKbGv0bId/nwm0i?= =?iso-8859-1?Q?5Ohpbg2cnXFvZsMqv54s/2eOxfrSEHcdb6oH3J9l1pXrBoYk567n1TET5g?= =?iso-8859-1?Q?G3eglCRO7+QcakJ5WLeP79SA4W576p5pmsJo6nYTcjGr4VXAwvd8EeNGtE?= =?iso-8859-1?Q?CpsP/74XVYxVQtVR5hNVDpwedZzGZzG9qrWhS1sWbVpfVqG46VelmLSXSP?= =?iso-8859-1?Q?tT7jQPMQHa6bnzj2DnmodJzmXWmnsS7fFlWxaP5pXEbUw7ieAvMnNe7qEd?= =?iso-8859-1?Q?Gnw4HygZhPcpxmR9oBqa8jXTUY9YskeU+BVwMrdqItMjVIMx4upYg2TJx+?= =?iso-8859-1?Q?bC5n03hYVSrcO83zz47epTu9dA9oxR6C6Z4MYKaY81qK04dqvJyZjb4jju?= =?iso-8859-1?Q?HTSBGHfGKcadhnOIUFwRI06q15xq5o2ohXwl8bj2zONllUxQhxUA0GAm7N?= =?iso-8859-1?Q?Hnjn1ni07TfW4CMDE2pXSbmfw3TimaDuO2EAdPoSmO0gXnIIwU8K6nHjj3?= =?iso-8859-1?Q?CA/7qv4tM90S7mqW3O3peSxZqunV8hxL0+c782gln8WZ66b5rIlYQyEVXG?= =?iso-8859-1?Q?Z8jjX38oixY/qCqI+fenyH8UeNi4TDiH5aw/e1MvhLyOfYTxz27PJgYENb?= =?iso-8859-1?Q?YS1NI/XTiN2sOn4KpYR1Vyh3gak2kQB2Omty/1x/CLoxnkHgzoFRdzPK/g?= =?iso-8859-1?Q?SvHb44NWnCmnf5eQxMeB5zDkkBCCyScZ6TMb0vyxRZoiYpc168bVXRFUEW?= =?iso-8859-1?Q?aoWi0BLx+rXW9inhGOOy/aWw1gguHDAQen8b94qvimgFwsBuCuQoDePFpu?= =?iso-8859-1?Q?P1MxydhTZB0LnhFpDx51+QXUB6v+Fybn1ed0mU5XEbrHyg6MnJnwVDOdVY?= =?iso-8859-1?Q?s/WzZuoUVlm9xtyFAAaDGgaaDMlazUTFHO3wIzkNPHgWe0tQdAnq56Imxn?= =?iso-8859-1?Q?pEnQEIQ9vubJSCCimOLUYVLOEIsVv0u0JBCy6/dfI2mNkOx2Q1+Huc2NOJ?= =?iso-8859-1?Q?m6zbFRP5nfKJ8zNIP3VrUSAB3hoq/vMFltcoRprxf9lj9q+g7e5uuTOjg4?= =?iso-8859-1?Q?Pocw9AAHo9kSu3Ty50otEITeRWHLikOlVkrS2f/lB9KrQCxiyaDD7rjw?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: c51b106e-2345-4e78-9d34-08dc23479f22 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2024 17:02:50.1509 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kLttiCvqPpNZ5i7UcfaAJFSelOQKDksgjdJKhB1muLPCmOjb2IW+6wcBpVOjNsI9CITtyOdUJQ+QPMOAKSfpZ1snnBhIHhy/p1FjXqnsT2Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5004 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jan 24, 2024 at 12:34:50PM +0100, Mattias Rönnblom wrote: > On 2024-01-19 18:43, Bruce Richardson wrote: > > Clarify the meaning of the NEW, FORWARD and RELEASE event types. > > For the fields in "rte_event" struct, enhance the comments on each to > > clarify the field's use, and whether it is preserved between enqueue and > > dequeue, and it's role, if any, in scheduling. > > > > Signed-off-by: Bruce Richardson > > --- > > > > As with the previous patch, please review this patch to ensure that the > > expected semantics of the various event types and event fields have not > > changed in an unexpected way. > > --- > > lib/eventdev/rte_eventdev.h | 105 ++++++++++++++++++++++++++---------- > > 1 file changed, 77 insertions(+), 28 deletions(-) > > > > diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h > > index cb13602ffb..4eff1c4958 100644 > > --- a/lib/eventdev/rte_eventdev.h > > +++ b/lib/eventdev/rte_eventdev.h > > /** > > @@ -1473,53 +1475,100 @@ struct rte_event { > > /**< Targeted flow identifier for the enqueue and > > * dequeue operation. > > * The value must be in the range of > > - * [0, nb_event_queue_flows - 1] which > > + * [0, @ref rte_event_dev_config.nb_event_queue_flows - 1] which > > The same comment as I had before about ranges for unsigned types. > Actually, is this correct, does a range actually apply here? I thought that the number of queue flows supported was a guide as to how internal HW resources were to be allocated, and that the flow_id was always a 20-bit value, where it was up to the scheduler to work out how to map that to internal atomic locks (when combined with queue ids etc.). It should not be up to the app to have to do the range limiting itself! /Bruce