From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60C7643A4E; Fri, 2 Feb 2024 10:36:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3CE70402DC; Fri, 2 Feb 2024 10:36:45 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by mails.dpdk.org (Postfix) with ESMTP id 8F4B14026E for ; Fri, 2 Feb 2024 10:36:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706866604; x=1738402604; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=U/B+nP5f7X3wp/uIL/j+mAkBxtg5yJTiWlFUiXS/fcg=; b=kYXZKeXPBOMx39dQD1myvgzD1GUBS0HqwNfOpqAPemXT2MIFySFs84L0 xg65rzOG1SzQiYJvnqEqDiYRIS1Tbq5cTty3ttz0O+q8BTQ2Z9kIpwhcb 6GQdkgn/9t+xH7aXEcZgIPGap7PPAhkpNqJqDXqUcnoPXEuAUc45magYz WHvIZA7sckvRygWmYktNopqPVEHdILTvo6BTOmCQUJXWWI9LLXf3pIEND 08EeIycVTGc2U7x58WSMnLCitXVxp3CF86xh2jjFo096F2OB9r/d5Hgdb V8uLhTnn/RkQaG8KOQp+cX8LesCkVnpBCowuT6UcrAlyKQocp5neBKSqE Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10971"; a="34218" X-IronPort-AV: E=Sophos;i="6.05,237,1701158400"; d="scan'208";a="34218" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2024 01:36:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,237,1701158400"; d="scan'208";a="4653392" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 02 Feb 2024 01:36:42 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 2 Feb 2024 01:36:41 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 2 Feb 2024 01:36:40 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 2 Feb 2024 01:36:40 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 2 Feb 2024 01:36:40 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jRxOAV5/C1dkf6tH/hV6yREhgQzyQkV3fJ9S+fj4eT+7rNAR4ALmo2Ak4/qE580sX3xgiMD6k6Lc9QJAJVGJVPmEhTk0RJ67Gr71HZAHcwPOVc/JpV5inRqjg0plP374HYLeWMyDJ9/tbLh60La1uzPaZNIOvVNwj7Ovyj/6R9HJ4RdnQNBKTxFqezAvUecyiyEyrmE8A/xT8O07CQHYK7SV1l4ffMpw/DwtlmnJIoj6mzEXKNdSXY7M6xiZl11Pzs521TWK3G7ZzZMCA7pM4qGQCp82aHNnHt6ASCz3+Rj/+1WtxpPZZ+JqgBkF32ztbyjoEFEgE9awmDvIzXfW+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N0+Rh0l2gjtN5et0ChgFV+QxEx6KSuPX2defiX0W/Zo=; b=YMB+9Tbwj8BR6A+OlhqFAS7VbM00bUb1D0vWrflJNrJhG7GvqHTNGb+jzVmONXpp35qLJAlDdxI3bj8GfVJ6PTblygHqknJEh3JvvET4UpgtKYr8RKVNShwJ4ynIu7nz1fVH8XiRCIkrhM2LFgjoDhjVYduk1FbK6HYhOyG2hkquJ08G0aifl58sAlsIc8zI5ChJV/Oh2m3FJ17FcOI4osLeeXLD5Izoj6bzOPWaUjKJbrBCiX7RSqp+i+nRW6hIdettWvSlayvs4CeJFTrRVK0uGxy0OMDSG4R8wiD0FKfOp4rvgBgWvUCDKpARzcebSRnYTgGWegB6tpulCsFNJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SJ0PR11MB6621.namprd11.prod.outlook.com (2603:10b6:a03:477::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.32; Fri, 2 Feb 2024 09:36:34 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::df88:b743:97f8:516c]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::df88:b743:97f8:516c%5]) with mapi id 15.20.7249.027; Fri, 2 Feb 2024 09:36:34 +0000 Date: Fri, 2 Feb 2024 09:36:29 +0000 From: Bruce Richardson To: Jerin Jacob CC: Mattias =?iso-8859-1?Q?R=F6nnblom?= , , , , , , , , Subject: Re: [PATCH v2 11/11] eventdev: RFC clarify docs on event object fields Message-ID: References: <20240118134557.73172-1-bruce.richardson@intel.com> <20240119174346.108905-1-bruce.richardson@intel.com> <20240119174346.108905-12-bruce.richardson@intel.com> <211a59b9-095d-418e-be82-b49f4e5d1d00@lysator.liu.se> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DB8PR03CA0035.eurprd03.prod.outlook.com (2603:10a6:10:be::48) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SJ0PR11MB6621:EE_ X-MS-Office365-Filtering-Correlation-Id: 5144e6c1-cfd2-4d2e-0958-08dc23d271c1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WLXma3uXWXPSc9Y3bz3OGIIo4t7PLxwJdEMj8QcebiOjpaQ7iSV1Z/5DwngKyNi0oYYckXcB8qUxutp63uYHDn8bH6KgbWf91+cIQ+JPA7P8fqbui3DRCYUbP//sidTZh3Z+hcM32ocA70VyLs7WAws4Tfdsd/1/to7i2XkXlC/LD5/MexTb9mRK9AqoEOJQp62pTBBWy9oNikyhglbh39SjQJ5dwLcZaPjMyYy8pKmIQ3ZtxEt1PyTAy6aZ9QAv83HpGueOCSG8SmMXJFdM7sYSwqOq8dyniYo6WLMGmHPck9L7tXNBjP0lIHnFUvMq5F6HliBe6IK2YhiRQEmHS6lir640+CszeAtFDdp7Kak5i+i+OZFyYkjFUNuhn80cL4+jVLROExSE5U7F8hrKYwm21x/XecWDIEELSOd3kAT+qFHxGNLkjKJgO0mP5MOn75ZwzaV6I6PqcPByrEL7wau+Gcvg+Dta9VmTfhBNhuX/E75b0JROCwi+8u7TNiJvbG5tJMOn15/gecgectJzv30R5rKPYjcwlV/J0vPbQ4XvzsZ4EMBvC8H12FKHjc08 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(136003)(366004)(376002)(346002)(396003)(230922051799003)(64100799003)(451199024)(186009)(1800799012)(44832011)(2906002)(8676002)(4326008)(8936002)(86362001)(66946007)(66476007)(66556008)(5660300002)(38100700002)(6916009)(6512007)(82960400001)(6506007)(316002)(478600001)(53546011)(6486002)(6666004)(83380400001)(107886003)(41300700001)(26005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z293WHhmUEhidU84aTBjbHJwUTdZNnFDZDcyUGIzMlQrb001NThJRllMTHdw?= =?utf-8?B?eUVUL01wUkVyc2hNWnNKQ2F1MnordE1GdThscGduOFZlOGpLSEYzZGFGYmlw?= =?utf-8?B?RDJGVlNKcGpIaVZ2TG5meGRWc2N3TVVETnlYN3lvUzZ6c2ExYjF1dFQzcTYy?= =?utf-8?B?d1p3U1lkRnY1emJWQSsyN1FDY1E4VmF1VFV2N2VkNlNOWlgwT3NRbDJDMkcy?= =?utf-8?B?T0R3RFVOam5xU2JDM0RHV1hHMzFqR3BNZy8wSExES252dkw0Sk1pTEZBVm5U?= =?utf-8?B?SUdvY0Z3Z2NBbC85dEYvUmhxNDNFMVUyMlg0TFpta05lWVRGUUhEWDN1ZzZW?= =?utf-8?B?V2FSakgvNUlQWHFqa2hzTTNjdHdWVHIvc3U4Z2Fkbkd1WWpIWUcxUzVScVp5?= =?utf-8?B?TmlGOTQzSmhsTGk4RTgrNmtZeWkyK0QxbzZwQ2htbmUyenZtWWZWSTNiOTN5?= =?utf-8?B?OGg3bFNLMVN5YUJkRVlIZUQrc253eGFld1ZMZHlqbVNpLzhWY1FjTThrMkZL?= =?utf-8?B?SlVLUjcyamtyN2hxa2FaRDhvd0E5MUlLbkl1R3RHcmwwc2xtM0dCekhsN0Fx?= =?utf-8?B?YkVVaTVWbFJObkdzNnlVZVdjaGt6WGM4LzN3cXFIWU9abmhpWEdBN3RnKy9J?= =?utf-8?B?djVZdnBBdkFGZ08rWlVEa3FrNHJTSnowdlZUQ1kvNFlINldUOEY3ZUZ5Zkgy?= =?utf-8?B?R284azNBV25ld041SzNPY1UwNGt5R3UwdlVKY1RUMkFEQ3BvNGtER05qc0hw?= =?utf-8?B?RFRRTlIvL0xyNWhIYm1la0piV2VTUEdwbWtMYVVqZ3AxemQyNngwYlFnOTYv?= =?utf-8?B?WDRUTytUZHhCMWdpOEtYcG8zWnc0WCtYNitNMHNwak5qUlFWV2k2NmY5ejN4?= =?utf-8?B?VGZDK0lrL0pHekQwRGprL2ZOdkFRalNDNCtrTEtVcUNEb2d6SnIyTXM1WE9L?= =?utf-8?B?bU1CcUJaUVVkdTIwVmdsT05ySnhWN3BTMGhFeTF4WURFZmlodGdKM0dPUXI2?= =?utf-8?B?cnNPdk1xc2c1U2ZqTm5BdWJvMGUwMkxhL2JOcTJyREJSejkwOGkwOGZIMERp?= =?utf-8?B?TlByRERjSzF2UExqR21qYkEzUzRTQWJpQ2U1UjN5dHJ5ZS9ic29DdDcxR3k5?= =?utf-8?B?bEVITmVlYXRBRTUwaFpGbFgrL05yMm9MS2RDd1NqUmZOMno1VVBuV0JwQTI5?= =?utf-8?B?SzhWNllWTU9UOE8rcnRlUUY0Skh0VlVDYmtJWVBiRUFoUC9hazFINFplK2VG?= =?utf-8?B?MlE2U2lQL3lBQUc2bDdxUG9mZmJrejVTOEtXNnVtck1KZTdGZnV2ZkdkdmEx?= =?utf-8?B?Slk0VWtFYU0yOVBjWVBITzJzc2tHRVhMbEpkNUxERnFtRzRuM09QRk14WFBF?= =?utf-8?B?dWJoNjBoNFBGem05MmtqbWRqVkdjNXNKbVdIaWZxMTRHNXdYWTZDeWxCcXdi?= =?utf-8?B?N205WjcrOFRNcWM0Q0RmNHJHREFzL0pWZERzWHBqSmI1WWNQUittemt5TkF6?= =?utf-8?B?VCtLeUhkVEtGZlF5bVl3RHhQWkNYNTE1aHVaUmdKaTQxSzdhK0ovQ1ZlNk5s?= =?utf-8?B?K3VEek1ZL0NwTnVsd3NxSU83dytRTFVFNWtVWnltMldFa2FzVng2RGpPbzdV?= =?utf-8?B?VlFzem1yNittQlRYR3F1VVlEemRnQk5kcDZwQnM5SjkyMUtKdHVDY216eDVI?= =?utf-8?B?cmVnOUQ2eWx2bVBnbTcvbkFEcEZVRUhwWUlBczk0Y0diRXVwTTFud3pmM2tx?= =?utf-8?B?T05meUlXbG1GWSt0aFVrTk1FUUJXUFRMNUdVV04zaTZCNU5Hb0E4aUtNbG9i?= =?utf-8?B?b0FPM2cxcEJDWm93aGp6M1VyOFpYbWNjdFFaa0hHd3VVaHIwUGZXeFpTTkh4?= =?utf-8?B?MEpzcWlVZlI2ZUhxMWpxTU9ZTTVRWW80QTBCZmlZR3c2aEZNWnlyeVdSZS96?= =?utf-8?B?NXpTcFF1MkVwMkwvbytHZGtweFp2MmQvUGVPTEh0eksvNW4rdEhPUnUxNm9a?= =?utf-8?B?M3FvQVg0WnRFa1ExczFjQitTcWpkQnRWYklCaktCZEVpLytYcFB3VzNISDht?= =?utf-8?B?ZmVUVlY3UllIYVFFT2FzMFR3dStRNyszcTNtUWlXeUpxTllvbmhTSUlrZXZs?= =?utf-8?B?LzhSck1zUUVURkpjN21BaVJ1WEdwdHlFT2NmeXJSVS9ra3hhU3ljbW5YdkRD?= =?utf-8?B?K0E9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5144e6c1-cfd2-4d2e-0958-08dc23d271c1 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2024 09:36:33.9364 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ANueXcouyp6YaHFVVH7hTZiW5OIDsmRrkr3/jlX5qOTlwvuDeyNyHLTJNuRoPLkKEevVaXip6nhnDW0PXHc1LGMtx2PLcqMlQfgLb5o8dwY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6621 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Feb 02, 2024 at 02:52:05PM +0530, Jerin Jacob wrote: > On Thu, Feb 1, 2024 at 10:33 PM Bruce Richardson > wrote: > > > > On Wed, Jan 24, 2024 at 12:34:50PM +0100, Mattias Rönnblom wrote: > > > On 2024-01-19 18:43, Bruce Richardson wrote: > > > > Clarify the meaning of the NEW, FORWARD and RELEASE event types. > > > > For the fields in "rte_event" struct, enhance the comments on each to > > > > clarify the field's use, and whether it is preserved between enqueue and > > > > dequeue, and it's role, if any, in scheduling. > > > > > > > > Signed-off-by: Bruce Richardson > > > > --- > > > > > > > > As with the previous patch, please review this patch to ensure that the > > > > expected semantics of the various event types and event fields have not > > > > changed in an unexpected way. > > > > --- > > > > lib/eventdev/rte_eventdev.h | 105 ++++++++++++++++++++++++++---------- > > > > 1 file changed, 77 insertions(+), 28 deletions(-) > > > > > > > > diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h > > > > index cb13602ffb..4eff1c4958 100644 > > > > --- a/lib/eventdev/rte_eventdev.h > > > > +++ b/lib/eventdev/rte_eventdev.h > > > > > > > > /** > > > > @@ -1473,53 +1475,100 @@ struct rte_event { > > > > /**< Targeted flow identifier for the enqueue and > > > > * dequeue operation. > > > > * The value must be in the range of > > > > - * [0, nb_event_queue_flows - 1] which > > > > + * [0, @ref rte_event_dev_config.nb_event_queue_flows - 1] which > > > > > > The same comment as I had before about ranges for unsigned types. > > > > > Actually, is this correct, does a range actually apply here? > > > > I thought that the number of queue flows supported was a guide as to how > > internal HW resources were to be allocated, and that the flow_id was always > > a 20-bit value, where it was up to the scheduler to work out how to map > > that to internal atomic locks (when combined with queue ids etc.). It > > should not be up to the app to have to do the range limiting itself! > > On CNXK HW, it supports 20bit value. I am not sure about other HW. > That is the reason I add this configuration parameter by allowing HW > to be configured if it is NOT free. > Ok, but that is making the assumption that the number of flow slots is directly related to the number of bits of flow_id which can be passed in. I think it's the driver or device's job to hash down the bits if necessary internally. For v3 I'm going to remove this sentence, as the event RX adapter doesn't seem to be limiting things, and nobody's reported an issue with it, and also because the rte_event_dev_config struct itself doesn't mention the config value having an impact on the flow-ids that can be passed. /Bruce