From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1ABD343A4E; Fri, 2 Feb 2024 10:14:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A7394026E; Fri, 2 Feb 2024 10:14:36 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by mails.dpdk.org (Postfix) with ESMTP id 2EA374021D for ; Fri, 2 Feb 2024 10:14:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706865274; x=1738401274; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=2NC2t2+bR4poxFpkHkuycLxgGUhXyebzjLvYB35y/fY=; b=ceBrYsmfNmB5JLSBs9TbeyDGvW/gG9IRR6E0P8+3a2zn4kMoUULeWyXO bQttztyZIs0w45gBJimL3vkusTRxpxhRYHng1TFdUrbrkmQsCUQgLEern hKolGl7DfX17YV5fr1IzjEphFHJrX6KpPQha5Pe34cfRDEVrQqD4Ryhic bV4UjsYrkT0LnY3Sbpehf/kC9q1lurMwpvzQSlE+JAtQPjouIbcF6ThxM AoqhEhYe4mOXHHhdnYzFKKof6LpLu2tUEi8kJRvY8Ai/MV7ywifdmJ9n7 qS2P5ZhO5ZhBGb1bpntbQx7T3oooAb+JzgHbhE1Socn/ZrNlCvLvi7LX0 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10971"; a="3943131" X-IronPort-AV: E=Sophos;i="6.05,237,1701158400"; d="scan'208";a="3943131" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2024 01:14:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,237,1701158400"; d="scan'208";a="23318378" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 02 Feb 2024 01:14:32 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 2 Feb 2024 01:14:31 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 2 Feb 2024 01:14:31 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 2 Feb 2024 01:14:31 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 2 Feb 2024 01:14:30 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xvg3heu4J7EoEPlGtWUI0C+RmM1ECAIMn0qz8qoNBIxg7fojThC6ZK6N5VHFLAPahEWicWg/ULK3o70/YvbqnP5V5KAahUr5DnaGJms6uUYelL2JJnBHfnKmjktx35oexpJhXGGchix8RQ5niqeX6+1LxQCEZ7ZXnjRmxLA8xOHToXApVMRjyXQrWpIMLf2oZ7lir/IoF+VVnBz/YohgGbawkL2oQggiRg3l+FHTlo/WiLbH/Z/CpL+EbVipUDGqr9FPemJPVCApGpJb2WejdktV12AgCVQt1oB0QYeJLSDzhSb39OdrsPPoIRlPvNh535EjVPvTBVbOP9+/W6NURA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PIAG6knFlzI84+OsRnJXjgjA0symKrfIfVBaVQfcXiE=; b=g9PoLGIswaladDIWGbe6xQGo1wUyKdTlwoMb3kdOs7O+Kg80WOkyIyHoW+RJ2v4kxfi778aIsys5voTsB0aGSioqmu3CTEdbjZn0n09DQeW0GOMzDPOEYvk12YToA9eql0lwe6Bfnwfmrte3VZcWU6Z1IVOLL0X/kQP9aRSRRfn+0szt5pM25nNjYSVea0C/7e86RYkj+YbZoVt0SzO7MnGw3gU1tzMyU33GOhw/mew1xlggPg5mQBRHtpYVoplEpvvlgwXfwvJGqwDQMS9GXObujMXpDofNLtNx3vjg55G9OOusbiKTD/hyBOIHHyosqk4D7vFiOpYF3nx6YlHaqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MN2PR11MB4568.namprd11.prod.outlook.com (2603:10b6:208:266::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.30; Fri, 2 Feb 2024 09:14:23 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::df88:b743:97f8:516c]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::df88:b743:97f8:516c%5]) with mapi id 15.20.7249.027; Fri, 2 Feb 2024 09:14:23 +0000 Date: Fri, 2 Feb 2024 09:14:19 +0000 From: Bruce Richardson To: Mattias =?iso-8859-1?Q?R=F6nnblom?= , CC: , , , , , , Subject: Re: [PATCH v2 11/11] eventdev: RFC clarify docs on event object fields Message-ID: References: <20240118134557.73172-1-bruce.richardson@intel.com> <20240119174346.108905-1-bruce.richardson@intel.com> <20240119174346.108905-12-bruce.richardson@intel.com> <211a59b9-095d-418e-be82-b49f4e5d1d00@lysator.liu.se> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DB3PR08CA0001.eurprd08.prod.outlook.com (2603:10a6:8::14) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MN2PR11MB4568:EE_ X-MS-Office365-Filtering-Correlation-Id: 6f177b0c-c775-4530-a53a-08dc23cf58c6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9tlgPI0zjeyqfzkSiR4T4LQbD7RO/8mwv/jX+AAiJqIyy5kzIbUerqRYovg7s+csA12RB5y5qYexWkKuGuZiyaPhSqY60yrCbeWwdo6yX3CFLIvBQ0+wZs+x84dYURVyP6oMgC73SqIbEy9MjrT8wgTRQx9BiNyGC6aNc3LH3C86x4BDvBXD+cnc4y5s/aiFeWP7urK1elrmm0YYNfqn5Hy67R5N2ekmavSwOYns3OFBQTWQBIc19TqBF2gUJAyKZLJkpBx6sltgEujYiHkenInt37WujsjdGe1nVHvTM55OojgKCSZNug/0ytnHaBQxjxIZ53MKLKN21HI5jB06YVv9MEhOdNzNZMh5Fg6NrnY/C+mXgGHNiXeC5lxAmIqS0oODD+bwBN/I1qfpGfjAEp2opw5uvUJOkoQHbSaEXghXmu896eLDNB6I1IK/3m5gBz1V3VLJUWct4J1+5CteHXikodq49dh/TWLSWUSei2RBjRA7rsLvnnG5t4SHaMfTTJFeT+gcT0n8mKyWUyv4RYe7pbdESMdoGhA1/YM4inRSedkWh6PIbcHWO9jBjzCM X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(376002)(366004)(39860400002)(346002)(396003)(230922051799003)(451199024)(1800799012)(186009)(64100799003)(41300700001)(83380400001)(26005)(107886003)(82960400001)(38100700002)(316002)(66946007)(8936002)(8676002)(66476007)(5660300002)(296002)(2906002)(66556008)(4326008)(44832011)(6506007)(6666004)(6512007)(6486002)(478600001)(86362001)(53546011); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?Bmvh8KhaiTjQXWqak6r59512tyS5x0x84anHnmo8d+yYyzgIsbr16BFpSP?= =?iso-8859-1?Q?2nmUwbcdw3DMeeIA2BLIxZLUaiBuZSIpLssmzoTBCic/QOiGD5GbGkAv6k?= =?iso-8859-1?Q?uQcvowdrr6m0Hd3pC2wsoVdU9EdMtnNJ64OUn/CAMLBll6XFvyVCJx/YEf?= =?iso-8859-1?Q?ya9a5ugONR1uI3zP+nWuZhPFIY1taX/kGgGTTrg25iryctEyJTQT9V3MfC?= =?iso-8859-1?Q?SSUmoqexzpjWUeWDhD02JM7K/46dwHIo+//PECTmvpR9X0G/1TnFGDdwi9?= =?iso-8859-1?Q?+QkpfP7e5OL9ZFm1nSImg4OMC/FGQQbwKdJarYpEGhSufaoOot24buNSsl?= =?iso-8859-1?Q?Hv/n0yLc0QkYHPrScuOHEMw8b/LUWqJ4xzbMg51vVJL2X+k1Fyd1jWgFID?= =?iso-8859-1?Q?er8fPjd/ELPldZWL5WdAxa1ZQ1WrjliYHKOuCehjwzqIQIKOV19eeTsdIO?= =?iso-8859-1?Q?ScoUm9yLTqa6a2d3/5Y7ctzq77Nuv3W4pOENT/Afhy+OjtXs1hstgJDEOU?= =?iso-8859-1?Q?G0qY4k/rJCrWNFrRegVLMaAizIUXSPG5xc/GGLJ/JlgNqbQCBcfZ2KTtsu?= =?iso-8859-1?Q?nTj4MolxDnv46XJkxpCeGvhoHNdorBmk8QoBQK7crkvMtUVBTg3cMP6AiE?= =?iso-8859-1?Q?6Slscxhs8gixXLQdtx/RMrEM8Al70MYY7DcP+E12G+Fp6t0+pvrByd7QIO?= =?iso-8859-1?Q?bYp8Hzt/4IZ+su9guPa6gkNE1F2yczvfcI6PrZ53VDukKT6MDOtkvieGVV?= =?iso-8859-1?Q?9DlVW35n78V/c6GyS83LNhturDhRbSStA+NpQPNnCN9ozm7e2l8ypDed1n?= =?iso-8859-1?Q?0pPVNkejmzi4u6aqwnckn9QqUZyQYUuDyU0b2J8/jgeGWYswmLiNDxMm+2?= =?iso-8859-1?Q?vv0HDlq1nlJfF/ZiX540AVNBtsrE4bjlfepvZbVDwhFZM+xga1m0MByuRo?= =?iso-8859-1?Q?S5IvrNE4NkfaBwRYCamjP4NCXGKRxZTfnJQixcYooFiyvsLBqSGPrnpOeX?= =?iso-8859-1?Q?X+VRnQaXICkw2l0VfwikHnfRo1fcBPnO3mP4RxunvJu164UAJE29aNN4Yq?= =?iso-8859-1?Q?v82KzsP/yyiZGXVa+w/NuRRsC6t33nyU8lfC3kNthO9GuXnIBKUahysxWY?= =?iso-8859-1?Q?zjRwHfbSnr3K+rr/401Ij5O//e4BaO4pDEXO0S8SEOBL5+OsDwCQV0qIGI?= =?iso-8859-1?Q?3C45jOcBTxTAVpu6+ZSWEjjePYIajX/yqkMPsj8V/NP9H1qgsmjhpMLBIx?= =?iso-8859-1?Q?rbpRIF+gHvzcKSF2NGwAoCCj9cciDnBkxgNfoBI4ZVkZSFzurZK5rI466r?= =?iso-8859-1?Q?TqfWPC8I7JzuRvjsLJCjHtPoD1GL7hVqBYx6Duaq7sH2K2Gct9Yit+dtfn?= =?iso-8859-1?Q?m0cKKsM3ichPVoAOfef0qNnZt39pD8TxPuGerzDE3kzHJxR6W6Nvk6VIYc?= =?iso-8859-1?Q?bnPgAn3sNmakLKgBpUlkEdY+HChgT/SH4msObvGKVv3zolLz/g/uFSrXHG?= =?iso-8859-1?Q?ScIdPwDAeHC1v5aDHadgvq4KUcfezzlnnUECCDTBa6RmtE/+9aPnBDpMb8?= =?iso-8859-1?Q?kPwEjo0cn5ZZdeQccczAPENoNFRPVBxf/ai6EiO8RIRIeB1c6q1hgVu6p9?= =?iso-8859-1?Q?1j/+yzzgSUnB8ztot1cHiyS5yVvIadULNZcpKU257AKl+w3HDcCHTiKw?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6f177b0c-c775-4530-a53a-08dc23cf58c6 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2024 09:14:23.5454 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 43VCIQGu2chvRSXOqmtYRPffD2P7kxZ1P1lwbvcS8AYB9UKC2UVGmKbzyleSr4mv+h+BcAJuQr3d6H3LnDXHCYVTw9yOY1i/nA6LV0wDAzc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4568 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Feb 01, 2024 at 05:02:44PM +0000, Bruce Richardson wrote: > On Wed, Jan 24, 2024 at 12:34:50PM +0100, Mattias Rönnblom wrote: > > On 2024-01-19 18:43, Bruce Richardson wrote: > > > Clarify the meaning of the NEW, FORWARD and RELEASE event types. > > > For the fields in "rte_event" struct, enhance the comments on each to > > > clarify the field's use, and whether it is preserved between enqueue and > > > dequeue, and it's role, if any, in scheduling. > > > > > > Signed-off-by: Bruce Richardson > > > --- > > > > > > As with the previous patch, please review this patch to ensure that the > > > expected semantics of the various event types and event fields have not > > > changed in an unexpected way. > > > --- > > > lib/eventdev/rte_eventdev.h | 105 ++++++++++++++++++++++++++---------- > > > 1 file changed, 77 insertions(+), 28 deletions(-) > > > > > > diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h > > > index cb13602ffb..4eff1c4958 100644 > > > --- a/lib/eventdev/rte_eventdev.h > > > +++ b/lib/eventdev/rte_eventdev.h > > > > > /** > > > @@ -1473,53 +1475,100 @@ struct rte_event { > > > /**< Targeted flow identifier for the enqueue and > > > * dequeue operation. > > > * The value must be in the range of > > > - * [0, nb_event_queue_flows - 1] which > > > + * [0, @ref rte_event_dev_config.nb_event_queue_flows - 1] which > > > > The same comment as I had before about ranges for unsigned types. > > > Actually, is this correct, does a range actually apply here? > > I thought that the number of queue flows supported was a guide as to how > internal HW resources were to be allocated, and that the flow_id was always > a 20-bit value, where it was up to the scheduler to work out how to map > that to internal atomic locks (when combined with queue ids etc.). It > should not be up to the app to have to do the range limiting itself! > Looking at the RX adapter in eventdev, I don't see any obvious clamping of the flow ids to the range of 0-nb_event_queue_flows, though I'm not that familiar with that code, so I may have missed something. If I'm right, it looks like this doc line may indeed by a mistake. @Jerin, can you comment again here. Is flow_id really meant to be limited to the specified range, or is it a full 20-bit value supplied in all cases? Thanks, /Bruce