From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58D6943A52; Fri, 2 Feb 2024 11:47:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A56B542E3C; Fri, 2 Feb 2024 11:47:14 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mails.dpdk.org (Postfix) with ESMTP id 91F744026E; Fri, 2 Feb 2024 11:47:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706870833; x=1738406833; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=sewk/DZUImfrTW/9ikoBul2OXBOKFqpQhbNj/G7S8Do=; b=eSCp525q30udilrTUZAbCsx3klSZRS6qXZ6lFu+FCOmF32FtOga481Vo LW2YcmVnxYWrM4DT0hQzNbrjuyGx98pSUPvMV7/9hCVx0RfllC3+tO4Ta 7HWbidnV4KNjBoQ/VnFfaP/ePZ3ot5IiBYj6sARgMvaCjRayzDqhwud4J FVcHJBbFhOOBEK0LaT599Cxm+p7kZd3ziY6nKF29ovcA5yFlzJMJqtjmN dheGflysNhkT9ywqDlWahYaUuCb9iCWhIWuCNeAGuCpiCyy6/wGz8sfEX 47uj7/r3aAgfbXkLMQaCcnnkpKq93l3GEHTVK2jKxM4tDkoE466/zO9Oi g==; X-IronPort-AV: E=McAfee;i="6600,9927,10971"; a="17552311" X-IronPort-AV: E=Sophos;i="6.05,237,1701158400"; d="scan'208";a="17552311" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2024 02:47:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10971"; a="823183680" X-IronPort-AV: E=Sophos;i="6.05,237,1701158400"; d="scan'208";a="823183680" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 02 Feb 2024 02:47:11 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 2 Feb 2024 02:47:11 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 2 Feb 2024 02:47:11 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 2 Feb 2024 02:47:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M0P0wtbKvq5L1JJXP6Y8AD0TgzYXcjJAq+Z885lGBsVmBmnV7UGJARVATBMgSspvp+Hi0QOSaJ70vP6V8OS13Wm8weAOhSo/ajJGAhjUQIS963U+WoQTBA3KlZ9oeEdRZUlKdb5OhcVvxcvfsNf3iPUZF6+hl2w4uf+Ga65ANnh6RtZgJzRCXjsmuId7BjYVxkiHQ9ryRy39PFtI2ydNspjidzpLU2w/MvEzcj+byo2KDAAMDDVB4tXHvZjQdgxvEF7CajRVQucpjjbsAOLby6eJi/jBI92WRU+CzaWlsEm4IpR7/QpGqdYLXbCZaJAk3y5+juwytY5T0lxhTGdJrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ODs2IiMlX8zsy3l5PdrfUlJWa+7wRU2cJQ5UQpfrFy8=; b=Avv5M1QZHTtVfvrqcGuF9EYTc88Fesl0DWX26p3IlKjPYI+GsHjFD63t5c7sFksleFl4p1nhg6ZbzwsaSWGjUDMGWe6bKql+JCjGhaTl5mg103JcjRuPcukH7c5Vzilz6Wl7v7P/PnagD0y2BGEDs7qH7dpzDLqnPBNDTwGNGtiUyQVKq7mtL0cT+e24kwIKaeyQ739GZUOaKJT5W0M38NZKgcytv2qpARZdTRk29gYdf8umP9llnQC2rGbvqck8nPzVySrkxAmAru1x1wZhUM69gP7GGRwm68lnPz0ONZz85fV/NygJJAaPdxte3DCEmSx3Gh9M6072nAWjVCmW1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DM4PR11MB5343.namprd11.prod.outlook.com (2603:10b6:5:392::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.30; Fri, 2 Feb 2024 10:47:08 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::df88:b743:97f8:516c]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::df88:b743:97f8:516c%5]) with mapi id 15.20.7249.027; Fri, 2 Feb 2024 10:47:08 +0000 Date: Fri, 2 Feb 2024 10:47:03 +0000 From: Bruce Richardson To: Mingjin Ye CC: , , Jingjing Wu , Beilei Xing Subject: Re: [PATCH] net/iavf: fix access to null value Message-ID: References: <20240124020555.3336924-1-mingjinx.ye@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240124020555.3336924-1-mingjinx.ye@intel.com> X-ClientProxiedBy: DU6P191CA0057.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:53e::15) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DM4PR11MB5343:EE_ X-MS-Office365-Filtering-Correlation-Id: 81f00ec9-1d79-485a-71f8-08dc23dc4dd5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HxtDTK4Rqd7/Tppd8wJnEzyPpI4vmbbybI/S4Beie3HFQcU54LW7IOxP+lGU7ow4t5ggvotQ1ibwmas3M6VM1g0N0fIZGrRVQWhlD9ZaZenNoeW2c1Zo39a7vTY3Zb3zFbepZeirQZxztJLQ+oDzaSCfostBQ9HbMZdUG9a3uB92LdEZMISWJaOHhV9xz1n4jX53PMdmQkpWX2MxuLXUSUb/oXwtbXJdY/szmNWHF1lBACDEBEwRzzY4ivEd7EACD2X/JVGqnFcbijEzd2ACcv9LabpPbO/zFSALl3r2P/CkNO6VuABdIGdQxrUblz5m8DG0Y3sJMOaCk7c6rGlTQO29SdsgUexAbh7Hr4kSLGx2q+Qo1mmmD1lR2FfAe5VbG4GYpqgo2DdSXCbdmJ/vmgXWpWpB+6HLa0PwDL1U4Z5VuWqR6nNrfgKQpiWsPj5bNAS3554xPyXO9F3mUCDDu3Rw2ZUqtamToPvM1xn+mv1dnq2Pths5/SGetKa2CE+o9toddI2sh8aiZYevwomfzSlL1vXfgFIYqzij0USBTYSvBbB7iUzzL7upNabnWEif X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(39860400002)(346002)(366004)(396003)(136003)(230922051799003)(1800799012)(186009)(64100799003)(451199024)(83380400001)(41300700001)(82960400001)(86362001)(44832011)(38100700002)(107886003)(26005)(6512007)(478600001)(6506007)(66946007)(66556008)(6636002)(316002)(6666004)(54906003)(8936002)(8676002)(4326008)(450100002)(5660300002)(66476007)(4744005)(2906002)(6486002)(6862004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8meY3nBUpiUgZ+4mnpdXRHO1WMxfOoOXP1kNZjZypKY2MusrsddXsmGGMI4w?= =?us-ascii?Q?o0d9nFtzKHLzJayGtjdb4/9EmsM+4cYpGBIj0AHrdgt/lfxo1VwLpk6GlxBv?= =?us-ascii?Q?WF4zp2SDULPWxTmeofgIYjtVjEw0/ky6ecZDTS9eNZMCIrVrkqrrt8Bl2iye?= =?us-ascii?Q?sk+vxetn78L3nYyoN2diw+d+EwvNV22KSKAxExYjtgnX0uQ/6yi6zsD5toD5?= =?us-ascii?Q?KfSfONLQo8l8X0+pEg7L9FSIhw36qci6WbUi+EWguaseBZ8rHho/m9Rh0Pws?= =?us-ascii?Q?HehhmPlaBzst6v8H5JyHj8wOZEMyKhsvRLUSBD6BGUBzmf3HNt24EJX6gw65?= =?us-ascii?Q?Vci7Q98/FyVGYM/fZ6uoW43f5L4G/5eWcZHrm125TIee+wGXg19QjT9VD95x?= =?us-ascii?Q?moqvL+0OIpBkgkpAAd2LGmVj3UMNF8yHCEmyI96ler77G+CvU+uIaxev8ZX/?= =?us-ascii?Q?AC7pgNwg2E2vdUUFmEuyeEzPYAjz7l13dmcVFbuTdT3rVQIlYvtIMd6i0m/I?= =?us-ascii?Q?rXMAuqAY+5QTphOMuIq2YOChEaWtbtK6cle3kRZ1N7woMe2qYRIqm4s4TWvM?= =?us-ascii?Q?7RVAfzRjdYOlhq77YE3cV4SVOii3IVNkoKbrFwOKRmmpWDmJdR6ynLDrQupj?= =?us-ascii?Q?sXDj1NJzK7muOfmudx/8EN8yCjFCeMIY7CSBplhaJXtHh5GgYbuy1JZ/FKYW?= =?us-ascii?Q?+dtcbuorktQavaL48DbvzNKpIUQcWcctoKwq4ovlZzGNU0gfjDHITkGGCTKp?= =?us-ascii?Q?s+5ITpRaff/ewpNkMmHip0IguLSq0vAR8MMNeJRX+j1iH99t6GiKROXgiWom?= =?us-ascii?Q?zY5qiPBhJXIjD6f96rY7Bk19xMSvdboX4LCJxjMsob3KmzsEX2Kb2fzLjUPh?= =?us-ascii?Q?gZpOtOYhEP0zteg21CebhDVNpWdAGKthYpzPV9J4DCKC2rO92WDrnhm2qnpE?= =?us-ascii?Q?FEC+qz1kJK6fMqU/3+5h/vAguRN7YlHcuOtpwwjS51aaxMavLMBJyyUhiekO?= =?us-ascii?Q?9QGO25IST6yrtan2n6BpYw2b8GPXs3C1Kzp0fV3BKkI1eBn4vDkhdHpCyygh?= =?us-ascii?Q?vcIVBXOXr63h5y0Cws0kd1pi5pIvqrrtQ0cVElJOfkD21MwApqIO9/Jw47nd?= =?us-ascii?Q?nTaRG5tG6bi+iu+O9o+H20uy99RXSMo0mVQgKM/LtH8ju3QVMRlFTjs3bk6y?= =?us-ascii?Q?sJC6d2kyZYXVSD7ZbrB/4bIBZGf8ZnUxT9hb62t1+mB4uFE9xIB0pxjxrUlF?= =?us-ascii?Q?iluuYX3ChrdsPS2fEZj2SFw2yNG+jn/DRLxzW9bBY+p/vu4yfjn4240UY9Jq?= =?us-ascii?Q?qDacG6f6bs6LHTlcfa4nxbvfdVd09RvlV8xszFrOXPf8ZjbAbNtlymf6y/X5?= =?us-ascii?Q?KhKK8k2p/TH970m76HMUCur0OCnarD4CccxceX30N7El+pU9boiA68eBlxY3?= =?us-ascii?Q?Qs2k9uSGlnPVPsq8DMe9vKTSV3nvRO4CQVVQoARgRefv6m61gJo3Aq+bG8C5?= =?us-ascii?Q?5vCC4HpEt9aQq7E3PaTQVOkeDJUN1f8KRTWSfv104PPahMn3Io84gFLSJEc+?= =?us-ascii?Q?zSrYRg75Tshxv+FxS3yng2tTn0ZhHNW/6jRdacCPQKIkbITEMIvR/8nWORDc?= =?us-ascii?Q?Vw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 81f00ec9-1d79-485a-71f8-08dc23dc4dd5 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2024 10:47:08.6257 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ILPgj6I/FvoPfNSKxhS10JdpAL1Fh4web/edEEud1AepOpggphlxSwKYjqn5e2yAFpAfVQ4o8ZPovNmpyg9Cf5vB+Mm0TKJ4icegPV2Plqs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5343 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jan 24, 2024 at 02:05:55AM +0000, Mingjin Ye wrote: > The "vsi" may be null, so it needs to be used after checking. > > Fixes: ab28aad9c24f ("net/iavf: fix Rx Tx burst in multi-process") > Cc: stable@dpdk.org > > Signed-off-by: Mingjin Ye > --- > drivers/net/iavf/iavf_rxtx.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > This looks safer with the checks this way. Acked-by: Bruce Richardson