From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CAE4343A99; Tue, 6 Feb 2024 11:03:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 52EB1402C8; Tue, 6 Feb 2024 11:03:14 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) by mails.dpdk.org (Postfix) with ESMTP id 019A14025E; Tue, 6 Feb 2024 11:03:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707213792; x=1738749792; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=zL6hOvOF1UwLrNOUaFk1iXL3HAw2vIY5HVM3PqJn3pI=; b=mk/RUVKeTk3ayHoj6xtr31E4cBsSZDe3YOQIeLt/C9SkWr56vSGjzM+C YhYHE82bmuxMEZZB7+nrpH6nXrnH6nHP6uQWpCgpnG5PvRpae5vStPr4a +h7Wsd1HYn2DoC7KNwLGAzGT+sZGz+yF3K7SE2LDxHcl3SulS0JhpgQry X4fQscA4ppt4aoNVUML2hTJjIBtxm5kLppYNRgMRbRPkvhziS6ds7WDYM kSKwmGsTHzJOI8L+Ok23htQpKGHG1gwifjbTmIZuAy+OCY836q9fENtKV wr6v/db4cK+9VO2w6VQP55URRRh5kKya5evl8+gnCCP+ranwtW79uFmyi A==; X-IronPort-AV: E=McAfee;i="6600,9927,10975"; a="875516" X-IronPort-AV: E=Sophos;i="6.05,246,1701158400"; d="scan'208";a="875516" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2024 02:03:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10975"; a="933418158" X-IronPort-AV: E=Sophos;i="6.05,246,1701158400"; d="scan'208";a="933418158" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 06 Feb 2024 02:03:10 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 6 Feb 2024 02:03:10 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 6 Feb 2024 02:03:09 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 6 Feb 2024 02:03:09 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 6 Feb 2024 02:03:09 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IGgK+RQ5kReb/FvuI6wMinZGKWbfixsHzNTaM2PigXvgAOsRsBV0n9cs9Z124wDiveDbVnENYXpB9sOgDP+1d1lFGrxfuB6lNvtL37xFN2QdSB+uhR3n/fR5veGvstSUGWfJOs+dCZKHkQWXAqwrj0Y812AxMIo0VxLXXAt5wkeimO/fX62afd1Vv5mfqNKZD5Kc3Jv+eLyucUMqJFCdUmk4CPFxKHbe2leaBSIgTPKp/XalrJ9G+0bBhLP+b+EOM3V/IriOWdXDJSD4cMF14vbxgWUgzCn9Or3JhfGikvJyzxpjHQYKmJAoHPl2fDtk3VHqqCTBG077jadEaN0JAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/HrhKBoml99fChmPEiI9QB7qi75/ewuyzxPOqeEkEK0=; b=UY0G62yEKDeIIiDqjXhEUp3MfM5xEI1LDWgHmOPEthHProXphtri4Dl8q3ZNpOazeOImwScLVuM+pMIMjDOSZTNfp/HUpIZUy13s9urAELgNG8Qd1kvNuddSA/UVY6lqfbGhIgjkH46spjQ9ExuH6iiUmG/R67H2rMxjKeOUNIpgPRsd+/HLSt6trI4nTzrEEcwXoGF7j4pdg3ctOISqBjpxIy5oadw9a87FRhK5YrVFM9AL66tM80ubfJwIsZTwCtU+Uhr9AYtfeEBOkAU29T4H3jpZelC9IaVv4/VA+lCMoIoxQelRtTcTim/8W8orxh1G/DYuroEsyFelRQNMpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DS7PR11MB6015.namprd11.prod.outlook.com (2603:10b6:8:74::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.36; Tue, 6 Feb 2024 10:03:06 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::df88:b743:97f8:516c]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::df88:b743:97f8:516c%5]) with mapi id 15.20.7249.035; Tue, 6 Feb 2024 10:03:06 +0000 Date: Tue, 6 Feb 2024 10:03:01 +0000 From: Bruce Richardson To: David Marchand CC: , , Jingjing Wu , Haiyue Wang , Qi Zhang , "Qiming Yang" Subject: Re: [PATCH] net/iavf: remove error logs for vlan offloading Message-ID: References: <20240206095607.339410-1-david.marchand@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240206095607.339410-1-david.marchand@redhat.com> X-ClientProxiedBy: DBBPR09CA0006.eurprd09.prod.outlook.com (2603:10a6:10:c0::18) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DS7PR11MB6015:EE_ X-MS-Office365-Filtering-Correlation-Id: 0237b281-be3b-43bb-2ff1-08dc26fad098 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vj1tcGYCJqb4buTdk2gA4j0kBP+H+MDtFAyeL8a0cAFTYVc+fjsI4RDJYPNzx5k2cX0rEvc4A/yo+/zhuplSeQk58eW9xhH8w2N70na9DRq0nyQtWqbzKHPDdtgidyXT8yzQhIz3y2YfPpC/wOsIvDSAoMfP6lyodkNHLOxZYLj0PvFfpW3iwODUFcaqePfj/QrVE4SktMFeGjQZW1YFRwZfP/XS+Pr7ysOr8am7Ik51TaW2ki3nXMgqK9hpQBlc1BxXd1Ua7HPR/d8LSqV2gEP8iHznIAuuCyt/BtvHSH5ZV1Pdp4l/zvGxWlaKx3V9bbUvCBL2RcRgzE/KfsDVbUeCRe5k8lLBCEgEEdC6pptdUUHCdeY2ZbtqurD5dzJRA6p8qi/Xvjm43pzUDiS4vD7Mm4gDLii0QF/ROJQxuw80fjLeBLzbUE7/2sCLRJng4XnzS7p2H+z+nli/hxIh8vk0/jQg8zR2VgMbPOURQ2GVPy/AuT4LxWyUFk7StP2Daj8a+QnOZw00LKl1i9wC5xW4SKeIkrQahWR5rnyddrxa7vLdNLHULI3Ybguoi47g X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(39860400002)(376002)(136003)(346002)(396003)(230922051799003)(1800799012)(451199024)(64100799003)(186009)(41300700001)(86362001)(4326008)(44832011)(8676002)(8936002)(5660300002)(6486002)(478600001)(107886003)(6512007)(6506007)(6666004)(26005)(66946007)(66476007)(66556008)(54906003)(6916009)(316002)(2906002)(83380400001)(38100700002)(82960400001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?g9JN9HBLdRJ0SjopGw6FZ4n1MdRZGMeTu3v6Csjj4f/Z9tnu0NQTl+Qbp4Az?= =?us-ascii?Q?UT0sSku8i83KOrYjd+Bq5D1SCbj3bB8/WZEIEYzn9MOS0A/Iys/Nw7IPGVxl?= =?us-ascii?Q?4b2x0YucMZLb/XNH82Jv0Fyt9AOfZLyPQTqZM6ZVMBfvJYOZjoEoB2qe5jrw?= =?us-ascii?Q?mdt9owIVp3QgU71pK7TnqEx4injZnIOvwz+Yw6G7NlQABsH57r3sJ3vrJfdE?= =?us-ascii?Q?tO8SbtiNxHnqyl17eDTW7B5TPe8e0ukFrytAOnI+cwyviHdH7mkQ7LU66YHv?= =?us-ascii?Q?A2j7y3o1yxF1LtEHUPqZvDTh3uYZ1XsJAEZ7JV6sytEmWh4CToc8b+NeXf/D?= =?us-ascii?Q?PcUuseLJ2BQ1em5ymXs/ojfSjbYq1oNyVTcYXAE8MRfZ+792qa3Nh+ux3XXk?= =?us-ascii?Q?6eITwVrPsC9V3tPVgcqsxAYGs/8wQTjaM9RCeuQWAU+8R3c9k9Nskoo4fOCn?= =?us-ascii?Q?uVXh8aPro8CDIdMkignKM1thkEmAdSxkk6Hmmn3FMO/iMya+nhmXDZ101oWj?= =?us-ascii?Q?cAYGqsdXsZlJOy+TTfVjj20n3rIQje7khRk8kXa4FaLi++goHcBpN85f3UFH?= =?us-ascii?Q?V2KnkcaqlnQMVYGNX3W5dTLcfY8sssYdeSl/PKIOxmv5F4BaARlXOo06K0ty?= =?us-ascii?Q?72J0Zhbb9shmBybvAsHIOZqIzBoe3o2tjEBC3i9VT0xEoFyJddIeGW7PeYwi?= =?us-ascii?Q?5lEYrLgFMo/BKJCFtwspThTOlbB6Xd2rUCosoCXi2sv32PHmYzzO/JHFQdHo?= =?us-ascii?Q?kvEB/Y6wHrpPab7tXK8aJfw+Zw1q08/3hMtnR9UUjqBlpAHzHhfYLG3YnAkY?= =?us-ascii?Q?wgCWy8LASOKePx1lHTPlhaSC4vAHqSQ4ELSK5FCHq9VahCmeHk5K5rw6SGq6?= =?us-ascii?Q?LKxfigr86mUZRn1tnS/AlQvFaIjLsnV/n+iRb25+s8mFTIDIvRViHBD6PvZO?= =?us-ascii?Q?ZI079KFN4YvJHnGy5jrjtlJiUsQSL2nbZQg13wMuRsyU6fEcaj7Ltt+OkObi?= =?us-ascii?Q?soL8ODDvoeNQDq2zMAhn9Lx74ysI3OCwuY0gsJ9GJG96AydTp0tsgWt2zLps?= =?us-ascii?Q?v015rDbpxWSHLQXmqr+A4QnJGBfXTXQcpMS4kMGPDXnlI8PXsZe5NHbdwwXp?= =?us-ascii?Q?A0m8aUUl24cv4e2Z9QKUg6uCpAWOa8yuSZ57cNTx8HXmTqgy9Z0OrSo1Qkrj?= =?us-ascii?Q?PkbysUf/pdwzrsTGKEkZSSPmz2ql4F6Qq2pE0k7sy6JIpG0JSuAdJhVqgR2i?= =?us-ascii?Q?+7f2I+bHPe8YpLtO3OiDuWyJznIMQJrbUFy8jgjb9zHR23nC/BKSgxhJXk0R?= =?us-ascii?Q?o+znSj3RZ4rn9hRnc3wMoTU2WaurRk5GAKqFRfcr/da95XL85y0RjlPr3iVt?= =?us-ascii?Q?0btK1+4g/m6TBVrzVXDo1B8CJfbKktEzIApds0qOfXBefHCzRBgj2jhzGGVz?= =?us-ascii?Q?i4j0CFDcgbAsec+VwmDgWtaoM03NHg4ZY64pmZ3APOS4egw7bpHj8vXqb2N/?= =?us-ascii?Q?j2m2kSgbev3c1fGvxlVTCb/kbk2eosVXr3fQF8D1MG1OdFteBPjcLmiNtaz6?= =?us-ascii?Q?jJdGS/aZkeq0ODC1ZZnwoyZkgWdy/OQHB6eVE/6H5dIL7eRKzHBYOqy9tEAK?= =?us-ascii?Q?9Q=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0237b281-be3b-43bb-2ff1-08dc26fad098 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2024 10:03:06.5085 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1rwDdwmqiSm8ULumE6eNwywFK/C5m3D2KiqR3GEpbOUELq1I9jFWWHQFMvtFaWxA2vSE7nfux3/BG3YB/A3OJgsjqhaZbgA7wvLvI4rv0FE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6015 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Feb 06, 2024 at 10:56:07AM +0100, David Marchand wrote: > This was reported by RH QE. > > When a vlan is enforced on a VF via an administrative configuration on > the PF side, the net/iavf driver logs two error messages. > Those error messages have no consequence on the rest of the port > initialisation and packet processing works fine. > > [root@toto ~] # ip l set enp94s0 vf 0 vlan 2 > [root@toto ~] # dpdk-testpmd -a 0000:5e:02.0 -- -i > ... > Configuring Port 0 (socket 0) > iavf_dev_init_vlan(): Failed to update vlan offload > iavf_dev_configure(): configure VLAN failed: -95 > iavf_set_rx_function(): request RXDID[1] in Queue[0] is legacy, set > rx_pkt_burst as legacy for all queues > > The first change is to remove the error log in iavf_dev_init_vlan(). > This log is unneeded since all error path are covered by a dedicated log > message already. > > Then, in iavf_dev_init_vlan(), requesting all possible VLAN offloading > must not trigger an ERROR level log message. This is simply confusing, > as the application may not have requested such vlan offloading. > The reason why the driver requests all offloading is unclear so keep it > as is. Instead, rephrase the log message and lower its level to INFO. > > Fixes: 1c301e8c3cff ("net/iavf: support new VLAN capabilities") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand Acked-by: Bruce Richardson One small suggestion inline below. > --- > drivers/net/iavf/iavf_ethdev.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c > index 1fb876e827..fc92cdf146 100644 > --- a/drivers/net/iavf/iavf_ethdev.c > +++ b/drivers/net/iavf/iavf_ethdev.c > @@ -631,7 +631,7 @@ iavf_dev_init_vlan(struct rte_eth_dev *dev) > RTE_ETH_VLAN_FILTER_MASK | > RTE_ETH_VLAN_EXTEND_MASK); > if (err) { > - PMD_DRV_LOG(ERR, "Failed to update vlan offload"); > + PMD_DRV_LOG(INFO, "There is no support or the PF refused VLAN offloading"); Minor nit, the phrase "no support" seems ambiguous on first reading, since it's not completely clear that the no support refers to vlan offloading. How about: "VLAN offloading is not supported, or offloading was refused by the PF" > return err; > } > > @@ -707,9 +707,7 @@ iavf_dev_configure(struct rte_eth_dev *dev) > vf->max_rss_qregion = IAVF_MAX_NUM_QUEUES_DFLT; > } > > - ret = iavf_dev_init_vlan(dev); > - if (ret) > - PMD_DRV_LOG(ERR, "configure VLAN failed: %d", ret); > + iavf_dev_init_vlan(dev); > > if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_RSS_PF) { > if (iavf_init_rss(ad) != 0) { > -- > 2.43.0 >