From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 041BC43B37; Wed, 14 Feb 2024 14:07:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D24BF4026A; Wed, 14 Feb 2024 14:07:19 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mails.dpdk.org (Postfix) with ESMTP id 0B03140263 for ; Wed, 14 Feb 2024 14:07:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707916038; x=1739452038; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=TuThySqRnQUretWML0ZQVv7/cXPSYstjDQOa3iQY/jA=; b=aCw78/x6rXnSZfKWGUxYmMVlT3a1GHapL57CBNageraC0Y7qoKwdJkVq SaQ6t0JR8V3edtzjnciYp7R9Nm6CZMh8sMt6CaeCqYssaglWHbdqO2I87 kT9i0qcPolRpXP0ek4p66Wdbg3Zl5AlGy3CIl02MurHFBo3Miy1+DzTGI iQ6UO7zxdPw8Y+qxh19k6GZ3LaQ8IL/mBAY2xyRgd5NyyLXos75JHOTYu tXiFKgLq7OZzgQ5Kr8JhfqP6ZRA9Lewq1x9TAyvMP61oHCoqmGS/43949 A50OSNyasPUVIsRjA+wHjk+xgSDsFgU4ZlLEbYJnm5nFn3gkwVMJMwkJJ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10982"; a="19375155" X-IronPort-AV: E=Sophos;i="6.06,159,1705392000"; d="scan'208";a="19375155" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2024 05:07:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,159,1705392000"; d="scan'208";a="7933177" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orviesa004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 14 Feb 2024 05:07:15 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 14 Feb 2024 05:07:15 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 14 Feb 2024 05:07:14 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 14 Feb 2024 05:07:14 -0800 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.41) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 14 Feb 2024 05:07:14 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LadXrAf3N+nVDzZi/lbIsk3Auj6nhZRnEp5kF/gceVXpkQOFf26dhCzRoKE2l1jM5iVC2i9dPG+I6CEYiTcfaVIcMV1guLH6omyZRGwq21S/PI6SERPb4IWdT9pL+RnlukRUBhR4lym1HRjFmHZvwT3tj5evH+jyIE6g7m2PXZIOcBDsm1QG1/uj2m7a9iMwVIMWukoz0L0h1hDihjoofNIM+wJ81kpMcHqqZTn2QMbOS56mNaZc4RuWA2zmmgenE0a217PNzp7cs5w9xujs2Y0Te5VSdZgRLX9OhGOcCy8VMMws19kp325q0WGNSPhQdQa2gwm9qz/6vbYqc2zyJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0NUIGGmurS8WSqszj8Odp8S5GVArRCewakRnyi1tUrA=; b=LFLAmmCbdPs7XRLE3icqT9LRovIw2j7RSnf9yArMTTy+OUTOpXtIRpRn241CNcdOeZs0If4uZ26MUhxrO9G43IJbNsbsNhfC6/zC3dyD5tBbw25sC5XFTIrMPYEUA/wKknOSS0VLFcvlbkntp7rGKSj0lKcjptIxE6Sut0W9I+oE7SjA3sdHQ1YSDKARm3ikuUTt5V7nPVJLamfsCT1WZqvgpUOJWh+pjcc6tgf+KM1LgQH350xU/meqbzntp/P5FRWxWzBW/uvyVweoF/qEh5SYyjN3FV4cUTHsuLYWim/McxfEJ9saWBTKQsffAUKzSdptupSwfGimacGNcLRRIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MW4PR11MB7149.namprd11.prod.outlook.com (2603:10b6:303:221::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.38; Wed, 14 Feb 2024 13:07:10 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e%7]) with mapi id 15.20.7270.036; Wed, 14 Feb 2024 13:07:10 +0000 Date: Wed, 14 Feb 2024 13:07:04 +0000 From: Bruce Richardson To: David Marchand CC: , , Sunil Kumar Kori , Rakesh Kudurumalla , "Jerin Jacob" , Srikanth Yalavarthi , Cristian Dumitrescu , Aman Singh , Yuying Zhang , "Brian Dooley" , Gowrishankar Muthukrishnan Subject: Re: [PATCH] eal: add helper to skip whitespaces Message-ID: References: <20240214121219.3408867-1-david.marchand@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240214121219.3408867-1-david.marchand@redhat.com> X-ClientProxiedBy: DBBPR09CA0011.eurprd09.prod.outlook.com (2603:10a6:10:c0::23) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MW4PR11MB7149:EE_ X-MS-Office365-Filtering-Correlation-Id: 295f3f3d-de7f-451a-dfab-08dc2d5dda9e X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hpHkq1lP3K/b0N2IdrCIksRbM8NKI/FXs6X0HoCCmemWHNwIYFZ2xgu26+Tt1zcnn3ZQwuTZ5Mj4NIy0G92OTXo7SE79fXb/99MepGmqw/NDvB8DtdledRg7+GppdEerL8nJOgYQ31SPx1PGmycLuwCgXOuE03rQR+ddnpEb8gYVF0uFBe4X6AU3CytTJSBAkbc3dBSOjOUQFmKXt9qJe0DBvflTJPqw5px66iWxc80yxnrkWOTYkAXHyW04yuHeztWkWCtDpviJdDUOgcvZ9wOeghdcSQRpBG+21spel5lwi6w65WFiPldf5c7mGbbMtbSTD20QbjA7S+bPYXRiJiL4KXHkegtBmvLwjke6RcbsFxnq4oga9OzOOJECMwB2xp6R7SK1jhVLtp0FrZ/IroBkNI/Nf5c87Aqbg2oaJu6lc1QA02RkGVIdw++PqwaM55xpzSmERNamGw5Jf3kA8jBqsV2qRVbuK0gJcOHqiYDLWFkIVOzmUU38OlrSepUKxkAYVNBjtLBH/QlBMJyHhuxI8RnL2tHd1YEUE346/G/tL2nTxJXmmIl2APTmCGzh X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(39860400002)(366004)(136003)(396003)(376002)(230922051799003)(451199024)(186009)(1800799012)(64100799003)(6916009)(316002)(66946007)(66556008)(41300700001)(54906003)(66476007)(5660300002)(4326008)(2906002)(8936002)(8676002)(44832011)(38100700002)(83380400001)(82960400001)(6506007)(478600001)(6666004)(6512007)(26005)(6486002)(86362001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PDZQ1vQP6JV1ydnMsM7vy1Fgry1xk1aqfdy3qqysAVW5ZTUSpVXTquE/xWG2?= =?us-ascii?Q?8jFjX/JVD4vnYlO89OOq9dPTMxJ2Szarnr1rK1HNpzjHIchO+VZ03yTOjCEF?= =?us-ascii?Q?a5RupPGlsNmNJ+Of6QTJxRL6WvywUkOyjhi+qMtIv1iaR4YKHNGETtlBdBW3?= =?us-ascii?Q?LMgHTc7uD/HFTjOZ0c1nZOx7QevdJvni753l9mtSACttEcvkYyQeQAnjMlGK?= =?us-ascii?Q?zEZG7acHLlVVsZAq5ftlJOGFRWtfRzU4a1oJupUjGX9Yi0X+8LC33PHYEhb3?= =?us-ascii?Q?lVBc4QMJW7gZ8Bd0I05xQGzmBdaaaEK/62mIkf9n0Hnzp0SB+rcwdSLF90B0?= =?us-ascii?Q?8crUaK6SB8b2ZBm2EQdMLmN1Yq7k4LK+XRyQXejCR0I80LsNFLxQJAoOE5Ao?= =?us-ascii?Q?RTX0vBPtL1PL6NctbAwa27lyYccCDeyOZRhG5SJamEgan5ty14Mphm7e3EdK?= =?us-ascii?Q?7U831BAUsYlqFProSeLgeOh0QgujI4Xcto3x5x1dPDhSAHxioppiKHexbm/l?= =?us-ascii?Q?aRuGr5km65aR3hMa2ExtIJl0FJ1Zzf/4fImwVekdF8TT2yZFygiq9rh0aZzf?= =?us-ascii?Q?o2S98CJN9MLWUwF2LTJsO8zhrhRFe7jUiH8Wk+Bo8SvCQjOjmMvIDAl0y2Bp?= =?us-ascii?Q?4rHyhQSQi+CsSg99aifqKbpIM3rG0m2qvyPwm4QDW00jer9dfhGBtfNL22hn?= =?us-ascii?Q?Y7VNDuBIp2ST2na2KK2tGY/dYCXGsT1kt+QXKE2AXst0IvuYI3lqhMW+UmqI?= =?us-ascii?Q?k/8ySV4qtiJG3TJ70p0jmeiU5JwY+gOc+wjKYLkH4YPzXTkb1rzRZ+o/aoDY?= =?us-ascii?Q?oRu8w0ZEic/8dKV8on8srX13FxeEpTRWk6vfEGoGA5JG33yeEop2jYSqUIwX?= =?us-ascii?Q?5pC8d3JJ4g+0fo/x+EGEd1jGJPpvoXfrWRxsWsJOEbDzPT1ZZs2UNxtSfanZ?= =?us-ascii?Q?dGEjBGC7gd5WuEFeQFfpzw5Cn1T2wxc4ILVry0qWgk8vs9hRGFf8/ya2Qswv?= =?us-ascii?Q?dyw12YcrtK4LWXBNb2wsHr6/tTjCfv8t4AWEAOQQZWmkmoObxc2y42tZmvhQ?= =?us-ascii?Q?goxnCkk3XDyjwcl0y+Hmg3DuDcu0oHKlYn+n1sQt1igNL2vZW3nWeUW07M4T?= =?us-ascii?Q?WGY8+kFzuT1PD2tMus7B5lp27bPF9cKmVfWGRqN6c6z+MhtE5gpLUtoQh4JH?= =?us-ascii?Q?eUZEPrYQSGInBTuKTNfs4n06lkmqB7t+Hxv3m5VbOvLck08SfRkNK+yqe1s/?= =?us-ascii?Q?vQ/Ia7fK17VtIuLI/8dZKl9pHcqVVIPFiUwAF71DVVCvt9bM678+VNnE6sv4?= =?us-ascii?Q?j3TjACNQzUwoTLEjIoyORf1XYP8i+EvBX3YumarSnWLKGcQSsVQMv2SrU/0z?= =?us-ascii?Q?uwc8yY1QZces2L29ZbeXSOaILGG0pu8FBGjCgiIrtqhbRljH2Z5xJIowt4wM?= =?us-ascii?Q?rx5fI2ccMBU0c97kXUuck3fd/SMuijq+mgm6HrCFC2pAnpuDXWOYULdYVKi0?= =?us-ascii?Q?+3bRmBG3WAesVhN3i5OCVc34p7wVUAfIMKNchCgNh26/GSbbKQvf3UG+Pflk?= =?us-ascii?Q?5FhenCOc7+f6xK38JA4NY5gV2NjNCro2QsUsFY5ub9IxmVrpXtmsiPIT3yOL?= =?us-ascii?Q?4w=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 295f3f3d-de7f-451a-dfab-08dc2d5dda9e X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2024 13:07:10.4432 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ac8KQYb8oeOThh13USY0ausLCNAo4zQKs53utR31jzgwhLP8CYYMlBkttGH8+01SpJGGIK4FhYSQZjAUtDOEMOKpkANsj5PLzGfxd7jZL4A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB7149 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Feb 14, 2024 at 01:12:19PM +0100, David Marchand wrote: > Reduce code duplication by providing a simple inline helper. > > Signed-off-by: David Marchand > --- > app/graph/utils.c | 13 ++------ > app/test-eventdev/parser.c | 14 ++++----- > app/test-eventdev/parser.h | 8 ----- > app/test-mldev/parser.c | 17 ++++++----- > app/test-mldev/parser.h | 8 ----- > app/test-pmd/cmdline_tm.c | 13 ++------ > app/test/test_string_fns.c | 35 ++++++++++++++++++++++ > examples/fips_validation/fips_validation.c | 16 +++------- > examples/ip_pipeline/parser.c | 14 ++++----- > examples/ip_pipeline/parser.h | 8 ----- > examples/pipeline/cli.c | 13 ++------ > lib/eal/include/rte_string_fns.h | 27 +++++++++++++++++ > 12 files changed, 98 insertions(+), 88 deletions(-) > > diff --git a/app/graph/utils.c b/app/graph/utils.c > index c7b6ae83cf..1f5ee68273 100644 > --- a/app/graph/utils.c > +++ b/app/graph/utils.c > @@ -9,17 +9,10 @@ > #include > > #include > +#include > > #include "module_api.h" > > -#define white_spaces_skip(pos) \ > -({ \ > - __typeof__(pos) _p = (pos); \ > - for ( ; isspace(*_p); _p++) \ > - ; \ > - _p; \ > -}) > - > static void > hex_string_to_uint64(uint64_t *dst, const char *hexs) > { > @@ -47,7 +40,7 @@ parser_uint64_read(uint64_t *value, const char *p) > char *next; > uint64_t val; > > - p = white_spaces_skip(p); > + p = rte_str_skip_whitespaces(p); > if (!isdigit(*p)) > return -EINVAL; > > @@ -73,7 +66,7 @@ parser_uint64_read(uint64_t *value, const char *p) > break; > } > > - p = white_spaces_skip(p); > + p = rte_str_skip_whitespaces(p); I like the idea of this. However, a question on naming. Do we want to make it clear in the name that it only skips leading whitespace, and doesn't e.g. trim whitespace off the end? How about: rte_str_skip_leading_spaces() It's longer, but I wonder if it's a bit clearer. Also, might it be worthwhile providing an "rte_str_ltrim()" function along with this, basically combining the skip_spaces call, with an memmove? Most string handling in DPDK is not perf-sensitive and so a function with similar name and behaviour to the python ltrim function may be appreciated for its simplicity. /Bruce