From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0B88A43C1D; Wed, 28 Feb 2024 10:03:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C16894027D; Wed, 28 Feb 2024 10:03:03 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by mails.dpdk.org (Postfix) with ESMTP id 46B2A4003C for ; Wed, 28 Feb 2024 10:03:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709110982; x=1740646982; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=lolMz2OjTjAEKezXYCZqNXuqc2KSqgDV66rdtz5+DtY=; b=k8ygL+myLgphlTDLUCSTovkmJKkOf2kKL8MSjVdTu8gUAOR9FUssUXnx NAUAIpo8N2UZw7+asSqtZzU8Df92l2+7u/cl8z88F5maUMElvkHeIUPgq qdDVLgwkI9qvo07TyMi0tDhpKdvICtIqS9LXmWVJpGIRBXu+XzwH920Na XWVtBqBsxsUg+QQoBNpHmTTwcsdThfqe7jnusYHS4mCMyLXspn1DIR2Su Ym35BYA3VQIOxIv1zw3G6yzuX5PjNuo1yPfjNB46+X71YRhA5vI2lZSPP /fXnGNoyNKEl3dxEnPrN+Gq8pRyQ6WyqjMhqWflJelgSQ8eotDdza2ntL g==; X-IronPort-AV: E=McAfee;i="6600,9927,10996"; a="3343496" X-IronPort-AV: E=Sophos;i="6.06,190,1705392000"; d="scan'208";a="3343496" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2024 01:02:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,190,1705392000"; d="scan'208";a="12078802" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 28 Feb 2024 01:02:59 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 28 Feb 2024 01:02:58 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 28 Feb 2024 01:02:58 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 28 Feb 2024 01:02:58 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 28 Feb 2024 01:02:57 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iubjWx9Rs0H6Um5U+7y3HK6ZRgv97lVH8GwYKT7ORgw7hEm+QI2nBke6s1llWOnqxXeWgf71BvW74GZMmLDoid0KwW1RS4wvSa902f86bc0/BDaQt7fX3URAf0NNBLgks+hPzqfMSfY53YQVGS8mF5Gnal/M1vKShJSJ2x4Sq9uOyUKN2RjUzNi7thVieqgMVuEeYym0/O1WIwlDiALw5vTuXUw3wc39c3f1g7YZa8dbKrswlinsmHc5skKzRMxkqQLlf9PAFfxirkFqnss91feYyicjEUwyBpEhms48OuYJU34rZEW0Z/cyktbVvPTrMx6j+anqQ2hQjZEPu+LYNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wKx9LxeVNUhE30KKSw87pm5c8yLfqYgYIkPy0Uzm2A0=; b=m0BQHQEUy9zH61QUF8TjvnlhhKkiycesyKQFW3wp8Z5YSyH8GOAZnisJX4G4enIsT+dJyWJPfyRQhdP8b/dbFI5KFKWSP3e2/4CXrZfl0d/cmoyehg+b1ZI0A6DHMhgHm3zBJAT7RE/AZsbQBGBq+RaXfIA4obQZnM/kIDaGeVxHigDQL4/mzkIMXuNUlJkVe+c4eoB9RSrfwobnj490IGf/ZqdV9I7msIIZVCyj+t943u/AqvWsUXSlC8u5mpnhZg0AyEr9p0sQCqvMth68iDi54e2rX7r4SCyRQ5twpkmc/Jj3KV1ePO6TbKuY+EUfDSMwfGgCtBahZcZDAr/R6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DM6PR11MB4530.namprd11.prod.outlook.com (2603:10b6:5:2a4::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.25; Wed, 28 Feb 2024 09:02:50 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e%7]) with mapi id 15.20.7339.024; Wed, 28 Feb 2024 09:02:50 +0000 Date: Wed, 28 Feb 2024 09:02:46 +0000 From: Bruce Richardson To: Stephen Hemminger CC: Morten =?iso-8859-1?Q?Br=F8rup?= , Jerin Jacob , Raslan Darawsheh , , , , , Subject: Re: [PATCH v9] net/bnx2x: fix warnings about rte_memcpy lengths Message-ID: References: <20240223140056.130844-1-mb@smartsharesystems.com> <98CBD80474FA8B44BF855DF32C47DC35E9F269@smartserver.smartshare.dk> <98CBD80474FA8B44BF855DF32C47DC35E9F275@smartserver.smartshare.dk> <20240227110604.56e19342@hermes.local> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240227110604.56e19342@hermes.local> X-ClientProxiedBy: DU2PR04CA0221.eurprd04.prod.outlook.com (2603:10a6:10:2b1::16) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DM6PR11MB4530:EE_ X-MS-Office365-Filtering-Correlation-Id: fce2eb3f-5299-43bd-479e-08dc383c0a5d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IuEEqP3vJS7YLjAzxC2g2tjnKsRlj8GRBlocZrChXyDAS8b/W5GEWMj6OeXU4wNcSMdb4YlK8shckJgBYp2VrkGMEbg7erFrkSFsfzfN3YZyolL18OdekuJLeVfSsLW8CsAjMQXAME8RHsjBml2IspWBM1KJj/gATGPMST8w4afW1NtTq1YIE+RaY+6gZcw6TjcfougxCrSWap5SSmw33MSGI0BnUC+6pC5yWXLcIoFZ59z6qs7sy40e6hb5AlIWZm2uf7z4Oba7jCGm78qNWB+e0eIy/ZSP8z6bj9ets+lgNj5iu155UGCDrfPP19MaVZixTrgDoi/PWNzTewDFUqJcwDN5RgKiDRYt6U/O1XQCZpW20X229kyxYzv5Nm9ERSkU+9nLe1jDKzqy3tPbkGJ0DZ5syx+pKHESPePaZy9NJgxBCfVz3x1MB8oCaaEgxd5urzH6lKVGUzcplxiUdiyQjw0isy0ztiRCxiGHIhoTpGR2O6M7U6XnCtw2OmDi9gQ5hmGFM9grNcBbieu53a+j5Bn1RBst7wkyIAYXftKbgqRWeH3XKLWJsfiPHONS0OV6z9XCC8G2y/os3bTR4czSTeBoDiX5I7bQOlDwxANJkutLx4G2dLsMD8l7eeTl X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?gy+TmgHOZRvczEdVcYRAs4Crj7K+DWS9clv7m68IUZJtHSOSPcZQrYyUXW?= =?iso-8859-1?Q?ZWCmk9wdJTCTslgYLeDoSmGObxJXYUnPia2WTCY/AYNKpbuLv6TUisURZD?= =?iso-8859-1?Q?O7RR4IAIMl1NifFxiWuDYwYHJp+7ZRdBQyC8fJaDEDGBZBMnfGjxA2NvwC?= =?iso-8859-1?Q?zJcSbYeGkjtNBodpsgMNCSfxVlH5pSyu/Wnbo1zI4V+7y4e6tw5df/uUw/?= =?iso-8859-1?Q?jzXbc/P87bD4AKFr77k3uE4Is30yZMQqn9LtKgoBZFAhhiDBOanitQvJ9e?= =?iso-8859-1?Q?vWR9Wt++WEfXVicl5gZ3FD8aE9+Zx4vL179FbgMx6OtAc6D0shLxXXvOdk?= =?iso-8859-1?Q?3FKeRoDzLeBFZWeA6nWdvMNZyadDl0uADi+CPsyUu09VwQLPs49v/NZLNo?= =?iso-8859-1?Q?2TTxl2vIAK++Zy97mDQdWYawS61UTSNc8hHU00yfpxSrdQnSIyVBgd+B+i?= =?iso-8859-1?Q?l5fTYsxK/BIq6JET3ff3Cx0DFgXN7ITQsiW42CIPHv8mQ+L/og+8bUVYMT?= =?iso-8859-1?Q?rz60e29c2lAZBLu7zsc7hbSyHljP4f0sMsfwHEbCWBUWwxL6zzTYdWZHdR?= =?iso-8859-1?Q?2moY9ncYblIZwhLf0TLIvLmTSWUGtldiosTcGSkGIfvXQ8LJtt9K7/hTKs?= =?iso-8859-1?Q?05L0Unce7binDXazCJx/UsP6FqGvyvS2JyC0r3dIedSwHL9Xmb3YemQ1R5?= =?iso-8859-1?Q?WwTbBfofym8q7p8b6/p6ZG8hng9urq0uVm71c51Tyizrcf1rR9DUSX//lV?= =?iso-8859-1?Q?QntL1GyLhvxbncI3vJI6gZQcksAmFHRQHUwHaU5TsucW7fY288n1seYeW+?= =?iso-8859-1?Q?cwB37TIOzNzSfxzQywdSO6Ya0xzZNHg1pSOhJRMAHXYnQEC7n9PM+86gBV?= =?iso-8859-1?Q?o4EGh2+POx/j98/619/SaLpHu5PyXivV2rHueDYE5hI1ZyU8c+ac2libCY?= =?iso-8859-1?Q?4wnjXWDCWhJXkL+g+N2wY5xDSf4vnQHqgDBqJY3Z07MHo5wEtQkzxwLPo/?= =?iso-8859-1?Q?Ff93c+KPYZi6D372yS7Lb5M068AOgww2fnsVMH6d5z0NvMq8p0/wHA+Gfd?= =?iso-8859-1?Q?nDVK1ZDVmzKDMui9Y83GVEx7+RutrEN8++UmN4W+aKlvLs6QAa0CYQHreN?= =?iso-8859-1?Q?4sFZItQ9HUN0WO/vlappSVd5VDvhAXcXK3laKrK2GO+2tPLs+eD96UvcKn?= =?iso-8859-1?Q?7GG/Bm9UnnPoYbF9HaFwjvr5Rqn6zOg/0853LFvDlkTCqxW7ej5TUy5dHd?= =?iso-8859-1?Q?1aYtDLeneNlGgM7h+AwDYh0u6Z9r556Ef/e5CxaZdBHzGe75zTuaRKyCBq?= =?iso-8859-1?Q?RVoiv5LuXQVP5nCM9UWZ4u/bOU4S8TOlLymwJFEvGD15+4pN/cAE9kEnjX?= =?iso-8859-1?Q?ohA93N38QCs5GLdE2G99kiqVSOE/Z8sAI3Bg4rKuOS9Y6Rmhg6Im94JQR0?= =?iso-8859-1?Q?QXHN0AKqQp578YTILnBLq4SaRU0YxOgqkTBnpwhEaRSuIgqNuTGoCIjqC+?= =?iso-8859-1?Q?nuj+zhlrM7itsb28FqG+nyebqxoJB+/cNtgqwW1bxE94lONCBQXPvqZEhp?= =?iso-8859-1?Q?ETAaPnJxdXPnEwW/Y6o6ETg7Nn4fGWg5KCilW99hoi/ZrVNHep78vK5zqw?= =?iso-8859-1?Q?fGMvlkbDitW+hrPwJyAC5PbWUwaiFZYPxHs0nDEt9uoUapqeLC+9EyIg?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: fce2eb3f-5299-43bd-479e-08dc383c0a5d X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2024 09:02:50.3972 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: figqRgdw/oTPRws1QaEuYR2JGEEdi2P8jz2K/bQkDiMdn1L9iHp7WHxz6Ar5vHNtINUuBQhGKhvRNgxPbnUFGGDBlvtJx9ELGiN+QiPl+1U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4530 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Feb 27, 2024 at 11:06:04AM -0800, Stephen Hemminger wrote: > On Tue, 27 Feb 2024 12:27:31 +0100 > Morten Brørup wrote: > > > > > 1. The extra 2 byte copy is effectively harmless due to padding, as > > > mentioned in the commit message. > > > > 2. The decorated rte_memcpy (if work on that patch series is ever resumed) > > > is an improvement, not a bug fix, and will not be backported. So the memcpy > > > parts of this patch are irrelevant for the stable versions. > > The function rte_memcpy only exists because glibc and gcc version of memcpy > is not optimized enough. Would love to see it go away in future. Definite +1.