From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39AC343C30; Thu, 29 Feb 2024 17:07:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 274C742EE6; Thu, 29 Feb 2024 17:07:39 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by mails.dpdk.org (Postfix) with ESMTP id 6056A402B4 for ; Thu, 29 Feb 2024 17:07:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709222845; x=1740758845; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=9rQEgeMuRSP8HN4r8cdPcHeLFFazZVcsj2HQ9ptQ168=; b=C0uxzi8gVrRNUXWIg9sFlUyot/fagxn4muy0vSKoIvZNtnZhpJz/n+hu W5VOfB5K/Xd7Y9u4mOGYr7fmF9wDSTHgm3RsC8x6WqGek6fjK/Vu4B+x4 0sgWPucXqn0mKrSxaXeEQ2RrSbpc4Nt1q1Yo+S1KY2dZWTGasaqapidma C3fbEdZUMafa2CkIuV1qlkP2BF4KRZsoHuQgGR4b6D4IFEGGFxnLexHbW vFqf3/ifYWtkvptydqV18s15rX326buh+dLz79EwTEaI/lJYZhu5+yAKr osxZLv0iH2JAptFlgrI+PjEKuQsxqsEccsyQ6LShTKwTvUXBC+QJlqZVp w==; X-IronPort-AV: E=McAfee;i="6600,9927,10999"; a="3583692" X-IronPort-AV: E=Sophos;i="6.06,194,1705392000"; d="scan'208";a="3583692" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Feb 2024 08:07:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,194,1705392000"; d="scan'208";a="12557291" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 29 Feb 2024 08:07:24 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 29 Feb 2024 08:07:23 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 29 Feb 2024 08:07:13 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 29 Feb 2024 08:07:13 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 29 Feb 2024 08:07:07 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YnVBwFcY5zd1PbKOvCnssICsIALEMjOYwOdhZaFKvGXQ0CzUStYEUd7CF4cdQh2znbynb19r02sPz+c4qIN/I0q2OxeQB9PCtyKh4P6X6yM5WoPmLkwa0OxtgBackKXMwLSJnToGcrRX7h63qnEMZLGmL9z3yKw9gl06upFhD0rNM3RaXf9W7DV17riHf6fEsZQ2Ekr2AopxS+QgQlAAGHgVa5UR65kBxf6Iy5+ON8tYLh1nY9DXIzoX7HzoVwDnfSE5NfZF+ck5S1iKrL7LFL1nsniL7vd92D0Db/yW2eUdbozFcU+MWHUIWuxO4AAoja3m9ioD9G89IhJfEOi1yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g+Q7lVVSillleECoVUWNfDx1t8ZiotGC975vPvnVi8M=; b=BoJHTN5I0INKCOHp+hT1o5tdRFUsTfGMi3TEwwVMD+9DuR0G3Z24CjvalqtMv5UqX6/r/CE6a8sZWXJfeMUggnj3IIcvNbmX5BfA83p1EwhzbBWoWsz9pVNPCj0bmmnUnfwdxFAeNx68eD63IKCKtnmMITJKtjbgeEHjMHIS6yJBSzY1CZAyxJx8SlF8SCOkacQBB1JyfoBeYtu5SCbzT/XqLrs0fynMx61g8ALsWwytw7di/jbqLhgY51dXXdpJwSlDUZm9hv/iBMigSU44CiX2Pw7EYupysOUwZXCfmqWw1qpQJXXLnwMC33bP126aF299aHmfd4xkB7i83GxHCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DM4PR11MB8202.namprd11.prod.outlook.com (2603:10b6:8:18b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.25; Thu, 29 Feb 2024 16:07:05 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e%7]) with mapi id 15.20.7339.024; Thu, 29 Feb 2024 16:07:04 +0000 Date: Thu, 29 Feb 2024 16:06:58 +0000 From: Bruce Richardson To: "Burakov, Anatoly" CC: Subject: Re: [PATCH 0/6] remove incorrect code for loading 16B descriptors Message-ID: References: <20240123114053.172189-1-bruce.richardson@intel.com> <12f8a391-2a54-4b5d-a72c-17712d544c64@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <12f8a391-2a54-4b5d-a72c-17712d544c64@intel.com> X-ClientProxiedBy: DUZP191CA0027.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:4f8::16) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DM4PR11MB8202:EE_ X-MS-Office365-Filtering-Correlation-Id: 8a0eb14a-2a4f-4258-f82f-08dc394078be X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cSyrmhZf96jF9v1cymfDLRYCTioTcVVahWn3kVJzLSbHe6Z/nWQqwpjf/bDGaAG6BQM7lHeCh7UxX4FQV6F5rtVEr7s7+89LxlYAZYiBl5NP/MlJGIP9YUw5kGz0WjXVgojuw1RAdjakH1oApz5gPlaFBHuGh30QwG9r3X2gN6vnmRTUgiPV6hk0scbyt4BTfK76tTMDnVQDpYFxdxJgq2Kqk67Uv4iIqXO68KqvRuQVZAqCmBpEg3WNzAjQYMpHxYIU4bWVaTPRq1ZZIiuaLQIo/0ddTSas94JwV40h8IlUzITfP3rEzqG6LZkdcLLtv9lT7Af3KK6JXWVdMtLT/hciOLDZ+aMe5MxFN3aFjAKrUuz2bLu8eiaVsj6MBlCVidGKMRe9+uarygRhssegD5ItISNHEE35U7/34tVSa6QbYfgqaqMjs7pO/9NSAL4HrUMQzCdl5neiee0dB/Wx+uP/apwXDyKKBZP7LM2A7cD07/GDwLZVBfJI5TzO+HLGT3ctn1vDZjuy6JKtTmk5/A61ndP318oweNVIHY81x0qEuPSxRHE0pw64gPZSZKSpVw8oTbOo8ThAzUzd3GBuYf0jgyOqvRKHP97wNgOCwTJr68CXsp8ZTUIQUbEqKLRR X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OOzlYafMpz4qZTsjj+iAsDHqRH2EFKmzinm1Y0mj3aLkgkFvt+sfrHGRf+UI?= =?us-ascii?Q?WRm0upMFH7CtopBQsP8Wmfnk2W6cGrwI+5rZYRwAExg+Y0R0UxmWfEOAZlrt?= =?us-ascii?Q?cpd4+1PoDPDqFE5XYyNgKfuRPyzp1p9EXlDkTdLSjYVMqinWSHjXaOfbe2Gh?= =?us-ascii?Q?peSle4BEB3G8owKuCaWKFiv/qv3E8Nwnseelgmz4K0sRn8uyQGAOxi3V3dx0?= =?us-ascii?Q?fQqwnnQ235mFb9IJBuZWmKnVf9c+MKnec3CrBGL29SWgTKeB+NZa0dZUvUb0?= =?us-ascii?Q?mjJ7VmJ3wHTQuriJNRAPqslNb30+BLT8XFGU+FTZZRdhpdFPqXKG+B2d4bve?= =?us-ascii?Q?He7TperAZwDIvFTwKK0IBqPeXTDF2uT1d8DPOibhqQlAhxaxgDmRBMFAVy6Z?= =?us-ascii?Q?k/nA02WG8y1aCwZFOpbgTR5S9oHthF7kiDM9WtAiTVWGZ3y3DSr3LJe94phU?= =?us-ascii?Q?+6C0mD6e9F8LNu+3LGXV9YivlCVM22nLmGBrulNm/s/IA4gIaOugJ2em8d1V?= =?us-ascii?Q?TiU2xXZe2QjjZEC/b/QocOFpCwJr7UNX/aSmKtDrUpuj/M5HBm3aBmy70CvC?= =?us-ascii?Q?0Jd3hEQotd2ovFxWERhhSOs2/x1EUWmwSq/Mq1FZ5EKfZ53w87zwcid+qya5?= =?us-ascii?Q?2NsOnZPxnW7fhT6XInMGdJa2GNpK6Bb4DGxZ+qUozU2mkryxRY1Y+ONiQ1z0?= =?us-ascii?Q?2qTZGUabPaD+ra0sd1YYjdlr1WI/wL2ud4ZnVPrA4VhqiVooaM22uRVPzQd6?= =?us-ascii?Q?m4aUBEgG3GfcEfz/HaGKWFwnL55PZmqGNFqVW/SI9coAyjyzoFtqlIYqFHKS?= =?us-ascii?Q?ICUGsbcjusaAaPttDTlSbcU2F0wvQvT/ZQc5SRZbJcLK8x3snZRfyAjZZhH3?= =?us-ascii?Q?jK80uU2HatZPCit/ladZ1JyAon6Rg5J66qAhLJnKg5S1b2OOmCBNmx8YV8tj?= =?us-ascii?Q?8pmH5CKmRH1WVb24tQz2MaWzTyhkEiBBTzPCip3rfp5Z42GMzxkUgou35BHc?= =?us-ascii?Q?XW23Bafet6OCOBAoCHIch+OMkJ6Ars42CUgctcDtIgrIaWmp8PczBYgCXK11?= =?us-ascii?Q?2tFgvOXA+Sx8q8WzxSOqf5/tSeV6sq3sGZ/vrRdV77t2N6godJtfvRcxnBzW?= =?us-ascii?Q?tpW6Y4CFIb1yFZHnn1evC4fMLuIRTs2EBuyH+5g1KMbT6RbpocoEuTygtGSR?= =?us-ascii?Q?1GY39lBZqDtyKZMoUb83jQYt+YfQLTS9wZrFwOgIGcFBTU1ILAPu1/E+Edyb?= =?us-ascii?Q?xle3SEN7xK+fcQ6ecDFwSpQvrdjE4OHdLwa7D2CpFIlqt2dL1zvqLB4q7Rg+?= =?us-ascii?Q?71Qm6BgeBodyGxdULSZtd9XPWu+nXlcZdoX+PU6/mUJYcX0fsg7/wUbSo7+0?= =?us-ascii?Q?JJ63OBO7zkvN+qL8AEE6Ql8gpiEkSwryr0vQr77yi/BwkFKnZK1H9oTGVt75?= =?us-ascii?Q?osqsNkNfj0YOpCV8oWEFIuiDg7L2f6ik3VnVcQeMMhMUMbMZWuyYO67/jZ2H?= =?us-ascii?Q?gUJYeDm/V9ISK0Zvq2K+opixyLvJW34QZ6aCOJf//SJpMZy2mGIHu5ltHN8C?= =?us-ascii?Q?uetYQiazh54vp2fJjmx4MUQWGr2rs41HJiheNGXoeVQ9fcII67IvCPHMR1lO?= =?us-ascii?Q?7A=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8a0eb14a-2a4f-4258-f82f-08dc394078be X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2024 16:07:04.8963 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ovI4XynVuoWK2rxczH0ecjytxjWGBc/Cgj6khhi9TFcU9eQP3fq3bHMLRaA/eM2vhT5LRfdIFTdeV856jGp4yYnltgxT+MsSY1LKizty2XU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB8202 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Feb 22, 2024 at 03:57:09PM +0100, Burakov, Anatoly wrote: > On 1/23/2024 12:40 PM, Bruce Richardson wrote: > > Inside the AVX2 code paths, there was special case code for loading two > > 16-byte descriptors simultaneously, if that build-time feature was > > enabled. As well as not being enabled by default, these code blocks also > > were incorrect as there is no guarantee of the two descriptors being > > loaded either atomically or in a defined order. If they were loaded in > > an unexpected order the driver logic would break. Therefore we remove > > these blocks, and do come cleanup of the following code to remove > > indentation. > > > > NOTE: I've split out the removal and subsequent cleanup into separate > > patches for ease of review. These can be merged into a single patch on > > merge, if so desired. > > > > Bruce Richardson (6): > > net/i40e: remove incorrect 16B descriptor read block > > net/i40e: reduce code indentation > > net/iavf: remove incorrect 16B descriptor read block > > net/ice: remove incorrect 16B descriptor read block > > net/ice: reduce code indent > > net/iavf: reduce code indent > > > > drivers/net/i40e/i40e_rxtx_vec_avx2.c | 64 ++++++++------------- > > drivers/net/iavf/iavf_rxtx_vec_avx2.c | 80 ++++++++------------------- > > drivers/net/ice/ice_rxtx_vec_avx2.c | 80 ++++++++------------------- > > 3 files changed, 72 insertions(+), 152 deletions(-) > > > > -- > > 2.40.1 > > > Series-Acked-by: Anatoly Burakov Squashed the 6 patches down to 3, and applied to dpdk-next-net-intel /Bruce