From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C25543B9E; Thu, 29 Feb 2024 19:38:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EDE5742D78; Thu, 29 Feb 2024 19:38:57 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mails.dpdk.org (Postfix) with ESMTP id 6F2D9402ED for ; Thu, 29 Feb 2024 19:38:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709231937; x=1740767937; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=KLCupO+Xt7XApNAJ1OMdOTJAtiuDStT/egIGJ006AJY=; b=hqJo/SbLxtFsL1X2yQEt7FkMoFxSLxvsgg6wgTsSUjTQX+oUikYyTRCQ JrnAjPbw6laJN2cvEJP+rDv3tjvj4DlgmSenNqNT45z8NllUbekjU4aDK LhRa3uusaOxyBf3Y7uOdvNR4cFOpaqVlyO42iS4w8mnzp5uNd+W+lK8iq k2X6D+9PRmMFXH1qsACdM8/Vwp7tqUmWSnGzMbOiw+w79BSusGqxtdcFC yrD7JShLqqNI14b3CvlcZX4BnDAOM4st7VcfbD6RGz5BjYtoOKhr479EJ 33D86xK56LbC5uKLDw6n03VLOPgqHSyEPITXoV2RBDUq+xwXZGfrOKCGw g==; X-IronPort-AV: E=McAfee;i="6600,9927,10999"; a="29158194" X-IronPort-AV: E=Sophos;i="6.06,194,1705392000"; d="scan'208";a="29158194" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Feb 2024 10:38:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,194,1705392000"; d="scan'208";a="12472776" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 29 Feb 2024 10:38:55 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 29 Feb 2024 10:38:55 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 29 Feb 2024 10:38:54 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 29 Feb 2024 10:38:54 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 29 Feb 2024 10:38:54 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GqeIGmkuDch4nhJJpOX9ieIfeK8SW0doRRbGGUcJ6RjYNxn42pWBXbL6eDNlI0tqW8PVlokwS5gXH5q4v4Z92Gb62tcHFqux7i+wUUe8RkGExYDwpPJHMldFJVLFGWgG/4uaK1bXlzWc6fBpjplMDnyvZ4x3vBMUZ0ZLT+Fw0+dOG0aWOK2+z1QZfKf5TZ61aEZBXhj3miC8QY5Tk6bMVm3nWmryNj6eYPHAaOBfX2hVZc4xSJrI6/jPlSB/v0gMnyQO5NOf6Gc0MBACQc2RWFxwu93caSBp0hkxupystWy6hsFCgH6ILSQFubo9swv6XSZpFvC+haCfok33Ps+xAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NW+M9AcLMt+QteQDgta9fHgtwANqw7y1T3ik/Xi4tfc=; b=bHpusYdKnEx2KGmZ1D9FAp4h19IntjN9KSNyDU1B8tXFU8uTKZL2b6QzKSpf1I7T2lafsS3XZdtMzpW8spFkS2IYK5ItHvEkyE68NLB9+JSs9SRBEkjTWSA781d1CupTVRuhQqpbt69G5Xx1e18gRf4taR2XQH3WvSU64c5zF5rQjqEh7jYnvOJHCxrDp2ng2+13NDSjuQtLqUQIyi5fkpiRq/RTYUzd2e7e+PUd6evsV6X0ROtoKZXiX87wUl1pJp2LcPc1Jz78nQBEQ36dTn/rRdZ28Ze5kJLNPsDRxDxKbHsyK+26+rqolyLx9myGr3ZuJhn5r6jUm/wwio9B2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MW6PR11MB8389.namprd11.prod.outlook.com (2603:10b6:303:23d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.15; Thu, 29 Feb 2024 18:38:53 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e%7]) with mapi id 15.20.7339.024; Thu, 29 Feb 2024 18:38:52 +0000 Date: Thu, 29 Feb 2024 18:38:47 +0000 From: Bruce Richardson To: Mingjin Ye CC: , Yuying Zhang , Beilei Xing , Qiming Yang , Wenjun Wu , Simei Su , Jingjing Wu Subject: Re: [PATCH v12] net/iavf: add diagnostic support in TX path Message-ID: References: <20240110022555.3084426-1-mingjinx.ye@intel.com> <20240219095514.66338-1-mingjinx.ye@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240219095514.66338-1-mingjinx.ye@intel.com> X-ClientProxiedBy: FR4P281CA0419.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:d0::18) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MW6PR11MB8389:EE_ X-MS-Office365-Filtering-Correlation-Id: b9f6c69c-0848-4340-2f80-08dc3955ad84 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uCN7Gk+2U5/u5Ma5TRmrRFLwxXQBe14iovgctqQQZY26B3i++YyNSbiPEASvHkWE2N/prqoO1kNqgFww3bu0wrGXlpMPs2Hn8HZbCDI66yabv3ONlnHTKz8mnQK+VYKgUplUAf1yuoeCqNQZyDzbbrtjwg32ZrLFAnlwI6KuoDOAMs4dlhZN94KppAbW9fxOZ9ALM236EvhgXKuOpOLgnu277vrysKW+6jbZOdO7dfAKUlG2gYiV/+bGy1nb15MLGIK7l8KfFEqVaFUBKDbjHLVELdM4rdMCUqGRL5lxQENgj2d8Q3k/b1t4y6IWHvixy1Nnr8aoR91NXujoXraQ+brvcszHoXEXoUU2OyD+tw48AVIZUpLx3rkK5O8A/U7Fh1K/+7nfyoyqCbq0WC5CL3vE+hFANTvaPQZI57opmM6qHQDXsbfBAufRfF97w9RtuR49AYpLZX8X/+XJE2LLeDogO952ZMg+0lnSqFgGrZIG4Sax3iWrQ6qBakoQbWv/ENP4XsyQJKj1+tj1doyAQ6eA5b3BQbxnHXB27RX5y3kLLCrKXBKgJojnCMXzonB0Pw5eD3Jpt9gAOnlZHMNp/yfH34YpqMIHnb1V6mQdR01QbPWFAv388T0DOR2z0oiP X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FUznKnmW7U440dztv9OG1SnaCdQe6+2Mdc0qxuOZQkxeWa9BEGaV9c3yfBDf?= =?us-ascii?Q?TVz32WT1QIDHAhzlNatPJaVxGcvRn6qcBTNugo4kY8XNL8COtDX7Dj4jPWjv?= =?us-ascii?Q?aUiWH7f2d99xAuUT07aHPonne/ZNM+q6WO/MzFR2EicvVuYvpmsDZqT7zyCo?= =?us-ascii?Q?yISoHkhNmMUXNoyKzzBQTXBBu59umwGzm5LoYfGmXWeeUT7bevEKuwGHW3dk?= =?us-ascii?Q?wg28ApBpcbrrcGSZjKaSYcNOXjKJMBDSqgk4oyflgUhSdemuZcsOC9Zg09cR?= =?us-ascii?Q?4oCC3TvRj8ynKzLoIHJgSg7NkuPC1zi/w6VBIUur5w9PiDx/D6jzt4iHMKO1?= =?us-ascii?Q?so+7WdpO/jdPsTYCI8TfS9M9A92k3HvygQen3u1JKH1yg7J5qXhdqMhQwVs1?= =?us-ascii?Q?VZrTm4HdlHW95wef2XLRpyu9VvzMl3yAcujYrAvILZG6mdSRyU9NTQjk7HPX?= =?us-ascii?Q?vlEiF9SuOw2LuTtecxF5bPCr7bTlGw23vScIdhg+FtPJcZ16xEa7KbTGlXlL?= =?us-ascii?Q?y7NR32Pu15uFLcE669mlVJb/41Mqc/DPeqJ78ChUoN9jNFid1K/6USDoF+iK?= =?us-ascii?Q?jnBp5ID31ASrfTF74RzyExO1l2zzFn9fIfh4ny5GdlqsgJNXuFk+Pu1eG+0o?= =?us-ascii?Q?u1tfB7AcqRMULcilZ5z8DdyFghiZi7rXUQ6T1YbJGCAM8iA0QjeSxgqA4RPg?= =?us-ascii?Q?FbJNJQ5rJGaDeyHi1xIB0uO+Eks++66KxM0rWLlhJNtHH0DRNevxQtp4AraA?= =?us-ascii?Q?7P3/r9plJEw/ueoEiH9D+fOF0w9Exx2C/2je78cHCxe+SlJVhx5hbeSARv0X?= =?us-ascii?Q?paOMF5X9r/ZRb2CpL5eINC2jl+raXqNHKc+9tliRtDM2enbCP90XCBZl0HKu?= =?us-ascii?Q?cdW5UAagNbCl2o36pLhz0tsbu9r1+YlmQyMgw+22D+WWsJzEcjSCN6PIPB6p?= =?us-ascii?Q?as/jZE6RNKewpMP6q+dskHe9ekAN4e+DlXtOaeM0IaBKqZ4mOUe8tNchuZ+4?= =?us-ascii?Q?pVUtALnJQCKqEUCZv9cOG7e4dTgADQJwTotfo/unPd0hPr6VeeC/k7vkbkb0?= =?us-ascii?Q?GMl92qQAqmb8eUj4gPEVV0nR1gpCTvO86AbkWcz1e4HBjqXVWa9V7hE+CSyn?= =?us-ascii?Q?Cs4/t3fQI0Qfpy1dqvPPJqRV8sDB+Lzwa2IFScNgeFE7LXvctwP5E3Z5zLlp?= =?us-ascii?Q?4wbcvPxfKfTdKduL1ThFwmH+2To1uuyskzMnVrcHovBfucQhaRUi2JpaCZFj?= =?us-ascii?Q?ggE5GXWs2nGhX2NVL3R3PwL9IZnj8YMcgwM6oGO17/1l2rGWUyP6198lUWq6?= =?us-ascii?Q?wvlaxZbiC8wwaM3eOqyRpvydY6FPGx8Qp5kW6khq/asjCAAPOcoy/wl95v35?= =?us-ascii?Q?uElq5nlbPFSf5ocMeT3U4uT2QNu/W6Bux4RKezYjMPE+rJGlf4L2vvEwe0Mf?= =?us-ascii?Q?Q2AnHeNiL9Ii8KAeeAa1CJfbL1WXzkwCqtnAYDJrKh1KvVmmDnrSyZn+Ye13?= =?us-ascii?Q?xmlhpIksqWbgiFuXVZfGh7kA4QPzUI9Y4us31hOBzRSOlv7U17XoAoxD9EUA?= =?us-ascii?Q?7qqVeiNlaYTAoxTDLfvWlCD3oVf9AnuC2Rs+xO9BwmY7Cw9MS+OSbE07vASd?= =?us-ascii?Q?vQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: b9f6c69c-0848-4340-2f80-08dc3955ad84 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2024 18:38:52.7998 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LVf3fJdJPAopOIUJQTF6sQX1dcPB+cH6WYJNyttcwEaIvKzyrSmcvgPIu+ni/bReeOMO0cVuJPgaYVzZQ+c7HmxrWw2vfvyDG0SzSIpiZAE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR11MB8389 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Feb 19, 2024 at 09:55:14AM +0000, Mingjin Ye wrote: > Implemented a Tx wrapper to perform a thorough check on mbufs, > categorizing and counting invalid cases by types for diagnostic > purposes. The count of invalid cases is accessible through xstats_get. > > Also, the devarg option "mbuf_check" was introduced to configure the > diagnostic parameters to enable the appropriate diagnostic features. > > supported cases: mbuf, size, segment, offload. > 1. mbuf: check for corrupted mbuf. > 2. size: check min/max packet length according to hw spec. > 3. segment: check number of mbuf segments not exceed hw limitation. > 4. offload: check any unsupported offload flag. > > parameter format: "mbuf_check=" or "mbuf_check=[,]" > eg: dpdk-testpmd -a 0000:81:01.0,mbuf_check=[mbuf,size] -- -i > > Signed-off-by: Mingjin Ye > --- Carrying ack from v11: Acked-by: Anatoly Burakov Patch applied, with some minor rework of the docs, to dpdk-next-net-intel. Thanks, /Bruce