From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B4DE043B7D; Fri, 1 Mar 2024 11:34:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 35F7342F53; Fri, 1 Mar 2024 11:34:58 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by mails.dpdk.org (Postfix) with ESMTP id 39197400D5 for ; Fri, 1 Mar 2024 11:34:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709289297; x=1740825297; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=DR3oKVKqJqLTeffy0A7LDjdFXd/R4lWITweNqTE4YHI=; b=YOXH8ENTqeZzWlAm3wGqKptwmFX7//Qg2Z5Anvl4HtU/yRRAw0rn1c/O 54nVO45sUSrZul1mBkwt6KaHEEtxyNLFmk7SM+AMhmXhTgPODnerS5KtX j9RxzwAG/qDvGDAhYg50QOrcIOEnDBUBwI8U2MS+5Ump0f4uob7Hq41Eu qQ9jit4tKs6Hn96Ew/p2mH6vCukgSBT6owkD3FBSgJ8xoCaiTuYDQaO29 BqINOGyk21BPxVp6jOYD8y8D6ZruxJNrPgOEUBknmKlOLgWe+eg5A5bam Vz5izA8nM0XKKeXf28pbMPQYwMt1Sh3UTShS6Xa7zS20WzNkKREsZtyGx g==; X-IronPort-AV: E=McAfee;i="6600,9927,10999"; a="6771992" X-IronPort-AV: E=Sophos;i="6.06,196,1705392000"; d="scan'208";a="6771992" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2024 02:34:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,196,1705392000"; d="scan'208";a="39013775" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 01 Mar 2024 02:34:55 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 1 Mar 2024 02:34:54 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 1 Mar 2024 02:34:54 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 1 Mar 2024 02:34:54 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 1 Mar 2024 02:34:54 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f5Ch5DbZSiioB8MtL9GBnG5qNkHE+9OUsresm9nSA2JOklLrkYk1ekbZj1QTlPE5lfodrEKfZMydZkkQBzaULVXjVdqIy94TlrD0zrT6acoSgUGNN1uSQMU9x3eZZDtG0gPVqijA0zzZiIhOJwcl3bfXHJxqtxrtpRv7Aph1fANauNeQ2SpGYjxNXpqo7ovQmgUV/d2yf+W1jPOLP1SouHP6q5W6HtlCx1cH3DZ/KJVPvpvi9mN0Tl65Ry6LLCyIJTtbRV5gWawjeVF1tqw0ZeKR0dHh8KnACfI3tG5kYZWVy+/ECejodMeYg3X4ea08dYoyfpfBwPsbdnlaMaH7KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0gpBAeNkk1/MdTz/rUWLxOi3GifIWTuGlFbg4s9s/ps=; b=MsJ7QETDiG6osEb9b+ykC1w48qFsw7m+i7WknF9Qn/t/r+P38NJTzzbvs11rpEpacmb4osIi/BpKbE0q8HJbHUael+nmR/hMXZ5dZ2EbicP4HXdfocdrqxjjJyrLaelVlqokXXVf0kaKAIXrAhFxgDi8RvVRxdVfVtVLR30sK78096kqa2l8C6lvaax98gzp3DQvVccVSl3ZRA/kI7NIsjbxT7231gGoqN+F86KUfy6eFrriEJAwRFZK4IEl9UW0rn9QfdYND4hdfRfA4Ety7eT65LPHbhdXyKcUiqmyp7aJf7Rcgp9q8Bjy3EnN9EQXI//7vfG8AdY7q5BQ0ysQJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by BL1PR11MB5286.namprd11.prod.outlook.com (2603:10b6:208:312::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.12; Fri, 1 Mar 2024 10:34:52 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e%7]) with mapi id 15.20.7339.024; Fri, 1 Mar 2024 10:34:52 +0000 Date: Fri, 1 Mar 2024 10:34:48 +0000 From: Bruce Richardson To: Wenwu Ma CC: , Subject: Re: [PATCH] net/ice: fix null pointer dereferences Message-ID: References: <20240301052029.543989-1-wenwux.ma@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240301052029.543989-1-wenwux.ma@intel.com> X-ClientProxiedBy: DB7PR03CA0091.eurprd03.prod.outlook.com (2603:10a6:10:72::32) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|BL1PR11MB5286:EE_ X-MS-Office365-Filtering-Correlation-Id: 84533ace-1165-4e16-4a60-08dc39db3a81 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Z4cqCwq/PRwbyhY6BCQIZ8tYvyYvkUcJIWBeh60EaGLg50LPPVjnrWOXZGoBecP4arm2v2DwDCdXYBF3AHkwuo8TVYB4aoOz48gD7ATggqbq/EVRcIxEFfbRZ+cMm9UGoikeq9PbfdqvpIgG6cf8o12kysF/TDv5qjmw0yhscNiBtGv2pvb1XHqXP2l8qIj2VeP8Hr/2GQayrVhY+LTZg0YaaGW3DKiXttuKwKhgWutY5mUuWr1AMY67HTQlVoW6j3PufzdNDp0NnPb4d8oUNWFNeO3+/4VS7ExOcd+VcRLdqZjrNz6U0O42vD06hF+lUxI30+9q6qY+ztgmFTItwYuaJKsK9no2KQLndbRVsubPzVw1b6AjiB6g8XC6nV6Z0+CEu4Dzr6OrFoDBd4ukVWMCKP+A7jEeguKJ7bnUiVDQNTVYlCc7yb4ZkaSD8iTHjS9lwempsWLR6ZUHeBVAJZ+WbiQuUSVUNZ4VppJuHFSxhm1haMLuC4OPNoX+VkOG+XsqmvGuhR1HIixdxItOPrK3Qq0kdpRRx3zm/NqiaX6QoMeWnj/ZAgcbSbL+hkNYcIz31rDoX6kIx+i2feizD2iewcG1ehJmU4F7tSKZ+MBwMTwMtUF2XODRLYzRLi6Z X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xjeD0rd1bRtGgC2wXear+FMi63shKkleKK19VE58eAHbImRQqT9x8m4eFvpx?= =?us-ascii?Q?wT7HtjX6kkSwtTbiUSEemEMcrj6w340tCH6ZQ5+3Oh/UMKshTHAibNWWgKWR?= =?us-ascii?Q?4OZ01j7VkQGzXdfsfOhIwhDeSkMslwRoDkwiuKyp9L+OGT5i/MPtIxGj3Hcd?= =?us-ascii?Q?2kWNeUVvSNvjFhkM61EcrB4dN1V4REVZAqRCwJO1kwM75iaqujJZvHyekp+5?= =?us-ascii?Q?aQBbf2siXUDZptb+PZ6t8qxy/p6+Nwvz8TRMyqqef10hfDegxvfy9umYCzoE?= =?us-ascii?Q?hqaoasU/bFQeLj8/Sgha1HQT7Dztz5GY91aeRtQMFl4lmL3talin5ueNVsTy?= =?us-ascii?Q?Xefy9/LYQIy6upF8h7eD5bust+7VEovTtfzs8d1tcFod4T45hBz0RgYHrhZS?= =?us-ascii?Q?yqKaU38dqeprOaLbcr1CLwRwX/B6c7whwei7+Hgz9PqYXRZR61wXizLFhrQL?= =?us-ascii?Q?p/Rb6NOFYUY+HMUAQqH54rfIi9LsGYqZRK/YRIZhPlysDdWmlblUaZ9KtRwC?= =?us-ascii?Q?HoiYd8T0bN8VhWntludAjOBQLWLEXonpa3GqKlJXugFlUCoyawyMLtConcos?= =?us-ascii?Q?QDi9Zxywtxe7bAVLr6zc5lwBSNHwaiPb/2CKDM1WqLDcZnsf3ksBErv9MjbE?= =?us-ascii?Q?sOYwMF+y0ms7eA8fPZ2c5oDcDqtgp8vq8QSoEqHG5g5NqMoiB1oE3XX9Dxmf?= =?us-ascii?Q?0QpFuAgNQDyfgVT9LBWPi1aXUyQOpSPBaifMGaKOfVPOFI3NtVvnaAby8KqI?= =?us-ascii?Q?g2kuPnSJSauL/87WCQ5mefrNq/REbjGZ4KSp2rPUq/l4edmalz3WB7V/LCML?= =?us-ascii?Q?92liZn9qaeZffS0jqis9trLgM1+w5rsb4XJJe8aY0aAQnYzK1QdtQQc2Wwzk?= =?us-ascii?Q?qtCOh86dNPCrUXaxLbWvBld1FdrKSe/CHMeo6MOptLAP6APcC5+a5UAFeBXs?= =?us-ascii?Q?ct0AEfolrKUPO7SOOnZ8Uf0kxKOaMQC/9XiUmgxtYDqGjlbTP7Xt60yZW8w1?= =?us-ascii?Q?w2Ywxkl3w7zO25p5XG69KahhTFv5zcKGKxJgd/fVP5/4EWo+H+492PSTEdAR?= =?us-ascii?Q?MH7A8Uuh2P9KjFgw4G8i40Af5NmrEOY2fiDpSTH3KJ9EkiFOI4lwY8o8PJtg?= =?us-ascii?Q?68/7zlOldCWEY2kHizzPq6dtXMJJkGC4NMALI6Vv4qr59oss456nL28YB4/W?= =?us-ascii?Q?zfnJCLKzEjBJgaZtmIMQQTu26tTSUtgpkfBS/cufJlC6orJw5vHT1QuQmMs1?= =?us-ascii?Q?H/RbAqEf9ykd6Ue3hP1OOGU7uMpMF4uijpKF77qD11qPF1crtNCOyTtIrByy?= =?us-ascii?Q?IE0yc1/rayvfCekhRx28H3bjhRKzX35cAo/JyluNO2J+FYOOQMnt0L7SPzke?= =?us-ascii?Q?kHUguDO8JUsHwPbhxvLTJnGdHt5bXhyGYit9eoCG7+rmw/UtxOd7kG9RD0bz?= =?us-ascii?Q?XoIcK5dizZ2To7A61sJ5bSsMuzCMd43OeyXH10RgiUNlNDHbpTELC+xjbM3K?= =?us-ascii?Q?mIGqhffhwV6rEuYBb5NjhplZjQ7+gIiEWIjSHRoTLsLR9DWqZMpoHnIleze2?= =?us-ascii?Q?vBSV8QwXUX76Cjc7wuXOAPeaGywKLCAx8keY0QWNWnQx8Q29CXEYbwJx1u5V?= =?us-ascii?Q?EQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 84533ace-1165-4e16-4a60-08dc39db3a81 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2024 10:34:52.3852 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RacEpteQErMbYuY+7irqAlofrCdZwCRf6ttEB6bwM2zqYyArJIA1C+yuZMHTdzKrv30sjyhWiJWole3G7QTRPQJqPUS8dFeIpwx7Nm+NFXg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5286 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Mar 01, 2024 at 01:20:29PM +0800, Wenwu Ma wrote: > This patch fixes two null pointer dereferences detected by > coverity scan. > > Coverity issue: 414096 > Fixes: 6ccef90ff5d3 ("net/ice: support VSI level bandwidth config") > > Signed-off-by: Wenwu Ma > --- > drivers/net/ice/ice_tm.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ice/ice_tm.c b/drivers/net/ice/ice_tm.c > index fbab0b8808..e10ac855f9 100644 > --- a/drivers/net/ice/ice_tm.c > +++ b/drivers/net/ice/ice_tm.c > @@ -616,7 +616,10 @@ static int ice_set_node_rate(struct ice_hw *hw, > ICE_MAX_BW, > rate); > if (status) { > - PMD_DRV_LOG(ERR, "Failed to set max bandwidth for node %u", tm_node->id); > + if (tm_node != NULL) > + PMD_DRV_LOG(ERR, "Failed to set max bandwidth for node %u", tm_node->id); > + else > + PMD_DRV_LOG(ERR, "Failed to set max bandwidth"); > return -EINVAL; > } > > @@ -630,7 +633,10 @@ static int ice_set_node_rate(struct ice_hw *hw, > ICE_MIN_BW, > rate); > if (status) { > - PMD_DRV_LOG(ERR, "Failed to set min bandwidth for node %u", tm_node->id); > + if (tm_node != NULL) > + PMD_DRV_LOG(ERR, "Failed to set min bandwidth for node %u", tm_node->id); > + else > + PMD_DRV_LOG(ERR, "Failed to set min bandwidth"); > return -EINVAL; > } > Hi Wenwu, I'm not sure that this is the best fix here, since the error message doesn't seem particularly useful without the node id. Looking at the code, this is a static function, so non-public, and only called in three places in rte_tm.c: from ice_cfg_hw_node, ice_do_hierarchy_commit and ice_reset_nolead_nodes. In all three cases, failure of this function is immediately followed by a more specific error message from the calling function. Therefore, I think we can solve the coverity problem by just deleting the error prints from here completely, and let the callers manage error reporting. What do you think? /Bruce