From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D487343B8F; Mon, 4 Mar 2024 16:49:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A804740695; Mon, 4 Mar 2024 16:49:53 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by mails.dpdk.org (Postfix) with ESMTP id 04E0C4027D; Mon, 4 Mar 2024 16:49:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709567392; x=1741103392; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=cN/fwbU2PMtZWHTVzx1gl4qdcemcRtK/bsRi3dDtjRA=; b=L1JNqacwL4gPqyABiUzGTWgiHi1hCv9EOVvIPgdSIszotuLAc2XJHHni jUu3CLYwgUPs+HDsyZSwR/ScU9b/viuyfQHu5Mewpgs9fIZ6396mjGtKx 6Frj/bVraftlVcINOlP8CuEFFxdAbblH0jyDj5k8Yj57dJPabprDWwRD+ S/FE0Cxyr5AGGZB3Z0mtacMBZ1WEHXeUCBPoXKnnvBN4bsHyptT1lIg5T bWVBZsXiQeREpWq2ATeconZFWy3Gp/FrDwcV3GlS+cUAcHfkqqXh5OlhJ ecUFPuy4iDnGaJLL2oQ8Gb3ycDtCBtwBwgrHNmL/hNWS53u+m4fg+7TJN w==; X-IronPort-AV: E=McAfee;i="6600,9927,11002"; a="4644364" X-IronPort-AV: E=Sophos;i="6.06,203,1705392000"; d="scan'208";a="4644364" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2024 07:49:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,203,1705392000"; d="scan'208";a="8955244" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa009.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 04 Mar 2024 07:49:51 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 4 Mar 2024 07:49:50 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 4 Mar 2024 07:49:49 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 4 Mar 2024 07:49:49 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 4 Mar 2024 07:49:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WMJQDItSVi04rzufYELmdgC0/J6rLlyIucT/NBi39Ll0oyw/3kyvMb4J3E7/HjMB3JBaOw4wA09V4q2UcTUefwVZ4TxTFxhGCGp5HsUp0vyQatuHRxCrPZMXDjvIo2u6Kvj+VTXsfH2LW6KO7aIFdsw+TeMzg+lXqPdbq4aGH5+rAOBjlx6jsucBe3dUTK8aLi6Pa3r3kK8W3x6YXA7Cpb9b8tprKoXBWBMQROBzltb+WBgvWA6C4+sjCtbuJs3Y+AU7RkCwRFJdEj8B7c7ZUNrlDhzG1tJ1BtaRPkbvDMgwvzijAZvHdT40m9YO/HE1ybLz+FxmzvJuJiAtd0cfuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U81oh2M3LcJR08gEQqlIfTAb/zE2cwZ/qnSFI267JNU=; b=bCnR/Ha+vcybV6lOzXqUp4fkpbx65IRkS3PtkQl7eXGqeJOaAjEEXHn2JEKtKDQXSDb9Bl/qdV5x+jbEHTrDeh1F0PjqnV0rKRc47aeltTlsSMXLeoT3MUCyOu4EJJibLIGk8zCy2SNeVZt/MrTHzvlz54seuU1JGaIVkbGAqiYpw41SrzzoLaXQhvhOXcuk8FBFw+c+8stVoXV25emWlxn+1MTLxrBxX+vVtOUuLaWWzp8sRp5enFDI8084Z24NTQC9ncfdNUjCMbcEq3T8hz4h8J0WLmYPtBK2jMhHLmaLhsfKfv1Cyz6IIFx0xJZ9NvmJ9Ub4atzrY5SGhAyD8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DS7PR11MB7834.namprd11.prod.outlook.com (2603:10b6:8:ed::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.23; Mon, 4 Mar 2024 15:49:47 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e%7]) with mapi id 15.20.7362.019; Mon, 4 Mar 2024 15:49:47 +0000 Date: Mon, 4 Mar 2024 15:49:42 +0000 From: Bruce Richardson To: Thomas Monjalon CC: , , , Subject: Re: [PATCH v4 12/12] eventdev: fix doxygen processing of event vector struct Message-ID: References: <20240119174346.108905-1-bruce.richardson@intel.com> <20240221103221.933238-1-bruce.richardson@intel.com> <20240221103221.933238-13-bruce.richardson@intel.com> <2866921.yaVYbkx8dN@thomas> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <2866921.yaVYbkx8dN@thomas> X-ClientProxiedBy: DB8PR03CA0020.eurprd03.prod.outlook.com (2603:10a6:10:be::33) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DS7PR11MB7834:EE_ X-MS-Office365-Filtering-Correlation-Id: f79c986c-13a2-4973-1ea1-08dc3c62b7f9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FhsfyrAFsMWo79rp6zBgdIJArQ1VFNHOWK+qHnne26xG6eiUnGLizstrahZe64rBasynnV7guo6dUpxLseFhjbY5m77sx+oviKPDiG80A9l23DzlOAOJCxGcJ0oDFnqalDN78TkPAhFftP64Yw38uBY8o7UPUOLpDzJ0SSS2XTkXBD2HZFk8AkKVRVqRuRyI3hiy5sHrbuyD4dh6sSasFTR8dZVI9ExHX1ZuqvO1GXIyN5PjI7Uq1BNr4O7xpY4Y2yjl9k9uWaxTu0BonJ0xSEMqhBkXbigPPxJDJQswue/pjXHAVxI8uoAhsE6Ffwug2mYa78JapAF/AB00sxZo1z+QxkxdscgwoUwLlDe4XEa7gVD6YEhr88a6izJZ8jtlWC5WLSvFte5Z9fncF1qdiO4tSDF9VKxiaOwO/iV5uAY4PvAMLYHu3L2KyGN91YEsuJX9GlHA2xkicqT0tbesRe0qDkOsed2YHTPm3cYy1juMTUM8j29rWIB4tHpYLK2hmvkKt5VKIEyjJPiL3i8bnmnHtGCPi84m/CRIBcYMmQsfJlwxI48L+LDnLgouLDHM5IvD9uWz32B69Ldk1jY3q9Rh9iAp+fyaH8cul+MJunA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?R++mQV0r6AWPGczZzhIBImGueihWAeRKjMfezP0IZnne6HouWbuhddcVSFlR?= =?us-ascii?Q?Ysq6qfeGQfZyo8WDw7mWDYxQ9rgSdSw+37Hv8TvZhJD8PwfdjzACPjUCKtRH?= =?us-ascii?Q?XQZah1CzYzobo76GjwcHrRqsYnm4IwPRAMUURsL+PTYBX8ISXFevFM7QWBmj?= =?us-ascii?Q?IhILTMB2iex3KMEnyuizwdYWaJRZfL87/bvkWf4yhtEJvFvpReqMp4WXCP59?= =?us-ascii?Q?Blgqpp28FUUzKRpAIPN9demkWOCb8ZwoL0eiULTAZcIMw/YMGRSiksM00AxY?= =?us-ascii?Q?U41hJv4J7QNPrX/31sj6+4i9FuUFtjaY3HHYrEPoW3/PJwNF5X9e++5LFuGd?= =?us-ascii?Q?ueAEP0mIWDAWpyBZWlljseA1FiBCKFBYEFbgScx6j18pf1xPk6HdiIW/VJ8y?= =?us-ascii?Q?WS/uP7MmVfDithB0GwJDY6100ezN7oUzcwDKE5RtxmEFgKCJTWOgR9TcCz5j?= =?us-ascii?Q?7kfd6/HXoXBoI8lOVQCE6m+qdjaeCSC22em7fezXSj8T9K6XK8KMQgyp19Ds?= =?us-ascii?Q?yE9smUUTQpB49N18t/TL0hgK3HvjYC09I9667a4f/xCNVwV1jjjYmIqStPeE?= =?us-ascii?Q?yImOIWeQeU8nTYf4uaeYQte6thRpfZDGvjSy0krqRiiCE4hT9G7W0N4WM7U5?= =?us-ascii?Q?mbD2fitzK0VlOvgFgYFiNz2KjssGCjRFaY5QzYrUCLg4hfeZxrT+2SXVNV7F?= =?us-ascii?Q?6lwFB4bhkgaimNV3VmMY26sdhS/0nv3dXoq2//kdoHMqvYMhnD3QdyGxbo6A?= =?us-ascii?Q?n/wE7xjdft89YHyy3Ew98WBsJwWlzVaGM2tor8hizv7yH82BDuVBGAaOs3VK?= =?us-ascii?Q?603QhVWPNa1WHm5JtZ9gVyI8bdFZfECRAtgQDbkdL9L6ey3cPXjkS4NKFB07?= =?us-ascii?Q?X404Ea6NPSjnWiR10+BSpXB3vPvJIKR6hCy8Pcn10liQErmfLTgCEAize4vE?= =?us-ascii?Q?62p7N7/tBjKw/kzlsTCRrD+STSDQZn7Fw4dxwzfL2Q/cT/qgkSY4DJnmtpQ0?= =?us-ascii?Q?EG5/EiJ+ItSeFluZpEY0ZTN+JPRfT0aC9+HlWmQJq2TrCIBmioXvU9CuKTDG?= =?us-ascii?Q?cdaszHajAoCknkAn0NR9gPae/cc6srht0VCZ7HQfoMTBmA078qphdk3yY1Ue?= =?us-ascii?Q?r81P1iCGn/wYMALXuIRbjch4jhm3mGU4fPmwP8mgROmdq8sACv5/MPS4Ao12?= =?us-ascii?Q?yvzmX0qWe0Ms4snz49CEkRJkWzC2QPJ89iWUuWZn5DGPIqTHyQZTQljstWWM?= =?us-ascii?Q?dl9T4V5APl6Z3Nazcgzmbq+oAXq7uu41sfAmrfZz1gpiubHhIWZrOzAILp+H?= =?us-ascii?Q?E5rQnImKoPXejcZNmL6NjWOLhliqN1T8Ky5MNdpRiVbUdiaP1pxCyHlnnDpp?= =?us-ascii?Q?OgetU6Xv8//Tni+ok/01e9N86p5yQq/cH5PXYA497VsAHkkdXafESt+1zCEa?= =?us-ascii?Q?HrugV8oB2OPSeeZtLthZHUQYh7Wwha7luFf6Ue13ScrPq2V+fYUD/1e0gPPi?= =?us-ascii?Q?+tAo07R9iqU/vH8gjUU4CeIgswJIEi5i9n4fD3kIQZRuORJAU3ez5ZuEq6Q/?= =?us-ascii?Q?6nxJc5WsSlXY04a1vFfulURHWvxmnpLPlwRZj47wgVX//vEbZYO4E7LQWWKr?= =?us-ascii?Q?vA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: f79c986c-13a2-4973-1ea1-08dc3c62b7f9 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2024 15:49:47.2057 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PFQ9Yw5QvupNweqL3uzeb5ByQ4WLFxKizwnopBCR43eV6mum7xZru1J8akz0JuxTVxWO4jkHiQ4/BKA4QSjSObcYT5RltJIpggIEBWxvkCw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7834 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Mar 04, 2024 at 04:35:41PM +0100, Thomas Monjalon wrote: > 21/02/2024 11:32, Bruce Richardson: > > The event vector struct was missing comments on two members, and also > > was inadvertently creating a local variable called "__rte_aligned" in > > the doxygen output. > > > > Correct the comment markers to fix the former issue, and fix the latter > > by putting "#ifdef __DOXYGEN" around the alignment constraint. > [..] > > +#ifndef __DOXYGEN__ > > } __rte_aligned(16); > > +#else > > +}; > > +#endif > > Would it be possible to make __rte_aligned empty in rte_common.h > instead of each call? Does it fix Doxygen bug? > I think that should be fixed globally by Tyler's series for "alignas"[1] With the new placement for the alignment macro, I don't think this doxygen issue will occur again. [1] https://patches.dpdk.org/project/dpdk/list/?series=31229