From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E14043C38; Tue, 5 Mar 2024 14:48:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 019AD40270; Tue, 5 Mar 2024 14:48:23 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mails.dpdk.org (Postfix) with ESMTP id DAAD0402AF for ; Tue, 5 Mar 2024 14:48:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709646501; x=1741182501; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=6QB/braQZDAdkRjrfNtNk+y9Uc3KSh5J/ZBJpLhCvpM=; b=F6TmxQmLLyhCqHJCnrWkpQGJ4mSCNZy2bRiF2a0c1GySVOwUf7+tJJpV sLQYIf5MgMQ90ksrO+5Hjt7cFrsrwyl4Qekmww7yXaeureHxZEZ2T/mxh PRsW7z9+PdR3SswO9awCamkRUeVpwPbky7VRt0VhS/vxvvcFNUGG73hyK BEmzRXO/IlbT1XjhwbNnNGgCGNKZqx/ZkBETyaoRw2rNh9i58260EX2wi 13Ui2zZPyBFv241NjeYlE88EzTuhYtMaoDcHcY1IZy9/lc8XqWOcXYOzb BMu+KOq2K0LpeUA+CYQxRNeyQwkdOE4nuaVqQ0XCVvux4045qcbY86sAm A==; X-IronPort-AV: E=McAfee;i="6600,9927,11003"; a="26656701" X-IronPort-AV: E=Sophos;i="6.06,205,1705392000"; d="scan'208";a="26656701" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2024 05:48:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,205,1705392000"; d="scan'208";a="32552567" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 05 Mar 2024 05:48:20 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 5 Mar 2024 05:48:19 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 5 Mar 2024 05:48:19 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 5 Mar 2024 05:48:18 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dzIbJT4uMSlhXTE4IKijbHtM0nEyjdrpfuaOlCoBUOjFo/A+TBDU3L2xKCS9nkw8IhuC3DfUEDkWPDSmNuwZhlsSVkMjfEQAH2did0Uk52DBbwC7KCR5f1kle7biwQKsAznHCyLSd8bQJ9GSK1vXCGLyAVChciu3X+qYrzebo6Bb+gPCWQwfg2ksmMOMQ39GKP8b+B54WuEFZSMMeZq8+IogaXuesa+MYYhV+Xd6IN8B54i676iQJb/YATL4CGoI2fYNeiK4hFhFEmRN5MWrUO8Xg9/CdW+428KfL8rzwG8NsbPdVb01TNNaLr2AVsVnSYTca8vZJlYZuzz5ahOlvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/7+BV3M376Bbk5J5XiYhN0i4j/PM51zHJkB5z5B7jnU=; b=aU49JPW/EMnAhInp8bRjYTKiE3z3I/HdheOTW5x9B+VIvkK0zvnXr7S2Gx9kcfFoJcUsRLIzcRMw2MezoP8inAcuKVF6WIzf6R3H8frUFKVRDCBPmyUP6IVOtJ8fO3bCudNy/0HjJ20FIURgSgboTFzB9zXKLvlU2WzxQvPh489oIMCXkHRyZMCBiCvoQzrbSM2QDGnVnBxzLW3d35RzyWMbBpnG47vS2pCmSbjCu19QHX7F86wwnPtL6AYX8OOkbn5d867WmJOwwKB9o/8mxEvrgnlYqj9iIelisB5oXpiAN7EGg3Iv++Znn1u+G48/vuMaSpOss2t51qDfaCg9Dw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DM4PR11MB7304.namprd11.prod.outlook.com (2603:10b6:8:107::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.24; Tue, 5 Mar 2024 13:48:17 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e%7]) with mapi id 15.20.7362.019; Tue, 5 Mar 2024 13:48:17 +0000 Date: Tue, 5 Mar 2024 13:48:12 +0000 From: Bruce Richardson To: Mingjin Ye CC: Subject: Re: [PATCH v4] net/ice: add diagnostic support in Tx path Message-ID: References: <20240301095052.460597-1-mingjinx.ye@intel.com> <20240305101843.769539-1-mingjinx.ye@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240305101843.769539-1-mingjinx.ye@intel.com> X-ClientProxiedBy: DUZPR01CA0055.eurprd01.prod.exchangelabs.com (2603:10a6:10:469::19) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DM4PR11MB7304:EE_ X-MS-Office365-Filtering-Correlation-Id: e6b32c05-0e91-4ced-783f-08dc3d1ae92c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5+BiYIwtpwk8q2I2DpZapEQ4x2WfCFM7t5zzpQrbzcBHsfKvTVSJKtKkkHmNjSezsPwlypdAs+/LFccuIGaWZHdbPzL+fh4Ph/ke/i9s5CARoCA/MTXGUW5JAK/6f8GYTkwVUB5tDWVAQKIGbMKjRYKrsanWlkORHr0+OcAvEwyixYtixXLieIxaH6KZ379EQ/fPwxSM1/YZ+oKdq2MdlAdutqDLJ7h1IEv2Ir4lFpzGtZJ/7IB4/g64kk8VZrEZOmv9r09Q8VfMmRTUUQdTGd4rEtTeORwsvdCBGSeI5VAPbMnAxic2BljdEKR/zbs7jbHYPGJ6Yg7/0vGJNrwV8iq0S1bqTkNcZEXzKRtAZMilZcw/HCebTRFAHjyx9GemlDEDtN59FBLiSTLznRuZBZ51bKX0ceQzCCO75a814qNfjqvHO94gLDQLd4vbt4/5jRsOhX+HhBs0jNsaHWeJbaUyO/YwqaBfgTfu5+qEYrwe0l81StCtrBKtbKC5sng7s9HEJC/kvd1iGXL7+iRp2H1DS76GTt/4NdafaVmUbNWK0VmqMj5QBjbpoWmaKPepQ35WjDRgeeVZPoHOTXVCvY+WmrvxnksGuFMxniQt382LQuruVe4PFj8U1H6qm9RTG/hU+E2PndUAneCtu1s94HPl7IsCRo7NprDqAqYg5NQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Z8CnI+ezm6l/DVlsHjoxnmRW4hnhGby28xLBVRHLr5+KB80qSYjrH/vK7vGi?= =?us-ascii?Q?uILSCuW2pxXP7SvwYPa7xYgLaxSthuCLH5jd5gznSCtGIsIsfE+AxoNCRQke?= =?us-ascii?Q?OAIKgJv/BfAEYF6F+cQnrHbwWUNl9LB9SgUJ3kH+mP5+a9DJvAtFDHvGG1ZK?= =?us-ascii?Q?AOexdCOz+b3SySpZTDtvYOvVT31vFx/5xnDX1yJMUyjZBiFrEvGIVMbVRu8E?= =?us-ascii?Q?3clmA5wvfzYUy6o546GTFv3Yzj94AJBQWb6k54sXCg8h0gwS6aDDT/Nr/EnB?= =?us-ascii?Q?LDvpMS2rhXuHHRH3cpS6nIfzXTjuziAd1YcNbQrTe9Jnjln53uIukV4Kpim2?= =?us-ascii?Q?at5AWhX9lr7ZKTsWdly0MeM1LIwpHG71qrmIVGeotb2Hewo0HnSGRQfpxV2F?= =?us-ascii?Q?tuU/F4vucgRpRj1fXDQsfDSnFsPWyv6XVSK7dkZGnOq35WkDGRYyoFzLiher?= =?us-ascii?Q?tD4usVD8NrMxo1XWeOYbqrK6KsK3/oD3Q2kl57VEBohJnZOri0I9qxljjAz6?= =?us-ascii?Q?bO/tfe2Kw3lokvgP8zFxC5u7h8+RgM6zFyBA/Ixc9xJ7n+cvRLkGKwYfOkXn?= =?us-ascii?Q?+OAETtBIC/jdb2tNX3/XFHUl5Xn7a8Be/8DMnam1dUyw9ISUS+AGrK1W9UaZ?= =?us-ascii?Q?TxjasCyKeAMg43MQR4wj7pZUZwa913plVjoCflN3upsBIBHyc+TnnKlRc4Dq?= =?us-ascii?Q?7k/j6H/fmcrCHAbmyq6352cmAPa78uAvHFhpsZZDCcyxbEqxTVJZRHld/Jk2?= =?us-ascii?Q?vXKr8XUU1FDjmgXvh9fj7FBeVe92HID18zaEZYDkRqxK95tOc/jzByiSKRYM?= =?us-ascii?Q?tITkwskpIytAo20I++XhIin0QZZ8ESFn4WhRg5lH99X5RJevP5OgB28DUOy8?= =?us-ascii?Q?Bvu3RuLnMsvlNCMRjz0Yh1Oqm6Hy5zG6OEA8Rr0zuluBtkmq1u3h2291trma?= =?us-ascii?Q?SL98NYkABrIhwA7ZAN+LK/4qyHNtoEsQVXUlbPFlr44IAQV+u4keZt6dnKZk?= =?us-ascii?Q?cyjXWPZw9xTtUI1pqg8WBZ4zIOvc2J1I0xlc1zTHm4Zq8cc7ePgxSCwzg5pw?= =?us-ascii?Q?QrUFjeahQ5W0zb9SczmAe6f8hHIYbTHCyqQEwknY6Tq7+r2+Um2BqVg3/vHd?= =?us-ascii?Q?+Ykmqbq9cWrgitBT/DX1OTIYrK/SmueK8NTvqwyeCrtr3FwhRIpHMxwKjYcs?= =?us-ascii?Q?NOmszwmYxHdQewAbqYEhIkmWq+2dseweaba3TiUvLdL3TyU6igRcFLYoep5+?= =?us-ascii?Q?WyvNHut2z8xqo+BIz9TwssRGLACdPd0znGJln7+yLf34dkxSDrh5cVK9PygJ?= =?us-ascii?Q?jk1QX9LHMg/bpWY3ra+1HB2Ad7PKr13ETr5yw8h2Tcs9FaYSYbRACLkeUnrm?= =?us-ascii?Q?OC7sYFSIDTu6/2Q7UwWGGOYbs1UfveCRfdPdbOAsRGamDWso1uGoTpje7yR1?= =?us-ascii?Q?VVt/CtaTUF7s+0Q10IU++33cNvP36nkz9DQir9vX5kPwGF8s9j7ISSyWBBIv?= =?us-ascii?Q?dtAQ1mI2n7k4/7ziY82Fk2M5ezS9iA+8nkI3oC6Kpd7o6zrlxn5yB0kfsfxh?= =?us-ascii?Q?NmYkigfH7iDXvLVmlLwcDagtoehrognQo7QZWn63tmA4MP7y3QdQSwyNiUqP?= =?us-ascii?Q?1Q=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: e6b32c05-0e91-4ced-783f-08dc3d1ae92c X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2024 13:48:17.1372 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Dd7Ciwq7mOv4dGjs9PZ8YQM2uE66bUWUOyEyetcso6Siu38MioxPRUwTW01b36c+9nG1qhnLY/0LT4c4w75dlwaRn/z6h9c5q7KgDbAl9y4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7304 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Mar 05, 2024 at 10:18:42AM +0000, Mingjin Ye wrote: > Implemented a Tx wrapper to perform a thorough check on mbufs, > categorizing and counting invalid cases by type for diagnostic > purposes. The count of invalid cases is accessible through xstats_get. > > Also, the devarg option "mbuf_check" was introduced to configure the > diagnostic parameters to enable the appropriate diagnostic features. > > supported cases: mbuf, size, segment, offload. > 1. mbuf: Check for corrupted mbuf. > 2. size: Check min/max packet length according to HW spec. > 3. segment: Check number of mbuf segments not exceed HW limits. > 4. offload: Check for use of an unsupported offload flag. > > parameter format: "mbuf_check=" or "mbuf_check=[,]" > eg: dpdk-testpmd -a 0000:81:00.0,mbuf_check=[mbuf,size] -- -i > > Signed-off-by: Mingjin Ye > --- Acked-by: Bruce Richardson Applied to dpdk-next-net-intel with some whitespace/indent fixups. Thanks, /Bruce