From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4441B43C5F; Wed, 6 Mar 2024 17:39:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 176CE40276; Wed, 6 Mar 2024 17:39:51 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by mails.dpdk.org (Postfix) with ESMTP id 7684A4026C for ; Wed, 6 Mar 2024 17:39:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709743190; x=1741279190; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Seakd8ZjTe4aG20iwi4XTTBeVXZjgd/58SsN4r9+tk0=; b=fzZM1jQJ9u3KZGL9sgLBNmlT6BUI/TJpm8VmWiVAClQVsjjlQOBBe8Xn Q8+Eiqg/hLBit3gMyuauJUKT1JPapFwHfq5ufvIjsRUPGi9SwMfWiJOLb vhcTZeSf6MtCNqKycf0Hugsnpw+Pt74pghpLKioM2bv1L3iDPq8/7268Q rmBBN2zHzEtAk9i+JGV7RQeHbJ9nLop/pZKz3PsDUqa8OHbOctbxPfnhL jszv0vZyOFmqQjz3TgiHwqUnqIPr4KcitxtWeVT8QilshfACw9a78aWIa KqxjQ5KHhXNAEeW7uRx7fSjxZnwEJi9R9snByTTHb3wMSri5ZzwXdL5/v g==; X-IronPort-AV: E=McAfee;i="6600,9927,11005"; a="15020165" X-IronPort-AV: E=Sophos;i="6.06,208,1705392000"; d="scan'208";a="15020165" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2024 08:39:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,208,1705392000"; d="scan'208";a="14458944" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 06 Mar 2024 08:39:49 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 6 Mar 2024 08:39:48 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 6 Mar 2024 08:39:47 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 6 Mar 2024 08:39:47 -0800 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 6 Mar 2024 08:39:46 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eickD+ocHTS/VXyPC7TrTWUfm9WUoE2pMYItq39xINwRQ9RcT9kODnFu+ugnh/+mb9NTUcIaceD3vY4iH8cFcHz1bptnwcJiOF2b5mDMHvTzLP2xtOLRabBnxpZ5wFShWvzUSFLMpj63O5gKRjhbRtu6zM57A4gh2oCrYubjAUhDE5mjuGY96QvuzL2ObgZRT8i9pIqBcg/aXAxW4Nxn5Lq9SGypqDA2kLO1FnA+Zd/QNAgMk5pNu1IQB5P1mtWD0xF6t9VgTHXNQ86nunFZoiDfZxcBOzY4Odbvd6cH4Ngydpr9//LxZugyIx1knl+rheFnu4m7xsO7PfTWQl+Cvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gyFBuUy27Gmn/Ula9gTfG13g1eJPULMW+EfsZ729avo=; b=NnrLnkuBiU611xWx/69rghXrToPSXpYhdHgTh0P0Kt/Szchms+B0Uh57+wsOYX7J0AL3owiHKjx3xA8iB/03e/vYsZWjXVEo1/FfjTCZ5SxvA9fHs5+FCGAL8bSlKyGQ18N2qljp+dYNF2bxm2XNLhrTHMFyD8E/oYWy7YXkq/qgsWHfHfAtaI1LB/s/BZ12A/+Yhc6QZ50ythrME7+RmOOpGs1wFJZa+fgSe2G0P1iQTShmn/TeDNyg/yeTG6739GeyzB1jp4+7zyLAJs72c6gciOhMCezBIjdiex9GgzPB7rbW7BAeYZ4y5Es7AfvBOrETQ0NF69Rd6N8N87dSYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH8PR11MB7070.namprd11.prod.outlook.com (2603:10b6:510:216::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.24; Wed, 6 Mar 2024 16:39:44 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e%7]) with mapi id 15.20.7362.019; Wed, 6 Mar 2024 16:39:44 +0000 Date: Wed, 6 Mar 2024 16:39:40 +0000 From: Bruce Richardson To: David Marchand CC: Paul Szczepanek , , Subject: Re: [RFC v1 1/1] devtools: allow libraries with no global section Message-ID: References: <20240306143539.160467-1-paul.szczepanek@arm.com> <20240306143539.160467-2-paul.szczepanek@arm.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DU7P195CA0018.EURP195.PROD.OUTLOOK.COM (2603:10a6:10:54d::18) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH8PR11MB7070:EE_ X-MS-Office365-Filtering-Correlation-Id: f0d6827c-0dd2-45d7-9d2c-08dc3dfc06ec X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: N8nSqda1Gwe04+fp+xpvUjYVzt1FTNJBr6rgEy3sAmNnXHbGegAYx0dsimg328U1pPFYl2a9U44yk4l1z41h5uKj0Cp4B0sgkIlqL+Wdqo5Xs4yIngz3ZGINe13QoWpXR5/LPYGE6nmbfpLTsPzXD32T0eFLtMTgoYncpg5+p6HOpDgTs2VGJTdtbu4fWxfddMSWkMqLyER6F62/k/NXrRaDwnkVFhjMDANo21U2ZZbJW5kvOdv0Nw0u/nixWnxf1aDDxhjJRb9sZ7kEUNKhIU8W4jai26l218sJK4t28iYgI+ljJEk4whuEgdl0wm99fJQGMCBqScDtzMD/G+KbdrFUlrg3KspyVeBXU+6Sldbks3aFmN9YHtLIPdSn+bCHiaWC5m4jcEN1hitNa95u/cAPEtY+KqMC8qvwnsKVJv4/Pylm0ssjJ5MbPa1Y+7DyVhZ8f8hBK9Z+4OHxxBKnv5AFKWdAso9eJ2b1W1619/WQ4Q8K42KQMKafdrY5kgrCfG7/jGssFl5U9Pc9+GmaCmm0LcCjcL9HCd3+RWyocpIR3KTK+NVCNeJRK0RK5IFSQaz+eGe5+kFhpNz5WHrmIclhKLQ38RgSieaJj38yB/c= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmFUM3ZuMzdlQ3JDSGtXZlc5aVAvQTZ5VGtXUzNTbmZydVhSN0pTc0FiTzQ2?= =?utf-8?B?T1ZkZzEzdkhOZU1Cb0U1eVhGcWhJY2Rld0VnMG16bUUxUUJPRXFORk9Yc3Js?= =?utf-8?B?NlZrakJKem5xZUNzOWtBNk9LOXFhZlcxR0xnSzBjUzJMYlo2S3N6elZIbFln?= =?utf-8?B?ejVKQXorckF0TDVXWmRsb05qaTBEQW9rZ1FRcDlMSkliVnpCTk16djF6ZlU4?= =?utf-8?B?aUxNTThVdDJmaE02UzN0bEZWbjV5bC9zTWpodjV6ZmdLRTJlVjZ2bHlNaTFx?= =?utf-8?B?NUJuOUxHUElqWVkvTWdobFZ2WE1EWW5FR0ZzMGRsUkxrRmdOMWhLRVR4MGYx?= =?utf-8?B?VTNwcllnUlBWNEo2SWtYbWROU3J5ZGdJbG0zRkNVM1pkVEVWRWk5MEYrOGph?= =?utf-8?B?dkZIRkVXY25pSGZGdWdGN1hSRTNnMm1yWkJvOXRrWWpXNUFSbGtuQTgwbVcz?= =?utf-8?B?NitLRmI0QUdNanlDazh6NER3M0o1SUl2SytScGlxaEhlS2FXcCtIVjlkdWRE?= =?utf-8?B?ejE0cm80SVhaMXVXc1pxcithRFoxM3FnckZ4TzBDVzRZSnRGQzFta3FGcVdw?= =?utf-8?B?VzdjSFlnb3hLQVlyTnNRQ05zeXk5SWdxWnlKUXRJZ0hYUGxYZGVSL1RocFVy?= =?utf-8?B?azJZNmovSFhSZjNSdFEwWUpVMVBIbFVORUZBenlTd0wrclY2THpnTVU4VEtB?= =?utf-8?B?bjhyMWhTRlpoSm1TbmlnWVZTbEFzakZDUmFGSnQwb3U5eEJWaVo0dnlYVVk1?= =?utf-8?B?dzI2VkNRUmwwN1lmSTd5MENiaUVFdCt0bGdYb1B4ODhuTWFYYnYxQUh3U1d2?= =?utf-8?B?NWZoUnRmakYzS0lRWnhrUjRUU2NvY0I1MWVybWRKSCtZY00rN0ZXeEovZVJ6?= =?utf-8?B?Qm95dFp3dzdjR1BET0xCejc2Tjd4clF3WDJuS3lOaEpkVWcycllidmJmV3ZW?= =?utf-8?B?WHpHaTh5dEVVay9ZT2lWK0d5ZmI4dVpPNWcyZTRUMWNGNGFBZm5maEhBR0ZY?= =?utf-8?B?eHRqdXVxejYvRlU3ZFRUMG04MVR6cUhVNzdpb0xsbFQrcWFQZzZkdFNTTGdP?= =?utf-8?B?YWx6UEFBM2xrSEM2ZXhMOUpCdStwY3poRUxyYWhyVmpnYmRYZCt4VUVaaHl5?= =?utf-8?B?d2lnYWlEdHNKcEdjQmVpMWVxdkxvUi8xdjMxOFhnVG16azRONkRURkQ5K09p?= =?utf-8?B?SDVrNks2c1ZHUGZIQ05GOHMybTBUMXk0M1dGdzZQd0I1eWpzOG84NkFzekFK?= =?utf-8?B?RDR5THlIbkNFYjQramtiYlVnOEtXc1FNR29XdU9xZFJoaDNDSmxkYTlkakR6?= =?utf-8?B?QUpFcUpTMmVqcjNua2JSOHQ1V1NodHFTRmpsNWFJUnF1WUYxUUxGQi91eW04?= =?utf-8?B?Z25PTXhFK3NSTkQxVGJPR2RLUGk1TUpoeDBZS0FjOVh1TkJJV21QUVduYXRJ?= =?utf-8?B?Y0Rpd21lYjgwT2NFV1daWEFyUEVBUVVFckZTR2FZczlLVk5iYURYcjRjTlZU?= =?utf-8?B?ZXpqQ21IRGIrTm5HNVZTL3JBNGR6Tll3ME1kRjNDQUdtdnBqR04yaVRFeXA2?= =?utf-8?B?QVUwL1FXenQvZVM1L2daVnZsM1Q2UjJiRGtTcGJUQ21jRGUwVVg4SDc3emk4?= =?utf-8?B?OG5GenNzSmp5Zk52M3RLV2lDU3IzNnhSeFdRS1FqNHZQdjdzOGZkQ0t6WUNI?= =?utf-8?B?NGdBTURocSt4U1VWNFdWTXNuNnhnSDhPTEZvcmtrTU96eEY4WE5KQXltdEEw?= =?utf-8?B?dEpHcnVzZnk5bFVGdVlxYkhQRWc4SzhDQzlUYWhFNzRNQ2dLZnpSSXdwZ2hh?= =?utf-8?B?RnBSNURyb1hKRWpPbS9qS1hrVWR2a0hpTml5MWdRT3QwRjg1Mk53djhVbDJm?= =?utf-8?B?T3h4WTVYbDBSTkJRTkYwcnE1dytqaHpRKzQ1WU0vbFphbFFKRU9CQTQySmpX?= =?utf-8?B?M1d4V3V0OHBOMkg4VWZrTlMwUUJORG9VWUtmZm1LQ2xseUtQMVhlYUZxdVJM?= =?utf-8?B?RW1Hd0NuZ0hZSGxHWjJTNUVwQS9vM1FGZDkwMHpKQ283OW5jRlgwdjQ1OUEy?= =?utf-8?B?Y0hYclhINlRyUGJPaG9VeHRQd0QvMzcvREZEVWsyNlF2SWV6MXExaklWR00r?= =?utf-8?B?RTh1L2xzQThiRFNtQ0RsZGhhb21QSWpIWC9SZDNxcmVhOFNON09FU08weTFV?= =?utf-8?B?OWc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: f0d6827c-0dd2-45d7-9d2c-08dc3dfc06ec X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2024 16:39:43.9317 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eLvba1IP93I70W9kyRZMKFUgfPj922XsPzqdalOfctZQxUbBpPFhKLTVkm5vfaXZxewCabAWxW+MHvRCouUXKP0M5BKeSxyvVsKJ/Vz68q8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7070 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Mar 06, 2024 at 05:14:15PM +0100, David Marchand wrote: > On Wed, Mar 6, 2024 at 3:36 PM Paul Szczepanek wrote: > > > > If a library has no global section in the version.map > > allow it not to have symbols and not report it as an error. > > This happens if a library doesn't export any functions > > if they're all inline. > > > > Signed-off-by: Paul Szczepanek > > Added Bruce. > > Having a library without any actual code compiled is (I think) new in DPDK. > > On the other hand, for headers only, there should be no need for a > version.map file at all. > > The current meson code expects that every library provides some files > to compile via the sources variable and it expects a version.map file > too. > I wonder if we could skip the whole library generation at the > lib/meson.build level. > Something like: > > diff --git a/lib/meson.build b/lib/meson.build > index 179a272932..f0bbab6658 100644 > --- a/lib/meson.build > +++ b/lib/meson.build > @@ -222,6 +222,10 @@ foreach l:libraries > includes += include_directories(l) > dpdk_includes += include_directories(l) > > + if sources.length() == 0 > + continue > + endif > + > if developer_mode and is_windows and use_function_versioning > message('@0@: Function versioning is not supported by > Windows.'.format(name)) > endif > > No version.map, no check to update :-) > Two thoughts/suggestions here: * in original meson port we did have support for header only libraries - I think for rte_compat.h, but that was done away with when the header was just merged into EAL. See [1] * for a header only lib - if we are prepared to forego being able to disable it - the easiest enablement path may be to not add the directory to the list of libraries, and just add the header file path to the global include path, or perhaps some other library include path. How to make it work best may depend on what the library does and what other DPDK libs, if any, it depends upon. [1] http://git.dpdk.org/dpdk/tree/lib/meson.build?h=v18.11&id=0da7f445df445630c794897347ee360d6fe6348b#n72