From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C56AB4342E; Fri, 15 Mar 2024 09:29:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4117242DCA; Fri, 15 Mar 2024 09:29:13 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mails.dpdk.org (Postfix) with ESMTP id E12694027B for ; Fri, 15 Mar 2024 09:29:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710491351; x=1742027351; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=BnD9wuBq7ltiKn3MY31X2GUrLjX9+YsiK8FI+//FLwY=; b=Ba3/KtWe/Wdv4dxvZFraLU4OhsI85eaT5XAZE+aZY3MnCnpU9JPNoDim M1uR1CPveXcydm+gapkADmpgiCLzMYGu4GS6YjQddd7Capg+2o4Qn6ppt 0cc3ewPU9UVMF1w+3kvc/7agNFe31iS0HfjF4q0M37SiQpvSXAevOLs3I h20yRHqk0Kv+GtFL+66BELk9NtRB3mgTZ7x5ulVsHzaASlKF7UbJaGlDe mIx1E910dtwC3sFnIwN/vOHxlzDJvT3lBh84gdNoWWdxkVvlD/XhwTRN3 LngExCml7fcQFOchmT/183I7YRdEwql6HXJS109XmgfFH59zOyupCg6gw A==; X-IronPort-AV: E=McAfee;i="6600,9927,11013"; a="22810366" X-IronPort-AV: E=Sophos;i="6.07,127,1708416000"; d="scan'208";a="22810366" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2024 01:29:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,127,1708416000"; d="scan'208";a="43494935" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 15 Mar 2024 01:29:09 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 15 Mar 2024 01:29:08 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 15 Mar 2024 01:29:08 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 15 Mar 2024 01:29:08 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.40) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 15 Mar 2024 01:29:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EemK6RrT8/2Dsg9kA+s6mbcuIrL8WjVAKfGEiNjXpms6rSMmy83vIkykTsEnEAYh1PjbEDq5QSnYir7ItQPTJehOxzx7+dbLjXjGDBLPRWzQmhlnivTNK4SiXGP0h6rq1Uol1KSutoaq/X3qV3+S86FWYY08ooFgTFcmVuZ7lKh7SQGApLLzuq3Ng+q4R4BM5Sln4HK9EuzVx/7UfdNHDf4aAkxX170sc9Cdpd6C7Eq8BPHLdZi+tlgDi0C7n3nQ6HRtem1qfIMPoABY+55i9n4Q/hMzHP3Fjy7XgWVEBExb+xFNSU/qN0caAUuAYVeeN5TtHxR13eqm0rsukVX9Ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XZ5Vnl1e2k1nGMTZpAOORUC5LEMRO+554qmxE6vEriM=; b=kQEJlKSFu5K/vSLGlu+aPyL4jIhrCB+nZ6McmeiH7guX1KI+gKR6trNlF8vstDvD+uRnJMEIZaEu6aES270H3fm5nubGCoEYxTFv5ZYv/F+Fc/VASCtAMomEnPPAdn3c/NzS3htUQyaLt9yUmv3zYXdyAaGPOP5mocpstjgLuI9lFac8uaDrCWSBjMtGsoLawbhFVE1yUjZ7arVFgK7WXJUsSp2ISK+2VgoZLwDARPhiuxHt3HdUwa1PULF7HaV3geYN+Ejr5/C2Jyk0OLdbuZ890aSSe7zxP5gFLpVGyEImmpakOKbBk1ow6xCtB0DE6L27B9hBvOfiEmCCl8s6Yg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH8PR11MB8064.namprd11.prod.outlook.com (2603:10b6:510:253::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.18; Fri, 15 Mar 2024 08:28:59 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f%7]) with mapi id 15.20.7386.017; Fri, 15 Mar 2024 08:28:59 +0000 Date: Fri, 15 Mar 2024 08:28:55 +0000 From: Bruce Richardson To: Tyler Retzlaff CC: , Harman Kalra Subject: Re: [PATCH v2 2/2] buildtools: when building static library use static deps Message-ID: References: <1710445477-23848-1-git-send-email-roretzla@linux.microsoft.com> <1710484222-17310-1-git-send-email-roretzla@linux.microsoft.com> <1710484222-17310-3-git-send-email-roretzla@linux.microsoft.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1710484222-17310-3-git-send-email-roretzla@linux.microsoft.com> X-ClientProxiedBy: DBBPR09CA0033.eurprd09.prod.outlook.com (2603:10a6:10:d4::21) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH8PR11MB8064:EE_ X-MS-Office365-Filtering-Correlation-Id: e9a3d6b0-38df-47a2-63e7-08dc44c9f680 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NIe3Cga9B/hW2PUWP1o10h29Mree+ceoNfCQ2Wtd+C0yRw76OwRAmlBz0NFM6bVLODatpJ+I4uWdzGI/oWnJiZVkeVZ/XQq39KnpWYBn+fAO/rwe8Qnu5ZcJLKa9w0oJm4MjiRZOPF6uTvMVk2CyajFc7ZsiDPocWdeHvEtIuyiwqf/Lk0qEuhGsRwkTCnTL0NpXwCfYbBv+1xdyuIweS/G43F6D5xs4qPVd/B7EvjgVKded+pvumh5Pxh598FR6qehiQ2Oku0MghWrLq4FYI7m3jg3+yataIjWtDcViv+jv8gQ41uNUtTqIXpnhST7FweMRMZtdQJcYq5RmlSithtKSMzcVqCLLdTi3N9a+NqGX8NRa83SINv5Mb9muKkxhnIfB7FHpviVBc9svIoFbYVTmwSx6976oQZoFATMEz5Dun2mSddDgg+rBK2sucP5fbau6KjpIOwh4oRQSvvQfrOOZeImcZMMgoTLO0VcfWHG60ykKivd4LTyybDnWQHVsfJG8H9OCngMGQ+CjXZcC3/ESqjrYAtaMOgnu2iRzyJOXtrHLJj7gvn/N0PEffBky5hhI+et2YF8b21GI8OWh5DS/lKPdPJ9UtPzVPVvOHW4xzCjMBgSLdX3jXQbSIH8V5qpULLKULDVVC0nIcmTJW+iytneVzdy4um6YLK5f0h8= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(366007)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fJCEWzWpj9RT1uHJbt/9LVi80mMln+7kYiLWdYFwc71//PRaQ+tDXjiU+kR7?= =?us-ascii?Q?l2menysJGaA37vvyj/tsB9hspMXGhKNFKIGiLXMXnvHCKDnGR8em01moKIR8?= =?us-ascii?Q?SzCZ5LBX5Q9MybEvemByIsoGVX6WRJTV8kqwo6v1eOy6faAZ90njt1TNfypj?= =?us-ascii?Q?J2qTwma57TVTOybTNSIwNs6u1YlYfI++k4Kwa3Q5CMv4RpzQDlrSr1ddf6iS?= =?us-ascii?Q?tWyuhttcnduQ2ofaiK1qAjDoW3z6lBsR/DZr6VNT8t7xo+JXHRb8sj8Ecfqp?= =?us-ascii?Q?2P5fuWdDdWLL1C2MajzskUZIaZx8jlH60/88eVAz3JQUHYzfMFZjYnkGy4Jc?= =?us-ascii?Q?7SKMMd7nqGqOxvTtOSgqqdpJ7RyRWsb4COZu/aUqImDa1GMbkWEF6ttG/LDC?= =?us-ascii?Q?GtN9CHVjnD4loJLQAg3kdjzjnDGGj9ylqlK9aa6NAkscchru7aSycoP9StGl?= =?us-ascii?Q?TSRgqWcfsdHd+DCla3RiTK4r9kWf85TT3IQq1r+fQ0unOg3bIgmQnNVJgLLd?= =?us-ascii?Q?5g47eSsogha+GH+imaG5vUlKiEQQ9RfiXhrAbQmu13YjFPTFsZJnXewU/EJY?= =?us-ascii?Q?n8ztVv8H55p9qxAKGTdCyU8yYkk+xHcPyfDtr0+Xt3TcHr3xCzWuwpS0TVpG?= =?us-ascii?Q?40D3EVdDoqX+NnFcPTLtRwGL3KLM6gIGIgKg2Y5nNPLKtn/vYKXvDqZe86Jz?= =?us-ascii?Q?IonEjtS4XLkWEv3IfXk3yJPQRKw/8AU148ASfWuCqi+R/Dyj7HZ02KfYyYhE?= =?us-ascii?Q?rGjqL2gvOZMOaL8SWFBovHgEOUxdHcWelgofMzoiwP7wV90vEXOe0KRp6Q+9?= =?us-ascii?Q?ak4UQm4KcgZ7i5BjSJs2K1uHS6/nDiVG8jUNOjrgO24yUnFocohGNM739T4u?= =?us-ascii?Q?ghMhd3ChdaX1fPfgVj0OUkmhlRKpcPV0JFVwidLIMQ8qfZbRErUqEffkim3Q?= =?us-ascii?Q?p5mOHs1wcZxHykeJyIsSVisUt9HPUdPwonuDEy8U9KVFiPF800fuXk2Oc43X?= =?us-ascii?Q?jw4tu58a2V7gsCbmnWghfAmLlQkoq53ylD+s6REocdROGJ+MM9bLZ8qs2YU3?= =?us-ascii?Q?GuL4wl3HvT5StHDg+BXvUC6HLp5bn7vNcxfT7ee44IMbWq+GxZ4UkB81Pq+I?= =?us-ascii?Q?glroEvI3VaGVQcLO5PTcg0xNxQQzVQ/0waoFbB1groHkIN5hq63xCaTntdG5?= =?us-ascii?Q?JH0oQUd5Mwg+/wk5MzyeF098BzOs6GO1agv31HM5tp0D1cGWBm09jWywQTDV?= =?us-ascii?Q?xxsJzp5sIqfEsIQ+JANTJSwSSI742Rg3j3NFd6vSg350Oop4Yb8kfsQJGDGb?= =?us-ascii?Q?E7giCtNRQCcCFDqcPE9rbUw51+LnHU4aO3CMP9Sp39yz5pcQ3ta7c9zhyRnA?= =?us-ascii?Q?7dp2liw+cu4Se8qBW73HYkqlQqiFQz7jzCI5Gwgs5vb+kDSYVnKqpRPydmSq?= =?us-ascii?Q?3Qs8vPnI3zhx9MjYaOMB2YToarEE2nY437C1YTLSqIJscAUpgGXmbzxGn1TM?= =?us-ascii?Q?N9/jJRQbSaYF3DjOTIrSY40DsSArRq/DZd2Ow6z+lZ0dt/d1Pm0/MM7zGA6X?= =?us-ascii?Q?yzSND4HBWLLg79xc7g21c2YhkNn5PCFihzzzHqV5xCy4l0zertIf/+T+qugu?= =?us-ascii?Q?/w=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: e9a3d6b0-38df-47a2-63e7-08dc44c9f680 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2024 08:28:59.6495 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Vfcsm+UbCXpToBKKe3TxhBJyS9pmjLxuGhoUyNDcEHLzNsp5JQwvwBrusgIHSM9A9i85AKHduf18a2QEzVo9Zmycgo1nEcb+trbcTigZBeg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB8064 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Mar 14, 2024 at 11:30:22PM -0700, Tyler Retzlaff wrote: > Use static deps when default_library=static and use shared deps when > using default_library=shared. > > Signed-off-by: Tyler Retzlaff > --- > buildtools/chkincs/meson.build | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-) > > diff --git a/buildtools/chkincs/meson.build b/buildtools/chkincs/meson.build > index f2dadca..66245a5 100644 > --- a/buildtools/chkincs/meson.build > +++ b/buildtools/chkincs/meson.build > @@ -20,11 +20,19 @@ sources += gen_c_files.process(dpdk_chkinc_headers) > > # some driver SDK headers depend on these two buses, which are mandatory in build > # so we always include them in deps list > -deps = [get_variable('shared_rte_bus_vdev'), get_variable('shared_rte_bus_pci')] > -# add the rest of the libs to the dependencies > -foreach l:dpdk_libs_enabled > - deps += get_variable('shared_rte_' + l) > -endforeach > +if is_shared_enabled > + deps = [get_variable('shared_rte_bus_vdev'), get_variable('shared_rte_bus_pci')] > + # add the rest of the libs to the dependencies > + foreach l:dpdk_libs_enabled > + deps += get_variable('shared_rte_' + l) > + endforeach > +else > + deps = [get_variable('static_rte_bus_vdev'), get_variable('static_rte_bus_pci')] > + # add the rest of the libs to the dependencies > + foreach l:dpdk_libs_enabled > + deps += get_variable('static_rte_' + l) > + endforeach > +endif > Should the deps checks in lib and driver not be similarly conditional? > executable('chkincs', sources, > c_args: cflags, > -- > 1.8.3.1 >