From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8378B43D17; Thu, 21 Mar 2024 17:28:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 70C1D42DEE; Thu, 21 Mar 2024 17:28:51 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) by mails.dpdk.org (Postfix) with ESMTP id 11EC742D7A for ; Thu, 21 Mar 2024 17:28:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711038530; x=1742574530; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=EG6v2FkY5iH8SnNjsymbmGV1gecSTIXRDDVz0d2aFZ4=; b=PqbSWyyzZzkNzjWmIMimnPRKkX24hzCcu2SYY6D5aNKlyDmRgLbH14FF dzGcbGCGrTsaDuZ7Xr+8nMcUw6eR0L6aBPw3Z59OrE0JwjYWsgKB21697 3jG3QMicOAyk21V5Hm4LlZ6/z1jrXb8XxRhwmgv4DTkW/fJZKVr2XkKEB ZTIxnT0xM7W4V8ye3/a8sL5iIpJZRefKKFcbZ+FqZ4yjxV4uf73/xDB1U smlp4tQ1AFH/0DUsZ06wGnjFCkpOkkDYlM2LfivIwmEhyyakwGUBoqTJn 2xoIHJBigUVPBNjEyaf8dIyNcyuT/gOVn4E9YGvPEHrTIQaBB8/gxAz+p g==; X-IronPort-AV: E=McAfee;i="6600,9927,11020"; a="6161245" X-IronPort-AV: E=Sophos;i="6.07,143,1708416000"; d="scan'208";a="6161245" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Mar 2024 09:28:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,143,1708416000"; d="scan'208";a="14569173" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orviesa009.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 21 Mar 2024 09:28:48 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 21 Mar 2024 09:28:46 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 21 Mar 2024 09:28:46 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 21 Mar 2024 09:28:46 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 21 Mar 2024 09:28:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YEdUq/Z483trcfUQvZP4GJMMEhpZIh86PrDpli8X/Yu4c1kedCLjzCnLmKKWLPYHTUl0b9MHzuSi7szMQabsDBColhKqZZi5ZY9O7ihmRAZMGYQ63HRQ28PfwZ3JQNJh5uJUAddCttpYLvSCbOLb/kjB/RKuUTjjYoNnwdJBkExJuqNdJW/iKntpeJ2ATYZSZrIZWBl8/IAJ9SVEjsmNv0WTikfrYq455NtsaN1viVPStUVb1fCp3J9B7JBlw12EN0kgztYgoGJVvJC8iw7HRt5+/Vk5psC4ALJ5YV9O+Xr/uISBMrY4uWC7Sy/cmp+WS0CL0aKJ2Zp6ovELmrrohA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IrNWs7Po7UOqJTmOROdvBoy5Gasjhzpk9eVcMjltKkQ=; b=HAptSlH0b/cOuzzWBj6gCXu/lRv5j5dvxTYRtoP6392jldnMZzUFmPM1K/L+0uB8b9WAIvXyN+uj7nQIemrmk7pzrbCfSC9oYLMDSH7Plot/Oys3jGfdcIZ5kDRCKvswQiQg4kEyihItGWnHkD/2lX178BnS9TfW3Pj1Rr6njHlLyO+AXNH9L8/K8SBH2U823JrKAcVGU4B2ZXa8Sni8INhRyeQ1Gfkry7FnEeSuAii9G1czVtCadCtvXM+QCmpb7FMk61RlvsfbesyWbOcVo1Te7l9TrlpcQW/c6EqfbYDMQbM0IMDvNPezjwMePmKy+71olTC1aqMmmQZcG6sMKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MN6PR11MB8219.namprd11.prod.outlook.com (2603:10b6:208:471::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.13; Thu, 21 Mar 2024 16:28:44 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f%7]) with mapi id 15.20.7409.010; Thu, 21 Mar 2024 16:28:44 +0000 Date: Thu, 21 Mar 2024 16:28:37 +0000 From: Bruce Richardson To: Tyler Retzlaff CC: , Akhil Goyal , Aman Singh , Anatoly Burakov , Byron Marohn , Conor Walsh , Cristian Dumitrescu , Dariusz Sosnowski , David Hunt , Jerin Jacob , Jingjing Wu , Kirill Rybalchenko , Konstantin Ananyev , Matan Azrad , Ori Kam , Radu Nicolau , Ruifeng Wang , Sameh Gobriel , "Sivaprasad Tummala" , Suanming Mou , Sunil Kumar Kori , Vamsi Attunuru , Viacheslav Ovsiienko , Vladimir Medvedkin , Yipeng Wang , "Yuying Zhang" Subject: Re: [PATCH 13/15] app/testpmd: pack structures when building with MSVC Message-ID: References: <1710968771-16435-1-git-send-email-roretzla@linux.microsoft.com> <1710968771-16435-14-git-send-email-roretzla@linux.microsoft.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1710968771-16435-14-git-send-email-roretzla@linux.microsoft.com> X-ClientProxiedBy: DU7P191CA0009.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:54e::13) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MN6PR11MB8219:EE_ X-MS-Office365-Filtering-Correlation-Id: 76986361-9b72-4ac6-3bb7-08dc49c3fa10 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YuMSCBtLjP1PsRSKMXZkLoFExr/8b2ZANqgqZGDDEcG2Xkx43EQp8M4gBg2ZvcNY9ViKuH2fJXvrYdAmu9OUK66nU4ZjCqhm0MgxsghugmS3+NXaVuJAJ5f4xiZKMpbXJQyn1hV4g/6zwNoJ+N9jDiRGM0UtLL3YynogVATvOXBYgNPnjG6HD6jxnCRI+/00MbT48ERUdHXs18rOwDPHaBH75882hVTwenew8NsOo/8Yy97OxBv2as7QseNwu0zcPWyBfzu0cj0NwRdY6GBwgyVMS5/Pl4Ppo5Eb7oFMvpY7m3EXj1OalhjCWdLNqKwdQFt5wTBp+FHGZRzN4Q8UWHnmFWLm4ABbRt4aW/0z5B9PInux4bLvjxAQx4UxE9tPFnahlL8s5Obiq6B4oKebHZTjfceO/U30Hs3Hlg12McaU/RIk72wgQAbrSvb9g5SK4Qy+gEcuK9k5uTkPnp8hIAFzMAZqkI4FZbzEQoF+km8WQ91l0f1R4FrCV2kDUKGKHzgHXiiSVrMHSLkoZsJh5fZTGivdA1oERyAwZ2GSJwwx9GPN2xYMjgwW22H3Ej47SDYa6wafBiJA7/Bmn5rmMa3rzClMLdLXKi9GT2Q/6BB8Qb1NQ7WOnihjGMSGcDphp9A2ht8ExGeTskNTVvnH1H/uF8TICwzcgP14GHXAvDg= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(7416005)(1800799015)(376005)(366007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9Oi2Z6aN6OJxxT5vkrhex8A1M+w/5wUwNK6U1v0mBikNW6eC2rXkcXRoEbjR?= =?us-ascii?Q?l/qro+K2/UoHXF/iRORHOtDFR1kkOu/MoF6i4SWWp7ophc6LF5YkwFfQ5H5m?= =?us-ascii?Q?9xHQet2mLuoWYeolXTzJnpzfYwjFzdVBq+AH85RzEHPPVNRkoO5OgKu7wdid?= =?us-ascii?Q?UsgyBqJEquM4M1DtoXkRD1jqd+U/sX3VBni3yY1bN8/VWGq02KZwzTHIPqet?= =?us-ascii?Q?FmdcLRaRToRz3f7zDRPWRdE264gWNuvDtC6M3NHDtkY5DVlI/l4vsjc9vByl?= =?us-ascii?Q?H/L+6ZkzmkYP3B9qWqxLLAGLpQ+zKjqstX1CBSY1eiuVE/Pnv21bnyBeru2z?= =?us-ascii?Q?MvVjV7XbQqph2yP9rjep3S7TKYbGTpLKSTDmyAd9VYvYSBKaNzBUuYV1VkZQ?= =?us-ascii?Q?pR8xnZMTcP9RlTXQnc/+uSJ2H5R/AMrH/8oRF6CG8CrZ3XGOblNzWdfG6Xvm?= =?us-ascii?Q?Dad0lVCGxoBcwKY4dCN27n4NDileuScMEGdrAfm6pemtcwv9gQivMvxPodiY?= =?us-ascii?Q?KM78qXD2X/5uEfkfxsA4DkQmc1A1O07sK5zKSG7LCDonsW6KL+wsiHojKlfk?= =?us-ascii?Q?ajScpmjhhGTaKGcwg0N8cGi41xybSjF5CsnkJPFOUSoPAqSrFyRjhKTWaQuq?= =?us-ascii?Q?vb7Wu+Yi7JJrj3Ouhy4TgjF1aAbdri4euEGszpnwSzaBxqBfn2ZHGvCblm2g?= =?us-ascii?Q?f46Kr68nRzVbgEhQ5jvZWevbspX1gPCJV6eS/boSg9VytQnnA41X2FQjHgZ9?= =?us-ascii?Q?d7Hhzpg0rO8Dsd+ePP/8C6tfZcVkW5h+WkoHxKN15oYZPY9urcTGvCwxxwcf?= =?us-ascii?Q?uJWSUq/IUSacgqEFgPOWst7WCk5mquNPjpDD0H3BRSz0o4MzfJCbSgFimJpJ?= =?us-ascii?Q?C2qrp620uj45ggDhvQgs8Zh0Y/TYr8oVJMsOI+1diAWmd/Wi0H77gS7+OdS+?= =?us-ascii?Q?fBjNPiafftv7zHqZ0lQ9zBYMM+Uj5q5WndJTbf21D48yvkFioW6gE1tY17HJ?= =?us-ascii?Q?p6DoabX1qv/8V0u0Bjis1Xb++c7wQAZpwefBkdLO49A3CbuWtUdsTM9oWqr9?= =?us-ascii?Q?S8cVFCtQKEhEPPz3EiJUNQC2M7IFpP42CLiNI85nNnOy5YYlJjHyFz3vn1jR?= =?us-ascii?Q?tBjatc0VCKvm4aXrq2THyJiudsr/Ga5AX4gGI6aIFlPYsDe6vec0kq8a+mu4?= =?us-ascii?Q?8VSE70Rm9eNotH+VYrGC+18MIWyfTEPmDQKudIOoYkDxSZFsC1yFQhH5pa9W?= =?us-ascii?Q?mq4VeWHFxag4G+cjTdQpTtxEukNnrhngCYxEbEyBUfaoZ+iBOR0bA2HP7s7e?= =?us-ascii?Q?Qt9LMkw7zrdt6mRofEeHiiU2dTikeGLA0Lo4Y8nFOlJb8QLRVndGt1Z3zFWt?= =?us-ascii?Q?h6w6aM63KLFSC/kpyxdVgaqNZs9nW+9jlLuxOHheubJoelak5bCYc04NTdYB?= =?us-ascii?Q?ut2vW6HuaFDMslBYu3ECZ1UksjMhvrOBQTJVQSgl97CipoAAu3wFOt5eLcrs?= =?us-ascii?Q?6hkKVX+cQ7l8y87PGUnDsRxXWZHCFsohQvfETvopFEb3NK+8ApAxD6UUGfkE?= =?us-ascii?Q?flL3NTKo9zGD4wfFXHia4hNOEH9ORsJShhUE44dNnbsZuvkf3URXyQtbr7Lx?= =?us-ascii?Q?GQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 76986361-9b72-4ac6-3bb7-08dc49c3fa10 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2024 16:28:44.4838 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QkIzSgd/F3b1xyK+FBaLCt8LSDsFML+lJTMyHPGc0V3TqPvzvojQycBHzVwBgSR4yi6SPJDBxlmHRuv+hO6Xke1Mn87KhHDLybz7VpEjGhs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR11MB8219 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Mar 20, 2024 at 02:06:09PM -0700, Tyler Retzlaff wrote: > Add __rte_msvc_pushpack(1) to all __rte_packed structs to cause packing > when building with MSVC. > > Signed-off-by: Tyler Retzlaff > --- > app/test-pmd/csumonly.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c > index 6711dda..638e607 100644 > --- a/app/test-pmd/csumonly.c > +++ b/app/test-pmd/csumonly.c > @@ -89,6 +89,7 @@ struct testpmd_offload_info { > }; > > /* simplified GRE header */ > +__rte_msvc_pack > struct simple_gre_hdr { > uint16_t flags; > uint16_t proto; Should not need to be packed, as no padding. However, if we don't mark this as packed could we hit problems if (for whatever reason) we ever receive a packet where the gre_hdr is not aligned on an even byte boundary? Does packing affect the minimum alignment requirements of the whole struct, as well as removing padding? /Bruce