From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D8AFC43DF8; Thu, 4 Apr 2024 12:39:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5A96140268; Thu, 4 Apr 2024 12:39:35 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mails.dpdk.org (Postfix) with ESMTP id 7F1D24025D; Thu, 4 Apr 2024 12:39:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712227174; x=1743763174; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=eDTu2fC4toxfJq58m6GPI6tRyrNLYA2Td3wgEGzgJS8=; b=lv1mzFODarbiWvBbbLFhZ/4kLTbZQgzGxjn/DtfPsl1+tyaE495yG1c2 vd745/HQl4meWAtBJy05d6bEZgH5cCEoSZImkxi0sGrRnsQWLtawfqWSh mB+jnxXwPDl2b8z9U0Av2rprOCftv2V8daKLUApBoxMl+KVfpIr4ElxIw mgfROm0vTMedW3gvXGOsZEHn6TiIMMbN3CJ+QUCLI5OeGxR1icjU7wM63 iD/vf+b6lv3xeAhI87OIHAv3LlV0gZBfH2rc+qBt8OfSep/0Fhs97t2Od 65aPhlFZSpxEFEjFevf4FyEJfqD5X3BtXZ6EIjoTMhrPi3Ygtqd5enCve w==; X-CSE-ConnectionGUID: Tix/9CcCR9utELJPHpNkYg== X-CSE-MsgGUID: nsvV0gFgR0u79pTnRZy8qQ== X-IronPort-AV: E=McAfee;i="6600,9927,11033"; a="29972135" X-IronPort-AV: E=Sophos;i="6.07,178,1708416000"; d="scan'208";a="29972135" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Apr 2024 03:30:43 -0700 X-CSE-ConnectionGUID: b5vZC2MeSBOlveOC+Xh+Mw== X-CSE-MsgGUID: 1EOX1HjES5++9I4MU3EUYA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,179,1708416000"; d="scan'208";a="23430134" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 04 Apr 2024 03:30:42 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 4 Apr 2024 03:30:42 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 4 Apr 2024 03:30:41 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 4 Apr 2024 03:30:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NUvPk22so2c49UZ0X6+qMRo4PPgxpSzOHuFQCtnvhyLvEZe9Ud0nvphlOctdjT7x7Kk5kLo1q1yBMvo2p21tpzR+0jmR1+Mf78ni/wWNC3PpQAu1HXLZZIyPCFQDpCJOsV39uuJsFo7mJoHTDWtgRw6KsVKhuyDXVq7LPqQh90XPOwLzbc15K6foC7ZY/gkc6lPIHzxYNJFlzinBB701+eDonno0U2ObgPMijheJCVbMZ2kcwmNdYdqTRBkcP3k35XngAoZ/reaCJ9DRRqFcl0gNvOH5luqXbPSGksGyTRBSbh/ZlO6HPfcp7u7b/+Pz8bkxgKXrXK7HxTs1EQMFjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UkLQNMcfGw46g8NR8s01fdHjRervk951I+BdvcZJUA8=; b=aM7WqW2CiCZ/pg1SCZp4FJvAYsv0+uFK4F5OV3L/3vbWHz95OezN+iYeWgm5NfFlE/mUmwNil9SSH7b8hVX40fITCFjt5pnLT1/ExAxabcApj62Okewzr29F3i2dbLpB8dQby1ThYK90UvMmEEZ56SAlZuFu4H2HpNz6nnWDlWHMXaXHOFIXWVlLLfh7y6Yl3wTq2PTqB+GFEUQcN1f/JfJ6lKfrKqGVaTvceoymJdOc1V2C2UuT8MdFnKiUDwWjK9ovXMAAYzTy3jinwwQ9T309so26EZ5f4HlCkcrBDNWPA/dCpDGc993xuodraSZicQL6vl8PWrBKM+o1ApmfeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA3PR11MB7979.namprd11.prod.outlook.com (2603:10b6:806:2f9::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.32; Thu, 4 Apr 2024 10:30:33 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f%7]) with mapi id 15.20.7452.019; Thu, 4 Apr 2024 10:30:33 +0000 Date: Thu, 4 Apr 2024 11:30:28 +0100 From: Bruce Richardson To: Julien Meunier CC: Jing Chen , Jeff Shaw , Michael Qiu , , Subject: Re: [PATCH] net/fm10k: fix cleanup during init failure Message-ID: References: <20240403115541.2369-1-julien.meunier@nokia.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DB8P191CA0015.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::25) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA3PR11MB7979:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jXNaHiKIA+tzdY70VJZzw2HZLPFkfHDyV/vKKPwbM95ACbhdPFEsdq/0K1RcgSCSXpEYiuAZPTWrPBVo76TL9nlfMROZeWZXaD3QlHqUY/wHwTjeYGqnuhLzrc66Deo0vW4MdVhYcgq3RKuDmq1JEf+DcWmRkryAWPQthIDsPUJ7gVCXTFqiLwEoROau9RxXLqxentDRodXlzHnATS4MgrfVwpZ3pjCW3+k92PD1lxdfm8AWoHfuuVZowN+xkiyu7/Cjis8FzPswqtrMAwFzfj/Wn9Bmjuz4s3qEXT6nXuqKCVU+RIDbUhxzEZvZMUYLtssxOt60+d+R2BubV/gL3dyfEb6G/+6woq4YtOMn0jJMBuM8DJ4/4+k0lOQiL6hxONMr2PXb2AvVyG0Z/vyqA3vgTQsyVoID1OOvW2ZtyBuQVAYxHjhc3fb2V5kIkRZNZkcmz/d1K80RCmuMSLzKXNwvGaw1Nc7DTXygAiRz/z9Vhv8oUK0qzsHAIs7afWxeY8h69Xp7DcQumFKXt9njmAroD0jshieu76dqWu+L24aY19DAKOtWWk70rAzivdIwwj9mLmflIRIqLscwCa232KVrMSn20ALgb+Tj/bqS2i4TKNKKjOllDCir7MPOql00h2naWYca8omSwG9RXg0+OXn77iD6NVOIaUlaRd3SbGg= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005)(366007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+ywuJlCafzuyZ2m/DxUOorJpdh1cKRzducvmjwOkUziRjfGyV+URxko3DE0y?= =?us-ascii?Q?9x84fefOVhSlb/WPF5szNVi1mrUuGIkrgwxGuLN47boiPQN0mkZMsm3Tjqgf?= =?us-ascii?Q?rTthFRYwnKkoRKeDMzSK4pwMZJ7N5swIhZBix2czCUQcte2aKyV9bjO3Ytn/?= =?us-ascii?Q?z7SBv7VrUVWLJItVUs8l20tXiiqG+kRyHPSQFDdpt5Rd28gmy0RxRIBZjv7L?= =?us-ascii?Q?ihWSPcBYAikM42XYiLStAcuktYI3XmNV8IjbH7PQulzPOrdAP+UGprNIrmzW?= =?us-ascii?Q?eX0L4f45jSo/s+HR2s1aBJAozzrL45KuKdrdRLltpTlGA1V0judJ6q4vWa58?= =?us-ascii?Q?gkL1DCZYkNNwrDDOxa+oByczFO+KqgqYPNiDCUl7wbtDgEuOV+4wK1Bq1EGd?= =?us-ascii?Q?ZbxEOOR6t0OfVU8sjR30L+8hcKcAIUs2CNVs/ubxjD6W4QGsplZXf7znBoo3?= =?us-ascii?Q?vXypC363ficsvA7EdmoiInLvir99fn2WHUV3P5Lzs4HmPDXBoBDiF4DAN6KT?= =?us-ascii?Q?ckUWAmA9378VAYYHJ4gvhwDRdWbgG5TKMR7Lwro528CAE6ilZ9IzBZAahrBV?= =?us-ascii?Q?s0GaSy46qo9ynVRVUKj6b/N7/tvkh7kKC8VUQvCie7lg5/A512XEPUefiBBy?= =?us-ascii?Q?WtzGq4XDeRxAJL0i99ZJ9i64knNjYTmW/xvFkA8XVuB3sG8UJ+zBWjkBsYZr?= =?us-ascii?Q?pP28JmDjzjI4ABvJGJT9VMu1uZhrhbffdpMwYjI9VoGLloyS74C167ywW94F?= =?us-ascii?Q?plorjCLAmcu0iEMRfWfMu08cQqbJ/jrWc2Ycf9T1GGeN1u0Iui2nLUhS2kj9?= =?us-ascii?Q?A/clpS+TZClouq1qmyNCVP9//ejVS4COslo5TXSRTDjW3D/itLZrDeqMgQTB?= =?us-ascii?Q?GzIvCgTgs23Pl7vMqevZaNhY/3iiG6am2Zdbt/ALPzVHo4GQctX+OcX1nWZ2?= =?us-ascii?Q?5mdxpqi8Et3jjHjHwhzGSobP9tsGU9UYedIyYpXyLkbqK/N12HOq+uoFh7si?= =?us-ascii?Q?T5lQpHg4J5ztmCvUU+SVRb04cOo5EZ7JuBYnenqeE/wNrduYiCwKtSMQseT5?= =?us-ascii?Q?kiX1525qTqSWSauWhX41qdmcD0PI9SRo5gm/Wz8PfRZItLLhtEjjIqtsxoW1?= =?us-ascii?Q?guH+qVT7VVsM0EujKKJ+ApY874+xaxT8oUS9boGY4NZZOBNL+1z1cjOeD8wV?= =?us-ascii?Q?aRbeEj9g1csum5i1oMLp2y5WmRJ8LZUIvGCV2iRhW4Ty1GUu1fSth0HPH9zt?= =?us-ascii?Q?c1vIRxYTv1UVXfDMktEE6lLURUA1Y2es5ovTHt2WMfEvdzrvwX0MC4wjEhxK?= =?us-ascii?Q?YU/NuPhvDLooTHt2zFTpKtS8ET6L7nmGY0nPaJRCYBekT2lnB9CS6jGZ5w3o?= =?us-ascii?Q?/sBYEWbQVvNd9hth4WWrmfoMntPYXoQdScpwFd4pKJLRA0gagdZPaa05xg+d?= =?us-ascii?Q?kCEuJURlncr9crsBZbW8YjtOgXY95op1XLv4YMeT5cxWRG0yDVy4eNNFuGbZ?= =?us-ascii?Q?ns6Ms5moOU2D4Uv2iWXsuDO9aVoHjAto7oVdLplf5u8NjYlc8LjMvRf3wN2s?= =?us-ascii?Q?UayWwImQivbuy3GOFbCAPFxRgnD01t8VylmPYKGLrUT3ti7roxLHHGPCDc6I?= =?us-ascii?Q?BA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2b849ef8-54b9-4084-6f0e-08dc549241f6 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2024 10:30:32.9369 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: r00i9I6RZSoqa6X/19KTKJ2reLuNy2KKeEQSNNrRL3ouSb3JKOmGrZ3z17EPArlRNIoj5zBWOgV3s72U8OcnUqajULtQF34AQ4cXm6GQgho= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7979 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Apr 04, 2024 at 11:18:16AM +0100, Bruce Richardson wrote: > On Wed, Apr 03, 2024 at 01:55:41PM +0200, Julien Meunier wrote: > > Cleanup was not done on this PMD if a error is seen during the init: > > - possible memory leak due to a missing free > > - interrupt handler was not disabled: if an IRQ is received after the > > init, a SIGSEGV can be seen (private data stored in > > rte_eth_devices[port_id] is pointing to NULL) > > > > Fixes: a6061d9e7075 ("fm10k: register PF driver") > > Fixes: 4c287332c39a ("fm10k: add PF and VF interrupt handling") > > Cc: stable@dpdk.org > > > > Signed-off-by: Julien Meunier > > Changes LGTM > > Reviewed-by: Bruce Richardson There are CI failures flagged in patchwork, but they appear unrelated to this patch itself. Patch applied to dpdk-next-net-intel. Thanks, /Bruce