From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B08C743DF8; Thu, 4 Apr 2024 12:48:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4030040268; Thu, 4 Apr 2024 12:48:22 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mails.dpdk.org (Postfix) with ESMTP id 6A9564025D; Thu, 4 Apr 2024 12:48:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712227701; x=1743763701; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=clV95iCgniqOBpcwQPnKu14wPeLBFwKZuqnD6ayxADA=; b=QMlE1Jm7bXscDKBqsXhJiiJa0kvgZDK2Jizp557B11I8I6xEL3oSUXc7 6YeuM012dKFs9Hix/Oiz5i+MynoRyEJHAdWSFZhN3foT7QXD67VWN4vm1 +UTiYyKkHeGiw8KIw2HZFwfLiUvpDFBVGfQquANZVtDtW3dIhmCuO7VO2 mChxKi+w+2vf1DPdgNVpij8Pao71w1kLV9tpkGQpulpt9Xl/4jnl6lw8c Bx4LNgZRbcpewn5AaFTsvHdKMgADs5udLPl9y12GW6ojmYh90XUYFQ+GQ nj8jCUdrdVH5QH3haxCsEhtqc4MYUj+o/hzp7POtHSe+9eY2Q9lWOdT/J Q==; X-CSE-ConnectionGUID: PsVCMY2hS5i6y7unBTBmwg== X-CSE-MsgGUID: f6b59tp6S3OuQlaL+D0gPw== X-IronPort-AV: E=McAfee;i="6600,9927,11033"; a="29973631" X-IronPort-AV: E=Sophos;i="6.07,178,1708416000"; d="scan'208";a="29973631" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Apr 2024 03:43:18 -0700 X-CSE-ConnectionGUID: O0MhZSWzSamVBcHtmQrVaQ== X-CSE-MsgGUID: 9MWBbUVAS3eCNxD4L6r49w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,179,1708416000"; d="scan'208";a="23436057" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 04 Apr 2024 03:43:17 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 4 Apr 2024 03:43:17 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 4 Apr 2024 03:43:17 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 4 Apr 2024 03:43:17 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.40) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 4 Apr 2024 03:43:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VM/cRl3pnhaLXRB4ai5cL1/dKMOKNqaKk/T6Oc+/AZDrPagFt6cC69ea+gdhUmI8TDU3NKKRLXltM8VZ0u4f2q2RvRl+gVEhbqV5Ek8J04lHTy/L6Wz/IjWw/TI0pWjc0ysX5HOsUnGLMwn1zTnBEuM2W4kKvSH1bHdIE+WgZ5xRKDrUXMXD7YNDMg6PHdlK1jBB7zw0GNx4gMvEc9H3jez8kL3A109/pUZOH1DMQeDGeRnE9XnTzekJXeJlS7qt+mwmWmoWAp8rCMhVXrYrT/qZQb8MXhVGj1D80Dk/j1+YLZG0e4dEY9aVw1XHlo+UwMSVF1iL2OgnrznJhZ5aAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5Cql8bEggbDZhCexSmHB/tqxJbChsGrQ+VC+RkYBPB8=; b=TYWEytr/ersYFu2jP27pSpgnyrNehTerA8epN5q4frNNcmXM2dNbTLlG0bHlUntcjuAjFyp61B3AbzuFlTZQD2H3RXhx3PU1vjPSe4mUR/TNaDCpJzpufikUFBOYjs4sfHJaC/W4nbtr9iFthhvM72VCGw2hEnfVM+VOqnpFZ14/mQidjaZDtNwc5LKcLH1VscaRizsCrpnYOykL+fvOabxNhKHNES46X5qOOyfxAgtcVXVuAaHJ0BAuSJdoOuLLfryF8AAqCS4pFb0Iqg13H+Z2MovSAi/GX0ccREDmaKwZfVwDDp5eFl9ukC+W471NBb4q6Ok1TJ4qHAPgqWn2OQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DS0PR11MB8134.namprd11.prod.outlook.com (2603:10b6:8:15a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.25; Thu, 4 Apr 2024 10:43:09 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f%7]) with mapi id 15.20.7452.019; Thu, 4 Apr 2024 10:43:09 +0000 Date: Thu, 4 Apr 2024 11:43:06 +0100 From: Bruce Richardson To: Vladimir Medvedkin CC: , , , , Subject: Re: [PATCH] net/ice: fix vlan stripping in double VLAN mode Message-ID: References: <20240327184413.3192526-1-vladimir.medvedkin@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240327184413.3192526-1-vladimir.medvedkin@intel.com> X-ClientProxiedBy: DB8P191CA0006.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::16) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DS0PR11MB8134:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: anKJC+pk0AZs+zoPjmV43ld2o7vQjmYtgfuCMRxHUiAIO86SklCaCYQoD1zzvUnReeqUkNxg9CFlx0iReF/fJpEdOn2CirIipGKiMYvMP9EULIxoro6vgQrHgdJ4TNkXni/Kta3BnQtCtA3zFRX09qEtIl3N06CuOsEDzUrUodrJvty1GSxmMMfR5aEEfxoEmx6Lfp0xJez2ButSTnQ69lUt0ZkWDxEmOEvlikwJG/UkYwPJAjOkTaDPXZhMPzXolCF6femNx1a3285NIFv0xDTcIKpmcsIzQmBKKmuqEhPEoycYgS29XoRqUUCnK735HbnRQm+s+phgJQ4m5vM++VQ4Dpvcn4tfNuOQXp1zgvY2CKUJygP+CK5Sm+pquG7kVSt1pg7Cqe41AXRaDS1PIznWlci1NGuwEgvjcSzx6TpHM+2VB1TYapgLq8NXo+w/8KJTLS3aAdvrYvC410D71OkcqY5CbXoSiTaOsLjJ92schmu3vDaf4V7dbwLMC4Hc0ppevzxNWQH6YVgahdA+Gc9x2dK6tYBflAKxZHBZQTB/kpfvU6Ei7QsXIXrMhdO3ewuKRUw2tZCSb9VB6i+k9ORkJuiyxF4Z8qBy2dclrYGcRA5Yfr36BUVFf/agxxKisaOuHkeB8bo/uvzs41uL3nYdszv3qfS3FAOpwR5R3SQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005)(366007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ek+tKs5nb545yU7qJNqqm5UnQAe5DXlWEpN1TU/h9HIbXNJ9KmSZZSSZ/3A/?= =?us-ascii?Q?lO0c84npJ0YwVVgJCKVM427/JBEO8andHp9kifqPYn5kTp30M1jRPGy6iULY?= =?us-ascii?Q?HYyOHggoLmCK4JzQZazpmlJOzfav80Fqwuw/vr6p11pYJ8HOD6yKkJHNVaDS?= =?us-ascii?Q?+H2ULCH55j7+vQMqeWA7LcHXOMu+vNB9gIA06MBagem2nZMn5ntfxtyUflbT?= =?us-ascii?Q?5BIcuIjlBSMRDEOXpdo0EwLLV1vIyb12kWf9b6uUcyEZv2Mtiyf4FtUNsyhO?= =?us-ascii?Q?Z9XWyoE2YZfHOIPUHZynPHJtVvM4i/i8wecX8BymJBKzEtZJ8QxH6nbkfP4l?= =?us-ascii?Q?LVgp5ZCzzeGoT8DlJVsMTPefKgsM8pLcTmhEyGes7YVTeO4mRE0vAGy0CQxD?= =?us-ascii?Q?sYVvutz5rmRRk8t0/ACjFjKFKJTDqm45tw13jkLQfQBZbqRF+muDC83MwCX/?= =?us-ascii?Q?7BtS15fTtzkB4OcgzBhxJWxnD9z1WApnUvoWTP4EU8bK5UV4dQrKDxHhIOxN?= =?us-ascii?Q?oz+XvySP2yFPOnwkvS4borwOMJvQbthIqRY6iEbq2JEAQJbZ0wtPCoeHFxyO?= =?us-ascii?Q?GNoMgdu+uMkrQDFU7wSajGp5KA2q/GVeu8T/WHRHdWIe3368Z9h76tTEj2CP?= =?us-ascii?Q?HQzPtds/Hs8r0iiqFrSgieEdUUVKkq0+j0j4x96qtCCtETuYmqWiNbIFaArb?= =?us-ascii?Q?OpQARRHlMj8O6miemQG30Dn21Qyr6Biptam/G9AxoWbJ6AhqT9zgwAlRZ1Nl?= =?us-ascii?Q?Gd6LJpp3btQGmxqQhkDV/qVY4BUSs7BNZ2VxXTnbJaXpjcRQ3C5v79eg7SCN?= =?us-ascii?Q?VeNsqmeJh/CzzRZ5SpliHCn1bHiVQ0zuF12K34pZLDVRRSJsHlN/T+TuWr2J?= =?us-ascii?Q?yY00jDyzCEL8jz1AaJn9Lq3JK2mGBJTnBVY+7jzAZI52OCou1eXY9Piud10a?= =?us-ascii?Q?V/HZO2tQlJZbGWwltVZfEiNc+ESEOLQDl9dy6l474nHAJhdXvGCQuq9NHmV2?= =?us-ascii?Q?IprdguM8hmZzFxOGqdr7EJtNuJ7dsA/2PqT1/k/GyVuNnB+Vv3MrpChiufyt?= =?us-ascii?Q?qKgZYscObUDZMq+3W2ncDIdIly8Birg8jAfguFGpzvUjo28rbQbgHsMOn6QU?= =?us-ascii?Q?VIbLK7sAWZ3SF9cCKU5nDTTnOj4RuTnkf7FGqzf3AybF4uv9OyVzm/uNCZJ9?= =?us-ascii?Q?GFG6wP5rX2Gvjx7ORdWusX9K7Dg1CLJ781RqRrGDqxwjBFIZTZNJ7IIoqpeO?= =?us-ascii?Q?PlZEtCtpQ5P2RjGkKbAdWq3gfixnIXyPbgydvJrEPw5Gy6gsGjt/wkqoIm90?= =?us-ascii?Q?fzi/1QDYdAkS9ORghZdjQt5/w8zHk9pRs+Y0RMlnaHW6I0vZebXyJjShL35q?= =?us-ascii?Q?lzABLOH4DD4f393WMwrwzUHPWziJ3rNvRQ+pIn8iFhTtRBDTnwQHyoYTVEGx?= =?us-ascii?Q?Lf5lRyPBjK+kOjJE4CjJ2FP6+oWtgbmmKj8nUhkK3tAyozQCG6ZrNJSUE+0r?= =?us-ascii?Q?YLkIhl8/3WbNLzzI9eWpe53MuCQKloyAK3hahQCmq7MjSrrq44tsPcfE/vY6?= =?us-ascii?Q?PzGwsxDGYwmONRsXCNrW6QeMMckWFji/N549ERg0BGZ6zmEuJBKbXz8QZVM6?= =?us-ascii?Q?sg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 14fd8836-f2a5-41a2-390c-08dc5494051e X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2024 10:43:09.8587 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +DkSYfjGmm7LLv/YCzTe33z2gP2ia6Eo/9rkOG+/F9IH4H2t2khs7CzRDvSnr7+UNsNnsgshpFER6/DNXEHdgPBr7qpWyLt+BVgCXEQTvi0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8134 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Mar 27, 2024 at 06:44:13PM +0000, Vladimir Medvedkin wrote: > The ICE hardware can operate in two modes - single vlan mode > or double vlan mode. Depending on the operating mode the hardware > handles vlan header with single vlan tag differently. > When double vlan enabled, a packet with a single VLAN is treated > as a packet with outer VLAN only. Otherwise, a single VLAN in a > packet is treated as inner VLAN. > > This patch fixes the logic of how vlan stripping is programmed. > > Bugzilla ID: 1402 > > Fixes: de5da9d16430 ("net/ice: support double VLAN") > Cc: mingjinx.ye@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Vladimir Medvedkin > --- Acked-by: Bruce Richardson Patch applied to dpdk-next-net-intel. Thanks, /Bruce