From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EBF2443D47; Mon, 25 Mar 2024 13:07:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BBBF940271; Mon, 25 Mar 2024 13:07:24 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by mails.dpdk.org (Postfix) with ESMTP id 014C04021D for ; Mon, 25 Mar 2024 13:07:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711368443; x=1742904443; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=8UdT3pGM/R+iHXtI0nsB+h9/jBi8YlplhxmnCVcVB/E=; b=b5QJbVigjFg3rnzAZQtbg31LjHTxx/u0Q8ECbowNXD9RQzqqatUlGPeW kvqykcKtpbpfWRfrCB2kzWNvkCZw+c757JYcKoG3lS/SQdoaWEDlQK/0I axmZlLkwldrZoszaAbdv1TXrYHg0FryqfWLIoWB9ow9kBKD8/cualKzlE zc3Jp7+y9rmlQ3uVpy28FPD4R82QtvRTx+xW+J+vrmUaJAq1/GE8LFmy4 PNtZP2woyX0Y5xsA0eS3xRrS0n6jlXtjq2hDiv1Qf88tmPHjoX4Z9rnzN 4gkl24QQGt/l34qffqS3QoQcQ7T9TOaGf86ANSU+fJzE5eBO/VRhSB4/r Q==; X-IronPort-AV: E=McAfee;i="6600,9927,11023"; a="6299691" X-IronPort-AV: E=Sophos;i="6.07,153,1708416000"; d="scan'208";a="6299691" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2024 05:07:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,153,1708416000"; d="scan'208";a="15679119" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 25 Mar 2024 05:07:21 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 25 Mar 2024 05:07:20 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 25 Mar 2024 05:07:20 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 25 Mar 2024 05:07:20 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 25 Mar 2024 05:07:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XADM02fcx6G8MgDhTx0sj9j1/Qz7tOjzsgjekiaYcE+k02zWEKXzELvbyKH+DoprGwsSZNXocmdFfGQfCSXgBmebdZ3kAHwEwpTIflX79JgOubVJsVrWKd+NZC4X8JhJbQd31sq+BFYSG76URM/lyHmMdl2LmDFm6PbDPcezkMIOF4az+obrT/D2M4PtPkIqV38yOMKPSEAp9T6qGIYm/NU98aOl5wQB4y+e3dmIajeC4fTEiUJv8KLTNnmhfovqmXwOsY9KYnh+aW2LxEU3MGEIPp/Z+ON3jRnmLZEhkLh4l7PwdEOzGj1qLWWkbjpvaO+gxOcRxepHsndWbQDU6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5127ZcNxYqKoSXoOOBzFiLsKnBsMKECswix295wmiak=; b=N6VwZPQDcZjR9RmyYD7QkF9+8GJ/sdagyeS221KgdMLagvd+ndyz3U1sdZsZGjHgw0M2YGL0wWXfmiaWwE3LPkhYRgcPJEufOjNmjPYECD6QpFjbj3dKDT0+ZHgEKw4NJ4VPn+6lTfQNrTOqbIw/oK+d3mSR3fS8SgvWdVQ5iiEPNsoblDsQvf8YG3/neHMgKorLaUEm7w64BQbmrt4esf7UWMZ8fa2fHlJoXi921ZJkqlMZRslNIBY+bpc0BA3aicSCrgGwPMqzMKkp6FAYFbfvhLxlK4H5jY+XpWBXv2+KLUE7SVPG+FhXVAlX9903T4M179jQLVH0XxfvnwAp2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DS0PR11MB6469.namprd11.prod.outlook.com (2603:10b6:8:c3::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.31; Mon, 25 Mar 2024 12:07:18 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f%7]) with mapi id 15.20.7409.028; Mon, 25 Mar 2024 12:07:17 +0000 Date: Mon, 25 Mar 2024 12:07:13 +0000 From: Bruce Richardson To: Jerin Jacob CC: Robin Jarry , , Jerin Jacob , Kiran Kumar K , "Nithin Dabilpuram" , Zhirun Yan , Tyler Retzlaff Subject: Re: [PATCH v3] graph: expose node context as pointers Message-ID: References: <20240325100500.694748-2-rjarry@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DU2PR04CA0342.eurprd04.prod.outlook.com (2603:10a6:10:2b4::21) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DS0PR11MB6469:EE_ X-MS-Office365-Filtering-Correlation-Id: 0c846881-27ca-4399-408f-08dc4cc41dad X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GvNuFPa9cAmZ1kqEla3EYGPY16hJ2rE2kFiGz6lXDt/4fxdvmWwJIKS3jgOkAJOiXdTP273ApF0ByX2WWoYbB6FShcV38nNSsL8K6er+LwNRYe+PRogWO7EktlieqZ2fgPx/U1+UUqqIsqmGdPgFv7kB9TTSBgyzOtVlyievNhaysbvI0bV3Yn19Ok+QxjKdBUVDBXM8oxBB0ZDkoTA897yYX5LKrnZp8dVp6/bo8rltfp5w1/ylBovzoKJV2uUMQAKuBr2NMNZjj61nIODxRjdaolWw+/ceQUaGWroGsBVizbCrqCYdue7SHyqOYU9JVb5mgdTOYUqKCx2BB5VpdUC/2jvWGRIqqznRjBl5c6pREa6nebBab6FnAPUJOTKVrEUuwWabXy1DgdASZqgFjOa5YrOy0gyHnAzossh7o1tn8eZ314QE5hfEJe/bpFSS6uBn4zZ54bvDhfgA6yREWR12sc7IexKOGVSrocGdKgBZ/mTL3UmP9yVXEfSLisYkny94jLYjuTUb4bzrIm5HsUZMB9A93SFaSgO2tU7b8lqvtBHpPblNY/tWXp3RmX23RDC1er5XKhpJOzh6rMZYgM8HHfoDVWju7QkadxFHAdu6r7vAWZsuTetOswCKZvYV X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015)(366007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R0RiUUtIVkNsVzVFMTZKRnRXNEMrWjJGMTQ2U1R2OWhGMFZub0RPU1hDcFNM?= =?utf-8?B?RjZSUXVzRmtRaitFT2ZGbEE3ZEdjakQ2NG8wQ2U1aktBVDMrMGJEbmhTMC9v?= =?utf-8?B?TGp6K1U4ZlcrbDl3ZVFnVEpwTjRtSmdkOWdPQWFCV0I4Z0dJazRnUG9CbytF?= =?utf-8?B?dWxLT1ZVUjR2Y3VQaGt0cUE4RStSTDBrcFVOV1VRYjhBMDRnZzhQQmlwdm12?= =?utf-8?B?WEhSOFNDalVOQkdwdDBLVlVhMEFkYmFPclRPNnN2L0tKSmNBYmRZZWRNY1Nz?= =?utf-8?B?L2JGNkxyK0t1YXZLRFhSaTd4NFgvaWdudmx1S1JMZnR5bUxXMkgvU3Z1TzJV?= =?utf-8?B?ZjdOeHFzSXNUZ2lYY2RJVFJlaUYwTHBQUHNpc2xMUW5QeTNlWVhlejA3emg0?= =?utf-8?B?Y3RpZlhoWWQvdlFQVG9ETjAraWhMUU5EeW9Vb01WM1c0SVU5V0c3WjU5c0Nh?= =?utf-8?B?Z1Y3RzZ0Q3JZbXFKb0tYSzhRSmU0ZDhJN0R2MmVDSGo1VkJDZEVubVFQZGlq?= =?utf-8?B?QjNFcmhsMGVDZ1R5cFlnV3JuaFVOWnNDUWRHbXhjR0h4VG5WbzkwZ3lDOVlK?= =?utf-8?B?TXFCY2J2N2Z4OWFoZjhkNlpXQTE2TTU0YTBWY29nK0taS3JzZ1cxZ1FkamdC?= =?utf-8?B?TWRkSnE2dTZmZ3g1SHV5RVF2MHZkSVFzS081NjBTRkJyOEFUSDJsRDhOelZ6?= =?utf-8?B?LzdDd0lETjFaSFVRTXVwYmxLcVd6RHZ0OFd0M2JxcFkvTENsVGFPeitYQzZq?= =?utf-8?B?ODRrOS9yMmhrYUxJeHg3c3QveU9pWWpFY0xhSk1SbThkZUFtTW0rNVdMOUw2?= =?utf-8?B?c0FaQkl3WDk1bzZlU3g3QU5zSW51bFVGaFdSRy84QXluaUUwSHdkZExuTFhm?= =?utf-8?B?Q0FLQjZzSkVsaUJjTHBRMUYrTnlZc3hOV3BCQlg3L1kyR2xqUFZFdlJMVXRy?= =?utf-8?B?cTNmdUVneFI2ZlBpTWp0SWZpTmx6S1dFOVU3aUlFNERmSnpTYmZNV0xhUWdi?= =?utf-8?B?K1lSVUhGYzUyb1hqdlViRURIT1BrbWpvVnl5MFc0U1l1MXRNOWFCL3lsWjFJ?= =?utf-8?B?SE41YU52em9PZ2hQUm55R2NxWFdmeGZVeWYzQkptWW5VVFI1T3dBemp1TGxy?= =?utf-8?B?RmVGV0w4OUg5bGpGQk42OUNGTnhWMUxBUDk5eE81ZVpYbWNDeCtLT3lNZ0Zt?= =?utf-8?B?TUFjR1FYUVpMRjdhRUdpOFVvV3B1eGNuTnAxNUFUUWY5V3diRkppRDV4MjBY?= =?utf-8?B?amJOZlNXNFRJQW1BR2xWaEpGS1NMeGhNSnV6eEhEM2lhS29hQlJoYnZzTHpO?= =?utf-8?B?RkVJRjIyN0s2M1BCc1RmejkxRStGZUJuNC9VUmdPZ01xUVdFZ1VLZ0VOem5Z?= =?utf-8?B?SXZBN1NETWNwaDRrcnMxRlJyaW5UT2dFKzd5d2w3Ujc1dzBhRmRlZDdUbXJ4?= =?utf-8?B?Y1E5VmtTTk9RSjFwYzVQMDVRM1JaOWY4RVAwYlVTVlFhTFRpK2tKRTN4SG1O?= =?utf-8?B?ekllSHBHbTRDZVdqbzFBTXUrSThFRThpb3Z0RHJmTEx5cjdIYkFQYzZjOXVo?= =?utf-8?B?L1JHUlprS3BVRUNKR1czT2JwVVdEV2tvVWtHYUdkaFNuRXU4eHg3NlBUcUFk?= =?utf-8?B?L0R2bzJsYTZtSFJMN3FNTEx4QTRqUXMwYzBYWUUrdzFQRUx0bnhlRFBXLzNV?= =?utf-8?B?VHIzMjZRc0ZHTksyVjhYYjZXRjhWTlFpWU5DNllhQWkxQk52VlV3UzRlTVhH?= =?utf-8?B?bzhYQStEMXd6OHJtdDF6WkxCem5Pa3dIaFNuTVlaaG9VSlBUSmtDcVJkOE1a?= =?utf-8?B?dmVucXR3YXdvT0IzRlZVM1ZtWTMvcnRnWUhIRHlTTjFHalpadk14T0NSZ1JE?= =?utf-8?B?TVB3VnpZR2VCWThOZDR1Z2N5OXdmR1ZxUkYvcFpEV2lyTml5QlpYYUtRMEZl?= =?utf-8?B?eXYzOUkvcWozTWhLNVY0Z1dqTGIyem1iZ0dOMURjZVpZeHdQSWMrVE1JeDc1?= =?utf-8?B?bHkwdVVpQ01JSS9kR0hSSTMwY2pMZEN0ZUZEc0k4eWVBN0g1Ykl2SVNGRWx1?= =?utf-8?B?TDdDYThERmZBenhPY1RqSmsrWWJnM3hoRkduTUZvTzlsZ055V0MwRmVLRnFw?= =?utf-8?B?Kytwd202WndZY0h4VjZwUGhvSjg5enh1dk5UTHRONUpKNjZ1OTRsSnM1U1BV?= =?utf-8?B?VUE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0c846881-27ca-4399-408f-08dc4cc41dad X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2024 12:07:17.8769 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QRVe+a2XTUbvfqDYkODhb2/Ee6IvsW6ocqzbfwrqpiMcXfFL+z82HwcGGWuf8+RZ4+ogIWllSL1zMcZNsNboZmR24sObO55kgHhSnu+d6Ew= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6469 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Mar 25, 2024 at 05:05:12PM +0530, Jerin Jacob wrote: > On Mon, Mar 25, 2024 at 4:45 PM Robin Jarry wrote: > > > > Jerin Jacob, Mar 25, 2024 at 12:08: > > > > It will not be taken into account for MSVC. Is that OK? > > > > > > Why?. rte_mbuf has a similar scheme. > > > RTE_MARKER cacheline1 __rte_cache_min_aligned; > > > > RTE_MARKER* types seem not defined for the MSVC toolchain. > > > > https://github.com/DPDK/dpdk/blob/v24.03-rc4/lib/eal/include/rte_common.h#L589-L602 > > Hmm. Not sure, how mbuf is building for MSCV tool chain then. > > Another option could be to have a helper inline function/macro to take > care of casting to make app code clean of casting. The markers are being removed from DPDK and being replaced by more portable, and more standards-conforming constructs. We should not be adding more markers to existing structures. See [1] /Bruce [1] https://patches.dpdk.org/project/dpdk/list/?series=31579