From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F10A43D67; Wed, 27 Mar 2024 12:12:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EA388402A3; Wed, 27 Mar 2024 12:12:30 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by mails.dpdk.org (Postfix) with ESMTP id 396AC4029F for <dev@dpdk.org>; Wed, 27 Mar 2024 12:12:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711537949; x=1743073949; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=sImNBMsTddPIc8l9EDPVXUqZeFVY30CZ17DfjGHjl8A=; b=iN9UsRbTxv5bTbM18Bs+dcXQR8OBZou8gmOsVlhftV6D0iTipHJYOs2w 3yE6YE4Mz8jioyoivGD6IZqIzRNRpYMhTv2l64Xqpr2vc6GdWbqFNMIaw ulPuc8DXM9Ew8CeIOQzdNfcRH0KiUSokxgNjgbg4jaShQgT39XoLlRj4N d4r+6LGelTWgLFcsD9UPXxjxPr5OCPqUxXGWv0mYNJ5tivUeNc4i3agFb XQV6dc+8Z/TDbPcwhoPhws1uN4s2AhOg+JRYpGrZ5dUGOOAbgWNJNlQBC VK/s9SDbe4MHnD/zFH+a2fHr7Ry8BLGi19S3QqsUOgbNt5YaKhBkS6E5A A==; X-CSE-ConnectionGUID: hHah66HASiyC7fJqcog24g== X-CSE-MsgGUID: LBWwK/1mRM6bq/TIF9pCEA== X-IronPort-AV: E=McAfee;i="6600,9927,11025"; a="6523123" X-IronPort-AV: E=Sophos;i="6.07,158,1708416000"; d="scan'208";a="6523123" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2024 04:12:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,158,1708416000"; d="scan'208";a="20970178" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 27 Mar 2024 04:12:28 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 27 Mar 2024 04:12:27 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 27 Mar 2024 04:12:27 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.41) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 27 Mar 2024 04:12:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=egnVMkZpAgogi98u64bKgG/KIgI/U1rGgRtBYy3OBNqKJYBiQSjT6u5X4iW5hbbfjDIvSc+bs6VdmrS1MG0AGBCJz8/MRKggGa965VnEPiaMkiaeyySb882eu0Wk+jKQm0Gl7kPuAIQ7JY3wxtnlYLxJwArxqYm5djz2SfASxxdiZx9Z0b+ovWGfHm3GFMInOyEhLZ36QdLie40uO4YErVx+CULhpD0ubc0fgGKl7x1vlcOs0v8Y1c9vw+F1NdJwjCUMatboCayzUpjxw1bna54FKx7gY6OQ7vauF/rVGEqXTFXKkjUss44ME1SjOMAaqDrpd3sClS3I9u0WN+U4YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fulo83kV5d0k8T9vY4+2wBzGKP0a6mDtkedlaz8Ex04=; b=LbU+AuV6EbvCbigATLRt8MGcBzIg/JwVsn7wrfv+niY6nvzdZw9wOVwSczPFEap9Bw2LO89IM2UfFxOybjKkdqr1t2yThTlWfk2e3yVn96MR8WgyFej9+eV4Mdx9uzYcVjDTVWEXy1diayW7cPRs/59yFUoGvlaBYxh7rWRuKmMeuZ8ZXpTPpmyqOzIl+MDjNQxDpF0HK8CDGIbXDpPvOh/RkikA5VSbmDr6U/nU7x7ZSBbZ0aT7BsbKLT2i1bM6ID8+V7UthhkZ4oHaVrNBzcCpKvuWVjrpyciippHNj6to8EqPhDTRD4HWd8kVRVOe9CKh9IiYtPaHMMsgtVIOQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by IA0PR11MB7186.namprd11.prod.outlook.com (2603:10b6:208:442::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.26; Wed, 27 Mar 2024 11:12:24 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f%7]) with mapi id 15.20.7409.031; Wed, 27 Mar 2024 11:12:24 +0000 Date: Wed, 27 Mar 2024 11:12:18 +0000 From: Bruce Richardson <bruce.richardson@intel.com> To: Marek Pazdan <mpazdan@arista.com> CC: Thomas Monjalon <thomas@monjalon.net>, Aman Singh <aman.deep.singh@intel.com>, Yuying Zhang <yuying.zhang@intel.com>, "Ferruh Yigit" <ferruh.yigit@amd.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, <dev@dpdk.org> Subject: Re: [PATCH] igc/ixgbe: add get/set link settings interface Message-ID: <ZgP_EivKBT4RxPVw@bricha3-mobl1.ger.corp.intel.com> References: <20240326235909.25276-1-mpazdan@arista.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240326235909.25276-1-mpazdan@arista.com> X-ClientProxiedBy: DB3PR06CA0004.eurprd06.prod.outlook.com (2603:10a6:8:1::17) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|IA0PR11MB7186:EE_ X-MS-Office365-Filtering-Correlation-Id: 5c6f0fc5-cdbb-4a2b-a41b-08dc4e4ec793 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sDGBLojuNysAVWmzChZ3H4ktHHjWXI1kchyXAVfkQKEtRQIV1whnqo8pfzKR5gtj1xm10Ryc8WibrbOhFU1KlPwsa5I2VUB/4+IQfqVRwh7k4gw9+5BBmcSQPLrQLzybBjd4DVYVhZ8kPZabroy7ZojEXsiavrWRiLIVugYf1/WtddQcoivtU2FhNRZL3SIawEyWA0jFxnPK6QQHGcKZFFkmmfEWbSRQUJxU0RXzvgGf+J5MEo2WkqGTFhjEEWlWtaULZtvO6Mz2YNqHeOOwvL8ncPT0ouKdHFhiWwHpmlwj7gpj4kfT+l/AMKExv2PSo8aC8z6S2VPbeKsn+1yjlhbyDxn6kU04z8mB/zcRBOs9vryVvDMOeRlc4E4a5hfS5dLLE4TGgU7Q0GZ+Dg6/Tz+kgqUg5EuyPLM/EEbrgaQlzG9yYaeticW+n8XpV8q99EkCLyt+tOWkOkA2obo/ElkBA4kmnK2vFKHKKeAAVuQQtzyYANM3hFUwlxyPy6hc1Pms0+SO6qOHXUCAwz1gZncq4iSnAw+25ijLCxVRNH9fQI/NhEeUJA9wJcIQ2J2rW0pBg1arki8GeKlLo9bgUjUSW6PnTSNkye4lvtSMwcPpH96Axn82kwg4XE/xrp3Xl0msf7tFOWihdn1eJLfSpx5Lm3kOXj945L1p6VnyRO8= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(366007)(1800799015); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qT1MAwoiV13MN7vOhdGCshcn13S2rwCMYEC1f6zp5qHn1Z7gGzNcYNHqrf3+?= =?us-ascii?Q?KklECusxVntXOjnAHu1y56TU0cJ0F8EQnqULgQs8YOfetA0vInaAcHpqi1jL?= =?us-ascii?Q?7gSnK1ZgJNdyw0k1qlJ3nktXaYHguYbv3TQ7ZDLvrRKLJAuwHxiFupBY4O5c?= =?us-ascii?Q?hGb442MdvyYm2aII2W66L5p2i0l55Z/HxRHGNoutnBcDPVZRF8V2bmzMJO+f?= =?us-ascii?Q?6aulUshuJf0JM/oadMfnxBk4GXozww2jQ2mXOkkPusDdjScXueqIX+OpIsmX?= =?us-ascii?Q?QO0qi0u+NWVKMOddVwksFtFuEgMRhoIY1MZRKaRJ8mpNdecMiH5x2gpcaljV?= =?us-ascii?Q?0ukzDGntgFWEcjXw/nv72KekksRrJdCnLrrlzTWgGxrdLC78hoJUMHnEyeEm?= =?us-ascii?Q?dLmgl/NAH4eGLgl3pMC8PPfCWSBm1q5Fx6qIygtXmYKXgwQiKAWhiypTzIko?= =?us-ascii?Q?B8rPGew7A8ZtzGZpSMwF9xXypeFd5W5/3BCUwguwgM66SITtihAl0pMaKnSe?= =?us-ascii?Q?NJLh1KSsnhREyytmvDtTWOEnKO+cKV7CuMTPlRIw68Mowb2w4sk9mYdz473v?= =?us-ascii?Q?yQBW0V5aexVWDoUsmKDXZRdbdHsOaFR74Aj/F8aO1AQ1R+6pFGTTnthgavIY?= =?us-ascii?Q?QFN4zrh0ObzqvnBH+qQTKN1DGfOnCrRaai/MAtZV/tO9Wsb1qOJ+S3xlaj2S?= =?us-ascii?Q?ORK9tVcxt/KX7pn7Thnsx4hPycLuLIM2TF5KQE0IrkVYD2B2YcaZOqJR49X9?= =?us-ascii?Q?6LIZgeoi26OjAf+kDcgaFHjyD+jLo1bTJaHVP7Ki3TbrpZjfq/K8QAa3sp2a?= =?us-ascii?Q?3G1acTwrnfDKt2sRqnMvTGr60tfs0q4naindSEg0fC8FJWEGoKGbqHv7HmXs?= =?us-ascii?Q?RaHNbgsrIXbfWQif8VpMBhmKhuVv0z83//LPvnmCfksv9fM3X+5eLBY1GXqX?= =?us-ascii?Q?J03+h9GXniqfhpO8PIQGYnwTJTUg8TjdVSEl3Cff7ySumrmSrahrZXjMWJFV?= =?us-ascii?Q?ARfIwkc74ZnYcMximXCoxyJEy/Rq/4EnatsjOQkAd8xaae/tTYpTt91jM8S5?= =?us-ascii?Q?/Io2PxR1w3Ed4/8YailyD2xamYSay4hOnePYRO6/mPjuOZLrkv4z/QskxEsf?= =?us-ascii?Q?5SD7js4WSaULYz5PYaiwPbalK73j0vXx83EhuaZnOqKJmsNXsVNpdBW8eQaD?= =?us-ascii?Q?M2aiSiiWa/6bB+fOlBgLTkrvZppAWfw0X62XN6lezMQjh05c3ZUcWAoN09M6?= =?us-ascii?Q?02EfOk2+2qVvt9t2cudjViU+yuxPTiUvV9YumlNyUDHz1P75gw+cJ98KzAJf?= =?us-ascii?Q?jSZ6fjLKmK5prGdhIkZYrlHP3ZujeObZbiECRozx8qgd8eX7e7rMYHokgscS?= =?us-ascii?Q?ocU74rk1DssnjdzxSoEPiKTfuqiO0K4gj3PPPKtPDr6scC/nDGmo4WOGZvEB?= =?us-ascii?Q?4SJqN5rN7Ze34aWniSa47dCX+hSfYvujsbtgAszi14E3ZodfuRiN47quUbZG?= =?us-ascii?Q?ySbMTAUAK8pk2t1U/NKLdrvqK6Y1zRcNrk6eqHzklfkg2nh0jv0SDf8qDi5L?= =?us-ascii?Q?8MsN0b+taZ7usRn6asz5Z1E6jw64yLbLJEeS0vP7CLafeJN1rTWdbYgit3ol?= =?us-ascii?Q?Cw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5c6f0fc5-cdbb-4a2b-a41b-08dc4e4ec793 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2024 11:12:24.4444 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ohIP8M0YD38ZmSWEB+Vr9kcRc2kEtBezXwt/w+hWBtXn+tuqXW6dkYJd7aNkSVgULG1Rb7Gr0D6c2E/H3hsyRk8xf6JYQ3k48t7Pah+IGKI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7186 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Tue, Mar 26, 2024 at 04:59:07PM -0700, Marek Pazdan wrote: > There are link settings parameters available from PMD drivers level > which are currently not exposed to the user via consistent interface. > When interface is available for system level those information can > be acquired with 'ethtool DEVNAME' (ioctl: ETHTOOL_SLINKSETTINGS/ > ETHTOOL_GLINKSETTINGS). There are use cases where > physical interface is passthrough to dpdk driver and is not available > from system level. Information provided by ioctl carries information > useful for link auto negotiation settings among others. > Additionally dpdk-testpmd application has been extended to provided > testing tool for newly implemtented interface functions. > > Signed-off-by: Marek Pazdan <mpazdan@arista.com> > --- > .mailmap | 1 + > app/test-pmd/cmdline.c | 9 + > app/test-pmd/cmdline_settings.c | 516 +++++++++++++++++++++++++++++ > app/test-pmd/cmdline_settings.h | 14 + > app/test-pmd/meson.build | 1 + > app/test-pmd/testpmd.h | 1 + > app/test-pmd/util.c | 10 + > drivers/net/igc/igc_ethdev.c | 229 ++++++++++++- > drivers/net/ixgbe/base/ixgbe_phy.h | 7 + > drivers/net/ixgbe/ixgbe_ethdev.c | 395 ++++++++++++++++++++++ > lib/ethdev/ethdev_driver.h | 33 ++ > lib/ethdev/rte_ethdev.c | 26 ++ > lib/ethdev/rte_ethdev.h | 215 +++++++++++- > lib/ethdev/version.map | 3 + > 14 files changed, 1450 insertions(+), 10 deletions(-) > create mode 100644 app/test-pmd/cmdline_settings.c > create mode 100644 app/test-pmd/cmdline_settings.h > Hi Marek, it seems this patch is not just for igc and ixgbe drivers, but is adding a new feature and pair of functions to ethdev, correct? In order to simplify review, can you please split this patch up into multiple patches based on component, for example, ethdev hooks, then testpmd calls using those hooks and finally the individual driver changes to implement the new functions. Even the driver changes could probably be omitted, if you want, for the early versions of the patchset, as we'd need to get agreement on the ethdev APIs before looking at specific implementations in detail. Thanks for the contribution, /Bruce