From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7538443DCA; Mon, 8 Apr 2024 17:05:43 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C92D8402C9; Mon, 8 Apr 2024 17:05:42 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mails.dpdk.org (Postfix) with ESMTP id 4F832402C0 for ; Mon, 8 Apr 2024 17:05:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712588741; x=1744124741; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=aNi98HDj0uI9jmnKQmzb6hYY7bVtI34IMGSIfzGa48w=; b=LvMS7KqXTtK8RZarcatIlJkv2tpbMzZNUdEdJtSAhlRWA74e6tLb0CQi 7aQIgXvQPMMjerJoO2mSZmAKVp6nLGPigji4rUOxQ1+d0UZNb5ELVCDwu uL0jBGbT3Bf6TvuiSBb7tdTRmamSOBm/IPsK1is8sPpFHTAcCzP8lelTk RNqc3XTKb7mEawF5ZyPojM1HGqnU1KNP9sdkmZIF0I5TAO/oge/C3URQo 0yQQsRmRsvAqRMXd66uiyq3MgqFjN3MNT2cYB7bjXeopF1QobbeaEY7Zi 90ASHri93srLTLZzHEdIMmNoq14oi5eRBmEIemlQVVRz11nhmh6dir01t Q==; X-CSE-ConnectionGUID: kp9P1vwYR52ELznWh6QViw== X-CSE-MsgGUID: wuDqptNvSwyMhc4wwzUi6g== X-IronPort-AV: E=McAfee;i="6600,9927,11038"; a="33267247" X-IronPort-AV: E=Sophos;i="6.07,187,1708416000"; d="scan'208";a="33267247" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2024 08:05:40 -0700 X-CSE-ConnectionGUID: t9ZGC8IKTf+THslR0/rjMA== X-CSE-MsgGUID: YGJWQok7SxyCPq3CMTKPFQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,187,1708416000"; d="scan'208";a="19839556" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa009.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 08 Apr 2024 08:05:40 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 8 Apr 2024 08:05:39 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 8 Apr 2024 08:05:39 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.40) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 8 Apr 2024 08:05:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OTskwpmjR2HgdkMPdTfFnNJ96K4mH+lUEhqaGpr17PzK3uzXZi6SiYnnRyNdjo4gyr2NQQRp9kWvqET+oP5SwzNDemntqhCyHQAKspTEf5/kv/1wW8v/btMNL+7i1eJgjed4ZZRsXRia/1mhcVnIE7csWscZSgZ5S5R8Zi4CAJ582Rv0CukVHzOu3O1yBn+m4+iKM8fFJE1al2KiLFv5QavzpAgluvduYhH2fYvr4cpQmaHvg42mR1R5n6CGCs/LizKTwGBDVkHmsGjoRWW+6Kn4zy0S4fGdGfpsGkaG2HkkPmBxK2g2rzxYOLAPPBBXidvM3wOQ44Faj60WgxU+gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LUqBkOrQ7pmjrst0Y/7uvBlbkPGcq9JVe5URSxQGGyA=; b=FzWNj5uCT36EiEasB1xysIUMHZI+SmwUzPa6S0muSyra9p0WL99n3qw0/ggXIVAUkurZNYxIgRrDBmHL4Bi4Y+Q7DrjqW/iWCcRJwxks3RkGYSx8MmyEjZ2a+Y82O1ARB8Ra6VWRx3iwFIh4ZU1czcdD0upb/7EgMcb5coyCZKDdhkNvfj8BT0WAmI01os1TJ8Ve1RGMr3fM9AoasPhlL8DHyhqGdDZNLD11InqVmu26VI6UOFtW85Vo88xRcQc9G3njMGJvgI4WzU76d2Klsg3+/CGjvM3t4qJ5ZO8FkTwgG0GHTfI5iW1suX7DXA5umsWdheVgD0uWyZic2UzpCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH8PR11MB6927.namprd11.prod.outlook.com (2603:10b6:510:225::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7430.46; Mon, 8 Apr 2024 15:05:34 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f%7]) with mapi id 15.20.7452.019; Mon, 8 Apr 2024 15:05:34 +0000 Date: Mon, 8 Apr 2024 16:05:29 +0100 From: Bruce Richardson To: David Marchand CC: , , , Qi Zhang , Murphy Yang Subject: Re: [PATCH v2 1/8] net/ice: fix check for outer UDP checksum offload Message-ID: References: <20240405125039.897933-1-david.marchand@redhat.com> <20240405144604.906695-1-david.marchand@redhat.com> <20240405144604.906695-2-david.marchand@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240405144604.906695-2-david.marchand@redhat.com> X-ClientProxiedBy: DU7PR01CA0008.eurprd01.prod.exchangelabs.com (2603:10a6:10:50f::29) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH8PR11MB6927:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lhpEI2ALpvQwfngFrhixfw4M5zrRXG0B0Y2nWijnVI50s+twAjF3ogrsToyqkBHDRYnQrR3BpnnynxOqKgKj8wm3kM7rlglrMCfm851y7MNSBl53T30YAzB+KgnHJTs1RAVjbEvZHC17Sz1vpip3pl9LZEgbk4O7GOiUjx1EC1T3r+rFNChQiVPSaLxvdDcQ9JbW//1E0xQkdxYCPw5JdLzR0IDxyxQNLo1nimWPzchQ1diTG/L+fc45G7JXp2WCR9VW8og+p6U+cw4scyrAAlGnxNeazpbXA8j7IK6BA499OH/PbWelpfUBB3gJw5+T3IWhCGWrzebTvCTxDxykTqzzeL+1qEMv3pFbiqeGqS+1HeSynFL8jdfW+xY0oQVApE1+OHJWcBTtTB8SUvo0W/SQCuAEXScC8rrjBNqag1jX1EBaiHhD7CjTWHIcecWx7mY6ELbDL8hA6rblkRBJf4TXMcHjWN9auRka9dMzQUC4hiA5LXbArNZav+bEl2QgzysZkZ2qbiv1sG1JyXSavIkSWz4DIZHjv3hmSm9i1xzbb4kwqcWcI35INAUm1z2E/loFgP+Kgx2pl2e+JY7shsJyKg2jXqNR1WsTqbNFgJnGM28xeiSxVXXZXoTVtE/9snygQaJczZqZ87uFUdLae2xnyfzSzeZYXtnAxqj7JCo= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005)(366007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lSkDR+9ybpos+pe2lPSYOiezvaXXBLo7RkpTJbK6aAp83j3A3f372+y0f8FZ?= =?us-ascii?Q?BIkmUefLF2fuH2+PSTPA5cDifI+LQC16oEGnxlPqU8O0ZY0g2Pex+nxcKCXg?= =?us-ascii?Q?cO4WkSpOgMcWWExEr+W/Fp4b2rgMb0CTveUt3kob7i6QmfCzD0HcZ393HQKw?= =?us-ascii?Q?70CR15MBg+2sbHQT4QzO0JM0ChQu4wM996uznd7tJX9sdiFDc54wv+Jf2WzI?= =?us-ascii?Q?PY+K6OwnrbRbpwtFQ5n7e+I6LGYBk3xC2qWP7BEkJR/1e7YAKTZpIBYSki2O?= =?us-ascii?Q?zoP/2GIQ2d/LJBM1PeOONt/CCj1oOEn4AabIWdpoRd+VSsKfGQJ44LNUeY8f?= =?us-ascii?Q?zdbFRFlg/ee7cOGT72ig+vhqSTDQoDrg6NlbS/T8NQJDpQVe2LA0L69NtIS0?= =?us-ascii?Q?5iTh1chPhsSbg6WdqW9it9/wRs6M8PG9Xs/X0xEvdQCosZYwnHjjbY8g6D0Q?= =?us-ascii?Q?xzbQ1EAGpau2LAul+SdRJ3iBmrt03KE+BqQXHyfBeKM36Oy4x/myR442M0NH?= =?us-ascii?Q?5lg15pEd+XDe2A4ZFkuKTMnEZeITOWVavj7p08XmRxb2+itV6B05uppIVEeZ?= =?us-ascii?Q?FND4f+ANRy+v0nZfO28rkQlJ92Z+G9Q/EYmUH/geJNcSSwQi0ualFAPFxf0o?= =?us-ascii?Q?RkctuFDmSJYjhGPeCK7/3KMIFjqjgCn1c86iVJnZJUAzWQu0gA1y6KKjAdUi?= =?us-ascii?Q?mXbeLA6bUEJwh235bQm/Ujq9e7ywpKCZb8/Uf1VwD6KXlrsA50lFregIEVP5?= =?us-ascii?Q?qPnwVQEJEyVYbhBcdV4ebx274X+gSD0tsXDOCKKdp1VCqHW8XbH/irXLR8Oy?= =?us-ascii?Q?DmMLuEl8dOjBLmYpi+PdS3LBOERh0/qpQXDk8TX5mRnbA/AFIxbr3w1PF2e8?= =?us-ascii?Q?QrvqstxCgEipLgYVp/+37mANzoYg0vnnaWpLOR+OWle9bwtAzLv+4yCTY3/Y?= =?us-ascii?Q?6YYjv1ttkiRW6fcxrBYVxQoNiQBLCQ+7lRh/xCfLOXLp/ag8YYwNc88malEc?= =?us-ascii?Q?4EcDjX7H+Ahx2QEpGMfWXie4IwGULnQ6Y0X8OJR5cs7p/Ymt75d3x6tpUolt?= =?us-ascii?Q?REEg18CIu4G3YuHCCKmhouFV7qMdXZux0R9HoRU3BZ3yFVPRTucmp82f02b/?= =?us-ascii?Q?AZu/oyOVKH4Np5TISvMEqIpTj5Yv7iGMX9JvDq3DfKnQn9w/YU45+Wv4ev7s?= =?us-ascii?Q?T5/Mlc1UBBGGQzRT0Sa75TxAgf3WTRQrljsZrJSiN8/48AsNvqIiirLzlRaa?= =?us-ascii?Q?Ly2JwBCC+w4R3BJglfB70u6mk2unNA3V8NFP33BmSOQYdO9+XMTCf1ybFI6y?= =?us-ascii?Q?j/npyeynaVMd3T3M1LZDbL8G0bd2wJFhvZwC7SR+Ao0sm2m/klf+5sqlyIZG?= =?us-ascii?Q?Jr6y/Nb6hH4E1sukKHHBkh6ej+SaSCh9vUqsrxLhAuLcEwJRMqE7DEWhIfBO?= =?us-ascii?Q?pf+MMF+iSsWeQUEeTOUm3UFWCbcA47DNy3GU/ItJM2t3FOYmtWYQDo8B4wVO?= =?us-ascii?Q?ggg1DM1CjqCCglrLzZMHs+xvGo2v6nxUUrBvSzrW+z54HPou7iLXkmlnVWXE?= =?us-ascii?Q?UfIaelrzklImlZ+a1oapRBvFulSZ3aOnBVGcVf/REh0nQgRAv/oN0m/9J3Ok?= =?us-ascii?Q?Rg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0ac28c63-d83d-4e30-80bf-08dc57dd5737 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2024 15:05:34.3932 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xAZ7xeolLz/BIYTXTex7VCAdAVazIFRvm0fOwPbZPoHyzqAdvZ6EUybLxe9+qN9iOmBQIacDPS+Tr0YMKin9KSMCzmz+fquxlX9zyyq14Rc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6927 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Apr 05, 2024 at 04:45:55PM +0200, David Marchand wrote: > ICE_TX_CTX_EIPT_NONE == 0. > There is a good chance that !(anything & 0) is true :-). > > While removing this noop check is doable, let's check that the > descriptor does contain a outer ip type. > > Fixes: 2ed011776334 ("net/ice: fix outer UDP Tx checksum offload") > > Signed-off-by: David Marchand > --- Reviewed-by: Bruce Richardson