From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id CB63F43DCA;
	Mon,  8 Apr 2024 17:23:23 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 607CB402C9;
	Mon,  8 Apr 2024 17:23:23 +0200 (CEST)
Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14])
 by mails.dpdk.org (Postfix) with ESMTP id 5030F402C0
 for <dev@dpdk.org>; Mon,  8 Apr 2024 17:23:21 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
 d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
 t=1712589802; x=1744125802;
 h=date:from:to:cc:subject:message-id:references:
 in-reply-to:mime-version;
 bh=6Af6KeVibXnWRuGob3VGo+77pTd91qeWNI5Y8x8tQK8=;
 b=Yd2OAGFuiZBfNOgaPo+7hLT/7xxPxjbGnMqutjAs3bAiT2+uYntxqY0o
 yt4QDmB8a7aZAjZRCC5/CTO5La11wtroO6DFIHJuKrsgMTYP4sg9yqDaE
 4AjyLK0fvb1d9Ovsbm+OMOsWkdtUoJS0pxVDqw07RS6P96jEbEsWlynxq
 y2r23aaXzsTISSqsBFMdjAxmvyYmanWBOQHgHX8jV7Uh2BmUtQEeeZ1Tm
 jOxr94yB5Wr/qsGcyK1y70PwQeWEiTRrDS4exqtL5SI4rJoMZpuZczTIu
 Gmkdb/+6sB3guZc8+Lh7lxzYGq3ciQVKKn3vC3zXHAZZqIreGQzaCiBhc A==;
X-CSE-ConnectionGUID: 5BiVnUBnT7Ot+l8SlHYDAw==
X-CSE-MsgGUID: X2FPiRi+Q82BnLot54a6Hw==
X-IronPort-AV: E=McAfee;i="6600,9927,11038"; a="11707868"
X-IronPort-AV: E=Sophos;i="6.07,187,1708416000"; d="scan'208";a="11707868"
Received: from orviesa005.jf.intel.com ([10.64.159.145])
 by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 08 Apr 2024 08:23:19 -0700
X-CSE-ConnectionGUID: GPaCa3TbRamS2qXPy7iBrQ==
X-CSE-MsgGUID: Oz/e4HkUQlekS5UPqZDHtw==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="6.07,187,1708416000"; d="scan'208";a="24701508"
Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81])
 by orviesa005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384;
 08 Apr 2024 08:23:19 -0700
Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by
 fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2507.35; Mon, 8 Apr 2024 08:23:18 -0700
Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by
 fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2507.35; Mon, 8 Apr 2024 08:23:18 -0700
Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by
 fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2507.35 via Frontend Transport; Mon, 8 Apr 2024 08:23:18 -0700
Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169)
 by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2507.35; Mon, 8 Apr 2024 08:23:18 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VyCaSPbWdCY9sQpSU4qBIv1Nc+b9YronhlVnP83wx1/wswXuCDMO77QzdsWQ0DMyGkW4Gtw6xkckHeY+sxMQ+gGmQOimxlbd97Ow1AHlwJtRSuXj8Br1q+FVB4vUEhyzrVIRMzCKbPHQyswrbSKEHI4TalQ35eEWZ11odXwWqj5Kc0qBz/G2Cu4AhzzCaNTQJiA6M5zb1DiEvaSLSE8/Sd7tpFDpMd6prQIE6Adyyl+JzROtsl4KX+MW3l74BAO4uxkjYhVSUBFnEps1jJqFyDEZXt+Y4jKuaaUzLQjCggLBtyhO+nWVTT0jBHt3zhANpiUGVkyJQbHGo5lLSMAWpA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xqD0+ZAx9kEPGj09NlV1HCJi6WEGEiLj03d+6FAtLcw=;
 b=dpQL3FrxFl6Izb78xK/+5Po/p5n92IzrKGKp0J1hzXizx/rN4Vt535FIb9lJGJTDZ3KrZWAh1fQe7XvOJhrTYWih2+9oGkw8+JF0WddFEcVgn3WRRzgpw+LJhDVfVRC66uYaAZg7nnMQxT4ehJ+2L8cE/CQ4wMZT3T++ZmFFyee6L9sT6ffahPLHf5/r93l3q6qgkwELCd05KVxxHb+IKirmpAI0ALtz1dwm2/YLttvtWqDMTku9Ua8hCru9OxESxXXneNaU7JiohVB0pSc2Xfcr2B45lQMoEAgEOeoUb6XpmZaMBktPirTTfcTHLNFZ25FKOsJSM1kZxNEKoNYpxQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17)
 by LV8PR11MB8558.namprd11.prod.outlook.com (2603:10b6:408:1ed::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7430.46; Mon, 8 Apr
 2024 15:23:16 +0000
Received: from DS0PR11MB7309.namprd11.prod.outlook.com
 ([fe80::487e:e20c:ad88:9c0f]) by DS0PR11MB7309.namprd11.prod.outlook.com
 ([fe80::487e:e20c:ad88:9c0f%7]) with mapi id 15.20.7452.019; Mon, 8 Apr 2024
 15:23:15 +0000
Date: Mon, 8 Apr 2024 16:23:10 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
CC: <dev@dpdk.org>, <thomas@monjalon.net>, <ferruh.yigit@amd.com>
Subject: Re: [PATCH v2 2/8] net/ice: enhance debug when HW fails to transmit
Message-ID: <ZhQL3s6ebaFgH0Hy@bricha3-mobl1.ger.corp.intel.com>
References: <20240405125039.897933-1-david.marchand@redhat.com>
 <20240405144604.906695-1-david.marchand@redhat.com>
 <20240405144604.906695-3-david.marchand@redhat.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240405144604.906695-3-david.marchand@redhat.com>
X-ClientProxiedBy: DUZPR01CA0106.eurprd01.prod.exchangelabs.com
 (2603:10a6:10:4bb::14) To DS0PR11MB7309.namprd11.prod.outlook.com
 (2603:10b6:8:13e::17)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|LV8PR11MB8558:EE_
X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: +2JrEKfAn/AKV9hWprWhRHZvcJCBoTSnyW4GSv1ZIG6EtEYuYJ1w9a15fN1N7MJiHN5cyE8yTfKlYDznJt7oT5jXLs4s5na8YkHBRlCpI+HBuUt7UMKUPj9YXMUT1AAUvUFJ7GKZcs4LBeWX7lhtUwhaQuWgYyCYFXMcsO2WU2MX1CPX02D9+2Vsbl8VCGoSRJRIz8HxQSTakROqAlthhtvTYeJvdsZ+G5IG4OpF9hBhAaZZKXLElUgXeh9L/Igx7N+AWHxH1PNvn+vWmQGloeH5dnxO6lyL+Eg46yI0P2b3pXVExO6R1W8b4AR3b0w/vIhKCdi1g2RNmbyGRSyts0F1+Ip9/GHGfCbttyySYRFxOSFMb2n4woPkKhbFjc5ckUXKduV5yu4Tj1O9Ku58SnJoirNejjSGTD9u+w/GS/xpxV0XgRFEj2LxeVf2o1IAeSd3Clb5KgH6XWkfRKx8mmaTl7tIFWM1aoQdrC92CoDzfO4m5BdsSyHjFVethonWqawoY2NAZaMklwhoXO5F+EK/S8tzPy6DgDgjt3rYK42m0xdQjX3pyvBDpqAK/jnQ2c/BWs1i24jMfk+O+HeNIuejJN2WFo4kwiblHG2xlhG2gN3ntTSbJo6oXjF4hXM2Nc+g8Wncma9qNx96pG7xV77p02x1Wm7yyMSZixPvEKw=
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(13230031)(1800799015)(366007)(376005); DIR:OUT; SFP:1102; 
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BxImqvHDVTon5flO1mLg1k3SkkgLGhku/+JVg5sLjrsl413J/mms/97Rw/f4?=
 =?us-ascii?Q?swYV3Y9Wkyv8uTIz0k3wpfCCDPNFUXQHnJRz2OVMocZmBcIF/tyPpf5CNtMN?=
 =?us-ascii?Q?BuuS0xa7+2Zv2kJP39chaaW3CxYhMm/mWtV270oEV5Yjmf4UEOjtHtDbbw7h?=
 =?us-ascii?Q?jWwE/3f/mBx0Y54GHFVhDWvUuyx3nnlvPXGAdLBR8JVd8Z9SqnhFSWu8Clwx?=
 =?us-ascii?Q?L/mCf6UL9S5Ghla1a4VzVglm8HZEdNDnkWMO/70gIzMYorRgKIV2CfScBPJT?=
 =?us-ascii?Q?a+HyfEcPpMggF1adgR0rBRSlM4RwYzTSbks57ejb3XOBnZ8TNR0dus98mjT+?=
 =?us-ascii?Q?c1YUUmN5OTzkVCyHIB+zO0qzyNaCuvwzt2ehPUl2d9XL/NiBM0mH2oERtHAT?=
 =?us-ascii?Q?xR59W0kdbzmSkuWkH4g7h1LuUDFpnQak2PXv+2NLBRxDj9nt1+yPlG++vOXu?=
 =?us-ascii?Q?yenRlZn9KGFoG801q6sprIqYoyhempompzjyJx/WQ72B2FpXN2ePYu73wKSw?=
 =?us-ascii?Q?tVTA55kP6LFsbGivV8SsrO3W1gR5/XhWJvN8DqhmxzbF8i4HgRifEjEBZl02?=
 =?us-ascii?Q?da7Rvu5toCo8P8cFw++yaYSWuBs892zIe7ODtt0E8I6ZB4Tovzk+caZcU012?=
 =?us-ascii?Q?1GOlz9BcZ8P/GV7MbI40ep8bUD5OhQOnvEIR100TJIwbhvL9tCxNQfqauUK+?=
 =?us-ascii?Q?DiT5VDxTwJjMHIT+eLIdpYAea1or8gEFNHawnqoKYAv+hZs9lNzyi2aRFlVa?=
 =?us-ascii?Q?E2VQzhZYKWs4Ukx15/o25EST1YayjzQVusGHBOEps7IMGcZxbuznzR87yKBP?=
 =?us-ascii?Q?fAMXiIYfFYEaFFRicEx1Mzecsu60L1Tni3kErTEJr+/nfD1EmL8bbifWm+HL?=
 =?us-ascii?Q?cGLhoGawTbk+TUqZz3A822bP+Aax15Fzztu1X9Jc1Iak6kS8/c40PV5AjVlF?=
 =?us-ascii?Q?fzMnl5cXS8U3cM1T+tmn6iKPFKI9fzaAGJXtGIIuqgcECkZm7aMg5/CAfB9I?=
 =?us-ascii?Q?CQOUMYDcK6CSQPA3MJsqEokynR2EWue6uYEd4qMCvMTpEkoMMmNSVzaNHcXj?=
 =?us-ascii?Q?TNbsO9Q67lM9EGc2wEN9GVB/oZeyhdLnKUzMPufKmdZLbNBmXS/LdVoXp5RG?=
 =?us-ascii?Q?0ieJ0NStUAFpQGN/Iy9T5JIVGfn4ZwDHxyAUuF1GLzfD/MoAtvvnS6MTv3yS?=
 =?us-ascii?Q?QvJ4+61KfRBljC+iUDhRw3EL2c79aDL1f9BhdBPw8bMOSd4SFkhYn9splPxO?=
 =?us-ascii?Q?HyfYNggUe/l3m6gggY48pSPo0Kp+Yq0iUsv7+D7r31dv+50rxdz0DlNqLuGH?=
 =?us-ascii?Q?T9/NYirskBp/gLuNpAdrCSVV2jQY+tN5q9Wwz4ReJGpn9fn9r+rRfgKtGBgm?=
 =?us-ascii?Q?poGBeoR6JYS0Pmfqczi7PtW8laQ9BHXmgdm61Y7bjmMpirZ2WKGTiUNGkBs0?=
 =?us-ascii?Q?HK8cWAH4rcmp49k/rofL993lir7tFfa213rySNPSed0Y8r5Mpl+ltWC0BWdY?=
 =?us-ascii?Q?WvTYyIQBsZB8z7Fw3mk44EnGHsbeYKIILQfdlg64443eZVXERgL5vVpZJXZR?=
 =?us-ascii?Q?nuUsHOkDJiVY+fKEV6ZuaZZemTkwTLnekXXBFRxBCnWhbSSTgeqp0CtaZrPz?=
 =?us-ascii?Q?Aw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ef364c81-db67-48ff-6316-08dc57dfcfdc
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2024 15:23:15.8634 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dTsynDAoP02OzCrysBE8zm7v9L7N15WxSSYL0/3gZNieTNqw9Yg19WgPlLgkZX46C0jEZi0w9d8EdLCICiW2uALspIqZjBi9SgPGni8Ie28=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8558
X-OriginatorOrg: intel.com
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Fri, Apr 05, 2024 at 04:45:56PM +0200, David Marchand wrote:
> At the moment, if the driver sets an incorrect Tx descriptor, the HW
> will raise a MDD event reported as:
> ice_interrupt_handler(): OICR: MDD event
> 
> Add some debug info for this case and the VF index in all logs.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  drivers/net/ice/ice_ethdev.c | 29 +++++++++++++++++++++++++----
>  1 file changed, 25 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
> index 87385d2649..fd494e6b3b 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -1389,6 +1389,7 @@ ice_interrupt_handler(void *param)
>  	uint32_t oicr;
>  	uint32_t reg;
>  	uint8_t pf_num;
> +	uint16_t vf_num;
>  	uint8_t event;
>  	uint16_t queue;
>  	int ret;
> @@ -1432,28 +1433,48 @@ ice_interrupt_handler(void *param)
>  		if (reg & GL_MDET_TX_PQM_VALID_M) {
>  			pf_num = (reg & GL_MDET_TX_PQM_PF_NUM_M) >>
>  				 GL_MDET_TX_PQM_PF_NUM_S;
> +			vf_num = (reg & GL_MDET_TX_PQM_VF_NUM_M) >>
> +				 GL_MDET_TX_PQM_VF_NUM_S;
>  			event = (reg & GL_MDET_TX_PQM_MAL_TYPE_M) >>
>  				GL_MDET_TX_PQM_MAL_TYPE_S;
>  			queue = (reg & GL_MDET_TX_PQM_QNUM_M) >>
>  				GL_MDET_TX_PQM_QNUM_S;
>  
>  			PMD_DRV_LOG(WARNING, "Malicious Driver Detection event "
> -				    "%d by PQM on TX queue %d PF# %d",
> -				    event, queue, pf_num);
> +				    "%d by PQM on TX queue %d PF# %d VF# %d",
> +				    event, queue, pf_num, vf_num);
>  		}
>  
Would this output be misleading in the case where there is no VF involved
and the actual MDD error comes from the PF?

/Bruce